[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-830084434 Hi @tqchen , @areusch , Any more thoughts on this? Thanks, Giuseppe -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-829117394 Hi @areusch , Should we set for a middle ground solution? I moved back the python interface of `tvm.relay.build`, which now retrieves the executor from the target. The inner fun

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-828639039 Hi @areusch , So, about solution 2) , it is also not affecting the logs, I think. Actually, it would be transparent to the logs because we are not touching the target.

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-828309661 Hi @areusch , @tqchen , @manupa-arm , About the target vs build discussion. I think we all agree that the executor should not be part of the target, but it should be a build par

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-827797374 Hi all, In addition to apply @tqchen comments, I also added: * Test for the stack allocator to verify that there is space to store the tags * Using `abs(x-ref)` to test AO

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825992689 Hi @areusch , I reworked most of the comments except the ones concerning the stack allocator where the discussion is still going on -- This is an automated message from the A

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825989178 Hi @areusch , I addressed most of the comments except the stack_allocator. Let's discuss a bit more on the thread here -- This is an automated message from the Apache Git Se

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825603629 Hi @areusch , I worked on your suggestions, this is what I did: * Moved meta_data.h in include/tvm/runtime. This is to use the runtime::kTvmExecutor{Graph,Aot} also from test

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-822853857 Hi @manupa-arm , @areusch , I applied most of the changes. Namely: * Moved to a `call_cpacked` builtin * Moved the `aot_executor.h` in internal * Moved to use `tir::Allo

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-821404672 Hi @areusch , Thanks for you comments. I left some questions where I didn't get exactly what you meant (sorry :) ). The major thing I will do next week is to introduce a new in

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-818846115 Hi @tqchen , @areusch , I updated a new patch while we agree on the codegen changes [here](https://github.com/apache/tvm/pull/7785#discussion_r611859910). -- This is an autom

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-816755729 Hi all, I refactored bits and pieces. In particular: * Moved everything in crt (with the agreement that in the next future we will remove dependencies on things that embedded

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-814383996 Hi @jwfromm , I am happy to add docs for AOT. Could you just point me to an example of what you mean by doc/tutorial? Where should it go in the codebase? Thanks! -- Thi

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-814382489 Hi @areusch , just back from holidays. First of all, thank you so much to be so thorough in the review. I appreciate this. Instead of a big single reply, I will gra

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-812028482 cc: @u99127 @mshawcroft @areusch @Mousius @MatthewARM @manupa-arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub