[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-31 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r840043998 ## File path: tests/python/topi/python/test_topi_conv2d_int8.py ## @@ -364,7 +365,7 @@ def get_ref_data(): # ), ] -# TODO(tvm-team): Prop

[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-31 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r839409880 ## File path: python/tvm/topi/x86/conv2d_int8.py ## @@ -120,7 +120,7 @@ def _pack_data(cfg, data, kernel): kernel = te.compute( (oc_chunk, ic_c

[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-31 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r839409880 ## File path: python/tvm/topi/x86/conv2d_int8.py ## @@ -120,7 +120,7 @@ def _pack_data(cfg, data, kernel): kernel = te.compute( (oc_chunk, ic_c

[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-30 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r839161718 ## File path: python/tvm/topi/arm_cpu/tensor_intrin.py ## @@ -614,21 +614,22 @@ def _instr(index): ib.emit(outs[0].vstore(0, tvm.tir.const(0

[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-30 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r839161718 ## File path: python/tvm/topi/arm_cpu/tensor_intrin.py ## @@ -614,21 +614,22 @@ def _instr(index): ib.emit(outs[0].vstore(0, tvm.tir.const(0

[GitHub] [tvm] masahi commented on a change in pull request #10839: [ARM] Fix int8 NCHWc compute and alter layout

2022-03-30 Thread GitBox
masahi commented on a change in pull request #10839: URL: https://github.com/apache/tvm/pull/10839#discussion_r839160185 ## File path: tests/python/topi/python/test_topi_conv2d_int8.py ## @@ -364,7 +365,7 @@ def get_ref_data(): # ), ] -# TODO(tvm-team): Prop