Lunderberg merged PR #16543:
URL: https://github.com/apache/tvm/pull/16543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Lunderberg commented on PR #16543:
URL: https://github.com/apache/tvm/pull/16543#issuecomment-2030270161
Last CI failure is due to a flaky hexagon test. I've added a
`@pytest.mark.skip` to this PR, now just waiting on CI.
--
This is an automated message from the Apache Git Service.
To
Lunderberg commented on code in PR #16543:
URL: https://github.com/apache/tvm/pull/16543#discussion_r1539344129
##
src/tir/transforms/arg_binder.cc:
##
@@ -186,18 +191,8 @@ void ArgBinder::BindDLTensor(const Buffer& buffer, const
PrimExpr& device_type,
if (!(buffer->dtype
Lunderberg commented on code in PR #16543:
URL: https://github.com/apache/tvm/pull/16543#discussion_r1539338859
##
rust/tvm-graph-rt/tests/test_tvm_basic/build.rs:
##
@@ -48,10 +48,6 @@ fn main() -> Result<()> {
obj_file.exists(),
"Could not build tvm lib:
slyubomirsky commented on code in PR #16543:
URL: https://github.com/apache/tvm/pull/16543#discussion_r1538390306
##
src/tir/transforms/arg_binder.cc:
##
@@ -186,18 +191,8 @@ void ArgBinder::BindDLTensor(const Buffer& buffer, const
PrimExpr& device_type,
if (!(buffer->dtype
Lunderberg commented on PR #16543:
URL: https://github.com/apache/tvm/pull/16543#issuecomment-1936580514
Merged from main to PR branch, to resolve CI breakage that was fixed in
https://github.com/apache/tvm/pull/16546.
--
This is an automated message from the Apache Git Service.
To
Lunderberg commented on PR #16543:
URL: https://github.com/apache/tvm/pull/16543#issuecomment-1933217017
This came about while debugging the implementation of
https://github.com/apache/tvm/pull/16542, but is otherwise unrelated.
--
This is an automated message from the Apache Git
Lunderberg opened a new pull request, #16543:
URL: https://github.com/apache/tvm/pull/16543
Prior to this commit, the `MakePackedAPI` pass would output steps in the
following order:
1. Check the number of arguments.
2. All `LetStmt` produced by the `ArgBinder`
3. `AssertStmt`
