[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/754 ---

[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...

2017-09-29 Thread acton393
Github user acton393 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/754#discussion_r141800529 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebSocketModule.m --- @@ -126,7 +126,7 @@ - (void)close - (void)close:(NSString *)code

[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...

2017-09-29 Thread gurisxie
Github user gurisxie commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/754#discussion_r141799500 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebSocketModule.m --- @@ -126,7 +126,7 @@ - (void)close - (void)close:(NSString *)code

[GitHub] incubator-weex pull request #754: * [ios] support attributes to set scrollVe...

2017-09-28 Thread acton393
GitHub user acton393 opened a pull request: https://github.com/apache/incubator-weex/pull/754 * [ios] support attributes to set scrollVertical when the scrollView contentSize smaller than the scrollview frame size * [ios] support attributes to set scrollVertical when the