Re: [PR] [590] Add interface for CatalogSyncClient and CatalogSyncOperations [incubator-xtable]

2024-12-07 Thread via GitHub
the-other-tim-brown commented on code in PR #591: URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1874530616 ## xtable-api/src/main/java/org/apache/xtable/model/exception/CatalogRefreshException.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [Enhancement] Support restore/rollback sync during conversion (1/2) [incubator-xtable]

2024-12-07 Thread via GitHub
the-other-tim-brown commented on code in PR #569: URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1874528546 ## xtable-core/src/main/java/org/apache/xtable/hudi/HudiConversionTarget.java: ## @@ -316,6 +323,53 @@ public String getTableFormat() { return T

Re: [PR] [Enhancement] Support restore/rollback sync during conversion (1/2) [incubator-xtable]

2024-12-07 Thread via GitHub
the-other-tim-brown commented on code in PR #569: URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1874506009 ## xtable-api/src/main/java/org/apache/xtable/model/metadata/TableSyncMetadata.java: ## @@ -51,6 +51,8 @@ public class TableSyncMetadata { /** Pro

Re: [PR] [Enhancement] Support restore/rollback sync during conversion (1/2) [incubator-xtable]

2024-12-07 Thread via GitHub
the-other-tim-brown commented on code in PR #569: URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1874505789 ## xtable-api/src/main/java/org/apache/xtable/spi/sync/ConversionTarget.java: ## @@ -90,4 +91,7 @@ public interface ConversionTarget { /** Initi