the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1874505789
##########
xtable-api/src/main/java/org/apache/xtable/spi/sync/ConversionTarget.java:
##########
@@ -90,4 +91,7 @@ public interface ConversionTarget {
/** Initializes the client with provided configuration */
void init(TargetTable targetTable, Configuration configuration);
+
+ /** Return the commit identifier from target table */
Review Comment:
That makes sense to me but the java doc can be a bit more clear. It should
also include context on when the Optional will be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
