[GitHub] hadoop pull request: YARN-4434.NodeManager Disk Checker parameter ...

2015-12-08 Thread aajisaka
Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/62#issuecomment-163142634 I've committed the patch (B), so would you close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] hadoop pull request: YARN-4434.NodeManager Disk Checker parameter ...

2015-12-08 Thread aajisaka
Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/62#issuecomment-163142562 Thank you for the pull request. I reviewed the patch (A) and the another patch in YARN-4434 jira (B) and decided to commit the patch (B) because the patch (B) replaces

[GitHub] hadoop pull request: HADOOP-12984. Add GenericTestUtils.getTestDir...

2016-04-03 Thread aajisaka
Github user aajisaka commented on a diff in the pull request: https://github.com/apache/hadoop/pull/89#discussion_r58334727 --- Diff: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java --- @@ -87,7 +87,7 @@ public

[GitHub] hadoop pull request: HADOOP-12984. Add GenericTestUtils.getTestDir...

2016-04-04 Thread aajisaka
Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/89#issuecomment-205168263 Thank you for rebasing! Mostly looks good to me. Two comments: * Can we separate the patch into common change and hdfs change? That way the patch becomes smaller and

[GitHub] hadoop pull request: HADOOP-12984. Add GenericTestUtils.getTestDir...

2016-04-04 Thread aajisaka
Github user aajisaka commented on a diff in the pull request: https://github.com/apache/hadoop/pull/89#discussion_r58492524 --- Diff: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java --- @@ -55,9 +56,11 @@ public class TestFileUtil

[GitHub] hadoop pull request: HADOOP-12984. Add GenericTestUtils.getTestDir...

2016-04-04 Thread aajisaka
Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/89#issuecomment-205680037 Thank you for the update! I'm +1 if the above comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appe