Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Hi All, Please note that ATSv2 has been merged to branch-2. Refer to https://github.com/apache/hadoop/commit/ 54a694172d7162b2ff45d6e1780c0523cfda66e7 We will continue monitoring if everything works well post-merge. Regards, Varun Saxena. On Mon, Oct 16, 2017 at 9:54 PM, Vrushali C

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Timeline Service v2 should be landing on branch2 shortly. thanks Vrushali On Thu, Sep 7, 2017 at 4:57 PM, Vrushali C wrote: > Thanks everyone. > > It has been over a week (~9 days) since TSv2 has been merged to trunk with > no problems thus far. We are now thinking

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Thanks everyone. It has been over a week (~9 days) since TSv2 has been merged to trunk with no problems thus far. We are now thinking about merging timeline service v2 to branch2 some time in the next few weeks. So far, we have been maintaining a branch2 based YARN-5355_branch2 along with our

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Good to see this merged. I have initiated a separate thread with a smaller set of stakeholders to discuss inclusion in 2.9. We'll report back to the 2.9 release thread as soon as we reach consensus. On Thu, Aug 31, 2017 at 10:39 AM, Ravi Prakash wrote: > +1 to maintaining

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 to maintaining history. On Wed, Aug 30, 2017 at 11:38 PM, varunsax...@apache.org < varun.saxena.apa...@gmail.com> wrote: > Yes, I had used "git merge --no-ff" while merging ATSv2 to trunk. > Maintaining history I believe can be useful as it can make reverts > easier if at all required. > And

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Yes, I had used "git merge --no-ff" while merging ATSv2 to trunk. Maintaining history I believe can be useful as it can make reverts easier if at all required. And can be an easy reference point to look at who had contributed what without having to go back to the branch. Regards, Varun Saxena.

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Thanks Sangjin for the link to the previous discussions on this! I think that helps answer Steve's questions. As decided on that thread [1], YARN-5355 as a feature branch was merged to trunk via "git merge --no-ff" . Although trunk already had TSv2 code (alpha1) prior to this merge, we chose to

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

The "git" way of doing things would be to rebase the feature branch on master (trunk) and then commit the patch stack. Squashing the entire feature into a 10 MB megapatch is the "svn" way of doing things. The svn workflow evolved because merging feature branches back to trunk was really painful

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

I recall this discussion about a couple of years ago: https://lists.apache.org/thread.html/43cd65c6b6c3c0e8ac2b3c76afd9eff1f78b177fabe9c4a96d9b3d0b@1440189889@%3Ccommon-dev.hadoop.apache.org%3E On Wed, Aug 30, 2017 at 2:32 PM, Steve Loughran wrote: > I'd have assumed it

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

I'd have assumed it would have gone in as one single patch, rather than a full history. I don't see why the trunk needs all the evolutionary history of a build. What should our policy/process be here? I do currently plan to merge the s3guard in as one single squashed patch; just getting

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

I'm adding my +1 (binding) to conclude the vote. With 13 +1's (11 binding) and no -1's, the vote passes. We'll get on with the merge to trunk shortly. Thanks everyone! Regards Vrushali On Tue, Aug 29, 2017 at 10:54 AM, varunsax...@apache.org < varun.saxena.apa...@gmail.com> wrote: > +1

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding). Kudos to all the team members for their great work! Being part of the ATSv2 team, I have been involved with either development or review of most of the JIRAs'. Tested ATSv2 in both secure and non-secure mode. Also verified that there is no impact when ATSv2 is turned off. Regards,

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 I helped deploy and run the ATSv2 aux service on a cluster with ~400 node managers on it. I also verified that ATSv2 has no significant impact when disabled. Nice work everyone! On Tue, Aug 29, 2017 at 6:17 AM, Aaron Gresch wrote: > +1 non-binding > > I did some testing

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 non-binding I did some testing with security off running both ATS v1 and v2. On Tue, Aug 22, 2017 at 1:32 AM, Vrushali Channapattan < vrushalic2...@gmail.com> wrote: > Hi folks, > > Per earlier discussion [1], I'd like to start a formal vote to merge > feature branch YARN-5355 [2] (Timeline

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding) I participated in the review for the reader authorization and verified that ATSv2 has no significant impact when disabled. Looking forward to seeing the next increment in functionality in a release. A big thank you to everyone involved in this effort! Jason On Tue, Aug 22, 2017

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding) I’ve participated in the review of ATSv2 security related patch. JIan > On Aug 28, 2017, at 1:39 AM, Rohith Sharma K S > wrote: > > +1 (binding) > > Thank you very much for the great team work! > > Built from source and deployed in secured cluster.

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding) Thank you very much for the great team work! Built from source and deployed in secured cluster. The below are the test result. Deployment : Standard hadoop security deployment authentication and authorization as well. Branch-2 Hadoop and Hbase security cluster. Branch-3

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

That makes sense to me, after merge to trunk and branch 2, it probably makes sense to create a new jira and feature branch for atsv2 additional feature dev. Cheers, Joep On Fri, Aug 25, 2017 at 3:05 PM, Vrushali C wrote: > Hi Subru, > > Thanks for your vote and your

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Hi Subru, Thanks for your vote and your response! Regarding your question about merging to branch2, I think, after the merge to trunk is done, it will be good to merge to branch-2 as soon as we can. A lot of testing with trunk has been done presently and it will be good to repeat the same with

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Thanks Subru for voting. > What are the timelines you are looking for getting this into branch-2? We haven't yet decided on it and were thinking of discussing this in detail within the team after merge to trunk. The timelines would depend on whether we release whatever we merge to trunk in 2.9

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding). I have been following the effort and had few design discussions around the team especially about how it integrates with Federation. Overall I feel it's a welcome improvement to YARN. What are the timelines you are looking for getting this into branch-2? Thanks, Subru On Fri, Aug

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (binding) I've built the current branch, and checked out a few basic areas including documentation. Also perused the most recent changes that went in. Thanks much for the great team work! I look forward to seeing it in action. Regards, Sangjin On Fri, Aug 25, 2017 at 9:27 AM, Haibo Chen

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 from my side. More from the perspective of ensuring there is no impact of ATSv2 when it is off (by default), I deployed the latest YARN-5355 bits into a few clusters and ran internal Smoke tests. The tests shows no impact when ATSv2 is off. Best, Haibo On Thu, Aug 24, 2017 at 7:51 AM, Sunil

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Thank you very much Vrushali, Rohith, Varun and other folks who made this happen. Great work, really appreciate the same!! +1 (binding) from my side: # Tested ATSv2 cluster in a secure cluster. Ran some basic jobs # Accessed new YARN UI which shows various flows/flow activity etc. Seems fine. #

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Hi Naga Thank you for the kind words and appreciate your vote very much. Yes, among everyone who has worked on contributing to the TSv2 code, there has been a strong sense of camaraderie. Let me try to address your questions one by one. bq. Though i have not tested, just went through the jiras

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (Binding), Great work guys, unwavering dedication and team effort. Kudos to the whole team. Though i have not tested, just went through the jiras and features added. Just wanted to know whether there was any other key out standing features left after phase 2 and their impacts ? And it would

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Hi All, Just to update. Folks who may be interested in going through the documentation for the feature can refer to current documentation attached in pdf format, on the umbrella JIRA i.e. YARN-5355. Furthermore, we have run the YARN-5355 patch(with all the changes made in the branch) against

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

+1 (non-binding) for the merge @Vinod I hope that means a +1 from you as well! Cheers, Joep On Tue, Aug 22, 2017 at 11:15 AM, Vinod Kumar Vavilapalli < vino...@apache.org> wrote: > Such a great community effort - hats off, team! > > Thanks > +Vinod > > > On Aug 21, 2017, at 11:32 PM, Vrushali

Re: [VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Such a great community effort - hats off, team! Thanks +Vinod > On Aug 21, 2017, at 11:32 PM, Vrushali Channapattan > wrote: > > Hi folks, > > Per earlier discussion [1], I'd like to start a formal vote to merge > feature branch YARN-5355 [2] (Timeline Service v.2)

[VOTE] Merge feature branch YARN-5355 (Timeline Service v2) to trunk

Hi folks, Per earlier discussion [1], I'd like to start a formal vote to merge feature branch YARN-5355 [2] (Timeline Service v.2) to trunk. The vote will run for 7 days, and will end August 29 11:00 PM PDT. We have previously completed one merge onto trunk [3] and Timeline Service v2 has been