Patch advice rerquired: trailing whitespace cleanup

2015-06-19 Thread Alan Burlison
While running the dev-support/test-patch.sh I got some warnings about trailing whitespace. I'll fix the 2 that I introduced but what about all the others in the files I've touched, fix or leave? I can fix easily enough but it makes the patches rather noisy. -- Alan Burlison --

Re: Patch advice rerquired: trailing whitespace cleanup

2015-06-19 Thread Chris Nauroth
Hi Alan, If it flags a warning on a line of code that your patch touches, then go ahead and trim the whitespace. If you find that it flags a warning on a line of code in the surrounding diff context, but not something that you're actually changing, then don't bother. I agree that doing a mass cl

Re: Patch advice rerquired: trailing whitespace cleanup

2015-06-19 Thread Alan Burlison
On 19/06/2015 17:19, Chris Nauroth wrote: If it flags a warning on a line of code that your patch touches, then go ahead and trim the whitespace. If you find that it flags a warning on a line of code in the surrounding diff context, but not something that you're actually changing, then don't bo

Re: Patch advice rerquired: trailing whitespace cleanup

2015-06-19 Thread Allen Wittenauer
We should probably file and work some liras to remove excess whitespace, tabs, etc. from the source files. > There are some known issues with false positives on the whitespace check > right now. Fixes are in progress. fixes for this and a bunch of other issues are already fixed upstream. ;)