Trunk fails

2017-07-22 Thread Bokor Andras
Hi all, Trunk currently fails without -DskipShade.To see the full error message check one of the pre-commit buils, eg:https://builds.apache.org/job/PreCommit-HADOOP-Build/12839/artifact/patchprocess/branch-mvninstall-root.txtand look for "Duplicate classes found" string.It's related to shading.

RE: Trunk fails

2017-08-14 Thread Brahma Reddy Battula
] Sent: 23 July 2017 22:34 To: common-dev@hadoop.apache.org Cc: Bokor Andras; Brahma Reddy Battula Subject: Re: Trunk fails > On Jul 22, 2017, at 11:31 PM, Brahma Reddy Battula > wrote: > > AFAIK, Patch install(i mean,mvn install) will not run all the projects hence > you didn'

Re: Trunk fails

2017-08-14 Thread Allen Wittenauer
> On Aug 14, 2017, at 5:36 AM, Brahma Reddy Battula > wrote: > > How about let this comment on Jira if there is any failure(compile/Test)..? > so that corresponding Jira reporter/committer can look into it(can > reduce/avoid pre-commit failures..?). > hadoop-commit-trunk does. We c

RE: Trunk fails

2017-09-19 Thread Brahma Reddy Battula
.@effectivemachines.com] Sent: 14 August 2017 22:09 To: Brahma Reddy Battula Cc: common-dev@hadoop.apache.org Subject: Re: Trunk fails > On Aug 14, 2017, at 5:36 AM, Brahma Reddy Battula > wrote: > > How about let this comment on Jira if there is any failure(compile/Test)..? >

Re: Trunk fails

2017-09-19 Thread Allen Wittenauer
> On Sep 19, 2017, at 6:48 AM, Brahma Reddy Battula > wrote: > > Can we run "mvn install" and "compile" for all the modules after applying the > patch(we can skip shadeclients) We need to get over this idea that precommit is going to find all problems every time. Committers actually

Re: Trunk fails

2017-09-19 Thread Chris Douglas
On Tue, Sep 19, 2017 at 8:55 AM, Allen Wittenauer wrote: > We need to get over this idea that precommit is going to find all > problems every time. Committers actually do need to spend some time with a > patch. Besides, in this particular case, it was shading that actually broke… > w

Re: Trunk fails

2017-09-20 Thread Steve Loughran
> On 19 Sep 2017, at 16:55, Allen Wittenauer wrote: > > >> On Sep 19, 2017, at 6:48 AM, Brahma Reddy Battula >> wrote: >> >> Can we run "mvn install" and "compile" for all the modules after applying >> the patch(we can skip shadeclients) > > We need to get over this idea that precomm

Re: Trunk fails

2017-09-20 Thread Sean Busbey
On Wed, Sep 20, 2017 at 5:12 AM, Steve Loughran wrote: > > > > > What we could do is have a patch submission process which says "if you are > playing with packaging, you must declare at the time of patch submission > that you have run a full mvn clean install". And a commit process which > says "

Re: Trunk fails

2017-07-22 Thread Bokor Andras
Something wrong with my formatting and new lines were skipped. So the correct link for build log is https://builds.apache.org/job/PreCommit-HADOOP-Build/12839/artifact/patchprocess/branch-mvninstall-root.txt Bokor Andras írta: >Hi all, Trunk currently fails without -DskipShade.To see the f

Re: Trunk fails

2017-07-22 Thread Brahma Reddy Battula
rom: Bokor Andras Sent: Sunday, July 23, 2017 6:33 AM To: common-dev@hadoop.apache.org Subject: Re: Trunk fails Something wrong with my formatting and new lines were skipped. So the correct link for build log is https://builds.apache.org/job/PreCommit-HADOOP-Build/12839/artifact/patchprocess/

Re: Trunk fails

2017-07-22 Thread Brahma Reddy Battula
FYI..After Jian he comment on YARN-6804,I reverted. Now trunk build will pass. From: Brahma Reddy Battula Sent: Sunday, July 23, 2017 12:38 PM To: Bokor Andras; common-dev@hadoop.apache.org; jianhe Subject: Re: Trunk fails Yes, it's failing after foll

Re: Trunk fails

2017-07-22 Thread Allen Wittenauer
The "update the maven snapshot repo after a commit then update the JIRA issue on the build status" job caught it (https://s.apache.org/bXUp) but looks like it's feedback and the -1 on the mvninstall after it was ignored. *shrugs* > On Jul 22, 2017, at 3:33 PM, Bokor Andras wrote: > > Somethin

Re: Trunk fails

2017-07-22 Thread Allen Wittenauer
> On Jul 22, 2017, at 10:12 PM, Brahma Reddy Battula > wrote: > > FYI..After Jian he comment on YARN-6804,I reverted. Now trunk build will pass. > Yup: https://s.apache.org/S6yd - To unsubscribe, e-mail: common-dev-unsubscr.

Re: Trunk fails

2017-07-22 Thread Jian He
2017 12:38 PM To: Bokor Andras; common-dev@hadoop.apache.org<mailto:common-dev@hadoop.apache.org>; jianhe Subject: Re: Trunk fails Yes, it's failing after following commit. https://issues.apache.org/jira/browse/YARN-6804 <https://issues.apache.org/jira/browse/YARN-6804>@jianhe&l

Re: Trunk fails

2017-07-22 Thread Brahma Reddy Battula
;&1 Elapsed: 0m 26s From: Jian He Sent: Sunday, July 23, 2017 1:26 PM To: Brahma Reddy Battula Cc: Bokor Andras; common-dev@hadoop.apache.org; jianhe Subject: Re: Trunk fails Thanks Brahma. The jenkins report before the commit actually did NOT catch the mvninstall issue. Strange.

Re: Trunk fails

2017-07-23 Thread Allen Wittenauer
> On Jul 22, 2017, at 11:31 PM, Brahma Reddy Battula > wrote: > > AFAIK, Patch install(i mean,mvn install) will not run all the projects hence > you didn't seen this failure. Correct. By design, precommit only runs the test suite against the maven modules that the patch modifies to save (si