Re: Yes/No newbie question on contributing

2016-08-31 Thread Andrew Wang
Hello Martin, Sorry for the slow followup here. If you'd like, someone can give you edit permissions to the wiki so you can make changes yourself. In this case, please provide your wiki username. I also took a look at your document, and am having a hard time determining the diff between it and

Re: Yes/No newbie question on contributing

2016-07-28 Thread Martin Rosse
I don't have permissions to edit the Wiki, but I've included a link below to my proposed revisions to the How To Contribute page. As a reminder, these changes are meant to make it clear that one does not need to run/pass *all* project unit tests before starting to write code or submit a patch.

Re: Yes/No newbie question on contributing

2016-07-26 Thread Martin Rosse
Thanks everyone...that helped. I'll go ahead and edit the Wiki to clarify the expectation. I got a successful build using: ~/code/hadoop$ mvn install -DskipTests To respond to Vinod's questions: I think the answer is trunk. I obtained the source code using: git clone

Re: Yes/No newbie question on contributing

2016-07-26 Thread Sean Busbey
The current HowToContribute guide expressly tells folks that they should ensure all the tests run and pass before and after their change. Sounds like we're due for an update if the expectation is now that folks should be using -DskipTests and runs on particular modules. Maybe we could instruct

Re: Yes/No newbie question on contributing

2016-07-26 Thread Vinod Kumar Vavilapalli
The short answer is that it is expected to pass without any errors. On branch-2.x, that command passes cleanly without any errors though it takes north of 10 minutes. Note that I run it with -DskipTests - you don’t want to wait for all the unit tests to run, that’ll take too much time. I expect

Yes/No newbie question on contributing

2016-07-26 Thread Martin Rosse
Hi, In the How To Contribute doc, it says: "Try getting the project to build and test locally before writing code" So, just to be 100% certain before I keep troubleshooting things, this means I should be able to run mvn clean install -Pdist -Dtar without getting any failures or errors at