[jira] [Resolved] (HADOOP-14468) S3Guard: make short-circuit getFileStatus() configurable

2019-05-20 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Bota resolved HADOOP-14468. - Resolution: Fixed Release Note: Resolved this with HADOOP-15999 : fix for OOB operations.

[jira] [Commented] (HADOOP-14468) S3Guard: make short-circuit getFileStatus() configurable

2019-05-20 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843753#comment-16843753 ] Gabor Bota commented on HADOOP-14468: - Resolved this with HADOOP-15999 : fix for OO

[jira] [Updated] (HADOOP-14468) S3Guard: make short-circuit getFileStatus() configurable

2019-05-20 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Bota updated HADOOP-14468: Release Note: (was: Resolved this with HADOOP-15999 : fix for OOB operations.) > S3Guard: make

[GitHub] [hadoop] bshashikant commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh.

2019-05-20 Thread GitBox
bshashikant commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/825#issuecomment-493900456 Thanks @mukul1987 for working on this. The patch overall looks good to me. Some comments :

[GitHub] [hadoop] bshashikant commented on a change in pull request #826: HDDS-1517. AllocateBlock call fails with ContainerNotFoundException.

2019-05-20 Thread GitBox
bshashikant commented on a change in pull request #826: HDDS-1517. AllocateBlock call fails with ContainerNotFoundException. URL: https://github.com/apache/hadoop/pull/826#discussion_r285500751 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/

[GitHub] [hadoop] mukul1987 commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh.

2019-05-20 Thread GitBox
mukul1987 commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/825#issuecomment-493926256 Thanks for the review @bshashikant. I have changed the name of the variable to checkNoReferen

[GitHub] [hadoop] bshashikant opened a new pull request #833: HDDS-1502. Add metrics for Ozone Ratis performance.

2019-05-20 Thread GitBox
bshashikant opened a new pull request #833: HDDS-1502. Add metrics for Ozone Ratis performance. URL: https://github.com/apache/hadoop/pull/833 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (HADOOP-16317) ABFS: improve random read performance

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843852#comment-16843852 ] Steve Loughran commented on HADOOP-16317: - Be happy to talk about this some tim

[jira] [Commented] (HADOOP-16320) Workaround bug with commons-configuration to be able to emit Ganglia metrics to multiple sink servers

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843853#comment-16843853 ] Steve Loughran commented on HADOOP-16320: - Thomas: you can now submit github PR

[jira] [Commented] (HADOOP-13656) fs -expunge to take a filesystem

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843855#comment-16843855 ] Steve Loughran commented on HADOOP-13656: - Tests LGTM; the HDFS test failures

[jira] [Commented] (HADOOP-16203) ITestS3AContractGetFileStatusV1List may have consistency issues

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843858#comment-16843858 ] Steve Loughran commented on HADOOP-16203: - more detailed listing. The output of

[jira] [Updated] (HADOOP-16203) ITestS3AContractGetFileStatusV1List may have consistency issues

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16203: Component/s: test > ITestS3AContractGetFileStatusV1List may have consistency issues > ---

[GitHub] [hadoop] hadoop-yetus commented on issue #833: HDDS-1502. Add metrics for Ozone Ratis performance.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #833: HDDS-1502. Add metrics for Ozone Ratis performance. URL: https://github.com/apache/hadoop/pull/833#issuecomment-493972530 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[jira] [Assigned] (HADOOP-16321) ITestS3ASSL+TestOpenSSLSocketFactory failing with java.lang.UnsatisfiedLinkErrors

2019-05-20 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sahil Takiar reassigned HADOOP-16321: - Assignee: Sahil Takiar > ITestS3ASSL+TestOpenSSLSocketFactory failing with > java.lan

[jira] [Commented] (HADOOP-16085) S3Guard: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-20 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843993#comment-16843993 ] Ben Roling commented on HADOOP-16085: - Thanks Steve for all your help! > S3Guard:

[jira] [Resolved] (HADOOP-13402) S3A should allow renaming to a pre-existing destination directory to move the source path under that directory, similar to HDFS.

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-13402. - Resolution: Won't Fix > S3A should allow renaming to a pre-existing destination directo

[jira] [Resolved] (HADOOP-14124) S3AFileSystem silently deletes "fake" directories when writing a file.

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-14124. - Resolution: Won't Fix > S3AFileSystem silently deletes "fake" directories when writing

[jira] [Resolved] (HADOOP-14621) S3A client raising ConnectionPoolTimeoutException in test

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-14621. - Resolution: Cannot Reproduce > S3A client raising ConnectionPoolTimeoutException in tes

[jira] [Commented] (HADOOP-16321) ITestS3ASSL+TestOpenSSLSocketFactory failing with java.lang.UnsatisfiedLinkErrors

2019-05-20 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844045#comment-16844045 ] Sahil Takiar commented on HADOOP-16321: --- Can confirm this is environmental, since

[jira] [Commented] (HADOOP-15658) Memory leak in S3AOutputStream

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844049#comment-16844049 ] Steve Loughran commented on HADOOP-15658: - Fixing in HADOOP-15183; the gentle S

[jira] [Commented] (HADOOP-15658) Memory leak in S3AOutputStream

2019-05-20 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844057#comment-16844057 ] Piotr Nowojski commented on HADOOP-15658: - Thanks [~ste...@apache.org], that's

[GitHub] [hadoop] ajayydv closed pull request #754: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv closed pull request #754: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/754 This is an automated message from the Apache

[GitHub] [hadoop] hadoop-yetus commented on issue #754: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #754: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/754#issuecomment-494053441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] bshashikant commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh.

2019-05-20 Thread GitBox
bshashikant commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/825#issuecomment-494057436 Thanks @mukul1987 for updating the patch. The patch looks good to me but TestContainerPersist

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285672796 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipel

[jira] [Commented] (HADOOP-16321) ITestS3ASSL+TestOpenSSLSocketFactory failing with java.lang.UnsatisfiedLinkErrors

2019-05-20 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844090#comment-16844090 ] Sahil Takiar commented on HADOOP-16321: --- I don't actually know why the {{Unsatisf

[GitHub] [hadoop] ajayydv opened a new pull request #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv opened a new pull request #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/834 (cherry picked from commit 7254bf06e66deaf4dd9d00e65fc8894bd869a797)

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285681320 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipel

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285682170 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipel

[jira] [Commented] (HADOOP-16321) ITestS3ASSL+TestOpenSSLSocketFactory failing with java.lang.UnsatisfiedLinkErrors

2019-05-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844123#comment-16844123 ] Steve Loughran commented on HADOOP-16321: - Its failing because there's no nativ

[GitHub] [hadoop] avijayanhwx commented on issue #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected.

2019-05-20 Thread GitBox
avijayanhwx commented on issue #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. URL: https://github.com/apache/hadoop/pull/799#issuecomment-494074290 > @avijayanhwx the patch looks good to me. Can you please confirm that the test failures are not du

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285694947 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285695497 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285695497 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[jira] [Commented] (HADOOP-16320) Workaround bug with commons-configuration to be able to emit Ganglia metrics to multiple sink servers

2019-05-20 Thread Thomas Poepping (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844148#comment-16844148 ] Thomas Poepping commented on HADOOP-16320: -- Great, thanks Steve, I'll get to w

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285697208 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285699438 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285702158 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285703674 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolPB/

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285706165 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rest

[GitHub] [hadoop] hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/834#issuecomment-494093153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] steveloughran closed pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-20 Thread GitBox
steveloughran closed pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-20 Thread GitBox
steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-494106274 Closing this PR and kicking off a new one ---

[jira] [Created] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Dongwook Kwon (JIRA)
Dongwook Kwon created HADOOP-16322: -- Summary: FileNotFoundException for checksum file from hadoop-maven-plugins Key: HADOOP-16322 URL: https://issues.apache.org/jira/browse/HADOOP-16322 Project: Hado

[jira] [Updated] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Dongwook Kwon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongwook Kwon updated HADOOP-16322: --- Description: I found hadoop-maven-plugins has an issue with checksum file creation which wa

[jira] [Updated] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Dongwook Kwon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongwook Kwon updated HADOOP-16322: --- Attachment: HADOOP-16322.patch Status: Patch Available (was: Open) > FileNotFoundE

[jira] [Commented] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844222#comment-16844222 ] Hadoop QA commented on HADOOP-16322: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Updated] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Dongwook Kwon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongwook Kwon updated HADOOP-16322: --- Status: Open (was: Patch Available) > FileNotFoundException for checksum file from hadoop-

[jira] [Updated] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Dongwook Kwon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongwook Kwon updated HADOOP-16322: --- Attachment: HADOOP-16322-branch-2.8.5.001.patch Status: Patch Available (was: Open)

[GitHub] [hadoop] steveloughran opened a new pull request #835: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-20 Thread GitBox
steveloughran opened a new pull request #835: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/835 This addresses * HADOOP-15183: S3Guard store becomes inconsistent after partial failure of rename * HADOOP-

[jira] [Commented] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2019-05-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844234#comment-16844234 ] Hadoop QA commented on HADOOP-16322: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] ben-roling opened a new pull request #836: HADOOP-16319 skip invalid tests when default encryption enabled

2019-05-20 Thread GitBox
ben-roling opened a new pull request #836: HADOOP-16319 skip invalid tests when default encryption enabled URL: https://github.com/apache/hadoop/pull/836 ETag values are unpredictable with some encryption algorithms. Skip tests asserting ETags when default encryption is enabled. -

[GitHub] [hadoop] anuengineer commented on issue #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected.

2019-05-20 Thread GitBox
anuengineer commented on issue #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. URL: https://github.com/apache/hadoop/pull/799#issuecomment-494130302 +1, LGTM. Thanks. This is an autom

[GitHub] [hadoop] anuengineer merged pull request #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected.

2019-05-20 Thread GitBox
anuengineer merged pull request #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. URL: https://github.com/apache/hadoop/pull/799 This is an automated message from the Apache Git Servic

[GitHub] [hadoop] anuengineer commented on issue #831: HDDS-1487. Bootstrap React framework for Recon UI

2019-05-20 Thread GitBox
anuengineer commented on issue #831: HDDS-1487. Bootstrap React framework for Recon UI URL: https://github.com/apache/hadoop/pull/831#issuecomment-494132578 @jiwq Thanks for the review. @vivekratnavel Thanks for the contribution, I will commit this to the trunk.

[GitHub] [hadoop] anuengineer merged pull request #831: HDDS-1487. Bootstrap React framework for Recon UI

2019-05-20 Thread GitBox
anuengineer merged pull request #831: HDDS-1487. Bootstrap React framework for Recon UI URL: https://github.com/apache/hadoop/pull/831 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [hadoop] hadoop-yetus commented on issue #836: HADOOP-16319 skip invalid tests when default encryption enabled

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #836: HADOOP-16319 skip invalid tests when default encryption enabled URL: https://github.com/apache/hadoop/pull/836#issuecomment-494144822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
xiaoyuyao commented on a change in pull request #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/834#discussion_r285765066 ## File path: hadoop-hdds/common/src/main/java/org/apache/had

[GitHub] [hadoop] hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#issuecomment-494149939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:--

[GitHub] [hadoop] ben-roling commented on issue #836: HADOOP-16319 skip invalid tests when default encryption enabled

2019-05-20 Thread GitBox
ben-roling commented on issue #836: HADOOP-16319 skip invalid tests when default encryption enabled URL: https://github.com/apache/hadoop/pull/836#issuecomment-494151693 With regard to testing: I've only run this one test class before and after the change. It is successfully skipping the

[GitHub] [hadoop] hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#issuecomment-494152503 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:--

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285773115 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285775332 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolP

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285775612 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolP

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
xiaoyuyao commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285775796 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolP

[GitHub] [hadoop] hadoop-yetus commented on issue #835: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #835: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/835#issuecomment-494158727 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus commented on issue #831: HDDS-1487. Bootstrap React framework for Recon UI

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #831: HDDS-1487. Bootstrap React framework for Recon UI URL: https://github.com/apache/hadoop/pull/831#issuecomment-494160899 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hadoop] arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

2019-05-20 Thread GitBox
arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#discussion_r285780568 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hado

[GitHub] [hadoop] arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

2019-05-20 Thread GitBox
arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#discussion_r285780681 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hado

[GitHub] [hadoop] arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

2019-05-20 Thread GitBox
arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#discussion_r285780657 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hado

[GitHub] [hadoop] arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

2019-05-20 Thread GitBox
arp7 commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#discussion_r285780876 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hado

[GitHub] [hadoop] ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#discussion_r285706165 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rest

[GitHub] [hadoop] amommendes opened a new pull request #837: Adding nodeId to Delimited File

2019-05-20 Thread GitBox
amommendes opened a new pull request #837: Adding nodeId to Delimited File URL: https://github.com/apache/hadoop/pull/837 Adding inodeId to delimited file as XML processor. This is an automated message from the Apache Git Serv

[GitHub] [hadoop] hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #828: HDDS-1538. Update ozone protobuf message for ACLs. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/828#issuecomment-494205774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:--

[GitHub] [hadoop] hadoop-yetus commented on issue #837: Adding nodeId to Delimited File

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #837: Adding nodeId to Delimited File URL: https://github.com/apache/hadoop/pull/837#issuecomment-494213730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | r

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285837310 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPi

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285837285 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPi

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285837951 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPi

[GitHub] [hadoop] bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-494224894 @lokeshj1703 Addressed the review comments. This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/834#issuecomment-494227265 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #834: HDDS-1065. OM and DN should persist SCM certificate as the trust root. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/834#issuecomment-494228490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-20 Thread GitBox
hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-494242612 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Commented] (HADOOP-16263) Update BUILDING.txt with macOS native build instructions

2019-05-20 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844572#comment-16844572 ] Adam Antal commented on HADOOP-16263: - I followed the steps and I successfully comp