[GitHub] [hadoop] bshashikant commented on issue #1076: HDDS-1782. Add an option to MiniOzoneChaosCluster to read files multiple times. Contributed by Mukul Kumar Singh.

2019-07-18 Thread GitBox
bshashikant commented on issue #1076: HDDS-1782. Add an option to MiniOzoneChaosCluster to read files multiple times. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/1076#issuecomment-512692092 Thanks @mukul1987 for working on this. The changes look good. I hav

[GitHub] [hadoop] hadoop-yetus commented on issue #1112: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1112: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1112#issuecomment-512697445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] lokeshj1703 commented on issue #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir

2019-07-18 Thread GitBox
lokeshj1703 commented on issue #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir URL: https://github.com/apache/hadoop/pull/1114#issuecomment-512733139 @anuengineer Thanks for reviewing the PR! I agree too. The acceptance test failure does not seem to be related. I will merge it with tr

[GitHub] [hadoop] lokeshj1703 merged pull request #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir

2019-07-18 Thread GitBox
lokeshj1703 merged pull request #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir URL: https://github.com/apache/hadoop/pull/1114 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on issue #1118: HDDS-1811. Prometheus metrics are broken

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1118: HDDS-1811. Prometheus metrics are broken URL: https://github.com/apache/hadoop/pull/1118#issuecomment-512734481 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] lokeshj1703 commented on issue #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir

2019-07-18 Thread GitBox
lokeshj1703 commented on issue #1114: HDDS-1481: Cleanup BasicOzoneFileSystem#mkdir URL: https://github.com/apache/hadoop/pull/1114#issuecomment-512734684 @anuengineer Thanks for reviewing the changes! I have merged the PR with trunk. --

[GitHub] [hadoop] lokeshj1703 merged pull request #1087: HDDS-1767: ContainerStateMachine should have its own executors for executing applyTransaction calls

2019-07-18 Thread GitBox
lokeshj1703 merged pull request #1087: HDDS-1767: ContainerStateMachine should have its own executors for executing applyTransaction calls URL: https://github.com/apache/hadoop/pull/1087 This is an automated message from the

[GitHub] [hadoop] lokeshj1703 commented on issue #1087: HDDS-1767: ContainerStateMachine should have its own executors for executing applyTransaction calls

2019-07-18 Thread GitBox
lokeshj1703 commented on issue #1087: HDDS-1767: ContainerStateMachine should have its own executors for executing applyTransaction calls URL: https://github.com/apache/hadoop/pull/1087#issuecomment-512736112 @mukul1987 Thanks for reviewing the PR! I have merged it with trunk.

[GitHub] [hadoop] adamantal opened a new pull request #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer

2019-07-18 Thread GitBox
adamantal opened a new pull request #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer URL: https://github.com/apache/hadoop/pull/1119 Both GpuDiscoverer and FpgaDiscoverer classes are now extending Configured. -

[jira] [Commented] (HADOOP-16417) abfs can't access storage account without password

2019-07-18 Thread Jose Luis Pedrosa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887842#comment-16887842 ] Jose Luis Pedrosa commented on HADOOP-16417: Hi [~iwasakims] Some progress

[GitHub] [hadoop] bshashikant closed pull request #1073: HDDS-1780. TestFailureHandlingByClient tests are flaky.

2019-07-18 Thread GitBox
bshashikant closed pull request #1073: HDDS-1780. TestFailureHandlingByClient tests are flaky. URL: https://github.com/apache/hadoop/pull/1073 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hadoop] bshashikant commented on issue #1073: HDDS-1780. TestFailureHandlingByClient tests are flaky.

2019-07-18 Thread GitBox
bshashikant commented on issue #1073: HDDS-1780. TestFailureHandlingByClient tests are flaky. URL: https://github.com/apache/hadoop/pull/1073#issuecomment-512761446 Thanks @mukul1987 @adoroszlai and @supratimdeka for the review. I have committed this change to trunk.

[GitHub] [hadoop] bshashikant commented on issue #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens.

2019-07-18 Thread GitBox
bshashikant commented on issue #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens. URL: https://github.com/apache/hadoop/pull/923#issuecomment-512762475 The unit test failures are not related and acceptance test results show it all passed

[GitHub] [hadoop] szilard-nemeth commented on issue #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer

2019-07-18 Thread GitBox
szilard-nemeth commented on issue #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer URL: https://github.com/apache/hadoop/pull/1119#issuecomment-512766231 Hi @adamantal ! Thanks for this patch. +1 This i

[jira] [Comment Edited] (HADOOP-16417) abfs can't access storage account without password

2019-07-18 Thread Jose Luis Pedrosa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887842#comment-16887842 ] Jose Luis Pedrosa edited comment on HADOOP-16417 at 7/18/19 11:26 AM: ---

[GitHub] [hadoop] bshashikant commented on issue #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens.

2019-07-18 Thread GitBox
bshashikant commented on issue #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens. URL: https://github.com/apache/hadoop/pull/923#issuecomment-512780643 Thanks @bharatviswa504 for the review. I have committed this change to trunk. ---

[GitHub] [hadoop] bshashikant closed pull request #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens.

2019-07-18 Thread GitBox
bshashikant closed pull request #923: HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens. URL: https://github.com/apache/hadoop/pull/923 This is an automated message from the Apa

[GitHub] [hadoop] szilard-nemeth edited a comment on issue #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer

2019-07-18 Thread GitBox
szilard-nemeth edited a comment on issue #1119: YARN-9375. Use Configured in GpuDiscoverer and FpgaDiscoverer URL: https://github.com/apache/hadoop/pull/1119#issuecomment-512766231 Hi @adamantal ! Thanks for this patch. +1 Pending jenkins -

[GitHub] [hadoop] hadoop-yetus commented on issue #1118: HDDS-1811. Prometheus metrics are broken

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1118: HDDS-1811. Prometheus metrics are broken URL: https://github.com/apache/hadoop/pull/1118#issuecomment-512788303 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] ChenSammi commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou…

2019-07-18 Thread GitBox
ChenSammi commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou… URL: https://github.com/apache/hadoop/pull/1067#issuecomment-512794027 @xiaoyuyao , with uuid as network name, here is output, ozone scmcli printTopology State = HEALTHY 10.5

[jira] [Comment Edited] (HADOOP-16436) Fix ITestS3GuardToolLocal#testInitNegativeRead test failure

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887943#comment-16887943 ] Steve Loughran edited comment on HADOOP-16436 at 7/18/19 12:49 PM: --

[jira] [Commented] (HADOOP-16436) Fix ITestS3GuardToolLocal#testInitNegativeRead test failure

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887943#comment-16887943 ] Steve Loughran commented on HADOOP-16436: - Code from the stack {code} Prec

[jira] [Assigned] (HADOOP-16436) Fix ITestS3GuardToolLocal#testInitNegativeRead test failure

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-16436: --- Assignee: Steve Loughran > Fix ITestS3GuardToolLocal#testInitNegativeRead test fai

[jira] [Updated] (HADOOP-16436) Fix ITestS3GuardToolLocal#testInitNegativeRead test failure

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16436: Priority: Major (was: Minor) > Fix ITestS3GuardToolLocal#testInitNegativeRead test failu

[jira] [Commented] (HADOOP-16207) Fix ITestDirectoryCommitMRJob.testMRJob

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887945#comment-16887945 ] Steve Loughran commented on HADOOP-16207: - Staging problem is fixed by MAPREDUC

[GitHub] [hadoop] steveloughran commented on issue #1115: HADOOP-16207 testMR failures

2019-07-18 Thread GitBox
steveloughran commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-512803294 Testing: S3 Ireland. Not retested since rebasing to trunk; will do when I have 1h to spare. Currently this patch is not going to fix the testMR

[jira] [Comment Edited] (HADOOP-16417) abfs can't access storage account without password

2019-07-18 Thread Jose Luis Pedrosa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887842#comment-16887842 ] Jose Luis Pedrosa edited comment on HADOOP-16417 at 7/18/19 1:26 PM:

[GitHub] [hadoop] adoroszlai opened a new pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
adoroszlai opened a new pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120 ## What changes were proposed in this pull request? NPE is caused by base `chooseDatanodes` not checking for `excludedNodes` being `null`. D

[GitHub] [hadoop] adoroszlai commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
adoroszlai commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512817437 /label ozone This is an automated message from the Apache Git Servi

[jira] [Commented] (HADOOP-16403) Start a new statistical rpc queue and make the Reader's pendingConnection queue runtime-replaceable

2019-07-18 Thread Jinglun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887980#comment-16887980 ] Jinglun commented on HADOOP-16403: -- Hi [~xkrogen], [~jojochuang], [~ayushtkn],  [~hexi

[GitHub] [hadoop] hadoop-yetus commented on issue #1112: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1112: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1112#issuecomment-512821424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-512821784 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | r

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1112: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-18 Thread GitBox
adoroszlai commented on a change in pull request #1112: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1112#discussion_r304925218 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/contain

[GitHub] [hadoop] hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-512838616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | r

[GitHub] [hadoop] steveloughran commented on a change in pull request #1106: HADOOP-16380. S3A non-recursive deletion of root to return false

2019-07-18 Thread GitBox
steveloughran commented on a change in pull request #1106: HADOOP-16380. S3A non-recursive deletion of root to return false URL: https://github.com/apache/hadoop/pull/1106#discussion_r304946676 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSyst

[jira] [Commented] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888027#comment-16888027 ] AiBe Gee commented on HADOOP-16311: --- [~tonyharvey] Sorry for the late reply, haven't

[GitHub] [hadoop] bshashikant commented on issue #1071: HDDS-1779. TestWatchForCommit tests are flaky.

2019-07-18 Thread GitBox
bshashikant commented on issue #1071: HDDS-1779. TestWatchForCommit tests are flaky. URL: https://github.com/apache/hadoop/pull/1071#issuecomment-512839848 Thanks @mukul1987 and @supratimdeka for the review. I have committed the change to trunnk. --

[GitHub] [hadoop] bshashikant edited a comment on issue #1071: HDDS-1779. TestWatchForCommit tests are flaky.

2019-07-18 Thread GitBox
bshashikant edited a comment on issue #1071: HDDS-1779. TestWatchForCommit tests are flaky. URL: https://github.com/apache/hadoop/pull/1071#issuecomment-512839848 Thanks @mukul1987 and @supratimdeka for the review. I have committed the change to trunk.

[GitHub] [hadoop] bshashikant closed pull request #1071: HDDS-1779. TestWatchForCommit tests are flaky.

2019-07-18 Thread GitBox
bshashikant closed pull request #1071: HDDS-1779. TestWatchForCommit tests are flaky. URL: https://github.com/apache/hadoop/pull/1071 This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Comment Edited] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888027#comment-16888027 ] AiBe Gee edited comment on HADOOP-16311 at 7/18/19 2:30 PM:

[GitHub] [hadoop] steveloughran commented on issue #1106: HADOOP-16380. S3A non-recursive deletion of root to return false

2019-07-18 Thread GitBox
steveloughran commented on issue #1106: HADOOP-16380. S3A non-recursive deletion of root to return false URL: https://github.com/apache/hadoop/pull/1106#issuecomment-512841362 -1 as is, because we need that qualified path. I'd also like the empty dir test of PR #1079 retained. Even t

[jira] [Comment Edited] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888027#comment-16888027 ] AiBe Gee edited comment on HADOOP-16311 at 7/18/19 2:34 PM:

[jira] [Comment Edited] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888027#comment-16888027 ] AiBe Gee edited comment on HADOOP-16311 at 7/18/19 2:36 PM:

[jira] [Comment Edited] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888027#comment-16888027 ] AiBe Gee edited comment on HADOOP-16311 at 7/18/19 2:42 PM:

[GitHub] [hadoop] adamantal opened a new pull request #1121: YARN-9124. Resolve contradiction in ResourceUtils: addMandatoryResour…

2019-07-18 Thread GitBox
adamantal opened a new pull request #1121: YARN-9124. Resolve contradiction in ResourceUtils: addMandatoryResour… URL: https://github.com/apache/hadoop/pull/1121 …ces / checkMandatoryResources work differently This is an auto

[GitHub] [hadoop] adoroszlai commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
adoroszlai commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512861537 @ChenSammi @mukul1987 @xiaoyuyao please review This is an automated

[GitHub] [hadoop] adoroszlai commented on issue #1118: HDDS-1811. Prometheus metrics are broken

2019-07-18 Thread GitBox
adoroszlai commented on issue #1118: HDDS-1811. Prometheus metrics are broken URL: https://github.com/apache/hadoop/pull/1118#issuecomment-512863607 @lokeshj1703 @mukul1987 please review This is an automated message from the A

[GitHub] [hadoop] hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512866565 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hadoop] adamantal opened a new pull request #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager

2019-07-18 Thread GitBox
adamantal opened a new pull request #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager URL: https://github.com/apache/hadoop/pull/1122 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512884621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
xiaoyuyao commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#discussion_r305009712 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithm

[GitHub] [hadoop] bharatviswa504 merged pull request #1116: HDDS-1820. Fix numKeys metrics in OM HA.

2019-07-18 Thread GitBox
bharatviswa504 merged pull request #1116: HDDS-1820. Fix numKeys metrics in OM HA. URL: https://github.com/apache/hadoop/pull/1116 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] bharatviswa504 commented on issue #1116: HDDS-1820. Fix numKeys metrics in OM HA.

2019-07-18 Thread GitBox
bharatviswa504 commented on issue #1116: HDDS-1820. Fix numKeys metrics in OM HA. URL: https://github.com/apache/hadoop/pull/1116#issuecomment-512892548 Thank You @arp7 for the review. Test failure is not related to this patch. I will commit this to the trunk. ---

[jira] [Updated] (HADOOP-16380) S3A tombstones can confuse empty directory status

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16380: Summary: S3A tombstones can confuse empty directory status (was: S3A non-recursive delet

[jira] [Updated] (HADOOP-16380) S3A tombstones can confuse empty directory status

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16380: Priority: Blocker (was: Major) > S3A tombstones can confuse empty directory status > ---

[jira] [Commented] (HADOOP-16380) S3A tombstones can confuse empty directory status

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888150#comment-16888150 ] Steve Loughran commented on HADOOP-16380: - # Yes, your patch is essential # Thi

[GitHub] [hadoop] arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512897424 Reviewing this patch, @hanishakoneru can you resolve the merge conflict meanwhile? ---

[GitHub] [hadoop] steveloughran opened a new pull request #1123: HADOOP-16380 tombstones

2019-07-18 Thread GitBox
steveloughran opened a new pull request #1123: HADOOP-16380 tombstones URL: https://github.com/apache/hadoop/pull/1123 Gabor's PR #1106 merged with the test of mine in #1079 with that test modified to show that yes, the tombstone problem goes all the way down --

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305018334 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305019552 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache

[jira] [Commented] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread Tony Harvey (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888161#comment-16888161 ] Tony Harvey commented on HADOOP-16311: -- A thanks for getting back anyway. I’m aw

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305025544 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305026469 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305026829 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305027589 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r304689358 ## File path: hadoop-ozone/integration-test/src/test/j

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305019890 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512907214 **Question:** In ShouldInstallSnapshot, it calls getLatestSnapshot() from stat

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r304690480 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305028836 ## File path: hadoop-hdds/common/src/main/resources/ozon

[GitHub] [hadoop] arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512908324 I am mostly +1 on this change. Couple of minor comments and one thing I requested Bharat to

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305029702 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305029959 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305030343 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305030842 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305032543 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305035508 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305038252 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039471 ## File path: hadoop-hdds/common/src/main/resources/ozon

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039875 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039831 ## File path: hadoop-hdds/common/src/main/resources/ozon

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305041874 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305041731 ## File path: hadoop-ozone/ozone-manager/src/main/java/

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305044258 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305046862 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305047773 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305047773 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305048987 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] goiri commented on issue #1040: HDFS-13693. Remove unnecessary search in INodeDirectory.addChild during image loa…

2019-07-18 Thread GitBox
goiri commented on issue #1040: HDFS-13693. Remove unnecessary search in INodeDirectory.addChild during image loa… URL: https://github.com/apache/hadoop/pull/1040#issuecomment-512928429 The parallel life of JIRAs and PRs is driving me a little crazy. We have both the patch and the diff h

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305052177 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] avijayanhwx opened a new pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
avijayanhwx opened a new pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124 …ne for reads. Currently the list of nodes returned by SCM are static and are returned in the same order to all the cli

[GitHub] [hadoop] avijayanhwx commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
avijayanhwx commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124#issuecomment-512929603 /label ozone This is an automated message fro

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305053446 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305053446 ## File path: hadoop-ozone/ozone-manager/src/main/java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305056316 ## File path: hadoop-ozone/integration-test/src/test/j

[GitHub] [hadoop] adoroszlai commented on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager

2019-07-18 Thread GitBox
adoroszlai commented on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager URL: https://github.com/apache/hadoop/pull/1122#issuecomment-512936966 rebuild This is an automated message from the Apache Git

[GitHub] [hadoop] adoroszlai removed a comment on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager

2019-07-18 Thread GitBox
adoroszlai removed a comment on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager URL: https://github.com/apache/hadoop/pull/1122#issuecomment-512936966 rebuild This is an automated message from the Ap

[GitHub] [hadoop] hadoop-yetus commented on issue #1123: HADOOP-16380 tombstones

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1123: HADOOP-16380 tombstones URL: https://github.com/apache/hadoop/pull/1123#issuecomment-512944956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
adoroszlai commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#discussion_r305071450 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorith

[GitHub] [hadoop] bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.

2019-07-18 Thread GitBox
bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-512952595 This is ready for review. Rebased with the latest trunk, as now HDDS-1689 got checked in. ---

  1   2   >