[jira] [Commented] (HADOOP-16398) Exports Hadoop metrics to Prometheus

2019-07-18 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888534#comment-16888534 ] Akira Ajisaka commented on HADOOP-16398: Hi [~elek] and [~anu], would you review this? After

[GitHub] [hadoop] Cosss7 opened a new pull request #1129: HDFS-14509 DN throws InvalidToken due to inequality of password when upgrade NN 2.x to 3.x

2019-07-18 Thread GitBox
Cosss7 opened a new pull request #1129: HDFS-14509 DN throws InvalidToken due to inequality of password when upgrade NN 2.x to 3.x URL: https://github.com/apache/hadoop/pull/1129 reference to jira This is an automated

[jira] [Commented] (HADOOP-16431) Remove useless log in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888499#comment-16888499 ] Hadoop QA commented on HADOOP-16431: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] Cosss7 opened a new pull request #1128: HDFS-14551 NN throws NPE if downgrade it during rolling upgrade from 3.x to 2.x

2019-07-18 Thread GitBox
Cosss7 opened a new pull request #1128: HDFS-14551 NN throws NPE if downgrade it during rolling upgrade from 3.x to 2.x URL: https://github.com/apache/hadoop/pull/1128 reference jira. This is an automated message from the

[GitHub] [hadoop] ChenSammi commented on a change in pull request #1112: HDDS-1713. ReplicationManager fail to find proper node topology based…

2019-07-18 Thread GitBox
ChenSammi commented on a change in pull request #1112: HDDS-1713. ReplicationManager fail to find proper node topology based… URL: https://github.com/apache/hadoop/pull/1112#discussion_r305190794 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305187064 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305186358 ## File path:

[GitHub] [hadoop] ChenSammi merged pull request #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou…

2019-07-18 Thread GitBox
ChenSammi merged pull request #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou… URL: https://github.com/apache/hadoop/pull/1067 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] ChenSammi commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou…

2019-07-18 Thread GitBox
ChenSammi commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou… URL: https://github.com/apache/hadoop/pull/1067#issuecomment-513070699 +1, will commit shortly. This is an automated

[GitHub] [hadoop] xiaoyuyao commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
xiaoyuyao commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124#issuecomment-513068886 Randomize is good to balance the load. However, For write, we still must go through the leader (first node).

[GitHub] [hadoop] anuengineer commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
anuengineer commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305183995 ## File path:

[jira] [Updated] (HADOOP-16431) Remove useless log in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16431: - Priority: Minor (was: Major) > Remove useless log in IOUtils.java and ExceptionDiags.java >

[jira] [Updated] (HADOOP-16431) Remove useless log in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16431: - Summary: Remove useless log in IOUtils.java and ExceptionDiags.java (was: Change Log Level to

[jira] [Commented] (HADOOP-16431) Change Log Level to trace in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888450#comment-16888450 ] Lisheng Sun commented on HADOOP-16431: -- Thank [~elgoiri] for your good suggestions. I have update

[GitHub] [hadoop] arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-513063053 /retest This is an

[jira] [Updated] (HADOOP-16431) Change Log Level to trace in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16431: - Attachment: HADOOP-16431.002.patch > Change Log Level to trace in IOUtils.java and

[jira] [Commented] (HADOOP-16431) Change Log Level to trace in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888439#comment-16888439 ] Íñigo Goiri commented on HADOOP-16431: -- Given that log and throw is not a very good approach I

[GitHub] [hadoop] mackrorysd commented on issue #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration

2019-07-18 Thread GitBox
mackrorysd commented on issue #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration URL: https://github.com/apache/hadoop/pull/1125#issuecomment-513057068 Common unit test failure is unrelated - not even changing common or anything it depends on. Not including other

[jira] [Commented] (HADOOP-16431) Change Log Level to trace in IOUtils.java and ExceptionDiags.java

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888429#comment-16888429 ] Lisheng Sun commented on HADOOP-16431: -- [~linyiqun]  [~jojochuang] [~hexiaoqiao] [~elgoiri] Could

[GitHub] [hadoop] hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-513052953 :broken_heart: **-1 overall** | Vote | Subsystem |

[GitHub] [hadoop] commanderchewbacca closed pull request #1127: Gcs connector

2019-07-18 Thread GitBox
commanderchewbacca closed pull request #1127: Gcs connector URL: https://github.com/apache/hadoop/pull/1127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] commanderchewbacca opened a new pull request #1127: Gcs connector

2019-07-18 Thread GitBox
commanderchewbacca opened a new pull request #1127: Gcs connector URL: https://github.com/apache/hadoop/pull/1127 added gcs connector for operator-metering This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] commanderchewbacca closed pull request #1126: Gcs connector

2019-07-18 Thread GitBox
commanderchewbacca closed pull request #1126: Gcs connector URL: https://github.com/apache/hadoop/pull/1126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] commanderchewbacca opened a new pull request #1126: Gcs connector

2019-07-18 Thread GitBox
commanderchewbacca opened a new pull request #1126: Gcs connector URL: https://github.com/apache/hadoop/pull/1126 added gcs connector to images to allow for gcs use for operator-metering This is an automated message from the

[jira] [Commented] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Josh Rosen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888419#comment-16888419 ] Josh Rosen commented on HADOOP-16437: - A fallback configuration is an interesting idea. I guess the

[GitHub] [hadoop] hadoop-yetus commented on issue #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration URL: https://github.com/apache/hadoop/pull/1125#issuecomment-513048431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-513043559 :broken_heart: **-1 overall** | Vote | Subsystem |

[GitHub] [hadoop] hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-513032608 :broken_heart: **-1 overall** | Vote | Subsystem |

[jira] [Commented] (HADOOP-13868) New defaults for S3A multi-part configuration

2019-07-18 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888395#comment-16888395 ] Sean Mackrory commented on HADOOP-13868: Bit-rot after only 2 1/2 years? Imagine that! Actually

[GitHub] [hadoop] mackrorysd opened a new pull request #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration

2019-07-18 Thread GitBox
mackrorysd opened a new pull request #1125: HADOOP-13868. [s3a] New default for S3A multi-part configuration URL: https://github.com/apache/hadoop/pull/1125 This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-13868) New defaults for S3A multi-part configuration

2019-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888392#comment-16888392 ] Hadoop QA commented on HADOOP-13868: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on issue #1108: HDDS-1805. Implement S3 Initiate MPU request to use Cache and DoubleBuffer.

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1108: HDDS-1805. Implement S3 Initiate MPU request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1108#issuecomment-513019346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-13868) New defaults for S3A multi-part configuration

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888382#comment-16888382 ] Steve Loughran commented on HADOOP-13868: - LGTM +1 > New defaults for S3A multi-part

[jira] [Commented] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888377#comment-16888377 ] Hudson commented on HADOOP-16437: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16955 (See

[GitHub] [hadoop] steveloughran merged pull request #1117: HADOOP-16437 documentation typo fix: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread GitBox
steveloughran merged pull request #1117: HADOOP-16437 documentation typo fix: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise URL: https://github.com/apache/hadoop/pull/1117 This is an automated message

[jira] [Commented] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888374#comment-16888374 ] Steve Loughran commented on HADOOP-16437: - thanks. Applied. We're probably going to have to

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305137102 ## File path:

[jira] [Updated] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16437: Fix Version/s: 3.3.0 > Documentation typos: fs.s3a.experimental.fadvise -> >

[jira] [Updated] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16437: Affects Version/s: 3.3.0 3.2.0 3.1.2 >

[jira] [Updated] (HADOOP-16437) Documentation typos: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16437: Component/s: fs/s3 > Documentation typos: fs.s3a.experimental.fadvise -> >

[GitHub] [hadoop] steveloughran commented on issue #1117: HADOOP-16437 documentation typo fix: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise

2019-07-18 Thread GitBox
steveloughran commented on issue #1117: HADOOP-16437 documentation typo fix: fs.s3a.experimental.fadvise -> fs.s3a.experimental.input.fadvise URL: https://github.com/apache/hadoop/pull/1117#issuecomment-513008816 +1 ,committed

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305134924 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305135149 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305134884 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305134992 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305113822 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou…

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou… URL: https://github.com/apache/hadoop/pull/1067#issuecomment-512994540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-512990741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-18 Thread GitBox
swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r305115724 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBStore.java

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305113822 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-18 Thread GitBox
swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r305113051 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305113075 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512985848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-18 Thread GitBox
swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r305112491 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API.

2019-07-18 Thread GitBox
swagle commented on a change in pull request #1033: HDDS-1391 : Add ability in OM to serve delta updates through an API. URL: https://github.com/apache/hadoop/pull/1033#discussion_r305112491 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305111915 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305108487 ## File path:

[GitHub] [hadoop] hanishakoneru commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512981397 > **Question:** > In ShouldInstallSnapshot, it calls getLatestSnapshot() from

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305104705 ## File path:

[GitHub] [hadoop] xiaoyuyao merged pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
xiaoyuyao merged pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] xiaoyuyao commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
xiaoyuyao commented on issue #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#issuecomment-512974489 +1. Thanks @adoroszlai for fixing this. I will merge this shortly.

[jira] [Comment Edited] (HADOOP-16311) Hadoop build failure - natively on ARM (armv7) - oom_listener_main.c issues

2019-07-18 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888027#comment-16888027 ] AiBe Gee edited comment on HADOOP-16311 at 7/18/19 8:24 PM: [~tonyharvey]

[GitHub] [hadoop] hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124#issuecomment-512967762 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.

2019-07-18 Thread GitBox
bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-512952595 This is ready for review. Rebased with the latest trunk, as now HDDS-1689 got checked in.

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes

2019-07-18 Thread GitBox
adoroszlai commented on a change in pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120#discussion_r305071450 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1123: HADOOP-16380 tombstones

2019-07-18 Thread GitBox
hadoop-yetus commented on issue #1123: HADOOP-16380 tombstones URL: https://github.com/apache/hadoop/pull/1123#issuecomment-512944956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] adoroszlai removed a comment on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager

2019-07-18 Thread GitBox
adoroszlai removed a comment on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager URL: https://github.com/apache/hadoop/pull/1122#issuecomment-512936966 rebuild This is an automated message from the

[GitHub] [hadoop] adoroszlai commented on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager

2019-07-18 Thread GitBox
adoroszlai commented on issue #1122: YARN-9679. Regular code cleanup in TestResourcePluginManager URL: https://github.com/apache/hadoop/pull/1122#issuecomment-512936966 rebuild This is an automated message from the Apache

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305056316 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305053446 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305053446 ## File path:

[GitHub] [hadoop] avijayanhwx commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
avijayanhwx commented on issue #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124#issuecomment-512929603 /label ozone This is an automated message

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305052177 ## File path:

[GitHub] [hadoop] avijayanhwx opened a new pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli…

2019-07-18 Thread GitBox
avijayanhwx opened a new pull request #1124: HDDS-1749 : Ozone Client should randomize the list of nodes in pipeli… URL: https://github.com/apache/hadoop/pull/1124 …ne for reads. Currently the list of nodes returned by SCM are static and are returned in the same order to all the

[GitHub] [hadoop] goiri commented on issue #1040: HDFS-13693. Remove unnecessary search in INodeDirectory.addChild during image loa…

2019-07-18 Thread GitBox
goiri commented on issue #1040: HDFS-13693. Remove unnecessary search in INodeDirectory.addChild during image loa… URL: https://github.com/apache/hadoop/pull/1040#issuecomment-512928429 The parallel life of JIRAs and PRs is driving me a little crazy. We have both the patch and the diff

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305048987 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305047773 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305047773 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305046862 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305044258 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305041874 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305041731 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039831 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039875 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039471 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305038252 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305035508 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305032543 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305030842 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305030343 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305029959 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305029702 ## File path:

[GitHub] [hadoop] arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512908324 I am mostly +1 on this change. Couple of minor comments and one thing I requested Bharat

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
hanishakoneru commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305028836 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305019890 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on issue #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#issuecomment-512907214 **Question:** In ShouldInstallSnapshot, it calls getLatestSnapshot() from

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r304690480 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305027589 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r304689358 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state

2019-07-18 Thread GitBox
arp7 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305026829 ## File path:

  1   2   >