[GitHub] [hadoop] adoroszlai commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai…

2019-08-26 Thread GitBox
adoroszlai commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai… URL: https://github.com/apache/hadoop/pull/1328#issuecomment-524756845 @pingsutw unfortunately it's not available from the `IOException`; `rootCause` is a `StateMachineException` and

[GitHub] [hadoop] iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r317531708 ## File path: LICENSE-binary ## @@ -0,0 +1,532 @@ + + Apache Licen

[GitHub] [hadoop] iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#issuecomment-524799624 I built dists with latest patch. Assembly part looks good overall. * built tarball and source-taball by "mvn package -Psrc,dist".

[GitHub] [hadoop] iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#issuecomment-524800266 CDDLs are not contained in licenses-binary. This is an automated mes

[jira] [Reopened] (HADOOP-16193) add extra S3A MPU test to see what happens if a file is created during the MPU

2019-08-26 Thread Ewan Higgs (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewan Higgs reopened HADOOP-16193: - I must have made a mistake in testing this. Re-reviewing it, it's not possible for this to work an

[jira] [Updated] (HADOOP-16531) Log more detail for slow RPC

2019-08-26 Thread Chen Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhang updated HADOOP-16531: Status: Patch Available (was: Open) upload patch v1. > Log more detail for slow RPC > -

[jira] [Updated] (HADOOP-16531) Log more detail for slow RPC

2019-08-26 Thread Chen Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhang updated HADOOP-16531: Attachment: HADOOP-16531.001.patch > Log more detail for slow RPC >

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden URL: https://github.com/apache/hadoop/pull/533#issuecomment-523064629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtim

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden URL: https://github.com/apache/hadoop/pull/533#issuecomment-522098790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtim

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #533: HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden URL: https://github.com/apache/hadoop/pull/533#issuecomment-523936173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtim

[jira] [Commented] (HADOOP-16193) add extra S3A MPU test to see what happens if a file is created during the MPU

2019-08-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915714#comment-16915714 ] Hudson commented on HADOOP-16193: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[jira] [Updated] (HADOOP-16152) Upgrade Eclipse Jetty version to 9.4.x

2019-08-26 Thread Yuming Wang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuming Wang updated HADOOP-16152: - Description: Some big data projects have been upgraded Jetty to 9.4.x, which causes some compa

[GitHub] [hadoop] adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349#issuecomment-524833276 /label ozone This is an automated message from the Ap

[GitHub] [hadoop] adoroszlai opened a new pull request #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
adoroszlai opened a new pull request #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349 ## What changes were proposed in this pull request? Only allow a single read/write operation for the same path in `ChunkUtils`,

[jira] [Commented] (HADOOP-16531) Log more detail for slow RPC

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915775#comment-16915775 ] Hadoop QA commented on HADOOP-16531: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-15998) Jar validation bash scripts don't work on Windows due to platform differences (colons in paths, \r\n)

2019-08-26 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915797#comment-16915797 ] Sean Busbey commented on HADOOP-15998: -- Thanks Rohith. [~briangru] or [~giovanni.

[GitHub] [hadoop] hadoop-yetus commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state URL: https://github.com/apache/hadoop/pull/1319#issuecomment-524871271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Co

[jira] [Updated] (HADOOP-15602) Support SASL Rpc request handling in separate Handlers

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated HADOOP-15602: -- Target Version/s: 3.1.4 (was: 3.1.3) > Support SASL Rpc request handling in separate Handler

[jira] [Commented] (HADOOP-15602) Support SASL Rpc request handling in separate Handlers

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915802#comment-16915802 ] Zhankun Tang commented on HADOOP-15602: --- Bulk update: Preparing for 3.1.3 release

[jira] [Comment Edited] (HADOOP-16310) Log of a slow RPC request should contain the parameter of the request

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915805#comment-16915805 ] Zhankun Tang edited comment on HADOOP-16310 at 8/26/19 2:03 PM: -

[jira] [Updated] (HADOOP-16310) Log of a slow RPC request should contain the parameter of the request

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated HADOOP-16310: -- Target Version/s: 3.1.4 (was: 3.1.2) > Log of a slow RPC request should contain the paramete

[jira] [Commented] (HADOOP-16310) Log of a slow RPC request should contain the parameter of the request

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915805#comment-16915805 ] Zhankun Tang commented on HADOOP-16310: --- Bulk update: Preparing for 3.1.3 release

[GitHub] [hadoop] steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-26 Thread GitBox
steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r317621630 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java

[jira] [Updated] (HADOOP-16082) FsShell ls: Add option -i to print inode id

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated HADOOP-16082: -- Target Version/s: 3.3.0, 3.2.1, 3.1.4 (was: 3.3.0, 3.2.1, 3.1.3) > FsShell ls: Add option -i

[jira] [Commented] (HADOOP-16082) FsShell ls: Add option -i to print inode id

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915816#comment-16915816 ] Zhankun Tang commented on HADOOP-16082: --- Bulk update: Preparing for 3.1.3 release

[jira] [Updated] (HADOOP-16083) DistCp shouldn't always overwrite the target file when checksums match

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated HADOOP-16083: -- Target Version/s: 3.3.0, 3.2.1, 3.1.4 (was: 3.3.0, 3.2.1, 3.1.3) > DistCp shouldn't always o

[jira] [Commented] (HADOOP-16083) DistCp shouldn't always overwrite the target file when checksums match

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915817#comment-16915817 ] Zhankun Tang commented on HADOOP-16083: --- Bulk update: Preparing for 3.1.3 release

[jira] [Updated] (HADOOP-15747) warning about user:pass in URI to explicitly call out Hadoop 3.2 as removal

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated HADOOP-15747: -- Target Version/s: 2.10.0, 3.0.4, 3.1.4 (was: 2.10.0, 3.0.4, 3.1.3) > warning about user:pass

[jira] [Commented] (HADOOP-15747) warning about user:pass in URI to explicitly call out Hadoop 3.2 as removal

2019-08-26 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915822#comment-16915822 ] Zhankun Tang commented on HADOOP-15747: --- Bulk update: Preparing for 3.1.3 release

[GitHub] [hadoop] symat opened a new pull request #1350: YARN-9783. Remove low-level zookeeper test to be able to build Hadoop against zookeeper 3.5.5

2019-08-26 Thread GitBox
symat opened a new pull request #1350: YARN-9783. Remove low-level zookeeper test to be able to build Hadoop against zookeeper 3.5.5 URL: https://github.com/apache/hadoop/pull/1350 Currently the Hadoop build (with ZooKeeper 3.5.5) fails because of a YARN test case: TestSecureRegistry.testL

[GitHub] [hadoop] bshashikant commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state

2019-08-26 Thread GitBox
bshashikant commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state URL: https://github.com/apache/hadoop/pull/1319#issuecomment-524886343 Thanks @lokeshj1703 for updating the patch . The patch looks good to me. I am +1 on this c

[jira] [Commented] (HADOOP-15602) Support SASL Rpc request handling in separate Handlers

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915861#comment-16915861 ] Hadoop QA commented on HADOOP-15602: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349#issuecomment-524890575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349#issuecomment-524892662 /retest This is an automated message from the Apache

[GitHub] [hadoop] nandakumar131 opened a new pull request #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
nandakumar131 opened a new pull request #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1351 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hadoop] nandakumar131 opened a new pull request #1352: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
nandakumar131 opened a new pull request #1352: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1352 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Created] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2019-08-26 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-16532: --- Summary: TestViewFsTrash uses home directory of real fs; brittle Key: HADOOP-16532 URL: https://issues.apache.org/jira/browse/HADOOP-16532 Project: Hadoop Common

[jira] [Commented] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2019-08-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915904#comment-16915904 ] Steve Loughran commented on HADOOP-16532: - me {code} java.lang.AssertionError:

[jira] [Commented] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2019-08-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915903#comment-16915903 ] Steve Loughran commented on HADOOP-16532: - yetus {code} Running org.apache.hado

[jira] [Commented] (HADOOP-15361) RawLocalFileSystem should use Java nio framework for rename

2019-08-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915908#comment-16915908 ] Steve Loughran commented on HADOOP-15361: - [~boky01] -stick this up as a PR to

[jira] [Commented] (HADOOP-16083) DistCp shouldn't always overwrite the target file when checksums match

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915907#comment-16915907 ] Hadoop QA commented on HADOOP-16083: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-517990909 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-523063714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-522253684 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-519335098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-519469472 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#issuecomment-522086393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
steveloughran commented on a change in pull request #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#discussion_r317675782 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] steveloughran commented on a change in pull request #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

2019-08-26 Thread GitBox
steveloughran commented on a change in pull request #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c… URL: https://github.com/apache/hadoop/pull/1222#discussion_r317676033 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] xiaoyuyao commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

2019-08-26 Thread GitBox
xiaoyuyao commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-524922722 +1, Thanks @bharatviswa504 for the update. Thi

[jira] [Commented] (HADOOP-15361) RawLocalFileSystem should use Java nio framework for rename

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915917#comment-16915917 ] Hadoop QA commented on HADOOP-15361: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] dineshchitlangia commented on issue #1352: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
dineshchitlangia commented on issue #1352: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1352#issuecomment-524924019 LGTM, +1 non-binding, pending Jenkins This is an automated mess

[GitHub] [hadoop] pingsutw commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai…

2019-08-26 Thread GitBox
pingsutw commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai… URL: https://github.com/apache/hadoop/pull/1328#issuecomment-524932029 @adoroszlai Thanks for your help Updated the patch --

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317121487 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java ##

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317673438 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java ## @@ -

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317672618 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java ## @@ -

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317563960 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java ## @@ -0,0 +

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317652114 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopFsValidator.java ## @@ -0

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317563795 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java ## @@ -0,0 +

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317648557 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java ## @@ -

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317121604 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java ##

[GitHub] [hadoop] adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
adoroszlai commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349#issuecomment-524934246 @anuengineer @bshashikant @elek please review This is

[jira] [Updated] (HADOOP-16485) Remove dependency on jackson

2019-08-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-16485: - Labels: release-blocker (was: ) > Remove dependency on jackson > -

[jira] [Updated] (HADOOP-16530) Update xercesImpl in branch-2

2019-08-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-16530: - Labels: release-blocker (was: ) > Update xercesImpl in branch-2 >

[jira] [Updated] (HADOOP-16439) Upgrade bundled Tomcat in branch-2

2019-08-26 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-16439: - Labels: release-blocker (was: ) > Upgrade bundled Tomcat in branch-2 > ---

[GitHub] [hadoop] elek commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

2019-08-26 Thread GitBox
elek commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto URL: https://github.com/apache/hadoop/pull/1345#issuecomment-524952097 We can also use the existing metadata hashmap to store these kind of data. It would make it more easy to add more featu

[GitHub] [hadoop] dineshchitlangia commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

2019-08-26 Thread GitBox
dineshchitlangia commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto URL: https://github.com/apache/hadoop/pull/1345#issuecomment-524953767 > We can also use the existing metadata hashmap to store these kind of data. It would make it more easy to

[GitHub] [hadoop] dineshchitlangia edited a comment on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

2019-08-26 Thread GitBox
dineshchitlangia edited a comment on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto URL: https://github.com/apache/hadoop/pull/1345#issuecomment-524953767 > We can also use the existing metadata hashmap to store these kind of data. It would make it more e

[GitHub] [hadoop] dineshchitlangia commented on issue #1340: HDDS-2021. Upgrade Guava library to v26 in hdds project

2019-08-26 Thread GitBox
dineshchitlangia commented on issue #1340: HDDS-2021. Upgrade Guava library to v26 in hdds project URL: https://github.com/apache/hadoop/pull/1340#issuecomment-524956616 > @dineshchitlangia I think we have a build issue, can you please check? @anuengineer After rebasing to trunk, I s

[GitHub] [hadoop] dineshchitlangia edited a comment on issue #1340: HDDS-2021. Upgrade Guava library to v26 in hdds project

2019-08-26 Thread GitBox
dineshchitlangia edited a comment on issue #1340: HDDS-2021. Upgrade Guava library to v26 in hdds project URL: https://github.com/apache/hadoop/pull/1340#issuecomment-524956616 > @dineshchitlangia I think we have a build issue, can you please check? @anuengineer After rebasing to tru

[GitHub] [hadoop] bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

2019-08-26 Thread GitBox
bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-524964926 Thank You @xiaoyuyao for the review. I will commit this to the trunk. -

[GitHub] [hadoop] bharatviswa504 merged pull request #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

2019-08-26 Thread GitBox
bharatviswa504 merged pull request #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315 This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
adoroszlai commented on a change in pull request #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1351#discussion_r317728393 ## File path: hadoop-hdds/server-scm/pom.xml ## @@ -100,10 +100,6 @@ https://maven.apache.org/xsd/m

[GitHub] [hadoop] anuengineer commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently

2019-08-26 Thread GitBox
anuengineer commented on issue #1349: HDDS-2026. Overlapping chunk region cannot be read concurrently URL: https://github.com/apache/hadoop/pull/1349#issuecomment-524973708 LGTM, I will test it to make sure it works as expected. I will also wait for others to comment and then commit.

[GitHub] [hadoop] hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-524975812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hadoop] hadoop-yetus commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient URL: https://github.com/apache/hadoop/pull/1329#issuecomment-524983994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] anuengineer commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
anuengineer commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1351#issuecomment-524988662 Nanda, it might be a good idea to depend on version 3.1.0, @arp7, @jnp can we do that in this pull request ? --

[GitHub] [hadoop] anuengineer commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
anuengineer commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1351#issuecomment-524988938 @elek are there any known issues if we depend on 3.1.0? like the OzoneFS ?

[GitHub] [hadoop] xiaoyuyao opened a new pull request #1353: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-26 Thread GitBox
xiaoyuyao opened a new pull request #1353: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1353 This is to verify cherry-pick HDDS-1927 from trunk to ozone-0.4.1 …buted by Xiaoyu Yao. Signed-off-by: Anu Engineer

[GitHub] [hadoop] elek commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

2019-08-26 Thread GitBox
elek commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto URL: https://github.com/apache/hadoop/pull/1345#issuecomment-524999802 Cool. But why do we add the gdprEnabled flag as a dedicated field in the protocol instead of adding a [gdprEnabled]=tru

[GitHub] [hadoop] dineshchitlangia commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

2019-08-26 Thread GitBox
dineshchitlangia commented on issue #1345: HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto URL: https://github.com/apache/hadoop/pull/1345#issuecomment-525003014 > Cool. But why do we add the gdprEnabled flag as a dedicated field in the protocol instead of adding a [gd

[GitHub] [hadoop] hadoop-yetus commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient URL: https://github.com/apache/hadoop/pull/1329#issuecomment-525021740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] nandakumar131 commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml.

2019-08-26 Thread GitBox
nandakumar131 commented on issue #1351: HDDS-2037. Fix hadoop version in pom.ozone.xml. URL: https://github.com/apache/hadoop/pull/1351#issuecomment-525027240 @anuengineer Until now all the testing is done with hadoop 3.2.0 and also the previous ozone release (0.4.0-alpha) was done with ha

[GitHub] [hadoop] xiaoyuyao commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…

2019-08-26 Thread GitBox
xiaoyuyao commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m… URL: https://github.com/apache/hadoop/pull/1311#issuecomment-525044434 The test failure in TestSecureContainerServer seems related. Can you take a look @vivekratnavel --

[GitHub] [hadoop] hadoop-yetus commented on issue #1353: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1353: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1353#issuecomment-525046724 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] vivekratnavel commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…

2019-08-26 Thread GitBox
vivekratnavel commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m… URL: https://github.com/apache/hadoop/pull/1311#issuecomment-525051986 Hi @xiaoyuyao I checked the cause of failure for this integration test `TestSecureContainerServer.te

[GitHub] [hadoop] vivekratnavel commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…

2019-08-26 Thread GitBox
vivekratnavel commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m… URL: https://github.com/apache/hadoop/pull/1311#issuecomment-525066689 Created https://issues.apache.org/jira/browse/HDDS-2040 to track the integration test failure.

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-26 Thread GitBox
hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-524522115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hadoop] bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-26 Thread GitBox
bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-525076456 /retest This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r317864952 ## File path: LICENSE-binary ## @@ -0,0 +1,532 @@ + + Apache Licens

[GitHub] [hadoop] aajisaka commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
aajisaka commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#issuecomment-525102811 > CDDLs are not contained in licenses-binary. Added licenses-binary/LICENSE-cddl-gplv2-ce.txt -

[jira] [Commented] (HADOOP-16485) Remove dependency on jackson

2019-08-26 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916288#comment-16916288 ] Akira Ajisaka commented on HADOOP-16485: bq. We should get rid of org.codehaus.

[jira] [Commented] (HADOOP-16485) Remove dependency on jackson

2019-08-26 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916289#comment-16916289 ] Akira Ajisaka commented on HADOOP-16485: bq. So what is the rule? IMHO, securi

[jira] [Commented] (HADOOP-16530) Update xercesImpl in branch-2

2019-08-26 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916293#comment-16916293 ] Masatake Iwasaki commented on HADOOP-16530: --- Thanks for working on this, [~jo

[jira] [Created] (HADOOP-16533) Update jackson-databind to 2.9.9.3

2019-08-26 Thread Akira Ajisaka (Jira)
Akira Ajisaka created HADOOP-16533: -- Summary: Update jackson-databind to 2.9.9.3 Key: HADOOP-16533 URL: https://issues.apache.org/jira/browse/HADOOP-16533 Project: Hadoop Common Issue Type:

[jira] [Updated] (HADOOP-16533) Update jackson-databind to 2.9.9.3

2019-08-26 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16533: --- Issue Type: Bug (was: Improvement) > Update jackson-databind to 2.9.9.3 >

[jira] [Updated] (HADOOP-16533) Update jackson-databind to 2.9.9.3

2019-08-26 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16533: --- Target Version/s: 3.3.0 > Update jackson-databind to 2.9.9.3 >

[GitHub] [hadoop] iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
iwasakims commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#issuecomment-525128588 +1. Thanks for the update. Further nits (of original LICENSE.txt) should be fixed in follow-ups. Once the split is done, reviewing th

[GitHub] [hadoop] hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-26 Thread GitBox
hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-525128821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] aajisaka commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

2019-08-26 Thread GitBox
aajisaka commented on issue #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#issuecomment-525135870 Committed. Thank you, @iwasakims ! This is an automated message from

  1   2   >