[jira] [Work logged] (HADOOP-17115) Replace Guava Sets usage by Hadoop's own Sets

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?focusedWorklogId=597857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597857 ] ASF GitHub Bot logged work on HADOOP-17115: --- Author: ASF GitHub Bot

[GitHub] [hadoop] busbey commented on a change in pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-17 Thread GitBox
busbey commented on a change in pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#discussion_r632984329 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Sets.java ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache

[jira] [Work logged] (HADOOP-17115) Replace Guava Sets usage by Hadoop's own Sets

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17115?focusedWorklogId=597847=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597847 ] ASF GitHub Bot logged work on HADOOP-17115: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17700) ExitUtil#halt info log with incorrect placeholders

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17700?focusedWorklogId=597843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597843 ] ASF GitHub Bot logged work on HADOOP-17700: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3015: HADOOP-17700. ExitUtil#halt info log should log HaltException

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3015: URL: https://github.com/apache/hadoop/pull/3015#issuecomment-841795763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hadoop] hadoop-yetus commented on pull request #2985: HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2985: URL: https://github.com/apache/hadoop/pull/2985#issuecomment-841809785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Work logged] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?focusedWorklogId=597832=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597832 ] ASF GitHub Bot logged work on HADOOP-13887: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2706: HADOOP-13887. Support S3 client side encryption (S3-CSE) using AWS-SDK

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2706: URL: https://github.com/apache/hadoop/pull/2706#issuecomment-841789913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2998: HDFS-16016. BPServiceActor to provide new thread to handle IBR

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2998: URL: https://github.com/apache/hadoop/pull/2998#issuecomment-841760389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hadoop] hadoop-yetus commented on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842490494 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17689) Avoid Potential NPE in org.apache.hadoop.fs

2021-05-17 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346262#comment-17346262 ] Takanobu Asanuma commented on HADOOP-17689: --- [~quanli] I'm not sure whether it actually

[GitHub] [hadoop] hadoop-yetus commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-842471198 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-17689) Avoid Potential NPE in org.apache.hadoop.fs

2021-05-17 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346257#comment-17346257 ] Takanobu Asanuma commented on HADOOP-17689: --- [~vjasani] Sorry I overlooked your last comment. 

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=597769=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597769 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3020: URL: https://github.com/apache/hadoop/pull/3020#issuecomment-842465032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597763=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597763 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842461374 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17694) abfs: Unable to use OAuth authentication at storage account level if the default authn type is Custom

2021-05-17 Thread Sneha Vijayarajan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346249#comment-17346249 ] Sneha Vijayarajan commented on HADOOP-17694: [~arunravimv] - This is already fixed in trunk

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=597753=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597753 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] bogthe commented on a change in pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-17 Thread GitBox
bogthe commented on a change in pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#discussion_r633141325 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/store/HttpReferrerAuditHeader.java ## @@ -0,0 +1,500 @@ +/* + *

[jira] [Work logged] (HADOOP-17669) Port HADOOP-17079, HADOOP-17505 to branch-3.3

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17669?focusedWorklogId=597747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597747 ] ASF GitHub Bot logged work on HADOOP-17669: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2959: HADOOP-17669. Port HADOOP-17079, HADOOP-17505 to branch-3.3

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2959: URL: https://github.com/apache/hadoop/pull/2959#issuecomment-842438940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17700) ExitUtil#halt info log with incorrect placeholders

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17700?focusedWorklogId=597746=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597746 ] ASF GitHub Bot logged work on HADOOP-17700: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3015: HADOOP-17700. ExitUtil#halt info log should log HaltException

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3015: URL: https://github.com/apache/hadoop/pull/3015#issuecomment-842438420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?focusedWorklogId=597725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597725 ] ASF GitHub Bot logged work on HADOOP-17705: --- Author: ASF GitHub Bot

[jira] [Updated] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17705: Labels: pull-request-available (was: ) > S3A to add Config to set AWS region >

[GitHub] [hadoop] mehakmeet opened a new pull request #3020: HADOOP-17705. S3A to add Config to set AWS region

2021-05-17 Thread GitBox
mehakmeet opened a new pull request #3020: URL: https://github.com/apache/hadoop/pull/3020 Tested by: mvn clean verify -Dparallel-tests -Dscale Region: ap-south-1 Test: ``` [INFO] Results: [INFO] [WARNING] Tests run: 537, Failures: 0, Errors: 0, Skipped: 5 ```

[GitHub] [hadoop] hadoop-yetus commented on pull request #3018: HDFS-16027. Replace abstract methods with default methods in JournalNodeMXBean

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3018: URL: https://github.com/apache/hadoop/pull/3018#issuecomment-842389544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-842369612 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-842369309 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597665=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597665 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842356693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=597660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597660 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-842351843 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=597647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597647 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-17 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-842340255 +git showing some log output during a terasort test https://gist.github.com/steveloughran/8e0aadb51c63f1c3538deda19ee952ae some of the events (e.g

[GitHub] [hadoop] hadoop-yetus commented on pull request #2496: YARN-10502. Add backlogs metric for CapacityScheduler

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2496: URL: https://github.com/apache/hadoop/pull/2496#issuecomment-842339473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597639=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597639 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842335209 On Ubuntu 18.04, OpensslSm4CtrCryptoCodec was available and worked. ``` $ bin/hadoop key create key-sm4 -cipher 'SM4/CTR/NoPadding' $ bin/hdfs dfs -mkdir /zone1

[GitHub] [hadoop] hadoop-yetus commented on pull request #3005: HDFS-13522. RBF: Support observer node from Router-Based Federation

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3005: URL: https://github.com/apache/hadoop/pull/3005#issuecomment-842320011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-842317253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597622 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842313287 On CentOS 8, OpensslAesCtrCryptoCodec is available while OpensslSm4CtrCryptoCodec is not. ``` $ bin/hadoop checknative 2021-05-17 13:02:39,196 DEBUG

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597613 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842303136 On CentOS 8, only `TestCryptoCodec#testOpensslSm4CtrCryptoCodec` was skipped as expected. ``` $ mvn test -Pnative -Dtest=TestCryptoCodec,TestOpensslCipher ...

[jira] [Work logged] (HADOOP-17700) ExitUtil#halt info log with incorrect placeholders

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17700?focusedWorklogId=597611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597611 ] ASF GitHub Bot logged work on HADOOP-17700: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3015: HADOOP-17700. ExitUtil#halt info log should log HaltException

2021-05-17 Thread GitBox
virajjasani commented on pull request #3015: URL: https://github.com/apache/hadoop/pull/3015#issuecomment-842299732 I think it would be fair to remove DEBUG log given that INFO level stacktrace is anyways going to be logged. -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] hadoop-yetus commented on pull request #881: YARN-2774. support secure clusters in shared cache manager

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #881: URL: https://github.com/apache/hadoop/pull/881#issuecomment-842289293 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17677) Distcp is unable to determine region with S3 PrivateLink endpoints

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346127#comment-17346127 ] Steve Loughran commented on HADOOP-17677: - all the logic to determine region seems to break

[jira] [Updated] (HADOOP-17677) Distcp is unable to determine region with S3 PrivateLink endpoints

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17677: Component/s: fs/s3 > Distcp is unable to determine region with S3 PrivateLink endpoints

[jira] [Work logged] (HADOOP-17700) ExitUtil#halt info log with incorrect placeholders

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17700?focusedWorklogId=597586=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597586 ] ASF GitHub Bot logged work on HADOOP-17700: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3015: HADOOP-17700. ExitUtil#halt info log should log HaltException

2021-05-17 Thread GitBox
steveloughran commented on pull request #3015: URL: https://github.com/apache/hadoop/pull/3015#issuecomment-842281065 +1 One aspect of the Exit code design was that returning != 0 doesn't mean print a stack trace at info. So the exit() calls must only log the message at info, full

[jira] [Updated] (HADOOP-17705) S3A to add Config to set AWS region

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17705: Summary: S3A to add Config to set AWS region (was: Config to set AWS region) > S3A to

[jira] [Updated] (HADOOP-17705) Config to set AWS region

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17705: Parent: HADOOP-17566 Issue Type: Sub-task (was: Bug) > Config to set AWS region

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597575=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597575 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842271339 I need additional fix to make falling back to JceSm4CtrCryptoCodec work. Tests should be fixed too. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on pull request #2966: HDFS-16004.startLogSegment and journal in BackupNode lack Permission …

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #2966: URL: https://github.com/apache/hadoop/pull/2966#issuecomment-842256549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597556=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597556 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims edited a comment on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims edited a comment on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842245830 I manually tested this by `hadoop checknative` after `-Pnative -Pdist` build on CentOS 8. ``` $ mvn clean install -DskipTests -DskipShade -Pnative -Pdist $

[jira] [Updated] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-17609: -- Status: Patch Available (was: Open) I opened

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597554=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597554 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims commented on pull request #3019: URL: https://github.com/apache/hadoop/pull/3019#issuecomment-842245830 I manually tested this by `hadoop checknative` after `-Pnative -Pdist` build. ``` $ mvn clean install -DskipTests -DskipShade -Pnative -Pdist $

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597553 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims opened a new pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims opened a new pull request #3019: URL: https://github.com/apache/hadoop/pull/3019 https://issues.apache.org/jira/browse/HADOOP-17609 This replaces #2847. After HDFS-15098, OpensslCipher does not work with OpenSSL >= 1.1.1 without SM4 support. RHEL/CentOS 8 provides

[jira] [Work logged] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=597552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597552 ] ASF GitHub Bot logged work on HADOOP-17609: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims closed pull request #2847: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

2021-05-17 Thread GitBox
iwasakims closed pull request #2847: URL: https://github.com/apache/hadoop/pull/2847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HADOOP-17705) Config to set AWS region

2021-05-17 Thread Mehakmeet Singh (Jira)
Mehakmeet Singh created HADOOP-17705: Summary: Config to set AWS region Key: HADOOP-17705 URL: https://issues.apache.org/jira/browse/HADOOP-17705 Project: Hadoop Common Issue Type: Bug

[jira] [Updated] (HADOOP-17609) Make SM4 support optional for OpenSSL native code

2021-05-17 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-17609: -- Status: Open (was: Patch Available) > Make SM4 support optional for OpenSSL native

[jira] [Created] (HADOOP-17704) HADOOP-16916 changed interface SASTokenProvider fields, breaking compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-17704: Summary: HADOOP-16916 changed interface SASTokenProvider fields, breaking compatibility between 3.3.0 and 3.3.1 Key: HADOOP-17704 URL:

[jira] [Commented] (HADOOP-17704) HADOOP-16916 changed interface SASTokenProvider fields, breaking compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346071#comment-17346071 ] Wei-Chiu Chuang commented on HADOOP-17704: -- cc: [~tmarquardt] > HADOOP-16916 changed

[jira] [Commented] (HADOOP-17704) HADOOP-16916 changed interface SASTokenProvider fields, breaking compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346070#comment-17346070 ] Wei-Chiu Chuang commented on HADOOP-17704: -- package org.apache.hadoop.fs.azurebfs.extensions

[jira] [Comment Edited] (HADOOP-16916) ABFS: Delegation SAS generator for integration with Ranger

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346062#comment-17346062 ] Wei-Chiu Chuang edited comment on HADOOP-16916 at 5/17/21, 10:45 AM:

[jira] [Commented] (HADOOP-16916) ABFS: Delegation SAS generator for integration with Ranger

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346062#comment-17346062 ] Wei-Chiu Chuang commented on HADOOP-16916: -- This is a potential breaker for Ranger. It changed

[GitHub] [hadoop] zhuxiangyi commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
zhuxiangyi commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842217065 @ferhui > If the baseTrashPath does not exist on Ns2, the following rename will fail, is it right? yes,It will fail. For this problem, we can add

[jira] [Work logged] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17703?focusedWorklogId=597531=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597531 ] ASF GitHub Bot logged work on HADOOP-17703: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3017: HADOOP-17703. checkcompatibility.py errors out when specifying annotations.

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3017: URL: https://github.com/apache/hadoop/pull/3017#issuecomment-842212446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17702) HADOOP-17065 breaks compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346051#comment-17346051 ] Steve Loughran commented on HADOOP-17702: - +having just scanned the directory, there's 30+

[jira] [Commented] (HADOOP-17702) HADOOP-17065 breaks compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346048#comment-17346048 ] Steve Loughran commented on HADOOP-17702: - Thanks for spotting this (automatically?) I don't

[jira] [Updated] (HADOOP-17671) Run jacc to check for Hadoop's Java API compat

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17671: - Attachment: report.html > Run jacc to check for Hadoop's Java API compat >

[GitHub] [hadoop] jojochuang opened a new pull request #3018: HDFS-16027. Replace abstract methods with default methods in JournalNodeMXBean

2021-05-17 Thread GitBox
jojochuang opened a new pull request #3018: URL: https://github.com/apache/hadoop/pull/3018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop] ferhui commented on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
ferhui commented on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842181520 @haiyang1987 Thanks for comments. You can push an empty commit to trigger Yutes, and then i will merge this if no problems because the lastest build is on 15 Mar -- This is

[jira] [Work logged] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17703?focusedWorklogId=597519=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597519 ] ASF GitHub Bot logged work on HADOOP-17703: --- Author: ASF GitHub Bot

[jira] [Updated] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17703: Labels: pull-request-available (was: ) > checkcompatibility.py errors out when

[jira] [Work logged] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17703?focusedWorklogId=597518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597518 ] ASF GitHub Bot logged work on HADOOP-17703: --- Author: ASF GitHub Bot

[GitHub] [hadoop] jojochuang commented on pull request #3017: HADOOP-17703. checkcompatibility.py errors out when specifying annotations.

2021-05-17 Thread GitBox
jojochuang commented on pull request #3017: URL: https://github.com/apache/hadoop/pull/3017#issuecomment-842178053 @aajisaka could you help with this trivial patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] jojochuang opened a new pull request #3017: HADOOP-17703. checkcompatibility.py errors out when specifying annotations.

2021-05-17 Thread GitBox
jojochuang opened a new pull request #3017: URL: https://github.com/apache/hadoop/pull/3017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop] hadoop-yetus commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-17 Thread GitBox
hadoop-yetus commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-842177412 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Assigned] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-17703: Assignee: Wei-Chiu Chuang > checkcompatibility.py errors out when specifying

[jira] [Created] (HADOOP-17703) checkcompatibility.py errors out when specifying annotations

2021-05-17 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-17703: Summary: checkcompatibility.py errors out when specifying annotations Key: HADOOP-17703 URL: https://issues.apache.org/jira/browse/HADOOP-17703 Project:

[jira] [Work started] (HADOOP-17671) Run jacc to check for Hadoop's Java API compat

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-17671 started by Wei-Chiu Chuang. > Run jacc to check for Hadoop's Java API compat >

[jira] [Created] (HADOOP-17702) HADOOP-17065 breaks compatibility between 3.3.0 and 3.3.1

2021-05-17 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-17702: Summary: HADOOP-17065 breaks compatibility between 3.3.0 and 3.3.1 Key: HADOOP-17702 URL: https://issues.apache.org/jira/browse/HADOOP-17702 Project: Hadoop

[jira] [Commented] (HADOOP-17671) Run jacc to check for Hadoop's Java API compat

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345980#comment-17345980 ] Wei-Chiu Chuang commented on HADOOP-17671: -- HDFS-15245 adds new methods to the public evolving

[GitHub] [hadoop] ferhui edited a comment on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui edited a comment on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842146030 @zhuxiangyi Thanks for comments! > With this solution, as long as there is a mount point for Trash and the Trash directory exists, Router can move data to Trash.

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842146030 @zhuxiangyi Thanks for comments! > With this solution, as long as there is a mount point for Trash and the Trash directory exists, Router can move data to Trash. I want to

[GitHub] [hadoop] haiyang1987 edited a comment on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
haiyang1987 edited a comment on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842136488 @ferhui Thanks for reviewing. This does not seem to cause any problems in production, However in this case the debug log output execution information is a

[jira] [Commented] (HADOOP-17671) Run jacc to check for Hadoop's Java API compat

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345975#comment-17345975 ] Wei-Chiu Chuang commented on HADOOP-17671: -- HADOOP-17065 is an Evolving Public API that breaks

[jira] [Assigned] (HADOOP-17671) Run jacc to check for Hadoop's Java API compat

2021-05-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-17671: Assignee: Wei-Chiu Chuang > Run jacc to check for Hadoop's Java API compat >

[GitHub] [hadoop] haiyang1987 edited a comment on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
haiyang1987 edited a comment on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842136488 @ferhui Thanks for reviewing. This does not seem to cause any problems in production, However in this case the debug log output execution information is a

[GitHub] [hadoop] haiyang1987 edited a comment on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
haiyang1987 edited a comment on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842136488 @ferhui Thanks for reviewing. This does not seem to cause any problems in production, However in this case the debug log output execution information is a

[GitHub] [hadoop] haiyang1987 commented on pull request #2747: HDFS-15877. BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

2021-05-17 Thread GitBox
haiyang1987 commented on pull request #2747: URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842136488 @ferhui Thanks for reviewing. This does not seem to cause any problems in production, However in this case the debug log output execution information is a problem.

<    1   2   3   >