[GitHub] [hadoop] virajjasani commented on pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

virajjasani commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-995505670 Javadoc warnings are not relevant to the PR changes and can be taken up in a separate Jira. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] aajisaka commented on a change in pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

aajisaka commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r770274630 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminBackoffMonitor.java ## @@ -189,6

[jira] [Updated] (HADOOP-17783) Old JQuery version causing security concerns

[ https://issues.apache.org/jira/browse/HADOOP-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17783: --- Component/s: (was: hdfs-client) > Old JQuery version causing security concerns >

[jira] [Updated] (HADOOP-17783) Old JQuery version causing security concerns

[ https://issues.apache.org/jira/browse/HADOOP-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17783: --- Priority: Major (was: Blocker) > Old JQuery version causing security concerns >

[jira] [Resolved] (HADOOP-17783) Old JQuery version causing security concerns

[ https://issues.apache.org/jira/browse/HADOOP-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-17783. Target Version/s: (was: 3.3.0, 3.3.1) Resolution: Duplicate Closing as

[GitHub] [hadoop] hadoop-yetus commented on pull request #3805: YARN-11050. Typo in method name: RMWebServiceProtocol#removeFromCluserNodeLabels

hadoop-yetus commented on pull request #3805: URL: https://github.com/apache/hadoop/pull/3805#issuecomment-995447067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tasanuma commented on pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

tasanuma commented on pull request #3784: URL: https://github.com/apache/hadoop/pull/3784#issuecomment-995436984 Thanks for your contribution, @tomscut, and thanks for your review, @virajjasani. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tasanuma merged pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

tasanuma merged pull request #3784: URL: https://github.com/apache/hadoop/pull/3784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jojochuang merged pull request #3798: HDFS-16384. Upgrade Netty to 4.1.72.Final

jojochuang merged pull request #3798: URL: https://github.com/apache/hadoop/pull/3798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] tasanuma commented on pull request #3769: HDFS-16375. The FBR lease ID should be exposed to the log

tasanuma commented on pull request #3769: URL: https://github.com/apache/hadoop/pull/3769#issuecomment-995429928 Merged it. Thanks for your contribution, @tomscut! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] tasanuma merged pull request #3769: HDFS-16375. The FBR lease ID should be exposed to the log

tasanuma merged pull request #3769: URL: https://github.com/apache/hadoop/pull/3769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3804: YARN-11049. MutableConfScheduler is referred as plain String instead of class name

hadoop-yetus commented on pull request #3804: URL: https://github.com/apache/hadoop/pull/3804#issuecomment-995390225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3799: YARN-11048. Add tests that shows how to delete config values with Mutation API

hadoop-yetus commented on pull request #3799: URL: https://github.com/apache/hadoop/pull/3799#issuecomment-995385491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3460: YARN-10963. Split TestCapacityScheduler by test categories

hadoop-yetus commented on pull request #3460: URL: https://github.com/apache/hadoop/pull/3460#issuecomment-995385161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] jojochuang commented on pull request #3798: HDFS-16384. Upgrade Netty to 4.1.72.Final

jojochuang commented on pull request #3798: URL: https://github.com/apache/hadoop/pull/3798#issuecomment-995379135 No this is good. We don't use netty for those sub-components so I think we're good here. Will merge later. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] shuzirra commented on a change in pull request #3799: YARN-11048. Add tests that shows how to delete config values with Mutation API

shuzirra commented on a change in pull request #3799: URL: https://github.com/apache/hadoop/pull/3799#discussion_r770173066 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #3754: YARN-11028. Add metrics for container allocation latency

goiri commented on a change in pull request #3754: URL: https://github.com/apache/hadoop/pull/3754#discussion_r770172689 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3800: YARN-10951. CapacityScheduler: Move all fields and initializer code that belongs to async scheduling to a new class

hadoop-yetus commented on pull request #3800: URL: https://github.com/apache/hadoop/pull/3800#issuecomment-995371524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

hadoop-yetus commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-995332962 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3790: HDFS-11242. Support refreshTopology

hadoop-yetus commented on pull request #3790: URL: https://github.com/apache/hadoop/pull/3790#issuecomment-995326904 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tamaashu commented on pull request #3798: HDFS-16384. Upgrade Netty to 4.1.72.Final

tamaashu commented on pull request #3798: URL: https://github.com/apache/hadoop/pull/3798#issuecomment-995310458 @jojochuang to me these test failures look unrelated but still would be good to have a green test. Do you have any special command to restart the testing or should I push an

[GitHub] [hadoop] szilard-nemeth opened a new pull request #3805: YARN-11050. Typo in method name: RMWebServiceProtocol#removeFromCluserNodeLabels

szilard-nemeth opened a new pull request #3805: URL: https://github.com/apache/hadoop/pull/3805 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] szilard-nemeth opened a new pull request #3804: YARN-11049. MutableConfScheduler is referred as plain String instead of class name

szilard-nemeth opened a new pull request #3804: URL: https://github.com/apache/hadoop/pull/3804 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] szilard-nemeth closed pull request #3795: YARN-11044. Fix TestApplicationLimits.testLimitsComputation() ineffective asserts.

szilard-nemeth closed pull request #3795: URL: https://github.com/apache/hadoop/pull/3795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] szilard-nemeth commented on pull request #3795: YARN-11044. Fix TestApplicationLimits.testLimitsComputation() uneffective asserts.

szilard-nemeth commented on pull request #3795: URL: https://github.com/apache/hadoop/pull/3795#issuecomment-995280393 Thanks @brumi1024 for working on this. This is a small, but quite useful patch as these hiding issues are quite difficult to find. LGTM, committed to trunk. --

[GitHub] [hadoop] hadoop-yetus commented on pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

hadoop-yetus commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-995262919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

hadoop-yetus commented on pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#issuecomment-995260480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3741: YARN-11026. Make default AppPlacementAllocator configurable in AppSch…

hadoop-yetus commented on pull request #3741: URL: https://github.com/apache/hadoop/pull/3741#issuecomment-995239471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3778: HDFS-16376. Expose metrics of NodeNotChosenReason to JMX

hadoop-yetus commented on pull request #3778: URL: https://github.com/apache/hadoop/pull/3778#issuecomment-995234967 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3754: YARN-11028. Add metrics for container allocation latency

hadoop-yetus commented on pull request #3754: URL: https://github.com/apache/hadoop/pull/3754#issuecomment-995233093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3772: YARN-11014. YARN incorrectly validates maximum capacity resources on …

hadoop-yetus commented on pull request #3772: URL: https://github.com/apache/hadoop/pull/3772#issuecomment-995175411 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

hadoop-yetus commented on pull request #3784: URL: https://github.com/apache/hadoop/pull/3784#issuecomment-995138990 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] goiri commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

goiri commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769937032 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #3754: YARN-11028. Add metrics for container allocation latency

goiri commented on a change in pull request #3754: URL: https://github.com/apache/hadoop/pull/3754#discussion_r769934084 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3769: HDFS-16375. The FBR lease ID should be exposed to the log

hadoop-yetus commented on pull request #3769: URL: https://github.com/apache/hadoop/pull/3769#issuecomment-995061785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3785: YARN-11042. Fix testQueueSubmitWithACLsEnabledWithQueueMapping in Tes…

hadoop-yetus commented on pull request #3785: URL: https://github.com/apache/hadoop/pull/3785#issuecomment-995045711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3798: HDFS-16384. Upgrade Netty to 4.1.72.Final

hadoop-yetus commented on pull request #3798: URL: https://github.com/apache/hadoop/pull/3798#issuecomment-995030515 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] minni31 commented on a change in pull request #3741: YARN-11026. Make default AppPlacementAllocator configurable in AppSch…

minni31 commented on a change in pull request #3741: URL: https://github.com/apache/hadoop/pull/3741#discussion_r769839953 ## File path:

[GitHub] [hadoop] minni31 commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

minni31 commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769830187 ## File path:

[GitHub] [hadoop] minni31 commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

minni31 commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769828897 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java ## @@ -430,6 +431,7 @@

[GitHub] [hadoop] minni31 commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

minni31 commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769827525 ## File path:

[GitHub] [hadoop] minni31 commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

minni31 commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769827525 ## File path:

[GitHub] [hadoop] minni31 commented on a change in pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

minni31 commented on a change in pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#discussion_r769826143 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

hadoop-yetus commented on pull request #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-994986046 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3799: YARN-11048. Add tests that shows how to delete config values with Mutation API

hadoop-yetus commented on pull request #3799: URL: https://github.com/apache/hadoop/pull/3799#issuecomment-994961073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3704: HDFS-16348. Mark slownode as badnode to recover pipeline

hadoop-yetus commented on pull request #3704: URL: https://github.com/apache/hadoop/pull/3704#issuecomment-994924195 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] ferhui commented on pull request #3803: HDFS-16385. Fix Datanode retrieve slownode information bug.

ferhui commented on pull request #3803: URL: https://github.com/apache/hadoop/pull/3803#issuecomment-994905819 @symious Can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] brumi1024 commented on pull request #3795: YARN-11044. Fix TestApplicationLimits.testLimitsComputation() uneffective asserts.

brumi1024 commented on pull request #3795: URL: https://github.com/apache/hadoop/pull/3795#issuecomment-994868819 The test issue seems to be a known flaky: [YARN-9450](https://issues.apache.org/jira/browse/YARN-9450) -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] liubingxing commented on pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

liubingxing commented on pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#issuecomment-994766378 Thanks for the review @virajjasani @Hexiaoqiao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #3803: HDFS-16385. Fix Datanode retrieve slownode information bug.

hadoop-yetus commented on pull request #3803: URL: https://github.com/apache/hadoop/pull/3803#issuecomment-994733897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani commented on pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

virajjasani commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-994712468 Thank you for confirming on Windows OS @minni31 FYI @jojochuang @aajisaka -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] tomscut commented on a change in pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

tomscut commented on a change in pull request #3784: URL: https://github.com/apache/hadoop/pull/3784#discussion_r769548861 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java ## @@ -967,6 +968,7 @@ private

[GitHub] [hadoop] minni31 commented on pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

minni31 commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-994677344 Thanks @virajjasani for the quick fix. I've tested out changes in my local setup also (windows). Things are looking fine now. -- This is an automated message from the

[GitHub] [hadoop] tasanuma commented on a change in pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

tasanuma commented on a change in pull request #3784: URL: https://github.com/apache/hadoop/pull/3784#discussion_r769497669 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java ## @@ -967,6 +968,7 @@ private

[GitHub] [hadoop] tomscut commented on pull request #3769: HDFS-16375. The FBR lease ID should be exposed to the log

tomscut commented on pull request #3769: URL: https://github.com/apache/hadoop/pull/3769#issuecomment-994619862 Thanks @tasanuma for your comments. I'm in favor of your suggestion and I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tasanuma commented on a change in pull request #3769: HDFS-16375. The FBR lease ID should be exposed to the log

tasanuma commented on a change in pull request #3769: URL: https://github.com/apache/hadoop/pull/3769#discussion_r769458969 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java ## @@ -2763,20 +2765,20 @@

[GitHub] [hadoop] tamaashu commented on pull request #3798: HDFS-16384. Upgrade Netty to 4.1.72.Final

tamaashu commented on pull request #3798: URL: https://github.com/apache/hadoop/pull/3798#issuecomment-994596320 Thanks @jojochuang, I've updated the License file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] virajjasani commented on pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

virajjasani commented on pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#issuecomment-994595002 +1 (non-binding) from my side, thanks @liubingxing and @Hexiaoqiao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] Jackson-Wang-7 opened a new pull request #3803: HDFS-16385. Fix Datanode retrieve slownode information bug.

Jackson-Wang-7 opened a new pull request #3803: URL: https://github.com/apache/hadoop/pull/3803 ### Description of PR in HDFS-16320, the DataNode will retrieve the SLOW status from each NameNode. But it didn't set isSlowNode to HeartbeatResponseProto in

[GitHub] [hadoop] virajjasani opened a new pull request #3802: YARN-11047. ResourceManager and NodeManager unable to connect to Hbase when ATSv2 is enabled

virajjasani opened a new pull request #3802: URL: https://github.com/apache/hadoop/pull/3802 ### Description of PR Yarn ResourceManager and NodeManager in the current state are not able to interact with HBase cluster because of the incompatible guava and guice dependencies being used

[GitHub] [hadoop] jojochuang merged pull request #3796: YARN-11045. ATSv2 storage monitor fails to read from hbase cluster

jojochuang merged pull request #3796: URL: https://github.com/apache/hadoop/pull/3796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jojochuang commented on pull request #3796: YARN-11045. ATSv2 storage monitor fails to read from hbase cluster

jojochuang commented on pull request #3796: URL: https://github.com/apache/hadoop/pull/3796#issuecomment-994506944 +1 based on the good faith of Viraj. Merging it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use