hadoop-yetus commented on pull request #4125:
URL: https://github.com/apache/hadoop/pull/4125#issuecomment-1084203173
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
hadoop-yetus commented on pull request #4124:
URL: https://github.com/apache/hadoop/pull/4124#issuecomment-1084256829
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-18144?focusedWorklogId=750835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-750835
]
ASF GitHub Bot logged work on HADOOP-18144:
---
Author: ASF GitHub B
tomscut commented on pull request #4087:
URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1084285726
> I think this is pretty similar to
https://issues.apache.org/jira/browse/HDFS-14378. If I remember correctly, the
better approach would be to have ANN roll its own edit logs.
hadoop-yetus commented on pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#issuecomment-1084324776
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
virajjasani commented on pull request #4107:
URL: https://github.com/apache/hadoop/pull/4107#issuecomment-1084329656
> It would be much more useful it can be made available on demand at runtime.
HDFS-16396 has good attempt to make it reconfigurable for datanodes, we can
extend the su
tomscut edited a comment on pull request #4087:
URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1084285726
> I think this is pretty similar to
https://issues.apache.org/jira/browse/HDFS-14378. If I remember correctly, the
better approach would be to have ANN roll its own edit
tomscut edited a comment on pull request #4087:
URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1084285726
> I think this is pretty similar to
https://issues.apache.org/jira/browse/HDFS-14378. If I remember correctly, the
better approach would be to have ANN roll its own edit
tomscut removed a comment on pull request #4001:
URL: https://github.com/apache/hadoop/pull/4001#issuecomment-1078572001
Hi @umamaheswararao @tasanuma @Hexiaoqiao @ferhui , could you please take a
look? Thank you very much.
--
This is an automated message from the Apache Git Service.
To
tomscut commented on pull request #4001:
URL: https://github.com/apache/hadoop/pull/4001#issuecomment-1084341924
Hi @umamaheswararao @ayushtkn @tasanuma , could you please take a look at
this? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the me
singer-bin commented on pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#issuecomment-1084354213
@tasanuma Hello, in the method startDFCluster, I set it as follows:
`conf.setClass(FS_GETSPACEUSED_CLASSNAME, DummyCachingGetSpaceUsed.class,
CachingGetSp
zuston commented on pull request #4105:
URL: https://github.com/apache/hadoop/pull/4105#issuecomment-1084362603
The test case failure looks unrelated with this PR. @brumi1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
iwasakims commented on pull request #4107:
URL: https://github.com/apache/hadoop/pull/4107#issuecomment-1084364741
You mean
[HDFS-16327](https://issues.apache.org/jira/browse/HDFS-16327)(#3716) needs
follow-up?
--
This is an automated message from the Apache Git Service.
To respond to t
tasanuma commented on pull request #4125:
URL: https://github.com/apache/hadoop/pull/4125#issuecomment-1084384414
Thanks for the work, @tomscut!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
tasanuma merged pull request #4125:
URL: https://github.com/apache/hadoop/pull/4125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-
virajjasani commented on a change in pull request #4108:
URL: https://github.com/apache/hadoop/pull/4108#discussion_r839439653
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java
##
@@ -319,4 +327,88 @@ public void testSet
[
https://issues.apache.org/jira/browse/HADOOP-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515229#comment-17515229
]
Viraj Jasani commented on HADOOP-18188:
---
{quote}be interesting to see which files
brumi1024 commented on pull request #4105:
URL: https://github.com/apache/hadoop/pull/4105#issuecomment-1084403080
Thanks @zuston, committed to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
brumi1024 closed pull request #4105:
URL: https://github.com/apache/hadoop/pull/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues
9uapaw commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839443638
##
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##
@@ -53,7 +53,7 @@
public class AMRunner {
private sta
szilard-nemeth commented on pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#issuecomment-1084423764
@9uapaw
Thanks for your comment. This is an independent change and the spotbugs
warning was in place before this patch, so I suggest to commit this first then
I will
9uapaw commented on pull request #4117:
URL: https://github.com/apache/hadoop/pull/4117#issuecomment-1084431501
The first spotbugs error could be eliminated by:
- Wrapping inputTraces in an unmodifiable collection or an immutable one
from Guava
The second is trickier, because I have a
hadoop-yetus commented on pull request #3960:
URL: https://github.com/apache/hadoop/pull/3960#issuecomment-1084434622
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
tomscut commented on pull request #4125:
URL: https://github.com/apache/hadoop/pull/4125#issuecomment-1084435821
Thank you @tasanuma .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
hadoop-yetus commented on pull request #4035:
URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1084436796
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
tomscut commented on pull request #4035:
URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1084440796
Hi @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you
very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
tomscut edited a comment on pull request #4035:
URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1084440796
Hi @umamaheswararao @ayushtkn @tasanuma @ferhui , could you please take a
look? Thank you very much.
--
This is an automated message from the Apache Git Service.
To res
virajjasani commented on pull request #4107:
URL: https://github.com/apache/hadoop/pull/4107#issuecomment-1084475215
> You mean
[HDFS-16327](https://issues.apache.org/jira/browse/HDFS-16327)(#3716) needs
follow-up?
I mean HDFS-16396 (#3827) can be extended for namenode as well (reco
virajjasani edited a comment on pull request #4107:
URL: https://github.com/apache/hadoop/pull/4107#issuecomment-1084475215
> You mean
[HDFS-16327](https://issues.apache.org/jira/browse/HDFS-16327)(#3716) needs
follow-up?
I mean HDFS-16396 (#3827) can be extended for namenode as wel
brumi1024 commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839520267
##
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##
@@ -53,7 +53,7 @@
public class AMRunner {
private
zuston commented on pull request #4105:
URL: https://github.com/apache/hadoop/pull/4105#issuecomment-1084483705
Thanks @brumi1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
9uapaw commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839526303
##
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##
@@ -53,7 +53,7 @@
public class AMRunner {
private sta
brumi1024 commented on pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#issuecomment-1084524716
Thanks @szilard-nemeth for the PR, since a different PR exists for the
spotbugs issue I committed this one to trunk. Fixed the indentation checkstyle
issues before merging.
brumi1024 closed pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues
brumi1024 commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839581419
##
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##
@@ -53,7 +53,7 @@
public class AMRunner {
private
hadoop-yetus commented on pull request #4009:
URL: https://github.com/apache/hadoop/pull/4009#issuecomment-1084552554
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515327#comment-17515327
]
Duo Zhang commented on HADOOP-16206:
This was talked before. Please see the above c
hadoop-yetus commented on pull request #3703:
URL: https://github.com/apache/hadoop/pull/3703#issuecomment-1084645754
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
tomscut commented on pull request #4009:
URL: https://github.com/apache/hadoop/pull/4009#issuecomment-1084741403
The cc warnings seem related to `mapreduce-client`. I'll rebase and
retrigger the build.
--
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515405#comment-17515405
]
Ahmar Suhail edited comment on HADOOP-14837 at 3/31/22, 3:41 PM:
[
https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515405#comment-17515405
]
Ahmar Suhail commented on HADOOP-14837:
---
[~ste...@apache.org] Object summaries in
hadoop-yetus commented on pull request #4126:
URL: https://github.com/apache/hadoop/pull/4126#issuecomment-1084764646
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515405#comment-17515405
]
Ahmar Suhail edited comment on HADOOP-14837 at 3/31/22, 3:42 PM:
tasanuma commented on a change in pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r839809073
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##
@@ -756,4 +759,33
simbadzina opened a new pull request #4127:
URL: https://github.com/apache/hadoop/pull/4127
### Description of PR
Enables routers to direct read calls to observer namenodes.
This is a refresh of a patch by Zhuobin Zhang to make it apply on current
trunk.
https://issues.apache
hadoop-yetus commented on pull request #4108:
URL: https://github.com/apache/hadoop/pull/4108#issuecomment-1084914963
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
hadoop-yetus commented on pull request #4117:
URL: https://github.com/apache/hadoop/pull/4117#issuecomment-1084920608
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
hadoop-yetus commented on pull request #4108:
URL: https://github.com/apache/hadoop/pull/4108#issuecomment-1085048559
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
omalley merged pull request #4123:
URL: https://github.com/apache/hadoop/pull/4123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-u
[
https://issues.apache.org/jira/browse/HADOOP-18144?focusedWorklogId=751210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751210
]
ASF GitHub Bot logged work on HADOOP-18144:
---
Author: ASF GitHub B
omalley merged pull request #4124:
URL: https://github.com/apache/hadoop/pull/4124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-u
[
https://issues.apache.org/jira/browse/HADOOP-18144?focusedWorklogId=751233&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751233
]
ASF GitHub Bot logged work on HADOOP-18144:
---
Author: ASF GitHub B
xinglin closed pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-u
[
https://issues.apache.org/jira/browse/HADOOP-18172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18172:
Labels: pull-request-available (was: )
> Change scope of getRootFallbackLink for InodeTr
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751235
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
xinglin opened a new pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106
Change scope for two functions. No tests is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751236
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-18169?focusedWorklogId=751247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751247
]
ASF GitHub Bot logged work on HADOOP-18169:
---
Author: ASF GitHub B
omalley merged pull request #4094:
URL: https://github.com/apache/hadoop/pull/4094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-u
omalley commented on a change in pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106#discussion_r840052389
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
##
@@ -59,9 +59,9 @@
* {@link #resolve(String
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751249
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen O'Malley reassigned HADOOP-18169:
--
Assignee: Xing Lin
> getDelegationTokens in ViewFs should also fetch the token from
[
https://issues.apache.org/jira/browse/HADOOP-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen O'Malley resolved HADOOP-18169.
Fix Version/s: 3.4.0
3.3.3
Resolution: Fixed
> getDelegationTok
xinglin opened a new pull request #4128:
URL: https://github.com/apache/hadoop/pull/4128
### Description of PR
cherry-pick of 15a5ea2c955a7d1b89aea0cb127727a57db76c76 from trunk to
branch-2.10 and created TestViewFsLinkFallback.java file with one test case
included.
A
xinglin commented on pull request #4128:
URL: https://github.com/apache/hadoop/pull/4128#issuecomment-1085245606
@omalley,
Here is the backport for DelegationToken for 2.10. Could you take a look?
Thanks,
--
This is an automated message from the Apache Git Service.
To respond to
tomscut commented on pull request #4101:
URL: https://github.com/apache/hadoop/pull/4101#issuecomment-1085245717
> @tomscut Thanks for your review. Yes, background reconstruction is
necessary. With missing block(s) of block group, client has to read `dataUnits`
blocks in block group to dec
hadoop-yetus commented on pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106#issuecomment-1085267908
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751312
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106#issuecomment-1085304511
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751338
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #4009:
URL: https://github.com/apache/hadoop/pull/4009#issuecomment-1085304848
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=751341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751341
]
ASF GitHub Bot logged work on HADOOP-18172:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #4106:
URL: https://github.com/apache/hadoop/pull/4106#issuecomment-1085306123
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
tomscut commented on pull request #4009:
URL: https://github.com/apache/hadoop/pull/4009#issuecomment-1085316647
Hi @ayushtkn , the jenkins log seems compiled failed. But I can compiled
successfully locally.
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-p
tomscut opened a new pull request #4129:
URL: https://github.com/apache/hadoop/pull/4129
JIRA: [HDFS-16527](https://issues.apache.org/jira/browse/HDFS-16527).
As @ayushtkn mentioned
[here](https://issues.apache.org/jira/browse/HDFS-16527#pullrequestreview-925554297].)
TestRouterDist
hadoop-yetus commented on pull request #4128:
URL: https://github.com/apache/hadoop/pull/4128#issuecomment-1085355165
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
singer-bin commented on a change in pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r840195947
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##
@@ -756,4 +759,3
singer-bin commented on a change in pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r840196034
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##
@@ -756,4 +759,3
singer-bin commented on a change in pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r840195947
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##
@@ -756,4 +759,3
hadoop-yetus commented on pull request #4127:
URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1085385474
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
hadoop-yetus commented on pull request #4129:
URL: https://github.com/apache/hadoop/pull/4129#issuecomment-1085403513
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
hadoop-yetus commented on pull request #4129:
URL: https://github.com/apache/hadoop/pull/4129#issuecomment-1085493702
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :
tomscut commented on pull request #4009:
URL: https://github.com/apache/hadoop/pull/4009#issuecomment-1085494617
Hi @aajisaka , do you know the cause of these cc warnings? This PR does not
change the c++ code associated with mapreduce-client. Could you please take a
look? Thank you very mu
83 matches
Mail list logo