[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1184027600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4523: [Draft] HDFS-13522: Allow routers to use observer namenode without an msync on even read. [Not ready for review]

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4523: URL: https://github.com/apache/hadoop/pull/4523#issuecomment-1184021972 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] PrabhuJoseph merged pull request #4546: YARN-11198. clean up numa resources from statestore

2022-07-13 Thread GitBox
PrabhuJoseph merged PR #4546: URL: https://github.com/apache/hadoop/pull/4546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #4510: YARN-11203. Fix typo in hadoop-yarn-server-router module.

2022-07-13 Thread GitBox
slfan1989 commented on PR #4510: URL: https://github.com/apache/hadoop/pull/4510#issuecomment-1183990204 @goiri @ayushtkn Please help me to review the code again, Thank you very much! This is a very small adjustment, but still necessary. -- This is an automated message from the Apache

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4543: YARN-8900. [Router] Federation: routing getContainers REST invocations transparently to multiple RMs

2022-07-13 Thread GitBox
slfan1989 commented on code in PR #4543: URL: https://github.com/apache/hadoop/pull/4543#discussion_r920748434 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4540: YARN-11160. Support getResourceProfiles, getResourceProfile API's for Federation

2022-07-13 Thread GitBox
slfan1989 commented on code in PR #4540: URL: https://github.com/apache/hadoop/pull/4540#discussion_r920744972 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java:

[GitHub] [hadoop] zhengchenyu commented on a diff in pull request #4314: YARN-11153. Make proxy server support yarn federation.

2022-07-13 Thread GitBox
zhengchenyu commented on code in PR #4314: URL: https://github.com/apache/hadoop/pull/4314#discussion_r920717298 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java:

[jira] [Commented] (HADOOP-18325) ABFS: Add correlated metric support for ABFS operations

2022-07-13 Thread Anmol Asrani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566633#comment-17566633 ] Anmol Asrani commented on HADOOP-18325: --- We are gathering metrics at AzureBlobFileSystem instance

[jira] [Updated] (HADOOP-18325) ABFS: Add correlated metric support for ABFS operations

2022-07-13 Thread Anmol Asrani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anmol Asrani updated HADOOP-18325: -- Summary: ABFS: Add correlated metric support for ABFS operations (was: ABFS: Add metric

[GitHub] [hadoop] zhengchenyu commented on a diff in pull request #4314: YARN-11153. Make proxy server support yarn federation.

2022-07-13 Thread GitBox
zhengchenyu commented on code in PR #4314: URL: https://github.com/apache/hadoop/pull/4314#discussion_r920733448 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java:

[jira] [Work logged] (HADOOP-18074) Partial/Incomplete groups list can be returned in LDAP groups lookup

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18074?focusedWorklogId=790702=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790702 ] ASF GitHub Bot logged work on HADOOP-18074: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4550: HADOOP-18074 - Partial/Incomplete groups list can be returned in LDAP…

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4550: URL: https://github.com/apache/hadoop/pull/4550#issuecomment-1183962472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4518: HDFS-16645. [JN] Bugfix: java.lang.IllegalStateException: Invalid log manifest

2022-07-13 Thread GitBox
ZanderXu commented on PR #4518: URL: https://github.com/apache/hadoop/pull/4518#issuecomment-1183962338 @tomscut Are you interesting to review this bug about JournalNode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw CacheMissException when SinceTxId is bigger than HighestWrittenTxId

2022-07-13 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1183960852 @tomscut Are you interesting to review this bug about selecting EditLogInputStreams? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] whbing commented on pull request #3960: HDFS-16446. Consider ioutils of disk when choosing volume

2022-07-13 Thread GitBox
whbing commented on PR #3960: URL: https://github.com/apache/hadoop/pull/3960#issuecomment-1183957526 Hi, @tomscut , we also face slow nodes caused by io, but in most cases it is slow to read data because the frequency of reading in the cluster far exceeds that of writing. We have counted

[jira] [Work logged] (HADOOP-18324) Interrupting RPC Client calls can lead to thread exhaustion

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18324?focusedWorklogId=790692=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790692 ] ASF GitHub Bot logged work on HADOOP-18324: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ZanderXu commented on pull request #4527: HADOOP-18324. Interrupting RPC Client calls can lead to thread exhaustion.

2022-07-13 Thread GitBox
ZanderXu commented on PR #4527: URL: https://github.com/apache/hadoop/pull/4527#issuecomment-1183957096 @omalley We encountered an incident in our prod environment that relate to connection. Limited the `rpcRequestQueue` can fix this problem and I'm looking for your good ideas. And

[GitHub] [hadoop] zhengchenyu commented on a diff in pull request #4314: YARN-11153. Make proxy server support yarn federation.

2022-07-13 Thread GitBox
zhengchenyu commented on code in PR #4314: URL: https://github.com/apache/hadoop/pull/4314#discussion_r920717298 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java:

[jira] [Work logged] (HADOOP-18324) Interrupting RPC Client calls can lead to thread exhaustion

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18324?focusedWorklogId=790670=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790670 ] ASF GitHub Bot logged work on HADOOP-18324: --- Author: ASF GitHub Bot

[jira] [Commented] (HADOOP-18033) Upgrade fasterxml Jackson to 2.13.0

2022-07-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566593#comment-17566593 ] Viraj Jasani commented on HADOOP-18033: --- Thanks [~ayushtkn], HADOOP-18332 PRs (trunk and 3.3)

[GitHub] [hadoop] hadoop-yetus commented on pull request #4527: HADOOP-18324. Interrupting RPC Client calls can lead to thread exhaustion.

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4527: URL: https://github.com/apache/hadoop/pull/4527#issuecomment-1183922988 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhengchenyu commented on a diff in pull request #4314: YARN-11153. Make proxy server support yarn federation.

2022-07-13 Thread GitBox
zhengchenyu commented on code in PR #4314: URL: https://github.com/apache/hadoop/pull/4314#discussion_r920702161 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java:

[GitHub] [hadoop] virajjasani commented on pull request #4552: HADOOP-18832. remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
virajjasani commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183921592 The changes look good, basically this patch is (revert of HADOOP-18033 + Jackson 2.12.7), QA looks good and since Tez tests are now passing as per @ayushtkn's testing, it seems this

[GitHub] [hadoop] ZanderXu commented on pull request #4524: HDFS-16283. RBF: reducing the load of renewLease() RPC

2022-07-13 Thread GitBox
ZanderXu commented on PR #4524: URL: https://github.com/apache/hadoop/pull/4524#issuecomment-1183907285 @ayushtkn @Hexiaoqiao Thanks for your discussion and review. I will continue to word hard to submit more patches to the community. -- This is an automated message from the Apache Git

[GitHub] [hadoop] ayushtkn merged pull request #4524: HDFS-16283. RBF: reducing the load of renewLease() RPC

2022-07-13 Thread GitBox
ayushtkn merged PR #4524: URL: https://github.com/apache/hadoop/pull/4524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-15984) Update jersey from 1.19 to 2.x

2022-07-13 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-15984: -- Priority: Major (was: Blocker) > Update jersey from 1.19 to 2.x >

[jira] [Commented] (HADOOP-18033) Upgrade fasterxml Jackson to 2.13.0

2022-07-13 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566573#comment-17566573 ] Ayush Saxena commented on HADOOP-18033: --- I have approved the PR at HADOOP-18332, Tried the two

[GitHub] [hadoop] hadoop-yetus commented on pull request #4563: YARN-11210. Fix YARN RMAdminCLI retry logic for non-retryable kerbero…

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4563: URL: https://github.com/apache/hadoop/pull/4563#issuecomment-1183864896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4311: URL: https://github.com/apache/hadoop/pull/4311#issuecomment-1183856828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4311: URL: https://github.com/apache/hadoop/pull/4311#issuecomment-1183855423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #4552: HADOOP-18832 remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
ayushtkn commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183840799 @pjfanning , that isn't related this PR, spent some time checking. Looks like a bad cherry-pick caused it. Have dropped a comment at:

[jira] [Commented] (HADOOP-18322) Yetus build failure in branch-3.3.

2022-07-13 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566567#comment-17566567 ] Mukund Thakur commented on HADOOP-18322: Oh yes. just resolved this. Thanks for reminding.  >

[jira] [Resolved] (HADOOP-18322) Yetus build failure in branch-3.3.

2022-07-13 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18322. Resolution: Fixed > Yetus build failure in branch-3.3. >

[GitHub] [hadoop] goiri commented on a diff in pull request #4561: HDFS-16660. Improve Code With Lambda in IPCLoggerChannel class

2022-07-13 Thread GitBox
goiri commented on code in PR #4561: URL: https://github.com/apache/hadoop/pull/4561#discussion_r920606905 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java: ## @@ -394,46 +361,43 @@ public ListenableFuture sendEdits(

[jira] [Commented] (HADOOP-18315) Fix 3.3 build problems caused by backport of HADOOP-11867.

2022-07-13 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566555#comment-17566555 ] Erik Krogen commented on HADOOP-18315: -- Looks like this was fixed in HADOOP-18322, is there

[jira] [Commented] (HADOOP-18322) Yetus build failure in branch-3.3.

2022-07-13 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566554#comment-17566554 ] Erik Krogen commented on HADOOP-18322: -- [~mthakur] it looks like this was resolved in [commit

[jira] [Work logged] (HADOOP-18324) Interrupting RPC Client calls can lead to thread exhaustion

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18324?focusedWorklogId=790624=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790624 ] ASF GitHub Bot logged work on HADOOP-18324: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4561: HDFS-16660. Improve Code With Lambda in IPCLoggerChannel class

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4561: URL: https://github.com/apache/hadoop/pull/4561#issuecomment-1183759146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4527: HADOOP-18324. Interrupting RPC Client calls can lead to thread exhaustion.

2022-07-13 Thread GitBox
mccormickt12 commented on code in PR #4527: URL: https://github.com/apache/hadoop/pull/4527#discussion_r920572884 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java: ## @@ -1183,51 +1158,7 @@ public void sendRpcRequest(final Call call)

[GitHub] [hadoop] ashutoshcipher commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-07-13 Thread GitBox
ashutoshcipher commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1183743712 Thanks @cnauroth for your comments. I will look into them. About unittest, I planned to get complete the main function first(make required changes for any new comments) and

[GitHub] [hadoop] cnauroth commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-07-13 Thread GitBox
cnauroth commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r920548705 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8 +545,33

[GitHub] [hadoop] KevinWikant opened a new pull request, #4563: YARN-11210. Fix YARN RMAdminCLI retry logic for non-retryable kerbero…

2022-07-13 Thread GitBox
KevinWikant opened a new pull request, #4563: URL: https://github.com/apache/hadoop/pull/4563 ### Description of PR Applications which call YARN RMAdminCLI (i.e. YARN ResourceManager client) synchronously can be blocked for up to 15 minutes with the default configuration of

[GitHub] [hadoop] hadoop-yetus commented on pull request #4559: HDFS-16658. Change logLevel from DEBUG to INFO if logEveryBlock is true

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4559: URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1183681965 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=790596=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790596 ] ASF GitHub Bot logged work on HADOOP-17461: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4352: HADOOP-17461. Thread-level IOStatistics in S3A

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4352: URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1183670262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4560: HDFS-16659. JournalNode should throw CacheMissException when SinceTxId is bigger than HighestWrittenTxId

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1183663577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4546: YARN-11198. clean up numa resources from statestore

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4546: URL: https://github.com/apache/hadoop/pull/4546#issuecomment-1183638787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4518: HDFS-16645. [JN] Bugfix: java.lang.IllegalStateException: Invalid log manifest

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4518: URL: https://github.com/apache/hadoop/pull/4518#issuecomment-1183575727 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4562: HDFS-16652. Upgrade jquery datatable version references to v1.10.19

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4562: URL: https://github.com/apache/hadoop/pull/4562#issuecomment-1183555173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] pjfanning commented on pull request #4552: HADOOP-18832 remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
pjfanning commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183550257 @ayushtkn this failed with issues based on a missing method: ``` Caused by: java.lang.NoSuchMethodException:

[jira] [Work logged] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?focusedWorklogId=790547=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790547 ] ASF GitHub Bot logged work on HADOOP-18330: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?focusedWorklogId=790546=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790546 ] ASF GitHub Bot logged work on HADOOP-18330: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4557: HADOOP-18330 S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4557: URL: https://github.com/apache/hadoop/pull/4557#issuecomment-1183544043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4557: HADOOP-18330 S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4557: URL: https://github.com/apache/hadoop/pull/4557#issuecomment-1183543689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18332) remove rs-api dependency (needs jackson downgrade to 2.12.7)

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18332?focusedWorklogId=790541=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790541 ] ASF GitHub Bot logged work on HADOOP-18332: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4547: HADOOP-18332: remove rs-api dependency as it conflicts with jsr311-api

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4547: URL: https://github.com/apache/hadoop/pull/4547#issuecomment-1183532007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] brahmareddybattula commented on pull request #4562: HDFS-16652. Upgrade jquery datatable version references to v1.10.19

2022-07-13 Thread GitBox
brahmareddybattula commented on PR #4562: URL: https://github.com/apache/hadoop/pull/4562#issuecomment-1183506393 @dmmkr thanks for reporting. changes lgtm.. can raise PR for branch-3.2 also..? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] goiri commented on a diff in pull request #4530: HDFS-15079. RBF: Namenode needs to use the actual client Id and callId when going through RBF proxy.

2022-07-13 Thread GitBox
goiri commented on code in PR #4530: URL: https://github.com/apache/hadoop/pull/4530#discussion_r920337146 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java: ## @@ -140,7 +140,7 @@ public long getExpirationTime() { @Override

[GitHub] [hadoop] goiri commented on a diff in pull request #4561: HDFS-16660. Improve Code With Lambda in IPCLoggerChannel class

2022-07-13 Thread GitBox
goiri commented on code in PR #4561: URL: https://github.com/apache/hadoop/pull/4561#discussion_r920333291 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java: ## @@ -346,36 +324,25 @@ public void run() { @Override

[GitHub] [hadoop] dmmkr opened a new pull request, #4562: HDFS-16652. Upgrade jquery datatable version references to v1.10.19

2022-07-13 Thread GitBox
dmmkr opened a new pull request, #4562: URL: https://github.com/apache/hadoop/pull/4562 ### Description of PR Upgrade jquery datatable version references to v1.10.19 ### How was this patch tested? Verified NameNode dfshealth.html and explorer.html

[jira] [Work logged] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?focusedWorklogId=790493=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790493 ] ASF GitHub Bot logged work on HADOOP-18330: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4557: HADOOP-18330 S3AFileSystem removes Path when calling createS3Client

2022-07-13 Thread GitBox
steveloughran commented on code in PR #4557: URL: https://github.com/apache/hadoop/pull/4557#discussion_r920269270 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java: ## @@ -264,5 +269,20 @@ public S3ClientCreationParameters withHeader(

[GitHub] [hadoop] ZanderXu opened a new pull request, #4561: HDFS-16660. Improve Code With Lambda in IPCLoggerChannel class

2022-07-13 Thread GitBox
ZanderXu opened a new pull request, #4561: URL: https://github.com/apache/hadoop/pull/4561 ### Description of PR Improve Code With Lambda in IPCLoggerChannel class, make it more readable. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (HADOOP-18258) Merging of S3A Audit Logs

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?focusedWorklogId=790470=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790470 ] ASF GitHub Bot logged work on HADOOP-18258: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-07-13 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r920187510 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,546 @@ +/* + * Licensed to the Apache

[jira] [Work logged] (HADOOP-18258) Merging of S3A Audit Logs

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?focusedWorklogId=790469=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790469 ] ASF GitHub Bot logged work on HADOOP-18258: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-07-13 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r920186659 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,546 @@ +/* + * Licensed to the Apache

[GitHub] [hadoop] ZanderXu opened a new pull request, #4560: HDFS-16659. JournalNode should throw CacheMissException when SinceTxId is bigger than HighestWrittenTxId

2022-07-13 Thread GitBox
ZanderXu opened a new pull request, #4560: URL: https://github.com/apache/hadoop/pull/4560 ### Description of PR JournalNode should throw `CacheMissException` if `sinceTxId` is bigger than `highestWrittenTxId`. And it will caused EditlogTailer can not able to tail edits. And it maybe

[jira] [Commented] (HADOOP-16711) S3A bucket existence checks to support v2 API and "no checks at all"

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566341#comment-17566341 ] Steve Loughran commented on HADOOP-16711: - if cherrypicking, pull in HADOOP-17801 > S3A bucket

[GitHub] [hadoop] hadoop-yetus commented on pull request #4546: YARN-11198. clean up numa resources from statestore

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4546: URL: https://github.com/apache/hadoop/pull/4546#issuecomment-1183263484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18079) Upgrade Netty to 4.1.77

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18079?focusedWorklogId=790429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790429 ] ASF GitHub Bot logged work on HADOOP-18079: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3977: HADOOP-18079. Upgrade Netty to 4.1.77.

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #3977: URL: https://github.com/apache/hadoop/pull/3977#issuecomment-1183232938 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-07-13 Thread GitBox
ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1183206857 > I have one question to ask, that is why some code should remove LOG.isDebugEnabled()? @slfan1989 Thanks for your review. If you have any other questions or good ideas, please

[GitHub] [hadoop] ZanderXu commented on pull request #4530: HDFS-15079. RBF: Namenode needs to use the actual client Id and callId when going through RBF proxy.

2022-07-13 Thread GitBox
ZanderXu commented on PR #4530: URL: https://github.com/apache/hadoop/pull/4530#issuecomment-1183202360 @goiri @ferhui @Hexiaoqiao @ayushtkn can you help me to review this patch? If you have any other ideas, please let me know. This is a very helpful issue for end users, so I want

[GitHub] [hadoop] ZanderXu opened a new pull request, #4559: HDFS-16658. Change logLevel from DEBUG to INFO if logEveryBlock is true

2022-07-13 Thread GitBox
ZanderXu opened a new pull request, #4559: URL: https://github.com/apache/hadoop/pull/4559 ### Description of PR During locating some abnormal cases about block replication in our prod environment, I found that BlockManager does not out put some logs in `addStoredBlock` even though

[jira] [Commented] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread Catherinot Remi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566292#comment-17566292 ] Catherinot Remi commented on HADOOP-18217: -- This patch is more on the robustness than on the

[jira] [Resolved] (HADOOP-18336) tag FSDataInputStream.getWrappedStream() @Public/@Stable

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18336. - Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed merged to 3.3

[jira] [Work logged] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=790389=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790389 ] ASF GitHub Bot logged work on HADOOP-17649: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18336) tag FSDataInputStream.getWrappedStream() @Public/@Stable

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18336?focusedWorklogId=790390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790390 ] ASF GitHub Bot logged work on HADOOP-18336: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran merged pull request #4555: HADOOP-18336.Tag FSDataInputStream.getWrappedStream() @Public/@Stable

2022-07-13 Thread GitBox
steveloughran merged PR #4555: URL: https://github.com/apache/hadoop/pull/4555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4539: HADOOP-17649.Update wildfly openssl to 2.2.1.Final

2022-07-13 Thread GitBox
ashutoshcipher commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1183129226 @steveloughran - I saw your comments on this PR - https://github.com/apache/hadoop/pull/3029 about running the integration tests for 1. hadoop-aws (Attached results in the PR)

[jira] [Commented] (HADOOP-18337) Supporting performant output committers for Aliyun

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566287#comment-17566287 ] Steve Loughran commented on HADOOP-18337: - the alibaba committer, looks like it is based on

[jira] [Commented] (HADOOP-18337) Supporting performant output committers for Aliyun

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566286#comment-17566286 ] Steve Loughran commented on HADOOP-18337: - this is a really hard piece of code to do. i say

[jira] [Resolved] (HADOOP-18338) Unable to access data from S3 bucket over a vpc endpoint - 400 bad request

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18338. - Resolution: Not A Problem change the endpoint and s3a doesn't know what region to sign

[GitHub] [hadoop] hadoop-yetus commented on pull request #4552: HADOOP-18832 remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183121892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4552: HADOOP-18832 remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183120139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566277#comment-17566277 ] Steve Loughran commented on HADOOP-18217: - given this is a deadlock issue, should we target

[jira] [Resolved] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18217. - Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed committed to

[jira] [Work logged] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=790381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790381 ] ASF GitHub Bot logged work on HADOOP-18217: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4255: HADOOP-18217. ExitUtil synchronized blocks reduced to avoid exit bloc…

2022-07-13 Thread GitBox
steveloughran commented on PR #4255: URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1183115938 +cherrypicked to branch-3.3; ran new test suite and all is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Work logged] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=790378=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790378 ] ASF GitHub Bot logged work on HADOOP-18217: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4255: HADOOP-18217. ExitUtil synchronized blocks reduced to avoid exit bloc…

2022-07-13 Thread GitBox
steveloughran commented on PR #4255: URL: https://github.com/apache/hadoop/pull/4255#issuecomment-1183110785 +1, merging. thank you for your diligence here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Work logged] (HADOOP-18217) shutdownhookmanager should not be multithreaded (deadlock possible)

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18217?focusedWorklogId=790377=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790377 ] ASF GitHub Bot logged work on HADOOP-18217: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran merged pull request #4255: HADOOP-18217. ExitUtil synchronized blocks reduced to avoid exit bloc…

2022-07-13 Thread GitBox
steveloughran merged PR #4255: URL: https://github.com/apache/hadoop/pull/4255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4552: HADOOP-18832 remove rs-api dependency (3.3 branch)

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4552: URL: https://github.com/apache/hadoop/pull/4552#issuecomment-1183103649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4546: YARN-11198. clean up numa resources from statestore

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4546: URL: https://github.com/apache/hadoop/pull/4546#issuecomment-1183098463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18338) Unable to access data from S3 bucket over a vpc endpoint - 400 bad request

2022-07-13 Thread Aarti (Jira)
Aarti created HADOOP-18338: -- Summary: Unable to access data from S3 bucket over a vpc endpoint - 400 bad request Key: HADOOP-18338 URL: https://issues.apache.org/jira/browse/HADOOP-18338 Project: Hadoop

[GitHub] [hadoop] hadoop-yetus commented on pull request #4558: HDFS-16657 Changing pool-level lock to volume-level lock for invalida…

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4558: URL: https://github.com/apache/hadoop/pull/4558#issuecomment-1182996943 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-17912) ABFS: Support for Encryption Context

2022-07-13 Thread Pranav Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena reassigned HADOOP-17912: -- Assignee: Pranav Saxena (was: Sumangala Patki) > ABFS: Support for Encryption

[GitHub] [hadoop] hadoop-yetus commented on pull request #4546: YARN-11198. clean up numa resources from statestore

2022-07-13 Thread GitBox
hadoop-yetus commented on PR #4546: URL: https://github.com/apache/hadoop/pull/4546#issuecomment-1182931486 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

  1   2   >