[GitHub] [hadoop] hadoop-yetus commented on pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4793: URL: https://github.com/apache/hadoop/pull/4793#issuecomment-1225209958 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18302) Remove WhiteBox in hadoop-common module.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583999#comment-17583999 ] ASF GitHub Bot commented on HADOOP-18302: - hadoop-yetus commented on PR #4457: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4457: HADOOP-18302. Remove WhiteBox in hadoop-common module.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4457: URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1225207531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4792: YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4792: URL: https://github.com/apache/hadoop/pull/4792#issuecomment-1225198391 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18189) S3PrefetchingInputStream to support status probes when closed

2022-08-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18189: - Assignee: Viraj Jasani > S3PrefetchingInputStream to support status probes when

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953335382 ##

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583990#comment-17583990 ] ASF GitHub Bot commented on HADOOP-18186: - virajjasani commented on PR #4796: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread GitBox
virajjasani commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1225182580 With `scale`: ``` $ mvn -Dparallel-tests -DtestsThreadCount=10 -Dscale clean verify [INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @ hadoop-aws ---

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583988#comment-17583988 ] ASF GitHub Bot commented on HADOOP-18186: - virajjasani commented on PR #4796: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1225181917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread GitBox
virajjasani commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1225181844 Endpoint `us-west-2`: ``` $ mvn -Dparallel-tests -DtestsThreadCount=8 clean verify [INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @ hadoop-aws ---

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583985#comment-17583985 ] ASF GitHub Bot commented on HADOOP-18186: - hadoop-yetus commented on PR #4796: URL:

[jira] [Updated] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18186: Labels: pull-request-available (was: ) > s3a prefetching to use

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953331074 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1225178955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953317155 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953317427 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953317155 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953295360 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953295280 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953294793 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953291856 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953290103 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/RouterMasterKey.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953289930 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/YARNDelegationTokenIdentifier.java: ## @@ -112,4 +115,14 @@

[GitHub] [hadoop] ZanderXu commented on pull request #4369: HDFS-16601. DataTransfer should throw IOException to client

2022-08-23 Thread GitBox
ZanderXu commented on PR #4369: URL: https://github.com/apache/hadoop/pull/4369#issuecomment-1225131216 @jojochuang Master, I have rebased this patch based on the latest trunk. I'm looking forward to getting some of your thoughts on this issue. BTW, Remote copy of

[GitHub] [hadoop] slfan1989 commented on pull request #4678: YARN-11240. Fix incorrect placeholder in yarn-module.

2022-08-23 Thread GitBox
slfan1989 commented on PR #4678: URL: https://github.com/apache/hadoop/pull/4678#issuecomment-1225113830 @ayushtkn Can you help review the code again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953266280 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4734: HDFS-16728. RBF throw IndexOutOfBoundsException with disableNameServices

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4734: URL: https://github.com/apache/hadoop/pull/4734#issuecomment-1225103180 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r953258995 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r953253625 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #4761: HDFS-16733.Improve INode#isRoot().

2022-08-23 Thread GitBox
jianghuazhu commented on code in PR #4761: URL: https://github.com/apache/hadoop/pull/4761#discussion_r953248876 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java: ## @@ -73,7 +73,8 @@ public abstract class INode implements

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r953247032 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r953245747 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4792: YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager.

2022-08-23 Thread GitBox
slfan1989 commented on code in PR #4792: URL: https://github.com/apache/hadoop/pull/4792#discussion_r953243985 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@

[GitHub] [hadoop] snmvaughan commented on pull request #4786: HDFS-16684. Exclude the current JournalNode

2022-08-23 Thread GitBox
snmvaughan commented on PR #4786: URL: https://github.com/apache/hadoop/pull/4786#issuecomment-1225057314 I've run all of the failed test classes locally without an issue. I've opened a ticket specifically for this problem. https://issues.apache.org/jira/browse/HDFS-16740 -- This is

[jira] [Commented] (HADOOP-18406) Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583928#comment-17583928 ] ASF GitHub Bot commented on HADOOP-18406: - hadoop-yetus commented on PR #4748: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4748: URL: https://github.com/apache/hadoop/pull/4748#issuecomment-1225048110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4794: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request (#4724)

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4794: URL: https://github.com/apache/hadoop/pull/4794#issuecomment-1225032086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 CVE-2022-2048 due to shaded jetty

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583913#comment-17583913 ] ASF GitHub Bot commented on HADOOP-18333: - jojochuang commented on PR #4600: URL:

[jira] [Resolved] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 CVE-2022-2048 due to shaded jetty

2022-08-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-18333. -- Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed >

[GitHub] [hadoop] jojochuang commented on pull request #4600: HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622

2022-08-23 Thread GitBox
jojochuang commented on PR #4600: URL: https://github.com/apache/hadoop/pull/4600#issuecomment-1225015487 Thanks for verifying the test for me. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 CVE-2022-2048 due to shaded jetty

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583912#comment-17583912 ] ASF GitHub Bot commented on HADOOP-18333: - jojochuang merged PR #4600: URL:

[GitHub] [hadoop] jojochuang merged pull request #4600: HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622

2022-08-23 Thread GitBox
jojochuang merged PR #4600: URL: https://github.com/apache/hadoop/pull/4600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ZanderXu commented on pull request #4784: HDFS-16737. Fix number of threads in FsDatasetAsyncDiskService#addExecutorForVolume

2022-08-23 Thread GitBox
ZanderXu commented on PR #4784: URL: https://github.com/apache/hadoop/pull/4784#issuecomment-1225011225 @ayushtkn Sir, can you help me review this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] ZanderXu commented on pull request #4734: HDFS-16728. RBF throw IndexOutOfBoundsException with disableNameServices

2022-08-23 Thread GitBox
ZanderXu commented on PR #4734: URL: https://github.com/apache/hadoop/pull/4734#issuecomment-1225010431 @goiri @Hexiaoqiao I have rebased this patch based on the latest trunk. Please help me review and merge it into trunk. Then I will rebase

[jira] [Commented] (HADOOP-18406) Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583907#comment-17583907 ] ASF GitHub Bot commented on HADOOP-18406: - omalley commented on PR #4748: URL:

[GitHub] [hadoop] omalley commented on pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread GitBox
omalley commented on PR #4748: URL: https://github.com/apache/hadoop/pull/4748#issuecomment-1225006293 +1 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18406) Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583906#comment-17583906 ] ASF GitHub Bot commented on HADOOP-18406: - omalley closed pull request #4748: HADOOP-18406:

[GitHub] [hadoop] omalley closed pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-23 Thread GitBox
omalley closed pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user. URL: https://github.com/apache/hadoop/pull/4748 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-18410) S3AInputStream.unbuffer() async drain not releasing http connections

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583890#comment-17583890 ] ASF GitHub Bot commented on HADOOP-18410: - virajjasani commented on PR #4766: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4766: HADOOP-18410. S3AInputStream.unbuffer() not releasing http connections

2022-08-23 Thread GitBox
virajjasani commented on PR #4766: URL: https://github.com/apache/hadoop/pull/4766#issuecomment-1224965093 > a way to do some retirement of long-lived input streams. Hmm might need some sort of "self expiring cache" kind of thing -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4793: URL: https://github.com/apache/hadoop/pull/4793#issuecomment-1224924118 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4786: HDFS-16684. Exclude the current JournalNode

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4786: URL: https://github.com/apache/hadoop/pull/4786#issuecomment-1224923563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-23 Thread GitBox
goiri commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r953096007 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/YARNDelegationTokenIdentifier.java: ## @@ -112,4 +115,14 @@

[jira] [Commented] (HADOOP-18417) Upgrade Maven Surefire plugin

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583839#comment-17583839 ] ASF GitHub Bot commented on HADOOP-18417: - hadoop-yetus commented on PR #4795: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4795: HADOOP-18417. Upgrade to M7 of surefire plugin

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4795: URL: https://github.com/apache/hadoop/pull/4795#issuecomment-1224832973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri merged pull request #4719: HDFS-16724. RBF should support get the information about ancestor mount points

2022-08-23 Thread GitBox
goiri merged PR #4719: URL: https://github.com/apache/hadoop/pull/4719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18345) Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583827#comment-17583827 ] ASF GitHub Bot commented on HADOOP-18345: - goiri commented on PR #4584: URL:

[GitHub] [hadoop] goiri commented on pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread GitBox
goiri commented on PR #4584: URL: https://github.com/apache/hadoop/pull/4584#issuecomment-1224788447 No worries, you merged manually instead of merging the existing PR. It is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (HADOOP-18345) Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread Owen O'Malley (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen O'Malley resolved HADOOP-18345. Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed > Enhance client

[jira] [Commented] (HADOOP-18345) Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583819#comment-17583819 ] ASF GitHub Bot commented on HADOOP-18345: - omalley commented on PR #4584: URL:

[GitHub] [hadoop] omalley commented on pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread GitBox
omalley commented on PR #4584: URL: https://github.com/apache/hadoop/pull/4584#issuecomment-1224730686 @goiri No, I committed the change to trunk and branch-3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] snmvaughan commented on a diff in pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-23 Thread GitBox
snmvaughan commented on code in PR #4415: URL: https://github.com/apache/hadoop/pull/4415#discussion_r953020342 ## hadoop-project/pom.xml: ## @@ -167,7 +167,7 @@ -Xmx2048m -XX:+HeapDumpOnOutOfMemoryError -3.0.0-M1 +3.0.0-M7 Review Comment: I've

[jira] [Commented] (HADOOP-18417) Upgrade Maven Surefire plugin

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583815#comment-17583815 ] ASF GitHub Bot commented on HADOOP-18417: - snmvaughan opened a new pull request, #4795: URL:

[jira] [Updated] (HADOOP-18417) Upgrade Maven Surefire plugin

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18417: Labels: pull-request-available (was: ) > Upgrade Maven Surefire plugin >

[GitHub] [hadoop] snmvaughan opened a new pull request, #4795: HADOOP-18417. Upgrade to M7 of surefire plugin

2022-08-23 Thread GitBox
snmvaughan opened a new pull request, #4795: URL: https://github.com/apache/hadoop/pull/4795 This addresses an issue where the plugin's default classpath for executing tests fails to include org.junit.platform.launcher.core.LauncherFactory. This commit was originally part of

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583814#comment-17583814 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #4706: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4706: URL: https://github.com/apache/hadoop/pull/4706#issuecomment-1224664703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18417) Upgrade Maven Surefire plugin

2022-08-23 Thread Steve Vaughan (Jira)
Steve Vaughan created HADOOP-18417: -- Summary: Upgrade Maven Surefire plugin Key: HADOOP-18417 URL: https://issues.apache.org/jira/browse/HADOOP-18417 Project: Hadoop Common Issue Type:

[GitHub] [hadoop] goiri commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-23 Thread GitBox
goiri commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r953004392 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] snmvaughan opened a new pull request, #4794: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request (#4724)

2022-08-23 Thread GitBox
snmvaughan opened a new pull request, #4794: URL: https://github.com/apache/hadoop/pull/4794 Backport from trunk. GetJournalEditServlet uses request.getRemoteuser() to determine the remoteShortName for Kerberos authorization, which fails to match when the JournalNode uses its own Kerberos

[GitHub] [hadoop] goiri commented on a diff in pull request #4792: YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager.

2022-08-23 Thread GitBox
goiri commented on code in PR #4792: URL: https://github.com/apache/hadoop/pull/4792#discussion_r953000614 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@ -450,4

[GitHub] [hadoop] goiri commented on a diff in pull request #4780: HDFS-16735. Reduce the number of HeartbeatManager loops.

2022-08-23 Thread GitBox
goiri commented on code in PR #4780: URL: https://github.com/apache/hadoop/pull/4780#discussion_r952993440 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java: ## @@ -492,12 +498,12 @@ void heartbeatCheck() {

[jira] [Commented] (HADOOP-18345) Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583799#comment-17583799 ] ASF GitHub Bot commented on HADOOP-18345: - goiri commented on PR #4584: URL:

[GitHub] [hadoop] goiri commented on pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread GitBox
goiri commented on PR #4584: URL: https://github.com/apache/hadoop/pull/4584#issuecomment-1224567895 @omalley I'm guessing the close was accidental? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] abhishekkarigar commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-23 Thread GitBox
abhishekkarigar commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1224559583 @ZanderXu hi one more question, i am setting up HA namenode on kubernetes on the standby namenode , i triggered the bootstrapStandby $ hdfs namenode

[jira] [Commented] (HADOOP-18345) Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583795#comment-17583795 ] ASF GitHub Bot commented on HADOOP-18345: - omalley closed pull request #4584: HADOOP-18345:

[GitHub] [hadoop] omalley closed pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-23 Thread GitBox
omalley closed pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices. URL: https://github.com/apache/hadoop/pull/4584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583772#comment-17583772 ] ASF GitHub Bot commented on HADOOP-16806: - jmahonin commented on PR #4753: URL:

[GitHub] [hadoop] jmahonin commented on pull request #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread GitBox
jmahonin commented on PR #4753: URL: https://github.com/apache/hadoop/pull/4753#issuecomment-1224436307 Thanks @dannycjones, that did it! All integration tests have now passed in this PR. I was indeed using `us-east-1` in `fs.s3a.endpoint.region`, which would explain the

[jira] [Assigned] (HADOOP-18416) ITestS3AIOStatisticsContext failure

2022-08-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18416: --- Assignee: Mehakmeet Singh > ITestS3AIOStatisticsContext failure >

[jira] [Updated] (HADOOP-18416) ITestS3AIOStatisticsContext failure

2022-08-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18416: Attachment: org.apache.hadoop.fs.s3a.ITestS3AIOStatisticsContext-output.txt >

[jira] [Created] (HADOOP-18416) ITestS3AIOStatisticsContext failure

2022-08-23 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18416: --- Summary: ITestS3AIOStatisticsContext failure Key: HADOOP-18416 URL: https://issues.apache.org/jira/browse/HADOOP-18416 Project: Hadoop Common Issue

[jira] [Assigned] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

2022-08-23 Thread Larry McCay (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Larry McCay reassigned HADOOP-18388: Assignee: Ayush Saxena > Allow dynamic groupSearchFilter in LdapGroupsMapping >

[jira] [Commented] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

2022-08-23 Thread Larry McCay (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583753#comment-17583753 ] Larry McCay commented on HADOOP-18388: -- [~ayushtkn] - thank you for the patch. I'd like to see a

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread ASF GitHub Bot (Jira)
://github.com/apache/hadoop/pull/4753#issuecomment-1224331509 Unfortunately, the errors can be a bit vague for S3 HeadObject (used by getFileStatus). There was a similar issue when the credentials had expired in HADOOP-18353. ``` ... Authorization: AWS4-HMAC-SHA256 Credential=/20220823

[GitHub] [hadoop] dannycjones commented on pull request #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread GitBox
. ``` ... Authorization: AWS4-HMAC-SHA256 Credential=/20220823/us-east-1/s3/aws4_request ... ``` The signature is signed for us-east-1, but the `landsat-pds` bucket is in us-west-2. Do you have `fs.s3a.endpoint.region` set? If so, try adding the following to your _auth-keys.xml_

[GitHub] [hadoop] hadoop-yetus commented on pull request #4728: MAPREDUCE-7403. manifest-committer dynamic partitioning support.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4728: URL: https://github.com/apache/hadoop/pull/4728#issuecomment-1224309966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread ASF GitHub Bot (Jira)
,838 [JUnit-testJobSubmissionCollectsTokens[0]] DEBUG http.wire (Wire.java:wire(73)) - http-outgoing-7 >> "amz-sdk-retry: 0/0/500[\r][\n]" 2022-08-23 16:15:25,838 [JUnit-testJobSubmissionCollectsTokens[0]] DEBUG http.wire (Wire.java:wire(73)) - http-outgoing-7 >> "Authoriz

[GitHub] [hadoop] jmahonin commented on pull request #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-23 Thread GitBox
java:wire(73)) - http-outgoing-7 >> "Authorization: AWS4-HMAC-SHA256 Credential=/20220823/us-east-1/s3/aws4_request, SignedHeaders=amz-sdk-invocation-id;amz-sdk-request;amz-sdk-retry;content-type;host;referer;user-agent;x-amz-content-sha256;x-amz-date, Signature=[\r][\n]" 2022-0

[GitHub] [hadoop] hadoop-yetus commented on pull request #4791: HDFS-16738. Invalid CallerContext caused NullPointerException

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4791: URL: https://github.com/apache/hadoop/pull/4791#issuecomment-1224301825 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583699#comment-17583699 ] ASF GitHub Bot commented on HADOOP-18073: - ahmarsuhail commented on code in PR #4706: URL:

[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-23 Thread GitBox
ahmarsuhail commented on code in PR #4706: URL: https://github.com/apache/hadoop/pull/4706#discussion_r952789775 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestRequestFactory.java: ## @@ -170,9 +170,11 @@ private void

[jira] [Commented] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 CVE-2022-2048 due to shaded jetty

2022-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583668#comment-17583668 ] ASF GitHub Bot commented on HADOOP-18333: - ashutoshcipher commented on PR #4600: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4600: HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622

2022-08-23 Thread GitBox
ashutoshcipher commented on PR #4600: URL: https://github.com/apache/hadoop/pull/4600#issuecomment-1224208228 @jojochuang I ran the following tests which are failing in Yetus Run and they are passing in local. ``` hadoop.mapred.TestMRTimelineEventHandling

[GitHub] [hadoop] sunchao commented on pull request #4724: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request

2022-08-23 Thread GitBox
sunchao commented on PR #4724: URL: https://github.com/apache/hadoop/pull/4724#issuecomment-1224203561 Merged, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] sunchao merged pull request #4724: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request

2022-08-23 Thread GitBox
sunchao merged PR #4724: URL: https://github.com/apache/hadoop/pull/4724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4792: YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager.

2022-08-23 Thread GitBox
hadoop-yetus commented on PR #4792: URL: https://github.com/apache/hadoop/pull/4792#issuecomment-1224181213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4793: YARN-11276. Add lru cache for RMWebServices.getApps

2022-08-23 Thread GitBox
slfan1989 commented on PR #4793: URL: https://github.com/apache/hadoop/pull/4793#issuecomment-1224136306 @leixm Modify CheckStyle and add relevant parameters in yarn-site.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4761: HDFS-16733.Improve INode#isRoot().

2022-08-23 Thread GitBox
Hexiaoqiao commented on code in PR #4761: URL: https://github.com/apache/hadoop/pull/4761#discussion_r952681531 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java: ## @@ -73,7 +73,8 @@ public abstract class INode implements

  1   2   >