[GitHub] [hadoop] hadoop-yetus commented on pull request #5072: HDFS-16817. Remove useless DataNode lock related configuration

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5072: URL: https://github.com/apache/hadoop/pull/5072#issuecomment-1290063145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1290034658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1290034554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1290017891 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2022-10-24 Thread t oo (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623568#comment-17623568 ] t oo commented on HADOOP-13363: --- CVE-2022-3171 > Upgrade protobuf from 2.5.0 to somethin

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2022-10-24 Thread t oo (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623569#comment-17623569 ] t oo commented on HADOOP-18197: --- CVE-2022-3171 > Update protobuf 3.7.1 to a version with

[jira] [Commented] (HADOOP-17860) Upgrade third party protobuf-java-2.5.0.jar to address vulnerabilities #CVE-2015-5237, CVE-2019-15544,

2022-10-24 Thread t oo (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623567#comment-17623567 ] t oo commented on HADOOP-17860: --- CVE-2022-3171 > Upgrade third party protobuf-java-2.5.0

[GitHub] [hadoop] tooptoop4 commented on pull request #4970: Bump protobuf-java from 2.5.0 to 3.16.3 in /hadoop-project

2022-10-24 Thread GitBox
tooptoop4 commented on PR #4970: URL: https://github.com/apache/hadoop/pull/4970#issuecomment-1290011574 CVE-2022-3171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5074: HDFS-16819. Remove the redundant write lock in FsDatasetImpl#createTemporary

2022-10-24 Thread GitBox
haiyang1987 opened a new pull request, #5074: URL: https://github.com/apache/hadoop/pull/5074 …mporary ### Description of PR HDFS-16819. Remove the redundant write lock in FsDatasetImpl#createTemporary -- This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop] xinglin commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
xinglin commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1289991163 yetus may come back with unit test failure of `TestRouterRPCMultipleDestinationMountTableResolver`. I have tested that this class is failing on trunk non-deterministically as well. Created

[GitHub] [hadoop] hadoop-yetus commented on pull request #5073: YARN-11354. [Federation] Add Yarn Router's NodeLabel Web Page.

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5073: URL: https://github.com/apache/hadoop/pull/5073#issuecomment-1289989817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4835: HDFS-16740. Mini cluster test flakiness

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4835: URL: https://github.com/apache/hadoop/pull/4835#issuecomment-1289965460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] haiyang1987 commented on pull request #5072: HDFS-16817. Remove useless DataNode lock related configuration

2022-10-24 Thread GitBox
haiyang1987 commented on PR #5072: URL: https://github.com/apache/hadoop/pull/5072#issuecomment-1289946349 Hi @ferhui @ZanderXu @Hexiaoqiao Can you help to review this simple modification? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-10-24 Thread GitBox
haiyang1987 commented on code in PR #5068: URL: https://github.com/apache/hadoop/pull/5068#discussion_r1003973853 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -2321,6 +2324,9 @@ protected String reconfigurePropertyI

[GitHub] [hadoop] tomscut commented on a diff in pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-10-24 Thread GitBox
tomscut commented on code in PR #4697: URL: https://github.com/apache/hadoop/pull/4697#discussion_r1003970562 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -1544,6 +1544,39 @@ public FSDataOutputStream append(Path f, int bufferS

[GitHub] [hadoop] ZanderXu commented on pull request #4209: HDFS-16550. [SBN read] Improper cache-size for journal node may cause cluster crash

2022-10-24 Thread GitBox
ZanderXu commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1289930632 @tomscut Thanks for involving me. In my case, I think this PR is unnecessary. But we can print some warning logs to prompt the admin if the set memory is too large, such as more than 90%

[GitHub] [hadoop] slfan1989 opened a new pull request, #5073: YARN-11354. [Federation] Add Yarn Router's NodeLabel Web Page.

2022-10-24 Thread GitBox
slfan1989 opened a new pull request, #5073: URL: https://github.com/apache/hadoop/pull/5073 JIRA: YARN-11354. [Federation] Add Yarn Router's NodeLabel Web Page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1289907315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623510#comment-17623510 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #4996:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1289879153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623500#comment-17623500 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1289868700 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623495#comment-17623495 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1289865110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623494#comment-17623494 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1289862848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623483#comment-17623483 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1289858087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomscut commented on pull request #4209: HDFS-16550. [SBN read] Improper cache-size for journal node may cause cluster crash

2022-10-24 Thread GitBox
tomscut commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1289848335 Hi @xkrogen @goiri @ZanderXu , could you please take a look? Thanks. The unit test is unrelated to this change. It is another issue. -- This is an automated message from the Apache

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003898982 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptorRetr

[GitHub] [hadoop] tomscut commented on a diff in pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-10-24 Thread GitBox
tomscut commented on code in PR #5068: URL: https://github.com/apache/hadoop/pull/5068#discussion_r1003894972 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -2321,6 +2324,9 @@ protected String reconfigurePropertyImpl(

[GitHub] [hadoop] tomscut commented on pull request #5069: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

2022-10-24 Thread GitBox
tomscut commented on PR #5069: URL: https://github.com/apache/hadoop/pull/5069#issuecomment-1289828012 Please fix the failed unit test and checkstyle warn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5072: HDFS-16817. Remove useless DataNode lock related configuration

2022-10-24 Thread GitBox
haiyang1987 opened a new pull request, #5072: URL: https://github.com/apache/hadoop/pull/5072 ### Description of PR [HDFS-16817](https://issues.apache.org/jira/browse/HDFS-16817) Remove useless DataNode lock related configuration When look at the code related to DataNode lock

[jira] [Commented] (HADOOP-18146) ABFS: Add changes for expect hundred continue header with append requests

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623446#comment-17623446 ] ASF GitHub Bot commented on HADOOP-18146: - mukund-thakur commented on PR #4039:

[GitHub] [hadoop] mukund-thakur commented on pull request #4039: HADOOP-18146: ABFS: Added changes for expect hundred continue header

2022-10-24 Thread GitBox
mukund-thakur commented on PR #4039: URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1289714876 Please make the changes as discussed during the call. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-18011) ABFS: Enable config control for default connection timeout

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623444#comment-17623444 ] ASF GitHub Bot commented on HADOOP-18011: - mukund-thakur commented on code in P

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3662: HADOOP-18011. ABFS: Configurable HTTP connection and read timeouts

2022-10-24 Thread GitBox
mukund-thakur commented on code in PR #3662: URL: https://github.com/apache/hadoop/pull/3662#discussion_r1003823510 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemE2E.java: ## @@ -229,4 +238,43 @@ private void testWriteOneByteToF

[GitHub] [hadoop] hadoop-yetus commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1289697594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1289661031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
goiri commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003737822 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptorRetry.ja

[GitHub] [hadoop] slfan1989 commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1289569883 @goiri Can you help review this pr again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623377#comment-17623377 ] ASF GitHub Bot commented on HADOOP-18430: - hadoop-yetus commented on PR #5070:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5070: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5070: URL: https://github.com/apache/hadoop/pull/5070#issuecomment-1289560040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003720625 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java: #

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003697221 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestSequentialBroadcastPolicyManage

[GitHub] [hadoop] hadoop-yetus commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1289525173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] snmvaughan commented on a diff in pull request #4835: HDFS-16740. Mini cluster test flakiness

2022-10-24 Thread GitBox
snmvaughan commented on code in PR #4835: URL: https://github.com/apache/hadoop/pull/4835#discussion_r1003683845 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniJournalCluster.java: ## @@ -64,7 +65,17 @@ public static class Builder { pub

[GitHub] [hadoop] snmvaughan commented on a diff in pull request #4835: HDFS-16740. Mini cluster test flakiness

2022-10-24 Thread GitBox
snmvaughan commented on code in PR #4835: URL: https://github.com/apache/hadoop/pull/4835#discussion_r1003680369 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniJournalCluster.java: ## @@ -64,7 +65,17 @@ public static class Builder { pub

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003668749 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptorRetr

[GitHub] [hadoop] slfan1989 commented on pull request #5030: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page.

2022-10-24 Thread GitBox
slfan1989 commented on PR #5030: URL: https://github.com/apache/hadoop/pull/5030#issuecomment-1289473469 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003631842 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public boolean de

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003606901 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +144,40 @@ private boolean

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003605313 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public bool

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003605800 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public boolean de

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003605313 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public bool

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623312#comment-17623312 ] ASF GitHub Bot commented on HADOOP-17612: - melissayou closed pull request #5047

[GitHub] [hadoop] melissayou closed pull request #5047: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241)

2022-10-24 Thread GitBox
melissayou closed pull request #5047: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241) URL: https://github.com/apache/hadoop/pull/5047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-24 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003591256 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,49 @@ public bool

[GitHub] [hadoop] xinglin opened a new pull request, #5071: Hdfs 16816

2022-10-24 Thread GitBox
xinglin opened a new pull request, #5071: URL: https://github.com/apache/hadoop/pull/5071 ### Description of PR In RBF, trash files are moved to trash root under user's home dir at the corresponding namespace/namenode where the files reside. This was added in [HDFS-16024](https://iss

[jira] [Commented] (HADOOP-18504) An unhandled NullPointerException in class KeyProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623302#comment-17623302 ] ASF GitHub Bot commented on HADOOP-18504: - steveloughran commented on PR #5064:

[GitHub] [hadoop] steveloughran commented on pull request #5064: HADOOP-18504. Fixed an unhandled NullPointerException in class KeyProvider

2022-10-24 Thread GitBox
steveloughran commented on PR #5064: URL: https://github.com/apache/hadoop/pull/5064#issuecomment-1289362288 sorry, i'd meant to say requireNonNull(); its what we are using to validate arguments now -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (HADOOP-18504) An unhandled NullPointerException in class KeyProvider

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623300#comment-17623300 ] ASF GitHub Bot commented on HADOOP-18504: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5064: HADOOP-18504. Fixed an unhandled NullPointerException in class KeyProvider

2022-10-24 Thread GitBox
steveloughran commented on code in PR #5064: URL: https://github.com/apache/hadoop/pull/5064#discussion_r1003577628 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java: ## @@ -646,8 +646,8 @@ public void invalidateCache(String name)

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623293#comment-17623293 ] ASF GitHub Bot commented on HADOOP-18430: - hadoop-yetus commented on PR #4832:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4832: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4832: URL: https://github.com/apache/hadoop/pull/4832#issuecomment-1289338568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri commented on a diff in pull request #5063: HDFS-16813. Remove parameter validation logic such as dfs.namenode.decommission.blocks.per.interval in DatanodeAdminManager#activate

2022-10-24 Thread GitBox
goiri commented on code in PR #5063: URL: https://github.com/apache/hadoop/pull/5063#discussion_r1003528435 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminDefaultMonitor.java: ## @@ -113,6 +113,17 @@ protected void pro

[GitHub] [hadoop] goiri merged pull request #5030: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page.

2022-10-24 Thread GitBox
goiri merged PR #5030: URL: https://github.com/apache/hadoop/pull/5030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[jira] [Resolved] (HADOOP-18506) Update build instructions for Windows using VS2019

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri resolved HADOOP-18506. -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Update build inst

[jira] [Commented] (HADOOP-18506) Update build instructions for Windows using VS2019

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623275#comment-17623275 ] ASF GitHub Bot commented on HADOOP-18506: - goiri merged PR #5066: URL: https://

[GitHub] [hadoop] goiri merged pull request #5066: HADOOP-18506. Update build instructions for Windows using VS2019

2022-10-24 Thread GitBox
goiri merged PR #5066: URL: https://github.com/apache/hadoop/pull/5066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] goiri commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
goiri commented on code in PR #5055: URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003516950 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptorRetry.ja

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623271#comment-17623271 ] ASF GitHub Bot commented on HADOOP-18430: - yuw1 opened a new pull request, #507

[GitHub] [hadoop] yuw1 opened a new pull request, #5070: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread GitBox
yuw1 opened a new pull request, #5070: URL: https://github.com/apache/hadoop/pull/5070 JIRA: https://issues.apache.org/jira/browse/HADOOP-18430 Refactor CallerContext's constructor to eliminate duplicate code -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] yuw1 closed pull request #4832: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread GitBox
yuw1 closed pull request #4832: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code URL: https://github.com/apache/hadoop/pull/4832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623261#comment-17623261 ] ASF GitHub Bot commented on HADOOP-18430: - yuw1 closed pull request #4832: HADO

[GitHub] [hadoop] slfan1989 commented on pull request #5030: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page.

2022-10-24 Thread GitBox
slfan1989 commented on PR #5030: URL: https://github.com/apache/hadoop/pull/5030#issuecomment-1289132011 @goiri Can you help to merge this pr into trunk branch? Thank you very much! I will follow up with YARN-11354 [Federation] Add Yarn Router's NodeLabel Web Page. -- This is an automate

[GitHub] [hadoop] slfan1989 commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-24 Thread GitBox
slfan1989 commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1289127779 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623203#comment-17623203 ] ASF GitHub Bot commented on HADOOP-17612: - hadoop-yetus commented on PR #5067:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5067: URL: https://github.com/apache/hadoop/pull/5067#issuecomment-1289086927 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Assigned] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

2022-10-24 Thread Ankit Saurabh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Saurabh reassigned HADOOP-18246: -- Assignee: Ankit Saurabh > Remove lower limit on s3a prefetching/caching block size >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5069: [HDFS-16815]: Fix two bugs occurred in processing CacheManagerSection for xml parsing fsimage

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5069: URL: https://github.com/apache/hadoop/pull/5069#issuecomment-1288896767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1288786473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1288765737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1288691890 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-24 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1288673482 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe