[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1306606896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1306604829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630140#comment-17630140 ] ASF GitHub Bot commented on HADOOP-18427: - virajith commented on PR #5118: URL:

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630141#comment-17630141 ] ASF GitHub Bot commented on HADOOP-18427: - virajith merged PR #5118: URL: https

[GitHub] [hadoop] virajith merged pull request #5118: Hadoop-18520. Backport HADOOP-18427 and HADOOP-18452 to branch-3.3

2022-11-07 Thread GitBox
virajith merged PR #5118: URL: https://github.com/apache/hadoop/pull/5118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] virajith commented on pull request #5118: Hadoop-18520. Backport HADOOP-18427 and HADOOP-18452 to branch-3.3

2022-11-07 Thread GitBox
virajith commented on PR #5118: URL: https://github.com/apache/hadoop/pull/5118#issuecomment-1306547093 Thanks for backporting these changes @melissayou! Changes look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] slfan1989 commented on pull request #5118: [Hadoop 18520]Backport HADOOP-18427 and HADOOP-18452 to branch-3.3

2022-11-07 Thread GitBox
slfan1989 commented on PR #5118: URL: https://github.com/apache/hadoop/pull/5118#issuecomment-1306544975 @melissayou Thanks for your contribution, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630137#comment-17630137 ] ASF GitHub Bot commented on HADOOP-18427: - slfan1989 commented on PR #5118: URL

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630130#comment-17630130 ] ASF GitHub Bot commented on HADOOP-18427: - hadoop-yetus commented on PR #5118:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5118: [Hadoop 18520]Backport HADOOP-18427 and HADOOP-18452 to branch-3.3

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5118: URL: https://github.com/apache/hadoop/pull/5118#issuecomment-1306518830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on pull request #4462: MAPREDUCE-7390. Remove WhiteBox in mapreduce module.

2022-11-07 Thread GitBox
slfan1989 commented on PR #4462: URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1306452399 @aajisaka Can you help review the code again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hadoop] slfan1989 commented on pull request #5105: YARN-11368. [Federation] Improve Yarn Router's Federation Page style.

2022-11-07 Thread GitBox
slfan1989 commented on PR #5105: URL: https://github.com/apache/hadoop/pull/5105#issuecomment-1306355450 @goiri Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630081#comment-17630081 ] ASF GitHub Bot commented on HADOOP-18427: - melissayou opened a new pull request

[GitHub] [hadoop] melissayou opened a new pull request, #5118: [Hadoop 18520]Backport HADOOP-18427 and HADOOP-18452 to branch-3.3

2022-11-07 Thread GitBox
melissayou opened a new pull request, #5118: URL: https://github.com/apache/hadoop/pull/5118 ### Description of PR As part of [HADOOP-18518](https://issues.apache.org/jira/browse/HADOOP-18518), this is the 3rd PR to fix deprecation of EnsurePath. in new Curator. It's a clean cher

[GitHub] [hadoop] virajith merged pull request #5112: Hadoop-18519. Backport HDFS-15383 and HADOOP-17835 to branch-3.3

2022-11-07 Thread GitBox
virajith merged PR #5112: URL: https://github.com/apache/hadoop/pull/5112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630014#comment-17630014 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: U

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-07 Thread GitBox
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1306147532 FYI @mehakmeet @mukund-thakur if you have some bandwidth to review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1306094812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629990#comment-17629990 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1306093551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629975#comment-17629975 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1306078980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629972#comment-17629972 ] ASF GitHub Bot commented on HADOOP-18517: - hadoop-yetus commented on PR #5103:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5103: URL: https://github.com/apache/hadoop/pull/5103#issuecomment-1306075462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Comment Edited] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629339#comment-17629339 ] Steve Loughran edited comment on HADOOP-18521 at 11/7/22 6:55 PM: ---

[GitHub] [hadoop] hadoop-yetus commented on pull request #5116: YARN-11369. Commons.compress throws an IllegalArgumentException with …

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5116: URL: https://github.com/apache/hadoop/pull/5116#issuecomment-1306028495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] goiri merged pull request #5105: YARN-11368. [Federation] Improve Yarn Router's Federation Page style.

2022-11-07 Thread GitBox
goiri merged PR #5105: URL: https://github.com/apache/hadoop/pull/5105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[jira] [Commented] (HADOOP-17436) envtoconf broken for .conf and few other formats

2022-11-07 Thread Nikolay Ivanitskiy (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629950#comment-17629950 ] Nikolay Ivanitskiy commented on HADOOP-17436: - this error is not related wi

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-07 Thread GitBox
simbadzina commented on code in PR #5088: URL: https://github.com/apache/hadoop/pull/5088#discussion_r1015741184 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -2879,9 +2880,12 @@ private void processRpcRequest(RpcRequestHeaderProto

[GitHub] [hadoop] simbadzina commented on pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-07 Thread GitBox
simbadzina commented on PR #5088: URL: https://github.com/apache/hadoop/pull/5088#issuecomment-1305990097 The change looks good to me. Still passes we refactored unit test in TestObserverWithRouter on trunk. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629945#comment-17629945 ] ASF GitHub Bot commented on HADOOP-18484: - hadoop-yetus commented on PR #5114:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1305980607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18479) Update jackson-databind to mitigate CVE-2022-42003

2022-11-07 Thread phoebe chen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629941#comment-17629941 ] phoebe chen commented on HADOOP-18479: -- Hi [~groot] [~ste...@apache.org]  hadoop-

[jira] [Updated] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18521: Labels: pull-request-available (was: ) > ABFS ReadBufferManager buffer sharing across co

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629937#comment-17629937 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran opened a new pull requ

[GitHub] [hadoop] steveloughran opened a new pull request, #5117: HADOOP-18521. ABFS ReadBufferManager does not reuse in-progress buffers

2022-11-07 Thread GitBox
steveloughran opened a new pull request, #5117: URL: https://github.com/apache/hadoop/pull/5117 Addresses the issue by not trying to cancel in-progress reads when a stream is closed()...they are allowed to continue and then their data discarded. To enable discarding, AbfsInputStream

[GitHub] [hadoop] virajith commented on pull request #5112: Hadoop-18519. Backport HDFS-15383 and HADOOP-17835 to branch-3.3

2022-11-07 Thread GitBox
virajith commented on PR #5112: URL: https://github.com/apache/hadoop/pull/5112#issuecomment-1305950656 I'll merge this in the next hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [hadoop] virajith commented on pull request #5112: Hadoop-18519. Backport HDFS-15383 and HADOOP-17835 to branch-3.3

2022-11-07 Thread GitBox
virajith commented on PR #5112: URL: https://github.com/apache/hadoop/pull/5112#issuecomment-1305950206 Thanks for the backport @melissayou . The changes look good to me - I expect the deprecated method will be addressed by [HADOOP-18520](https://issues.apache.org/jira/browse/HADOOP-18520).

[jira] [Resolved] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-07 Thread Virajith Jalaparti (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Virajith Jalaparti resolved HADOOP-18515. - Resolution: Fixed > Backport HADOOP-17612 to branch-3.3 > -

[GitHub] [hadoop] simbadzina closed pull request #4883: HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients.

2022-11-07 Thread GitBox
simbadzina closed pull request #4883: HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients. URL: https://github.com/apache/hadoop/pull/4883 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] bteke opened a new pull request, #5116: YARN-11369. Commons.compress throws an IllegalArgumentException with …

2022-11-07 Thread GitBox
bteke opened a new pull request, #5116: URL: https://github.com/apache/hadoop/pull/5116 …large uids after 1.21. ### Description of PR Encountering [COMPRESS-587](https://issues.apache.org/jira/browse/COMPRESS-587) with large uids/gids in hadoop-mapreduce-client-uploader/src/m

[GitHub] [hadoop] omalley commented on pull request #5078: HDFS-16821: Fixes regression in HDFS-13522 that enables observer reads by default

2022-11-07 Thread GitBox
omalley commented on PR #5078: URL: https://github.com/apache/hadoop/pull/5078#issuecomment-1305886044 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hadoop] omalley merged pull request #5078: HDFS-16821: Fixes regression in HDFS-13522 that enables observer reads by default

2022-11-07 Thread GitBox
omalley merged PR #5078: URL: https://github.com/apache/hadoop/pull/5078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] hadoop-yetus commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1305877086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-07 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1305769517 Thank you so much @aajisaka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hadoop] aajisaka commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-07 Thread GitBox
aajisaka commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1305767597 Thank you @ashutoshcipher for your patch. I reviewed 57 out of 105 files and now I have no comments. I'll review the rest tomorrow. -- This is an automated message from the Apache Git S

[GitHub] [hadoop] hadoop-yetus commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1305722509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18183) s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629856#comment-17629856 ] ASF GitHub Bot commented on HADOOP-18183: - hadoop-yetus commented on PR #5110:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5110: HADOOP-18183. s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5110: URL: https://github.com/apache/hadoop/pull/5110#issuecomment-1305718495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629854#comment-17629854 ] ASF GitHub Bot commented on HADOOP-18517: - hadoop-yetus commented on PR #5103:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5103: URL: https://github.com/apache/hadoop/pull/5103#issuecomment-1305716451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629843#comment-17629843 ] ASF GitHub Bot commented on HADOOP-18517: - steveloughran commented on PR #5103:

[GitHub] [hadoop] steveloughran commented on pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread GitBox
steveloughran commented on PR #5103: URL: https://github.com/apache/hadoop/pull/5103#issuecomment-1305665580 test with threads=8 happy; timeout on `ITestAzureBlobFileSystemLease` which was fine in standalone -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629827#comment-17629827 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1305635999 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-15245) S3AInputStream.skip() to use lazy seek

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629819#comment-17629819 ] ASF GitHub Bot commented on HADOOP-15245: - hadoop-yetus commented on PR #3927:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3927: HADOOP-15245. S3AInputStream.skip() to use lazy seek

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #3927: URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1305621038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] p-szucs opened a new pull request, #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-07 Thread GitBox
p-szucs opened a new pull request, #5115: URL: https://github.com/apache/hadoop/pull/5115 ### Description of PR Code improvements in MutableCSConfigurationProvider class: - Created ConfUpdateAssembler class to contain logic for ConfUpdate map creation from mutation info - Eliminated

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629804#comment-17629804 ] ASF GitHub Bot commented on HADOOP-18517: - steveloughran commented on PR #5103:

[GitHub] [hadoop] steveloughran commented on pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread GitBox
steveloughran commented on PR #5103: URL: https://github.com/apache/hadoop/pull/5103#issuecomment-1305592769 removed openFile() option; this is cluster admin only. tested with 14 threads and got timeout on lease and throttling out of range. clearly too many threads ``` [

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629800#comment-17629800 ] ASF GitHub Bot commented on HADOOP-18517: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-07 Thread GitBox
steveloughran commented on code in PR #5103: URL: https://github.com/apache/hadoop/pull/5103#discussion_r1015384392 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java: ## @@ -106,6 +106,7 @@ public final class FileSys

[jira] [Commented] (HADOOP-18183) s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629795#comment-17629795 ] ASF GitHub Bot commented on HADOOP-18183: - sauraank commented on PR #5110: URL:

[GitHub] [hadoop] sauraank commented on pull request #5110: HADOOP-18183. s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread GitBox
sauraank commented on PR #5110: URL: https://github.com/apache/hadoop/pull/5110#issuecomment-1305551465 Thanks @dannycjones @ashutoshcipher for the review. I have fixed the checkstyle recommendation. I have also added the integration test result for hadoop-aws. -- This is an automated m

[jira] [Commented] (HADOOP-15245) S3AInputStream.skip() to use lazy seek

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629791#comment-17629791 ] ASF GitHub Bot commented on HADOOP-15245: - hadoop-yetus commented on PR #3927:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3927: HADOOP-15245. S3AInputStream.skip() to use lazy seek

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #3927: URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1305527450 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629789#comment-17629789 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015354894 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -140,10 +138,10 @@ public int getCallCount() { FSDataIn

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629782#comment-17629782 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015341222 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Softw

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629780#comment-17629780 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015341222 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Softw

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629779#comment-17629779 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629778#comment-17629778 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015339894 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/MockAbfsClientThrottlingAnalyzer.java: ## @@ -0,0 +1,49 @@ +/** + * Lice

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015339638 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Softw

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629776#comment-17629776 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629777#comment-17629777 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015339457 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Softw

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015338948 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -311,6 +319,14 @@ private boolean executeH

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629761#comment-17629761 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1305474596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629760#comment-17629760 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1305472772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18183) s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629752#comment-17629752 ] ASF GitHub Bot commented on HADOOP-18183: - dannycjones commented on PR #5110: U

[GitHub] [hadoop] dannycjones commented on pull request #5110: HADOOP-18183. s3a audit logs to publish range start/end of GET requests in audit header

2022-11-07 Thread GitBox
dannycjones commented on PR #5110: URL: https://github.com/apache/hadoop/pull/5110#issuecomment-1305440067 >Please fix the style check Oops, didn't realise this doesn't fail CI. Thanks for calling that out, Ashutosh. -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629738#comment-17629738 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015235293 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/MockAbfsClientThrottlingAnalyzer.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629735#comment-17629735 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015231362 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629733#comment-17629733 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015227962 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629729#comment-17629729 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629731#comment-17629731 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015227331 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015226867 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629727#comment-17629727 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629726#comment-17629726 ] ASF GitHub Bot commented on HADOOP-18501: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015225635 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingIntercept.java: ## @@ -89,8 +90,17 @@ static void updateMetr

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-07 Thread GitBox
anmolanmol1234 commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1015224617 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -311,6 +319,14 @@ private boolean executeHttpOpera

  1   2   >