[GitHub] [hadoop] hadoop-yetus commented on pull request #5204: HDFS-16864. Drop cache behind entire block on close

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5204: URL: https://github.com/apache/hadoop/pull/5204#issuecomment-1404561494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5216: HDFS-16864. Drop cache behind entire block on close

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5216: URL: https://github.com/apache/hadoop/pull/5216#issuecomment-1404497942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-1404405227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680822#comment-17680822 ] ASF GitHub Bot commented on HADOOP-18535: - hadoop-yetus commented on PR #5325:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1404294389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680816#comment-17680816 ] ASF GitHub Bot commented on HADOOP-18535: - hadoop-yetus commented on PR #5325:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1404269165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5244: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5244: URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1404267749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] 9uapaw commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
9uapaw commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087133894 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySc

[GitHub] [hadoop] 9uapaw commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
9uapaw commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087132529 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySc

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680787#comment-17680787 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087115942 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,62 +17,34 @@ */ package org.apache.hadoop.util; -import o

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680772#comment-17680772 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087096464 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -360,7 +358,8 @@ public class DataNode extends Reconfigu

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087071885 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Stri

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087067420 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4917,7 +4917,6 @@ public CompletableFuture build() throws IOExcep

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087065955 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEnclosingRoot.java: ## @@ -92,11 +92,14 @@ protected void setProvider() { @After

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087064216 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Stri

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087063872 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetEnclosingRoot.java: ## @@ -0,0 +1,100 @@ +/** + * Licensed to

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087062926 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetEnclosingRoot.java: ## @@ -0,0 +1,100 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680747#comment-17680747 ] ASF GitHub Bot commented on HADOOP-18206: - jojochuang commented on code in PR #

[GitHub] [hadoop] jojochuang commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
jojochuang commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087030863 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -360,7 +358,8 @@ public class DataNode extends Reconfigur

[GitHub] [hadoop] szilard-nemeth commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1404008860 @K0K0V0K I will go through the changes in TestNMClient tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-25 Thread via GitHub
szilard-nemeth commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1086928113 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java: ## @@ -456,6 +456

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mkuchenbecker commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1086894151 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Str

[jira] [Commented] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2023-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680701#comment-17680701 ] ASF GitHub Bot commented on HADOOP-17649: - ashutoshcipher commented on PR #4539

[GitHub] [hadoop] ashutoshcipher commented on pull request #5023: MAPREDUCE-7413. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs-plugins

2023-01-25 Thread via GitHub
ashutoshcipher commented on PR #5023: URL: https://github.com/apache/hadoop/pull/5023#issuecomment-1403935034 Thanks @aajisaka for review and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] ashutoshcipher commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2023-01-25 Thread via GitHub
ashutoshcipher commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1403934316 > catching up on this. its' too late for 3.3.5, but we can get it into branch-3.3. for the successor. can you rebase? @steveloughran , I have rebased. Please help in review.

[GitHub] [hadoop] szilard-nemeth commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1403888682 Thanks @riyakhdl for working on this. Latest patch LGTM, committed to trunk. Thanks @K0K0V0K and @ashutoshcipher for the reviews. -- This is an automated message from the

[GitHub] [hadoop] szilard-nemeth closed pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5113: YARN-6971 Clean up different ways to create resources URL: https://github.com/apache/hadoop/pull/5113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403856616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] szilard-nemeth closed pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion URL: https://github.com/apache/hadoop/pull/5119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] szilard-nemeth commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1403689047 Thanks @susheel-gupta for working on this. Latest patch LGTM, committed to trunk. Thanks @K0K0V0K for the review. -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] szilard-nemeth closed pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure URL: https://github.com/apache/hadoop/pull/5295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] szilard-nemeth commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1403678232 Thanks @susheel-gupta for working on this. Latest patch LGTM, committed to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] slfan1989 commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
slfan1989 commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403569117 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1403526896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403510708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1403465967 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-25 Thread via GitHub
susheel-gupta commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1086487425 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/convert

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1403399970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5244: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2023-01-25 Thread via GitHub
slfan1989 commented on PR #5244: URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1403352045 > SQL Server 2008 R2 Enterprise > select @@version ``` Microsoft SQL Server 2008 R2 (SP3) - 10.50.6000.34 (X64) Aug 19 2014 12:21:34 Copyright (c) Micros

[GitHub] [hadoop] slfan1989 opened a new pull request, #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
slfan1989 opened a new pull request, #5326: URL: https://github.com/apache/hadoop/pull/5326 JIRA: YARN-11425. [Federation] Router Supports SubClusterCleaner. In YARN-Federation mode, once a SubCluster is registered, the SubCluster is always in the RUNNING state, even if the SubCluster