virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087096464
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ########## @@ -360,7 +358,8 @@ public class DataNode extends ReconfigurableBase FS_GETSPACEUSED_JITTER_KEY, FS_GETSPACEUSED_CLASSNAME)); - public static final Log METRICS_LOG = LogFactory.getLog("DataNodeMetricsLog"); + public static final org.apache.log4j.Logger METRICS_LOG = + org.apache.log4j.Logger.getLogger("DataNodeMetricsLog"); Review Comment: I agree for using slf4j directly but the problem here is that `makeMetricsLoggerAsync()` is adding async appenders and using few more APIs like `setAdditivity()` and `removeAppender()` directly from log4j. Hence, for this PR, it would be difficult to switch to using slf4j. But yes this work is planned as a sub-task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org