[GitHub] [hadoop] hadoop-yetus commented on pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5381: URL: https://github.com/apache/hadoop/pull/5381#issuecomment-1426645693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5358: HDFS-16907. Add LastHeartbeatResponseTime for BP service actor (#5349)

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5358: URL: https://github.com/apache/hadoop/pull/5358#issuecomment-1426642218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18628) Server connection should log host name before returning VersionMismatch error

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687360#comment-17687360 ] ASF GitHub Bot commented on HADOOP-18628: - virajjasani opened a new pull reques

[jira] [Updated] (HADOOP-18628) Server connection should log host name before returning VersionMismatch error

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18628: Labels: pull-request-available (was: ) > Server connection should log host name before r

[GitHub] [hadoop] virajjasani opened a new pull request, #5385: HADOOP-18628. Server connection should log host name before returning VersionMismatch error

2023-02-10 Thread via GitHub
virajjasani opened a new pull request, #5385: URL: https://github.com/apache/hadoop/pull/5385 In env with dynamically changing IP addresses, debugging issue with the logs with only IP address becomes a bit difficult at times. ``` 2023-02-08 23:26:50,112 WARN [Socket Reader #1 for

[jira] [Created] (HADOOP-18628) Server connection should log host name before returning VersionMismatch error

2023-02-10 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-18628: - Summary: Server connection should log host name before returning VersionMismatch error Key: HADOOP-18628 URL: https://issues.apache.org/jira/browse/HADOOP-18628 Pro

[GitHub] [hadoop] hadoop-yetus commented on pull request #4835: HDFS-16740. Mini cluster test flakiness

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #4835: URL: https://github.com/apache/hadoop/pull/4835#issuecomment-1426578575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
hfutatzhanghb commented on code in PR #5381: URL: https://github.com/apache/hadoop/pull/5381#discussion_r1103466438 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -1557,7 +1557,7 @@ public ReplicaH

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
hfutatzhanghb commented on code in PR #5381: URL: https://github.com/apache/hadoop/pull/5381#discussion_r1103466308 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5943,6 +5943,9 @@ LocatedBlock bumpBlockGeneratio

[GitHub] [hadoop] tomscut commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-02-10 Thread via GitHub
tomscut commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1426510355 Hi @hfutatzhanghb , could you please backport this to branch-3.3. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hadoop] tomscut commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-02-10 Thread via GitHub
tomscut commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1426508850 Thanks @hfutatzhanghb for your contribution! Thanks @goiri for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] tomscut merged pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-02-10 Thread via GitHub
tomscut merged PR #5276: URL: https://github.com/apache/hadoop/pull/5276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] tomscut commented on a diff in pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
tomscut commented on code in PR #5381: URL: https://github.com/apache/hadoop/pull/5381#discussion_r1103393439 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -1557,7 +1557,7 @@ public ReplicaHandler

[GitHub] [hadoop] hadoop-yetus commented on pull request #5372: HDFS-16904. Close webhdfs during TestSymlinkHdfs teardown

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5372: URL: https://github.com/apache/hadoop/pull/5372#issuecomment-1426191079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5384: Bump logback-classic from 1.1.2 to 1.2.0 in /hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5384: URL: https://github.com/apache/hadoop/pull/5384#issuecomment-1426180988 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5381: URL: https://github.com/apache/hadoop/pull/5381#issuecomment-1426143741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] omalley merged pull request #5371: HDFS-18324. Fix race condition in closing IPC connections.

2023-02-10 Thread via GitHub
omalley merged PR #5371: URL: https://github.com/apache/hadoop/pull/5371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[jira] [Comment Edited] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687104#comment-17687104 ] PJ Fanning edited comment on HADOOP-18619 at 2/10/23 5:40 PM: ---

[jira] [Commented] (HADOOP-18470) Release hadoop 3.3.5

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687213#comment-17687213 ] ASF GitHub Bot commented on HADOOP-18470: - hadoop-yetus commented on PR #5383:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5383: HADOOP-18470. More in the index.html about security

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5383: URL: https://github.com/apache/hadoop/pull/5383#issuecomment-1426121870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1426081305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] dependabot[bot] opened a new pull request, #5384: Bump logback-classic from 1.1.2 to 1.2.0 in /hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

2023-02-10 Thread via GitHub
dependabot[bot] opened a new pull request, #5384: URL: https://github.com/apache/hadoop/pull/5384 Bumps logback-classic from 1.1.2 to 1.2.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logback

[GitHub] [hadoop] brumi1024 commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-02-10 Thread via GitHub
brumi1024 commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1426065639 Thanks @tomicooler, the patch looks good to me, merged to trunk. Thanks @K0K0V0K for the review. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] brumi1024 merged pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-02-10 Thread via GitHub
brumi1024 merged PR #5311: URL: https://github.com/apache/hadoop/pull/5311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] hadoop-yetus commented on pull request #5382: YARN-8972. [Router] Add support to prevent DoS attack over ApplicationSubmissionContext size.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5382: URL: https://github.com/apache/hadoop/pull/5382#issuecomment-1426010945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18470) Release hadoop 3.3.5

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687128#comment-17687128 ] ASF GitHub Bot commented on HADOOP-18470: - steveloughran commented on PR #5383:

[jira] [Updated] (HADOOP-18470) Release hadoop 3.3.5

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18470: Labels: pull-request-available (was: ) > Release hadoop 3.3.5 > > >

[jira] [Commented] (HADOOP-18470) Release hadoop 3.3.5

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687127#comment-17687127 ] ASF GitHub Bot commented on HADOOP-18470: - steveloughran opened a new pull requ

[GitHub] [hadoop] steveloughran commented on pull request #5383: HADOOP-18470. More in the index.html about security

2023-02-10 Thread via GitHub
steveloughran commented on PR #5383: URL: https://github.com/apache/hadoop/pull/5383#issuecomment-1425988930 +@lmccay ...comments about Knox OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hadoop] steveloughran opened a new pull request, #5383: HADOOP-18470. More in the index.html about security

2023-02-10 Thread via GitHub
steveloughran opened a new pull request, #5383: URL: https://github.com/apache/hadoop/pull/5383 Expands on the comments in cluster config to tell people they shouldn't be running a cluster without a private VLAN in cloud, that Knox is good here, and unsecured clusters without a VLAN are

[jira] [Comment Edited] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687104#comment-17687104 ] PJ Fanning edited comment on HADOOP-18619 at 2/10/23 2:54 PM: ---

[jira] [Commented] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687104#comment-17687104 ] PJ Fanning commented on HADOOP-18619: - I had a quick look and getting jersey-core t

[GitHub] [hadoop] snmvaughan commented on a diff in pull request #5372: HDFS-16904. Close webhdfs during TestSymlinkHdfs teardown

2023-02-10 Thread via GitHub
snmvaughan commented on code in PR #5372: URL: https://github.com/apache/hadoop/pull/5372#discussion_r1102858612 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfs.java: ## @@ -100,7 +100,7 @@ public static void afterClassTeardown() throws Exce

[GitHub] [hadoop] hadoop-yetus commented on pull request #5382: YARN-8972. [Router] Add support to prevent DoS attack over ApplicationSubmissionContext size.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5382: URL: https://github.com/apache/hadoop/pull/5382#issuecomment-1425622427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Comment Edited] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687023#comment-17687023 ] PJ Fanning edited comment on HADOOP-18619 at 2/10/23 10:51 AM: --

[jira] [Commented] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687023#comment-17687023 ] PJ Fanning commented on HADOOP-18619: - I haven't tried playing with jersey-core too

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687020#comment-17687020 ] ASF GitHub Bot commented on HADOOP-18542: - CLevasseur commented on PR #4262: UR

[GitHub] [hadoop] CLevasseur commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-10 Thread via GitHub
CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1425612739 I just reran the whole test suite on a fresh install, and this time everything passed, without changing the code 🤷 Note that I had switched to an HNS account last time already. Th

[jira] [Commented] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687017#comment-17687017 ] Steve Loughran commented on HADOOP-18619: - could we get away with having a shad

[jira] [Updated] (HADOOP-18627) site intro docs to make clear Kerberos is mandatory for secure clusters

2023-02-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18627: Summary: site intro docs to make clear Kerberos is mandatory for secure clusters (was: s

[jira] [Created] (HADOOP-18627) site intro docs to make clear Kerberos is important

2023-02-10 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18627: --- Summary: site intro docs to make clear Kerberos is important Key: HADOOP-18627 URL: https://issues.apache.org/jira/browse/HADOOP-18627 Project: Hadoop Common

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2023-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687008#comment-17687008 ] ASF GitHub Bot commented on HADOOP-18501: - steveloughran commented on PR #5109:

[GitHub] [hadoop] steveloughran commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data: DRAFT

2023-02-10 Thread via GitHub
steveloughran commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1425579540 what is the status/plan for this? i'm starting to look at the 3.3.6 feature set... -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [hadoop] hadoop-yetus commented on pull request #5380: YARN-11079. Make an AbstractParentQueue to store common ParentQueue and ManagedParentQueue functionality

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5380: URL: https://github.com/apache/hadoop/pull/5380#issuecomment-1425552948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

2023-02-10 Thread via GitHub
hadoop-yetus commented on PR #5381: URL: https://github.com/apache/hadoop/pull/5381#issuecomment-1425470212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe