[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696065#comment-17696065 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on PR #5451: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5451: HADOOP-18631 (ADDENDUM) Avoid deleting audit log file under heavy writes

2023-03-02 Thread via GitHub
virajjasani commented on PR #5451: URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1453107859 Even though the test never failed as part of any build runs on PR #5418, after the PR was merged, the test failed on the daily builds (e.g.

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696062#comment-17696062 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-03-02 Thread via GitHub
virajjasani commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1453103919 Addendum PR https://github.com/apache/hadoop/pull/5451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696051#comment-17696051 ] ASF GitHub Bot commented on HADOOP-18631: - virajjasani commented on PR #5418: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-03-02 Thread via GitHub
virajjasani commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-1453083196 This flaky behavior is relevant to this change, even though it never failed on any of above build runs. Let me create an addendum. Thanks -- This is an automated message from the

[GitHub] [hadoop] slfan1989 commented on pull request #5450: HDFS-16939. Fix the thread safety bug in LowRedundancyBlocks.

2023-03-02 Thread via GitHub
slfan1989 commented on PR #5450: URL: https://github.com/apache/hadoop/pull/5450#issuecomment-1453082018 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18631) Migrate Async appenders to log4j properties

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696043#comment-17696043 ] ASF GitHub Bot commented on HADOOP-18631: - ayushtkn commented on PR #5418: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5418: HADOOP-18631. Migrate Async appenders to log4j properties

2023-03-02 Thread via GitHub
ayushtkn commented on PR #5418: URL: https://github.com/apache/hadoop/pull/5418#issuecomment-145302 There is a test failing ``TestFsck`` most probably due to this change.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5450: HDFS-16939. Fix the thread safety bug in LowRedundancyBlocks.

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5450: URL: https://github.com/apache/hadoop/pull/5450#issuecomment-1453058032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhangshuyan0 opened a new pull request, #5450: HDFS-16939. Fix the thread safety bug in LowRedundancyBlocks.

2023-03-02 Thread via GitHub
zhangshuyan0 opened a new pull request, #5450: URL: https://github.com/apache/hadoop/pull/5450 The remove method in LowRedundancyBlocks is not protected by synchronized. This method is private and is called by BlockManager. As a result, priorityQueues has the risk of being accessed

[jira] [Commented] (HADOOP-18649) CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696005#comment-17696005 ] ASF GitHub Bot commented on HADOOP-18649: - virajjasani commented on PR #5448: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5448: HADOOP-18649. CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread via GitHub
virajjasani commented on PR #5448: URL: https://github.com/apache/hadoop/pull/5448#issuecomment-1452990178 @Apache9 @jojochuang could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] saxenapranav commented on a diff in pull request #5445: HDFS-16938. Utility to trigger heartbeat and wait until BP thread queue is fully processed

2023-03-02 Thread via GitHub
saxenapranav commented on code in PR #5445: URL: https://github.com/apache/hadoop/pull/5445#discussion_r1124018756 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java: ## @@ -34,7 +34,8 @@ public class ErrorReportAction

[GitHub] [hadoop] hadoop-yetus commented on pull request #5447: HDFS-15765. WebHdfs: add support for basic auth and custom API path

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5447: URL: https://github.com/apache/hadoop/pull/5447#issuecomment-1452859975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5445: HDFS-16938. Utility to trigger heartbeat and wait until BP thread queue is fully processed

2023-03-02 Thread via GitHub
virajjasani commented on code in PR #5445: URL: https://github.com/apache/hadoop/pull/5445#discussion_r1123555498 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java: ## @@ -34,7 +34,8 @@ public class ErrorReportAction

[GitHub] [hadoop] saxenapranav commented on a diff in pull request #5445: HDFS-16938. Utility to trigger heartbeat and wait until BP thread queue is fully processed

2023-03-02 Thread via GitHub
saxenapranav commented on code in PR #5445: URL: https://github.com/apache/hadoop/pull/5445#discussion_r1123444698 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java: ## @@ -34,7 +34,8 @@ public class ErrorReportAction

[jira] [Commented] (HADOOP-17177) Java 17 support

2023-03-02 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695829#comment-17695829 ] Ashutosh Gupta commented on HADOOP-17177: - [~tasanuma] - That's interesting that you havnt seen

[jira] [Commented] (HADOOP-17177) Java 17 support

2023-03-02 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695827#comment-17695827 ] Ashutosh Gupta commented on HADOOP-17177: - [~ste...@apache.org] - The Teragen and terasort

[GitHub] [hadoop] saxenapranav commented on a diff in pull request #5445: HDFS-16938. Utility to trigger heartbeat and wait until BP thread queue is fully processed

2023-03-02 Thread via GitHub
saxenapranav commented on code in PR #5445: URL: https://github.com/apache/hadoop/pull/5445#discussion_r1123444698 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java: ## @@ -34,7 +34,8 @@ public class ErrorReportAction

[GitHub] [hadoop] szilard-nemeth commented on pull request #5286: YARN-11410. Add default methods for StateMachine

2023-03-02 Thread via GitHub
szilard-nemeth commented on PR #5286: URL: https://github.com/apache/hadoop/pull/5286#issuecomment-1451931848 Hi @K0K0V0K , Why this PR was closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5447: HDFS-15765. WebHdfs: add support for basic auth and custom API path

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5447: URL: https://github.com/apache/hadoop/pull/5447#issuecomment-1451907434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4093: YARN-11093: fix for reading files in timeline server in chronological order in case of fs-support-append to false

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #4093: URL: https://github.com/apache/hadoop/pull/4093#issuecomment-1451867986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-16387) S3A openFile() options to allow etag/version to be set

2023-03-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16387: Parent Issue: HADOOP-18477 (was: HADOOP-15620) > S3A openFile() options to allow

[jira] [Commented] (HADOOP-16387) S3A openFile() options to allow etag/version to be set

2023-03-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695715#comment-17695715 ] Steve Loughran commented on HADOOP-16387: - this is needed when explicitly downloading a

[jira] [Reopened] (HADOOP-16387) S3A openFile() options to allow etag/version to be set

2023-03-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-16387: - > S3A openFile() options to allow etag/version to be set >

[jira] [Commented] (HADOOP-18649) CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695701#comment-17695701 ] ASF GitHub Bot commented on HADOOP-18649: - hadoop-yetus commented on PR #5448: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5448: HADOOP-18649. CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5448: URL: https://github.com/apache/hadoop/pull/5448#issuecomment-1451820102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18649) CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695699#comment-17695699 ] ASF GitHub Bot commented on HADOOP-18649: - hadoop-yetus commented on PR #5448: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5448: HADOOP-18649. CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5448: URL: https://github.com/apache/hadoop/pull/5448#issuecomment-1451819132 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5434: HDFS-16934. org.apache.hadoop.hdfs.tools.TestDFSAdmin#testAllDatanodesReconfig regression

2023-03-02 Thread via GitHub
slfan1989 commented on PR #5434: URL: https://github.com/apache/hadoop/pull/5434#issuecomment-1451744187 > checkstyle failing on an unused import; other than that I'm happy -the assertj collection asserts are so much better for asserting on collections and debugging their failures. >

[jira] [Commented] (HADOOP-18649) CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695676#comment-17695676 ] ASF GitHub Bot commented on HADOOP-18649: - hadoop-yetus commented on PR #5448: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5448: HADOOP-18649. CLA and CRLA appenders to be replaced with RFA

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5448: URL: https://github.com/apache/hadoop/pull/5448#issuecomment-1451742473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17177) Java 17 support

2023-03-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695675#comment-17695675 ] Steve Loughran commented on HADOOP-17177: - ashutosh -this with data on s3? No HDFS issues AFAIK

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5443: YARN-11448 [Federation] Stateless Router Secret Manager

2023-03-02 Thread via GitHub
slfan1989 commented on code in PR #5443: URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122958706 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -419,31 +427,32 @@

[GitHub] [hadoop] krishan1390 commented on a diff in pull request #5443: YARN-11448 [Federation] Stateless Router Secret Manager

2023-03-02 Thread via GitHub
krishan1390 commented on code in PR #5443: URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122930678 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -419,31 +427,32 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #4093: YARN-11093: fix for reading files in timeline server in chronological order in case of fs-support-append to false

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #4093: URL: https://github.com/apache/hadoop/pull/4093#issuecomment-1451692475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5449: HDFS-16930. Update the wrapper for fuse-dfs

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5449: URL: https://github.com/apache/hadoop/pull/5449#issuecomment-1451675091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5317: YARN-11420 Stabilize TestNMClient

2023-03-02 Thread via GitHub
szilard-nemeth commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1122893607 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java: ## @@ -125,576 +117,362 @@ public

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5317: YARN-11420 Stabilize TestNMClient

2023-03-02 Thread via GitHub
szilard-nemeth commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1122893607 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java: ## @@ -125,576 +117,362 @@ public

[jira] [Commented] (HADOOP-18632) ABFS: Customize and optimize timeouts made based on each separate request

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695589#comment-17695589 ] ASF GitHub Bot commented on HADOOP-18632: - hadoop-yetus commented on PR #5399: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5399: HADOOP-18632: [ABFS] Customize and optimize timeouts made based on each separate request

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5399: URL: https://github.com/apache/hadoop/pull/5399#issuecomment-1451568775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] chaohengstudent opened a new pull request, #5449: HDFS-16930. Update the wrapper for fuse-dfs

2023-03-02 Thread via GitHub
chaohengstudent opened a new pull request, #5449: URL: https://github.com/apache/hadoop/pull/5449 ### Description of PR update path with LIBHDFS_PATH add path to LD_LIBRARY_PATH with compatible to java11 edit CLASSPATH ### How was this patch tested? manual test

[jira] [Commented] (HADOOP-18640) ABFS: Enabling Client-side Backoff only for new requests

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695569#comment-17695569 ] ASF GitHub Bot commented on HADOOP-18640: - hadoop-yetus commented on PR #5446: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5446: HADOOP-18640: [ABFS] Enabling Client-side Backoff only for new requests

2023-03-02 Thread via GitHub
hadoop-yetus commented on PR #5446: URL: https://github.com/apache/hadoop/pull/5446#issuecomment-1451533058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5443: YARN-11448 [Federation] Stateless Router Secret Manager

2023-03-02 Thread via GitHub
slfan1989 commented on PR #5443: URL: https://github.com/apache/hadoop/pull/5443#issuecomment-1451469175 > > allKeys needs to be consistently updated across all router instances > > > Multiple Routers will share and store the Delegation token, there is no updated across all router