hadoop-yetus commented on PR #5450:
URL: https://github.com/apache/hadoop/pull/5450#issuecomment-1455624438
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696724#comment-17696724
]
ASF GitHub Bot commented on HADOOP-18606:
-
saxenapranav commented on PR #5299:
saxenapranav commented on PR #5299:
URL: https://github.com/apache/hadoop/pull/5299#issuecomment-141173
> I'm happy with all the code! just a little bit of javadoc tuning and we
are done!
>
> +1 pending the changes
Thank you so much @steveloughran. Have made changes as per
hadoop-yetus commented on PR #5335:
URL: https://github.com/apache/hadoop/pull/5335#issuecomment-1455549292
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696719#comment-17696719
]
ASF GitHub Bot commented on HADOOP-18640:
-
hadoop-yetus commented on PR #5446:
hadoop-yetus commented on PR #5446:
URL: https://github.com/apache/hadoop/pull/5446#issuecomment-1455548802
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696718#comment-17696718
]
ASF GitHub Bot commented on HADOOP-18606:
-
saxenapranav commented on code in PR
saxenapranav commented on code in PR #5299:
URL: https://github.com/apache/hadoop/pull/5299#discussion_r1125997865
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/RetryReason.java:
##
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696717#comment-17696717
]
ASF GitHub Bot commented on HADOOP-18606:
-
saxenapranav commented on code in PR
saxenapranav commented on code in PR #5299:
URL: https://github.com/apache/hadoop/pull/5299#discussion_r1125997327
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/retryReasonCategories/package-info.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696707#comment-17696707
]
ASF GitHub Bot commented on HADOOP-18629:
-
hadoop-yetus commented on PR #5391:
hadoop-yetus commented on PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#issuecomment-1455526533
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696706#comment-17696706
]
ASF GitHub Bot commented on HADOOP-18653:
-
virajjasani commented on PR #5456:
U
virajjasani commented on PR #5456:
URL: https://github.com/apache/hadoop/pull/5456#issuecomment-1455515041
@Apache9 @jojochuang could you please also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696704#comment-17696704
]
ASF GitHub Bot commented on HADOOP-18653:
-
virajjasani commented on PR #5456:
U
virajjasani commented on PR #5456:
URL: https://github.com/apache/hadoop/pull/5456#issuecomment-1455513493
@steveloughran This PR is a follow-up task from #5315 (comment
[here](https://github.com/apache/hadoop/pull/5315#discussion_r1081327340))
Could you please review this PR?
--
T
[
https://issues.apache.org/jira/browse/HADOOP-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696703#comment-17696703
]
ASF GitHub Bot commented on HADOOP-18653:
-
virajjasani opened a new pull reques
[
https://issues.apache.org/jira/browse/HADOOP-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18653:
Labels: pull-request-available (was: )
> LogLevel servlet to determine log impl before u
virajjasani opened a new pull request, #5456:
URL: https://github.com/apache/hadoop/pull/5456
LogLevel GET API is used to set log level for a given class name
dynamically. While we have cleaned up the commons-logging references, it would
be great to determine whether slf4j log4j adapter is
Viraj Jasani created HADOOP-18653:
-
Summary: LogLevel servlet to determine log impl before using
setLevel
Key: HADOOP-18653
URL: https://issues.apache.org/jira/browse/HADOOP-18653
Project: Hadoop Comm
[
https://issues.apache.org/jira/browse/HADOOP-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696699#comment-17696699
]
ASF GitHub Bot commented on HADOOP-18640:
-
saxenapranav commented on code in PR
saxenapranav commented on code in PR #5446:
URL: https://github.com/apache/hadoop/pull/5446#discussion_r1125941455
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##
@@ -50,6 +50,14 @@ public final class FileSyste
krishan1390 commented on PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#issuecomment-1455462818
@slfan1989 @goiri let me try to summarise my changes better
1. I am refactoring router secret manager to a completely stateless setup
which now provides read after write consiste
krishan1390 commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1125881513
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##
@@ -102,26 +102,26 @@
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696684#comment-17696684
]
ASF GitHub Bot commented on HADOOP-18631:
-
hadoop-yetus commented on PR #5451:
hadoop-yetus commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455400811
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696679#comment-17696679
]
ASF GitHub Bot commented on HADOOP-18631:
-
hadoop-yetus commented on PR #5451:
hadoop-yetus commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455398684
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696676#comment-17696676
]
ASF GitHub Bot commented on HADOOP-18631:
-
hadoop-yetus commented on PR #5451:
hadoop-yetus commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455396011
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696670#comment-17696670
]
ASF GitHub Bot commented on HADOOP-18629:
-
zhuyaogai commented on code in PR #5
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125847429
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:
##
@@ -223,9 +233,25 @@ private long copyToFile(Path targetPa
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696669#comment-17696669
]
ASF GitHub Bot commented on HADOOP-18629:
-
zhuyaogai commented on code in PR #5
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125843372
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:
##
@@ -223,9 +233,25 @@ private long copyToFile(Path targetPa
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696664#comment-17696664
]
ASF GitHub Bot commented on HADOOP-18631:
-
hadoop-yetus commented on PR #5451:
hadoop-yetus commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455377317
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Hexiaoqiao commented on code in PR #5450:
URL: https://github.com/apache/hadoop/pull/5450#discussion_r1125839750
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/LowRedundancyBlocks.java:
##
@@ -369,7 +369,7 @@ synchronized boolean r
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696662#comment-17696662
]
ASF GitHub Bot commented on HADOOP-18629:
-
zhuyaogai commented on code in PR #5
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125837868
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java:
##
@@ -239,6 +239,21 @@ public static DistCpOptions parse(String[] args)
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696661#comment-17696661
]
ASF GitHub Bot commented on HADOOP-18629:
-
zhuyaogai commented on code in PR #5
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125837868
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java:
##
@@ -239,6 +239,21 @@ public static DistCpOptions parse(String[] args)
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696659#comment-17696659
]
ASF GitHub Bot commented on HADOOP-18629:
-
zhuyaogai commented on code in PR #5
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125831678
##
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:
##
@@ -247,6 +276,22 @@ private long copyToFile(Path targetPa
zhangshuyan0 commented on code in PR #5450:
URL: https://github.com/apache/hadoop/pull/5450#discussion_r1125809336
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/LowRedundancyBlocks.java:
##
@@ -369,7 +369,7 @@ synchronized boolean
[
https://issues.apache.org/jira/browse/HADOOP-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696651#comment-17696651
]
Xiaoqiao He commented on HADOOP-18644:
--
Thanks. Add [~zhaixiaojuan] to contributor
[
https://issues.apache.org/jira/browse/HADOOP-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoqiao He reassigned HADOOP-18644:
Assignee: zhaixiaojuan
> Add bswap support for LoongArch
> -
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696633#comment-17696633
]
ASF GitHub Bot commented on HADOOP-18631:
-
hadoop-yetus commented on PR #5451:
hadoop-yetus commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455233400
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696631#comment-17696631
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455218825
On the other hand, using unique location requires the kind of hacks with
log4j APIs that are not public and stable, hence we better avoid using them
rather than running into issues acr
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696630#comment-17696630
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455218356
I see, no problem, if you have strong opinion about this, then let me change
that test as well to use capture.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696629#comment-17696629
]
ASF GitHub Bot commented on HADOOP-18631:
-
ayushtkn commented on PR #5451:
URL:
ayushtkn commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455217924
I am ok to keep using the file logic, if we load that props file dynamically
and not write to a common place and to a unique location like previously, else
a test shouldn’t bother the com
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696628#comment-17696628
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455216823
> But should change the other test as well to use this, rather than the file
logic, that if someone copies that for a new test or so, he doesn’t leads us to
a mess
I still feel
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696625#comment-17696625
]
ASF GitHub Bot commented on HADOOP-18631:
-
ayushtkn commented on PR #5451:
URL:
ayushtkn commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455210420
If it doesn’t then we are good. But should change the other test as well to
use this, rather than the file logic, that if someone copies that for a new
test or so, he doesn’t leads us to
hadoop-yetus commented on PR #5455:
URL: https://github.com/apache/hadoop/pull/5455#issuecomment-1455207029
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #5454:
URL: https://github.com/apache/hadoop/pull/5454#issuecomment-1455196102
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696605#comment-17696605
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455168482
I also wrote test like this to verify that it doesn't print anything when
run simultaneously with both TestFsck and TestAuditLogs:
```
@Test
public void t1() throws Exc
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696602#comment-17696602
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455158738
For that to happen, all tests (the entire test class I mean) should also use
stop capturing of appender (which internally removes the appender). I just did
that in recent commit to set
varunsaxena closed pull request #5171: YARN-11383. Workflow priority mappings
is case sensitive
URL: https://github.com/apache/hadoop/pull/5171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
varunsaxena commented on PR #5171:
URL: https://github.com/apache/hadoop/pull/5171#issuecomment-1455156530
LGTM. Committed to trunk and branch-3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696596#comment-17696596
]
ASF GitHub Bot commented on HADOOP-18629:
-
hadoop-yetus commented on PR #5391:
hadoop-yetus commented on PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#issuecomment-1455156173
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
szilard-nemeth opened a new pull request, #5455:
URL: https://github.com/apache/hadoop/pull/5455
…onfigurationFields
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIR
szilard-nemeth opened a new pull request, #5454:
URL: https://github.com/apache/hadoop/pull/5454
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. '
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696551#comment-17696551
]
ASF GitHub Bot commented on HADOOP-18631:
-
ayushtkn commented on PR #5451:
URL:
ayushtkn commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455040719
Interfere means: it would only capture audit log pushed by that class and
won’t capture anything from other classes being run in parallel, doing the same
appender thing or the file thing?
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696540#comment-17696540
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455029246
> And one more to try if I delete the file while using appender, will the
test using appender fail?
The test using it's own appender (i.e. new LogCapturer instance) would not
fa
[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696538#comment-17696538
]
ASF GitHub Bot commented on HADOOP-18631:
-
virajjasani commented on PR #5451:
U
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455025728
> Do you mean to say we are reading via different mechanisms but reading
from the same place?
Basically they will read from their own WriterAppender so there is no sync
issue wh
76 matches
Mail list logo
