hadoop-yetus commented on PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1512435547
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5551:
URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1512420946
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5551:
URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1512412414
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5551:
URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1512407910
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
smarthanwang opened a new pull request, #5564:
URL: https://github.com/apache/hadoop/pull/5564
### Description of PR
see https://issues.apache.org/jira/browse/HDFS-16985
### How was this patch tested?
no unit tests need
### For code changes:
--
This is
hadoop-yetus commented on PR #5537:
URL: https://github.com/apache/hadoop/pull/5537#issuecomment-1512374432
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713340#comment-17713340
]
ASF GitHub Bot commented on HADOOP-18671:
-
taklwu commented on code in PR #5553:
URL:
taklwu commented on code in PR #5553:
URL: https://github.com/apache/hadoop/pull/5553#discussion_r1169365930
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemContract.java:
##
@@ -137,4 +142,30 @@ public void testRenameNonExistentPath() throws
[
https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713335#comment-17713335
]
ASF GitHub Bot commented on HADOOP-18691:
-
hadoop-yetus commented on PR #5540:
URL:
hadoop-yetus commented on PR #5540:
URL: https://github.com/apache/hadoop/pull/5540#issuecomment-1512306901
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5556:
URL: https://github.com/apache/hadoop/pull/5556#issuecomment-1512298008
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713266#comment-17713266
]
ASF GitHub Bot commented on HADOOP-18706:
-
cbevard1 opened a new pull request, #5563:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18706:
Labels: pull-request-available (was: )
> The temporary files for disk-block buffer
cbevard1 opened a new pull request, #5563:
URL: https://github.com/apache/hadoop/pull/5563
### Description of PR
This PR improves the ability to recovery partial S3A uploads.
1. Changed the handleSyncableInvocation() to call flush() after warning that
the syncable API
[
https://issues.apache.org/jira/browse/HADOOP-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bevard resolved HADOOP-18149.
---
Resolution: Invalid
> The FSDownload verifyAndCopy method doesn't support S3
>
hadoop-yetus commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1511935124
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Chris Bevard created HADOOP-18706:
-
Summary: The temporary files for disk-block buffer aren't unique
enough to recover partial uploads.
Key: HADOOP-18706
URL: https://issues.apache.org/jira/browse/HADOOP-18706
rdingankar commented on code in PR #5556:
URL: https://github.com/apache/hadoop/pull/5556#discussion_r1169036218
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java:
##
@@ -52,6 +52,8 @@ public class TestMutableMetrics {
goiri commented on code in PR #5556:
URL: https://github.com/apache/hadoop/pull/5556#discussion_r1169028613
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java:
##
@@ -52,6 +52,8 @@ public class TestMutableMetrics {
[
https://issues.apache.org/jira/browse/HADOOP-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713194#comment-17713194
]
Viraj Jasani commented on HADOOP-18704:
---
FYI [~bbeaudreault]
> Support a "permissive" mode for
hadoop-yetus commented on PR #5562:
URL: https://github.com/apache/hadoop/pull/5562#issuecomment-1511702885
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
rdingankar commented on PR #5556:
URL: https://github.com/apache/hadoop/pull/5556#issuecomment-1511698162
@goiri fixed the checkstyle warnings. Can you please take a look at the PR
and help merge if it looks good. Thanks!
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713186#comment-17713186
]
Viraj Jasani edited comment on HADOOP-18688 at 4/17/23 4:20 PM:
For
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713186#comment-17713186
]
Viraj Jasani commented on HADOOP-18688:
---
For instance, in addition to
szetszwo commented on PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1511669706
> Are we planning to address here? [#5532
(comment)](https://github.com/apache/hadoop/pull/5532#issuecomment-1499923239)
Probably not. I found a potential fix shown below -- it
[
https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713180#comment-17713180
]
ASF GitHub Bot commented on HADOOP-18399:
-
virajjasani commented on code in PR #5054:
URL:
virajjasani commented on code in PR #5054:
URL: https://github.com/apache/hadoop/pull/5054#discussion_r1168961829
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/impl/prefetch/TestBlockCache.java:
##
@@ -67,7 +72,7 @@ public void testPutAndGet() throws
szetszwo commented on code in PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#discussion_r1168961332
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeReference.java:
##
@@ -35,32 +35,45 @@
import
[
https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713173#comment-17713173
]
ASF GitHub Bot commented on HADOOP-18399:
-
virajjasani commented on PR #5054:
URL:
virajjasani commented on PR #5054:
URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1511638514
Re-run against us-west-2:
```
$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch
$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8
[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713157#comment-17713157
]
ASF GitHub Bot commented on HADOOP-18565:
-
ahmarsuhail commented on PR #5421:
URL:
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1511606609
I added
```
```
to hadoop-tools/hadoop-aws/dev-support/findbugs-exclude.xml, but that hasn't
suppressed the spotbug for some reason.
umamaheswararao commented on code in PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#discussion_r1168909843
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeReference.java:
##
@@ -35,32 +35,45 @@
import
umamaheswararao commented on PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1511590848
Are we planning to address here?
https://github.com/apache/hadoop/pull/5532#issuecomment-1499923239
--
This is an automated message from the Apache Git Service.
To respond to
brumi1024 commented on code in PR #5562:
URL: https://github.com/apache/hadoop/pull/5562#discussion_r1168885162
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/AbstractFSNodeStore.java:
##
@@ -65,8 +65,30 @@ protected
brumi1024 commented on code in PR #5562:
URL: https://github.com/apache/hadoop/pull/5562#discussion_r1168885162
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/AbstractFSNodeStore.java:
##
@@ -65,8 +65,30 @@ protected
[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713134#comment-17713134
]
ASF GitHub Bot commented on HADOOP-18565:
-
hadoop-yetus commented on PR #5421:
URL:
hadoop-yetus commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1511537779
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ashutoshcipher opened a new pull request, #5562:
URL: https://github.com/apache/hadoop/pull/5562
### Description of PR
Node Labels root directory creation doesn't have a retry logic
JIRA - YARN-11463
### For code changes:
- [X] Does the title or this PR starts
[
https://issues.apache.org/jira/browse/HADOOP-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713111#comment-17713111
]
ASF GitHub Bot commented on HADOOP-18705:
-
hadoop-yetus commented on PR #5560:
URL:
hadoop-yetus commented on PR #5560:
URL: https://github.com/apache/hadoop/pull/5560#issuecomment-1511439932
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
lfxy opened a new pull request, #5561:
URL: https://github.com/apache/hadoop/pull/5561
In concat RPC, it will call FSDirConcatOp::verifySrcFiles() to check the
source files. In this function, it would make permission check for srcs.
Whether do the permission check should be decided by
[
https://issues.apache.org/jira/browse/HADOOP-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Domok reassigned HADOOP-18705:
Assignee: Tamas Domok
> hadoop-azure: AzureBlobFileSystem should exclude incompatible
ayushtkn commented on PR #5547:
URL: https://github.com/apache/hadoop/pull/5547#issuecomment-1511269735
> Some pathnames which contains special character(s) may lead to unexpected
results. For example, there is a file named "/foo/file*" in my cluster, created
by
[
https://issues.apache.org/jira/browse/HADOOP-18028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713065#comment-17713065
]
ASF GitHub Bot commented on HADOOP-18028:
-
ahmarsuhail commented on PR #5559:
URL:
ahmarsuhail commented on PR #5559:
URL: https://github.com/apache/hadoop/pull/5559#issuecomment-1511252967
looks good so far, not sure if this helpful, but patches that came after
this big commit are (listed in order they were committed to trunk):
- ITestS3ACannedACLs failure; not
[
https://issues.apache.org/jira/browse/HADOOP-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713063#comment-17713063
]
ASF GitHub Bot commented on HADOOP-18705:
-
tomicooler opened a new pull request, #5560:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18705:
Labels: pull-request-available (was: )
> hadoop-azure: AzureBlobFileSystem should
tomicooler opened a new pull request, #5560:
URL: https://github.com/apache/hadoop/pull/5560
…atible credential providers when binding DelegationTokenManagers
Change-Id: I1ad8b5856a0b8c0b75d4538019d43e7fdb1962d2
### Description of PR
### How was this patch
Tamas Domok created HADOOP-18705:
Summary: hadoop-azure: AzureBlobFileSystem should exclude
incompatible credential providers when binding DelegationTokenManagers
Key: HADOOP-18705
URL:
slfan1989 commented on PR #5431:
URL: https://github.com/apache/hadoop/pull/5431#issuecomment-1511186191
@ayushtkn Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713035#comment-17713035
]
ASF GitHub Bot commented on HADOOP-18695:
-
hadoop-yetus commented on PR #5548:
URL:
hadoop-yetus commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1511162947
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1168511215
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/TestFileOutputCommitter.java:
steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1168507366
##
[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713018#comment-17713018
]
ASF GitHub Bot commented on HADOOP-18565:
-
ahmarsuhail commented on PR #5421:
URL:
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1511108657
thanks @steveloughran, `s3AsyncClient` looks safe to me, have suppressed the
warning. Like you mentioned, Similar to the `futurePool`, it's created in the
unsynchronized initialize()
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18696:
Affects Version/s: 3.3.9
> S3A ITestS3ABucketExistence access point test failure
>
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18696.
-
Fix Version/s: 3.3.9
Resolution: Fixed
> S3A ITestS3ABucketExistence access
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reassigned HADOOP-18696:
---
Assignee: Steve Loughran
> S3A ITestS3ABucketExistence access point test failure
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18696:
Component/s: test
> S3A ITestS3ABucketExistence access point test failure
>
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712979#comment-17712979
]
ASF GitHub Bot commented on HADOOP-18696:
-
steveloughran merged PR #5557:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712978#comment-17712978
]
ASF GitHub Bot commented on HADOOP-18696:
-
steveloughran commented on code in PR #5557:
URL:
steveloughran merged PR #5557:
URL: https://github.com/apache/hadoop/pull/5557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
steveloughran commented on code in PR #5557:
URL: https://github.com/apache/hadoop/pull/5557#discussion_r1168410522
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABucketExistence.java:
##
@@ -189,6 +190,17 @@ public void testAccessPointRequired()
[
https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712952#comment-17712952
]
ASF GitHub Bot commented on HADOOP-18399:
-
hadoop-yetus commented on PR #5054:
URL:
hadoop-yetus commented on PR #5054:
URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1510923937
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
YuanbenWang commented on PR #5547:
URL: https://github.com/apache/hadoop/pull/5547#issuecomment-1510845148
@ayushtkn @Hexiaoqiao Could you please help me to review this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
68 matches
Mail list logo
