[GitHub] [hadoop] slfan1989 commented on pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
slfan1989 commented on PR #5589: URL: https://github.com/apache/hadoop/pull/5589#issuecomment-1522823272 @goiri Thank you very much for helping to review the code! There are some checkstyle issues, I will submit [hotfix] pr. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] slfan1989 commented on pull request #5551: YARN-11378. [Federation] Support checkForDecommissioningNodes、refreshClusterMaxPriority API's for Federation.

2023-04-25 Thread via GitHub
slfan1989 commented on PR #5551: URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1522821906 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun updated HADOOP-18718: --- Description: {code} [WARNING] 'build.plugins.plugin.version' for

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716522#comment-17716522 ] Dongjoon Hyun commented on HADOOP-18590: I created HADOOP-18718 and made a PR to fix several

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716520#comment-17716520 ] ASF GitHub Bot commented on HADOOP-18718: - dongjoon-hyun opened a new pull request, #5592: URL:

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18718: Labels: pull-request-available (was: ) > Fix several maven build warnings >

[GitHub] [hadoop] dongjoon-hyun opened a new pull request, #5592: HADOOP-18718: Fix several maven build warnings

2023-04-25 Thread via GitHub
dongjoon-hyun opened a new pull request, #5592: URL: https://github.com/apache/hadoop/pull/5592 ### Description of PR This PR aims to fix the following build warnings which are a subset of the full warnings on Maven 3.9.1. ``` ``` [WARNING] 'build.plugins.plugin.version' for

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun updated HADOOP-18718: --- Description: {code} [WARNING] 'build.plugins.plugin.version' for

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun updated HADOOP-18718: --- Description: {code} [WARNING] 'build.plugins.plugin.version' for

[GitHub] [hadoop] hadoop-yetus commented on pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5363: URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1522728568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] yl09099 commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-25 Thread via GitHub
yl09099 commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1522726421 @slfan1989 The javac is not caused by this pull request. Could you please review the code again? Thank you very much! -- This is an automated message from the Apache Git Service. To

[jira] [Created] (HADOOP-18718) Fix several maven build warnings

2023-04-25 Thread Dongjoon Hyun (Jira)
Dongjoon Hyun created HADOOP-18718: -- Summary: Fix several maven build warnings Key: HADOOP-18718 URL: https://issues.apache.org/jira/browse/HADOOP-18718 Project: Hadoop Common Issue Type:

[GitHub] [hadoop] cxzl25 commented on pull request #5565: YARN-11467. RM failover may fail when the nodes.exclude-path file does not exist

2023-04-25 Thread via GitHub
cxzl25 commented on PR #5565: URL: https://github.com/apache/hadoop/pull/5565#issuecomment-1522720828 This is an corner case, which will cause RM failover to fail. Please help review it. Thanks. @ayushtkn @zhuqi-lucas @TaoYang526 -- This is an automated message from the Apache

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5564: HDFS-16985. delete local block file when FileNotFoundException occurred may lead to missing block.

2023-04-25 Thread via GitHub
Hexiaoqiao commented on code in PR #5564: URL: https://github.com/apache/hadoop/pull/5564#discussion_r1177275219 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java: ## @@ -116,10 +103,7 @@ import static

[GitHub] [hadoop] smarthanwang commented on pull request #5564: HDFS-16985. delete local block file when FileNotFoundException occurred may lead to missing block.

2023-04-25 Thread via GitHub
smarthanwang commented on PR #5564: URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1522670726 @Hexiaoqiao the failed UT seems not related to this PR,please help check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716482#comment-17716482 ] Dongjoon Hyun commented on HADOOP-18590: Sure, [~ayushtkn] > Publish SBOM artifacts >

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5329: HDFS-16897. fix abundant Broken pipe exception in BlockSender

2023-04-25 Thread via GitHub
ayushtkn commented on code in PR #5329: URL: https://github.com/apache/hadoop/pull/5329#discussion_r1177148000 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java: ## @@ -655,8 +655,11 @@ private int sendPacket(ByteBuffer

[GitHub] [hadoop] ayushtkn commented on pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-04-25 Thread via GitHub
ayushtkn commented on PR #5200: URL: https://github.com/apache/hadoop/pull/5200#issuecomment-1522480957 Flaky. Ran it locally for this PR, passes locally ``` [INFO] --- [INFO] T E S T S [INFO]

[GitHub] [hadoop] goiri commented on pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-04-25 Thread via GitHub
goiri commented on PR #5200: URL: https://github.com/apache/hadoop/pull/5200#issuecomment-1522464883 Is the failed unit test flaky or real? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] goiri commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-25 Thread via GitHub
goiri commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1522425467 Let's get a clean build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] goiri merged pull request #5551: YARN-11378. [Federation] Support checkForDecommissioningNodes、refreshClusterMaxPriority API's for Federation.

2023-04-25 Thread via GitHub
goiri merged PR #5551: URL: https://github.com/apache/hadoop/pull/5551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri merged pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
goiri merged PR #5589: URL: https://github.com/apache/hadoop/pull/5589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716443#comment-17716443 ] Ayush Saxena commented on HADOOP-18590: --- Thanx Steve for pointing that out. It prints in the very

[GitHub] [hadoop] ayushtkn merged pull request #4598: HDFS-16672. Fix lease interval comparison in BlockReportLeaseManager

2023-04-25 Thread via GitHub
ayushtkn merged PR #4598: URL: https://github.com/apache/hadoop/pull/4598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4598: HDFS-16672. Fix lease interval comparison in BlockReportLeaseManager

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #4598: URL: https://github.com/apache/hadoop/pull/4598#issuecomment-1522315699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5591: HDFS-16991. fix testMkdirsRaceWithObserverRead

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5591: URL: https://github.com/apache/hadoop/pull/5591#issuecomment-1522292169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18660: Fix Version/s: 3.3.9 > Filesystem Spelling Mistake > --- > >

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716398#comment-17716398 ] ASF GitHub Bot commented on HADOOP-18660: - steveloughran commented on PR #5475: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-25 Thread via GitHub
steveloughran commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1522278453 ok, merged to branch-3.3 too. looks suspiciously like most of the errors are mine, which is less spelling than typo. never mind. At least the only classname errors in were in test

[GitHub] [hadoop] steveloughran merged pull request #5579: MAPREDUCE-7437. spotbugs complains about MR Fetcher class.

2023-04-25 Thread via GitHub
steveloughran merged PR #5579: URL: https://github.com/apache/hadoop/pull/5579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5363: URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1522261156 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on pull request #5579: MAPREDUCE-7437. spotbugs complains about MR Fetcher class.

2023-04-25 Thread via GitHub
steveloughran commented on PR #5579: URL: https://github.com/apache/hadoop/pull/5579#issuecomment-1522260929 merging, spotbugs now happy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5579: MAPREDUCE-7437. spotbugs complains about MR Fetcher class.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5579: URL: https://github.com/apache/hadoop/pull/5579#issuecomment-1522196594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5532: HDFS-16972. Delete a snapshot may deleteCurrentFile.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5532: URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1522154309 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18717) Move CodecPool getCompressor/getDecompressor logs to DEBUG

2023-04-25 Thread Claire McGinty (Jira)
Claire McGinty created HADOOP-18717: --- Summary: Move CodecPool getCompressor/getDecompressor logs to DEBUG Key: HADOOP-18717 URL: https://issues.apache.org/jira/browse/HADOOP-18717 Project: Hadoop

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-25 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716355#comment-17716355 ] Dongjoon Hyun commented on HADOOP-18590: Thank you for reporting. It seems that I missed

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5591: HDFS-16991. fix testMkdirsRaceWithObserverRead

2023-04-25 Thread via GitHub
ayushtkn commented on code in PR #5591: URL: https://github.com/apache/hadoop/pull/5591#discussion_r1176752550 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java: ## @@ -583,7 +583,6 @@ public void

[jira] [Resolved] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18660. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Filesystem

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716350#comment-17716350 ] ASF GitHub Bot commented on HADOOP-18660: - ayushtkn merged PR #5475: URL:

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716351#comment-17716351 ] Ayush Saxena commented on HADOOP-18660: --- Committed to trunk. Thanx [~baunsgaard] for the

[GitHub] [hadoop] ayushtkn merged pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-25 Thread via GitHub
ayushtkn merged PR #5475: URL: https://github.com/apache/hadoop/pull/5475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (HADOOP-18660) Filesystem Spelling Mistake

2023-04-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18660: - Assignee: Sebastian Baunsgaard > Filesystem Spelling Mistake >

[jira] [Updated] (HADOOP-18273) Understand status of S3 access point alias support in S3A

2023-04-25 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18273: --- Summary: Understand status of S3 access point alias support in S3A (was: Support

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716346#comment-17716346 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn commented on PR #5586: URL:

[jira] [Updated] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18689: -- Fix Version/s: 3.3.9 > Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project >

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716345#comment-17716345 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn merged PR #5586: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5585: Hadoop 18712. upgrade to jetty 9.4.51 due to cve

2023-04-25 Thread via GitHub
ayushtkn commented on PR #5585: URL: https://github.com/apache/hadoop/pull/5585#issuecomment-1522044028 It isn't letting me access the test results, something broken for this run, neither it is letting me retrigger, @pjfanning can you rebase and push once? -- This is an automated message

[GitHub] [hadoop] ayushtkn merged pull request #5586: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread via GitHub
ayushtkn merged PR #5586: URL: https://github.com/apache/hadoop/pull/5586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ayushtkn commented on pull request #5586: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread via GitHub
ayushtkn commented on PR #5586: URL: https://github.com/apache/hadoop/pull/5586#issuecomment-1522042979 Thanx @simbadzina for the review!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] ayushtkn commented on pull request #5586: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread via GitHub
ayushtkn commented on PR #5586: URL: https://github.com/apache/hadoop/pull/5586#issuecomment-1522042340 TestAMSimulator passed locally, TestSLSRunner is failing without patch as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716344#comment-17716344 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn commented on PR #5586: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-25 Thread via GitHub
virajjasani commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1522040773 Is it good to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] ayushtkn commented on pull request #5583: HDFS-16987. [BugFix] NameNode should remove all invalid corrupt blocks when starting active service

2023-04-25 Thread via GitHub
ayushtkn commented on PR #5583: URL: https://github.com/apache/hadoop/pull/5583#issuecomment-1522037750 I think yes, we should fix the ``markBlockAsCorrupt`` method itself while maintaining the regular flow. If a newer block exists on the same storage, We should pass a flag to both

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716336#comment-17716336 ] ASF GitHub Bot commented on HADOOP-18695: - hadoop-yetus commented on PR #5548: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1522034504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5589: URL: https://github.com/apache/hadoop/pull/5589#issuecomment-1521992179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5589: URL: https://github.com/apache/hadoop/pull/5589#issuecomment-1521962121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5564: HDFS-16985. delete local block file when FileNotFoundException occurred may lead to missing block.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5564: URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1521933262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5551: YARN-11378. [Federation] Support checkForDecommissioningNodes、refreshClusterMaxPriority API's for Federation.

2023-04-25 Thread via GitHub
slfan1989 commented on PR #5551: URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1521930730 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up on YARN-11379. -- This is an automated message from the Apache Git

[GitHub] [hadoop] slfan1989 commented on pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
slfan1989 commented on PR #5589: URL: https://github.com/apache/hadoop/pull/5589#issuecomment-1521925773 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-17450) hadoop-common to add IOStatistics API

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716284#comment-17716284 ] ASF GitHub Bot commented on HADOOP-17450: - steveloughran merged PR #5590: URL:

[GitHub] [hadoop] steveloughran merged pull request #5590: HADOOP-17450. Add Public IOStatistics API -SemaphoredDelegatingExecutor changes

2023-04-25 Thread via GitHub
steveloughran merged PR #5590: URL: https://github.com/apache/hadoop/pull/5590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716283#comment-17716283 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1521844215 updated; tested s3 london -Dscale; failure of ` testRandomReadLargeFile(org.apache.hadoop.fs.s3a.ITestS3APrefetchingInputStream)` again; unrelated -- This is an automated message

[GitHub] [hadoop] fanluoo opened a new pull request, #5591: HDFS-16991. fix testMkdirsRaceWithObserverRead

2023-04-25 Thread via GitHub
fanluoo opened a new pull request, #5591: URL: https://github.com/apache/hadoop/pull/5591 ### Description of PR see https://issues.apache.org/jira/browse/HDFS-16991 ### How was this patch tested? no unit tests need ### For code changes: - [ ] Does the title or

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716258#comment-17716258 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176472714 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/statistics/impl/S3AMultipartUploaderStatisticsImpl.java: ## @@ -75,6 +76,7 @@ public

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716256#comment-17716256 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716257#comment-17716257 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176471948 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/statistics/impl/S3AMultipartUploaderStatisticsImpl.java: ## @@ -75,6 +76,7 @@ public

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176471072 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AHugeFilesNoMultipart.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716251#comment-17716251 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176462742 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java: ## @@ -257,11 +309,28 @@ public void

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716248#comment-17716248 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176447421 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java: ## @@ -257,11 +309,28 @@ public void

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716247#comment-17716247 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176446030 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AHugeFilesNoMultipart.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-17450) hadoop-common to add IOStatistics API

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716242#comment-17716242 ] ASF GitHub Bot commented on HADOOP-17450: - hadoop-yetus commented on PR #5590: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5590: HADOOP-17450. Add Public IOStatistics API -SemaphoredDelegatingExecutor changes

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5590: URL: https://github.com/apache/hadoop/pull/5590#issuecomment-1521694008 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5589: YARN-11437. [Federation] SQLFederationStateStore Support Version.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5589: URL: https://github.com/apache/hadoop/pull/5589#issuecomment-1521686372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716211#comment-17716211 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-25 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176328084 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditIntegration.java: ## @@ -142,4 +144,20 @@ public static void attachSpanToRequest(

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716200#comment-17716200 ] Steve Loughran commented on HADOOP-18590: - seeing some warnings about versions on a branch-3.3

[jira] [Commented] (HADOOP-18703) Backport S3A prefetching stream to branch-3.3

2023-04-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716197#comment-17716197 ] Steve Loughran commented on HADOOP-18703: - needs https://github.com/apache/hadoop/pull/5590 in,

[jira] [Commented] (HADOOP-17450) hadoop-common to add IOStatistics API

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716195#comment-17716195 ] ASF GitHub Bot commented on HADOOP-17450: - steveloughran opened a new pull request, #5590: URL:

[GitHub] [hadoop] steveloughran opened a new pull request, #5590: HADOOP-17450. Add Public IOStatistics API -SemaphoredDelegatingExecutor changes

2023-04-25 Thread via GitHub
steveloughran opened a new pull request, #5590: URL: https://github.com/apache/hadoop/pull/5590 This cherrypicks SemaphoredDelegatingExecutor changes from the trunk commit; somehow it didn't get into the backport to branch-3.3. Adds a constructor which takes a duration tracker,

[GitHub] [hadoop] hadoop-yetus commented on pull request #5431: YARN-11444. Improve YARN md documentation format.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5431: URL: https://github.com/apache/hadoop/pull/5431#issuecomment-1521473378 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716180#comment-17716180 ] ASF GitHub Bot commented on HADOOP-18689: - hadoop-yetus commented on PR #5586: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5586: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5586: URL: https://github.com/apache/hadoop/pull/5586#issuecomment-1521430782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5431: YARN-11444. Improve YARN md documentation format.

2023-04-25 Thread via GitHub
slfan1989 commented on PR #5431: URL: https://github.com/apache/hadoop/pull/5431#issuecomment-1521412468 This pr mainly modifies the format of the table in markdown, so as to better modify the content of the table in md later. - Take CapacityScheduler.md as an example

[GitHub] [hadoop] hadoop-yetus commented on pull request #5564: HDFS-16985. delete local block file when FileNotFoundException occurred may lead to missing block.

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5564: URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1521376057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4598: HDFS-16672. Fix lease interval comparison in BlockReportLeaseManager

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #4598: URL: https://github.com/apache/hadoop/pull/4598#issuecomment-1521365135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

2023-04-25 Thread via GitHub
mehakmeet commented on code in PR #5519: URL: https://github.com/apache/hadoop/pull/5519#discussion_r1176161440 ##

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

2023-04-25 Thread via GitHub
mehakmeet commented on code in PR #5519: URL: https://github.com/apache/hadoop/pull/5519#discussion_r1176027704 ##

[GitHub] [hadoop] zhtttylz commented on pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

2023-04-25 Thread via GitHub
zhtttylz commented on PR #5572: URL: https://github.com/apache/hadoop/pull/5572#issuecomment-1521307544 @ayushtkn @simbadzina Thank you for your assistance in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5577: YARN-11474.The yarn queue list is displayed on the CLI

2023-04-25 Thread via GitHub
hadoop-yetus commented on PR #5577: URL: https://github.com/apache/hadoop/pull/5577#issuecomment-1521261184 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |