steveloughran commented on code in PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176447421
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java:
##########
@@ -257,11 +309,28 @@ public void test_010_CreateHugeFile() throws IOException {
verifyStatisticGaugeValue(iostats, putRequestsActive.getSymbol(), 0);
verifyStatisticGaugeValue(iostats,
STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING.getSymbol(), 0);
+
progress.verifyNoFailures(
"Put file " + fileToCreate + " of size " + filesize);
- if (streamStatistics != null) {
- assertEquals("actively allocated blocks in " + streamStatistics,
- 0, streamStatistics.getBlocksActivelyAllocated());
+ assertEquals("actively allocated blocks in " + streamStatistics,
+ 0, streamStatistics.getBlocksActivelyAllocated());
+
+ if (!expectImmediateFileVisibility()) {
Review Comment:
I will add an override point; will need to pass in stream stats, path and
bytes read +anything else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
