hadoop-yetus commented on PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#issuecomment-1545090106
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545058013
> [HDFS-15086](https://issues.apache.org/jira/browse/HDFS-15086) changed
storedBlock to blockInfo without any specific reason.
>
> > (1) It does not stop
LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545057769
GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
1);
// The pending queue should be empty.
assertEquals("Size of
zhtttylz commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1545039162
@ayushtkn Thank you very much for your valuable suggestion. We will create a
ticket to add this feature to HTTPFs!
--
This is an automated message from the Apache Git Service.
To
zhtttylz commented on PR #5602:
URL: https://github.com/apache/hadoop/pull/5602#issuecomment-1545026505
@ayushtkn @slfan1989 Thank you for your assistance in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slfan1989 commented on code in PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#discussion_r1191852103
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java:
##
@@
slfan1989 commented on code in PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#discussion_r1191851956
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServiceUtil.java:
zhtttylz commented on code in PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#discussion_r1191851916
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##
@@ -2255,6 +2256,40 @@ public void testFileLinkStatus() throws
slfan1989 commented on PR #5625:
URL: https://github.com/apache/hadoop/pull/5625#issuecomment-1545019378
> The PR itself looks good. How are we going to manage the rebase of the
other branch after merging this?
@goiri Thank you very much for reviewing the code! The YARN-7402 branch
YuanbenWang commented on PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#issuecomment-1545017444
Thank you for the ticket and merging. Looking forward to meeting you in the
next PR. @ayushtkn
--
This is an automated message from the Apache Git Service.
To respond to
LiuGuH commented on PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1545015145
> The new code looks good to me.
>
> @LiuGuH for future changes, please keep the commit history so people can
see the changes between reviews.
> The new code looks
virajjasani commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191846344
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java:
##
@@ -670,6 +670,9 @@ public RouterServiceState
slfan1989 commented on code in PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#discussion_r1191845826
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##
@@ -2255,6 +2256,40 @@ public void testFileLinkStatus() throws
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1545008902
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1545004586
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721950#comment-17721950
]
ASF GitHub Bot commented on HADOOP-18709:
-
szilard-nemeth commented on PR #5638:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721948#comment-17721948
]
ASF GitHub Bot commented on HADOOP-18709:
-
szilard-nemeth commented on code in PR #5638:
URL:
szilard-nemeth commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1544898512
Thanks for the patch @ferdelyi, good job.
Added some comments / questions.
Could you please add testing evidence to the Jira?
To document how this was tested on a real
goiri commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191783244
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##
@@ -484,14 +486,14 @@ private RetryDecision
szilard-nemeth commented on code in PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#discussion_r1191770472
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java:
##
@@ -157,12 +175,44 @@ public void start(List
[
https://issues.apache.org/jira/browse/HADOOP-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena updated HADOOP-18603:
--
Description:
Steps to reproduce this issue:
Enable ldap auth with tls by configuring these
szilard-nemeth commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1544801015
Thanks @tomicooler for working on this.
Given the detailed description, I can understand the context easily.
Patch LGTM, committed to trunk
--
This is an automated message
ayushtkn merged PR #5520:
URL: https://github.com/apache/hadoop/pull/5520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
simbadzina commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191736478
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java:
##
@@ -670,6 +670,9 @@ public RouterServiceState
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721927#comment-17721927
]
Viraj Jasani commented on HADOOP-18291:
---
created HADOOP-18740 for cache file access to go through
Viraj Jasani created HADOOP-18740:
-
Summary: s3a prefetch cache blocks should be accessed by RW locks
Key: HADOOP-18740
URL: https://issues.apache.org/jira/browse/HADOOP-18740
Project: Hadoop Common
virajjasani opened a new pull request, #5648:
URL: https://github.com/apache/hadoop/pull/5648
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sodonnel commented on PR #5643:
URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1544680459
If I understand correctly, for a replicated block, if there are two corrupt
block the code in InvalidateCorruptReplicas will be called when the block has
been replicated correctly. At
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721918#comment-17721918
]
ASF GitHub Bot commented on HADOOP-18724:
-
hadoop-yetus commented on PR #5647:
URL:
hadoop-yetus commented on PR #5647:
URL: https://github.com/apache/hadoop/pull/5647#issuecomment-1544675058
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#discussion_r1191576231
##
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721908#comment-17721908
]
ASF GitHub Bot commented on HADOOP-18688:
-
hadoop-yetus commented on PR #5621:
URL:
hadoop-yetus commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1544646451
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on PR #5625:
URL: https://github.com/apache/hadoop/pull/5625#issuecomment-1544646264
The PR itself looks good.
How are we going to manage the rebase of the other branch after merging this?
--
This is an automated message from the Apache Git Service.
To respond to the
goiri commented on code in PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#discussion_r1191569769
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServiceUtil.java:
##
@@
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721862#comment-17721862
]
ASF GitHub Bot commented on HADOOP-18688:
-
virajjasani commented on PR #5621:
URL:
virajjasani commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1544462844
thanks for the review Steve!!
addressed latest review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HADOOP-18291:
-
Assignee: Viraj Jasani
> SingleFilePerBlockCache does not have a limit
>
[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721856#comment-17721856
]
ASF GitHub Bot commented on HADOOP-18695:
-
steveloughran commented on PR #5548:
URL:
steveloughran commented on PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1544402598
when backporting need to move test to optLong as added in #5611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721855#comment-17721855
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran commented on PR #5647:
URL:
steveloughran commented on PR #5647:
URL: https://github.com/apache/hadoop/pull/5647#issuecomment-1544400733
test with -Dparallel-tests -DtestsThreadCount=8 -Dscale
no failures. note, recent changes in trunk and huge file upload didn't
merge, when HADOOP-18695. S3A: reject multipart
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721852#comment-17721852
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran opened a new pull request, #5647:
URL:
steveloughran opened a new pull request, #5647:
URL: https://github.com/apache/hadoop/pull/5647
This:
1. Adds optLong, optDouble, mustLong and mustDouble methods to the FSBuilder
interface to let callers explicitly passin long and double arguments.
2. The opt() and must()
steveloughran merged PR #5611:
URL: https://github.com/apache/hadoop/pull/5611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721849#comment-17721849
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran merged PR #5611:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721846#comment-17721846
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran commented on PR #5611:
URL:
steveloughran commented on PR #5611:
URL: https://github.com/apache/hadoop/pull/5611#issuecomment-1544332942
yarn bower build failed with network issues; 100% unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1544279312
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5646:
URL: https://github.com/apache/hadoop/pull/5646#issuecomment-1544252241
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721822#comment-17721822
]
ASF GitHub Bot commented on HADOOP-18724:
-
hadoop-yetus commented on PR #5611:
URL:
hadoop-yetus commented on PR #5611:
URL: https://github.com/apache/hadoop/pull/5611#issuecomment-1544169434
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
cbevard1 commented on PR #5646:
URL: https://github.com/apache/hadoop/pull/5646#issuecomment-1544129524
Integration tests were run in us-east-2 with the following options,
`-Dparallel-tests -DtestsThreadCount=16 -Dscale`
The unit and integration tests added by this pull request all
hadoop-yetus commented on PR #5643:
URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1544110986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#issuecomment-1544102476
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
cbevard1 opened a new pull request, #5646:
URL: https://github.com/apache/hadoop/pull/5646
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g.
hadoop-yetus commented on PR #5643:
URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1544059352
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1544051417
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1544047480
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #5625:
URL: https://github.com/apache/hadoop/pull/5625#issuecomment-1544044559
@goiri Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Likkey closed pull request #5569: HDFS-16697.Add code to check for
minimumRedundantVolumes.
URL: https://github.com/apache/hadoop/pull/5569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hadoop-yetus commented on PR #5645:
URL: https://github.com/apache/hadoop/pull/5645#issuecomment-1543918969
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721751#comment-17721751
]
ASF GitHub Bot commented on HADOOP-18724:
-
steveloughran commented on PR #5611:
URL:
steveloughran commented on PR #5611:
URL: https://github.com/apache/hadoop/pull/5611#issuecomment-1543896406
ok, pushed up a pr with the fixed imports; if yetus is happy will merge and
then backport
--
This is an automated message from the Apache Git Service.
To respond to the message,
hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1543863109
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
tomicooler commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1191047117
##
YuanbenWang commented on PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#issuecomment-1543813297
@ayushtkn Hello,Would you please help assign the
Jira([HDFS-16965](https://issues.apache.org/jira/browse/HDFS-16965)) ticket to
me? Could you please help review this PR?
--
This
zhtttylz commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1543800176
@ayushtkn @slfan1989 Could you please help review this PR again? The `Junit
Test` error is not caused by our pr.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721735#comment-17721735
]
ASF GitHub Bot commented on HADOOP-18637:
-
steveloughran commented on PR #5641:
URL:
steveloughran commented on PR #5641:
URL: https://github.com/apache/hadoop/pull/5641#issuecomment-1543792390
1. what was missing from the previous cherrypick?
2. what were the full commands passed in to maven?
--
This is an automated message from the Apache Git Service.
To
slfan1989 opened a new pull request, #5645:
URL: https://github.com/apache/hadoop/pull/5645
### Description of PR
JIRA: YARN-8898. Fix FederationInterceptor#allocate to set application
priority in allocateResponse.
### How was this patch tested?
### For code
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721730#comment-17721730
]
ASF GitHub Bot commented on HADOOP-18688:
-
steveloughran commented on code in PR #5621:
URL:
steveloughran commented on code in PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#discussion_r1190995547
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestHttpReferrerAuditHeader.java:
##
@@ -350,6 +335,48 @@ public void
tomicooler commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1190991579
##
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721725#comment-17721725
]
ASF GitHub Bot commented on HADOOP-18688:
-
steveloughran commented on PR #5621:
URL:
steveloughran commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1543775384
thanks, just trying to be extra harsh as github was refusing to do the
"since last review" option as it couldn't find the last-review commit in the
chain.
--
This is an
tomicooler opened a new pull request, #5644:
URL: https://github.com/apache/hadoop/pull/5644
### Description of PR
YARN-11211 broke the JMX QueueMetrics, detailed root cause analysis in the
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721720#comment-17721720
]
ASF GitHub Bot commented on HADOOP-18736:
-
hadoop-yetus commented on PR #5635:
URL:
hadoop-yetus commented on PR #5635:
URL: https://github.com/apache/hadoop/pull/5635#issuecomment-1543753278
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb opened a new pull request, #5643:
URL: https://github.com/apache/hadoop/pull/5643
The description is in HDFS-17003.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1543595966
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
LiuGuH opened a new pull request, #5642:
URL: https://github.com/apache/hadoop/pull/5642
### Description of PR
TestPendingReconstruction.testProcessPendingReconstructions() verify
[HDFS-11960](https://issues.apache.org/jira/browse/HDFS-11960) is wrong.
(1) It does not
hadoop-yetus commented on PR #5640:
URL: https://github.com/apache/hadoop/pull/5640#issuecomment-1543494792
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721660#comment-17721660
]
ASF GitHub Bot commented on HADOOP-18739:
-
hadoop-yetus commented on PR #5640:
URL:
ayushtkn commented on PR #4990:
URL: https://github.com/apache/hadoop/pull/4990#issuecomment-1543449462
@ZanderXu this can be updated the other PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hadoop-yetus commented on PR #5629:
URL: https://github.com/apache/hadoop/pull/5629#issuecomment-1543449446
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
86 matches
Mail list logo
