[GitHub] [hadoop] haiyang1987 commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

haiyang1987 commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1555609612 Update PR. please @ayushtkn @virajjasani help review it again, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5678: HDFS-17022. Fix the exception message to print the Identifier pattern

hadoop-yetus commented on PR #5678: URL: https://github.com/apache/hadoop/pull/5678#issuecomment-155575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhtttylz commented on a diff in pull request #5660: HDFS-17014. HttpFS Add Support getStatus API

zhtttylz commented on code in PR #5660: URL: https://github.com/apache/hadoop/pull/5660#discussion_r1199540321 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java: ## @@ -2081,6 +2085,32 @@ private void

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724475#comment-17724475 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on PR #5638: URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555435928 Hi @ferdelyi , I added a couple of review comments. Could you please also add comments to the test class (e.g. in javadoc) about how the added certificate files, keystore

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724474#comment-17724474 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on PR #5638: URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555433823 > Thank you Szilard for the CR. > > The change was exclusively tested with the unit test, which is a kind of integration test, as a ZK Server was brought up and the

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199527654 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -503,4 +644,50 @@ private void

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724473#comment-17724473 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724469#comment-17724469 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199521345 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -478,10 +558,53 @@ public ZooKeeper

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724468#comment-17724468 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199522108 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/curator/TestSecureZKCuratorManager.java: ## @@ -0,0 +1,157 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724467#comment-17724467 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199521669 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/curator/TestSecureZKCuratorManager.java: ## @@ -0,0 +1,157 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724466#comment-17724466 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199521447 ## hadoop-common-project/hadoop-common/pom.xml: ## @@ -342,6 +342,14 @@ + Review Comment: Cool, thanks :) -- This is an

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724465#comment-17724465 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199521345 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -478,10 +558,53 @@ public ZooKeeper

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724464#comment-17724464 ] ASF GitHub Bot commented on HADOOP-18709: - szilard-nemeth commented on code in PR #5638: URL:

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

szilard-nemeth commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1199521127 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -157,12 +175,44 @@ public void start(List

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5660: HDFS-17014. HttpFS Add Support getStatus API

ayushtkn commented on code in PR #5660: URL: https://github.com/apache/hadoop/pull/5660#discussion_r1199520649 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java: ## @@ -2081,6 +2085,32 @@ private void

[jira] [Updated] (HADOOP-18745) Fix the exception message to print the Identifier pattern

[ https://issues.apache.org/jira/browse/HADOOP-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18745: -- Description: In case of an incorrect string passed as value, it would throw an exception,

[jira] [Commented] (HADOOP-17518) Usage of incorrect regex range A-z

[ https://issues.apache.org/jira/browse/HADOOP-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724459#comment-17724459 ] Ayush Saxena commented on HADOOP-17518: --- Committed to trunk. Thanx [~nishtha11shah] for the

[jira] [Commented] (HADOOP-17518) Usage of incorrect regex range A-z

[ https://issues.apache.org/jira/browse/HADOOP-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724460#comment-17724460 ] ASF subversion and git services commented on HADOOP-17518: -- Commit

[jira] [Updated] (HADOOP-17518) Usage of incorrect regex range A-z

[ https://issues.apache.org/jira/browse/HADOOP-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17518: Labels: pull-request-available (was: ) > Usage of incorrect regex range A-z >

[jira] [Resolved] (HADOOP-17518) Usage of incorrect regex range A-z

[ https://issues.apache.org/jira/browse/HADOOP-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-17518. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Usage of

[jira] [Commented] (HADOOP-17518) Usage of incorrect regex range A-z

[ https://issues.apache.org/jira/browse/HADOOP-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724457#comment-17724457 ] ASF GitHub Bot commented on HADOOP-17518: - ayushtkn merged PR #5669: URL:

[GitHub] [hadoop] ayushtkn merged pull request #5669: HADOOP-17518. Update the regex to A-Z

ayushtkn merged PR #5669: URL: https://github.com/apache/hadoop/pull/5669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724450#comment-17724450 ] ASF GitHub Bot commented on HADOOP-18709: - hadoop-yetus commented on PR #5638: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

hadoop-yetus commented on PR #5638: URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555369000 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

hadoop-yetus commented on PR #5676: URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1555355369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724432#comment-17724432 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5503: URL:

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724431#comment-17724431 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5503: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

hadoop-yetus commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1555322970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

hadoop-yetus commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1555322944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

hadoop-yetus commented on PR #5332: URL: https://github.com/apache/hadoop/pull/5332#issuecomment-1555215001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5672: YARN-7720. Race condition between second app attempt and UAM timeout when first attempt node is down.

hadoop-yetus commented on PR #5672: URL: https://github.com/apache/hadoop/pull/5672#issuecomment-1555201867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

goiri commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1555198815 Let's fix the checktyles and get a clean build (the failed unit tests look unrelated). -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] goiri commented on a diff in pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

goiri commented on code in PR #5676: URL: https://github.com/apache/hadoop/pull/5676#discussion_r1199338094 ##

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

simbadzina commented on code in PR #5674: URL: https://github.com/apache/hadoop/pull/5674#discussion_r1199299711 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java: ## @@ -1918,6 +1920,9 @@ public void

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

simbadzina commented on code in PR #5674: URL: https://github.com/apache/hadoop/pull/5674#discussion_r1199299711 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java: ## @@ -1918,6 +1920,9 @@ public void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

hadoop-yetus commented on PR #5353: URL: https://github.com/apache/hadoop/pull/5353#issuecomment-1555072013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5672: YARN-7720. Race condition between second app attempt and UAM timeout when first attempt node is down.

hadoop-yetus commented on PR #5672: URL: https://github.com/apache/hadoop/pull/5672#issuecomment-1555055872 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

hadoop-yetus commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1555054384 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1555018381 no problem @Hexiaoqiao, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

hadoop-yetus commented on PR #5332: URL: https://github.com/apache/hadoop/pull/5332#issuecomment-1555013561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5669: HADOOP-17518. Update the regex to A-Z

hadoop-yetus commented on PR #5669: URL: https://github.com/apache/hadoop/pull/5669#issuecomment-1554896812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5672: YARN-7720. Race condition between second app attempt and UAM timeout when first attempt node is down.

slfan1989 commented on code in PR #5672: URL: https://github.com/apache/hadoop/pull/5672#discussion_r1199137369 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5660: HDFS-17014. HttpFS Add Support getStatus API

hadoop-yetus commented on PR #5660: URL: https://github.com/apache/hadoop/pull/5660#issuecomment-1554801530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5678: HADOOP-18745. Fix the exception message to print the Identifier pattern

hadoop-yetus commented on PR #5678: URL: https://github.com/apache/hadoop/pull/5678#issuecomment-1554750410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] NishthaShah opened a new pull request, #5678: HADOOP-18745. Fix the exception message to print the Identifier pattern

NishthaShah opened a new pull request, #5678: URL: https://github.com/apache/hadoop/pull/5678 ### Description of PR Print the identifier pattern in the exception thrown if the string doesn't match the pattern. java.lang.IllegalArgumentException: [] = [!] must be

[GitHub] [hadoop] haiyang1987 commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

haiyang1987 commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554608527 > > a miss on the actual PR. "Period" > > I agree. > > @haiyang1987 for this PR, since you already have the opportunity, I would like to propose these changes so that any

[GitHub] [hadoop] haiyang1987 commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

haiyang1987 commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554602389 > In case you find the numbers messed up for any of the other commands as well, can you raise a ticket to fix it as well? yeah, I will review the code and if I find that the

[jira] [Assigned] (HADOOP-18745) Fix the exception message to print the Identifier pattern

[ https://issues.apache.org/jira/browse/HADOOP-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nishtha Shah reassigned HADOOP-18745: - Assignee: Nishtha Shah > Fix the exception message to print the Identifier pattern >

[jira] [Created] (HADOOP-18745) Fix the exception message to print the Identifier pattern

Nishtha Shah created HADOOP-18745: - Summary: Fix the exception message to print the Identifier pattern Key: HADOOP-18745 URL: https://issues.apache.org/jira/browse/HADOOP-18745 Project: Hadoop Common

[GitHub] [hadoop] haiyang1987 commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

haiyang1987 commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554599509 Thanks @ayushtkn @virajjasani help me review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

hadoop-yetus commented on PR #5676: URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1554594208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5669: HADOOP-17518. Update the regex to A-Z

NishthaShah commented on code in PR #5669: URL: https://github.com/apache/hadoop/pull/5669#discussion_r1198949950 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestCheck.java: ## @@ -116,6 +116,16 @@ public void validIdentifierInvalid3()

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5669: HADOOP-17518. Update the regex to A-Z

NishthaShah commented on code in PR #5669: URL: https://github.com/apache/hadoop/pull/5669#discussion_r1198949950 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestCheck.java: ## @@ -116,6 +116,16 @@ public void validIdentifierInvalid3()

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

hfutatzhanghb commented on code in PR #5353: URL: https://github.com/apache/hadoop/pull/5353#discussion_r1198943812 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ## @@ -178,13 +178,13 @@ void

[GitHub] [hadoop] ayushtkn merged pull request #5569: HDFS-16697.Add code to check the minimumRedundantVolumes value and add related log messages.

ayushtkn merged PR #5569: URL: https://github.com/apache/hadoop/pull/5569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

hfutatzhanghb commented on code in PR #5643: URL: https://github.com/apache/hadoop/pull/5643#discussion_r1198937622 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithDecoding.java: ## @@ -169,6 +171,108 @@ public void

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5669: HADOOP-17518. Update the regex to A-Z

ayushtkn commented on code in PR #5669: URL: https://github.com/apache/hadoop/pull/5669#discussion_r1198937053 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestCheck.java: ## @@ -116,6 +116,16 @@ public void validIdentifierInvalid3() throws

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

Hexiaoqiao commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1554533102 > FYI @Hexiaoqiao if you have bandwidth to review. Thanks Sorry for late response. Not familiar about log module, I think involve @Apache9 or @jojochuang should be better here.

[GitHub] [hadoop] ashutoshcipher commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

ashutoshcipher commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1554532846 Will make changes in my next commit. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] ayushtkn commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

ayushtkn commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1554522912 Hi @ashutoshcipher I just meant don't use *, there rather expand ``` diff --git

[GitHub] [hadoop] ashutoshcipher commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

ashutoshcipher commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1554514446 > Have triggered the build again, test were failing due to unable to create native thread. Changes lgtm @ashutoshcipher you missed answering/adressing [#5028

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

ashutoshcipher commented on code in PR #5028: URL: https://github.com/apache/hadoop/pull/5028#discussion_r1198912667 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapred/TestJobClientGetJob.java: ## @@ -18,15

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

hfutatzhanghb commented on code in PR #5643: URL: https://github.com/apache/hadoop/pull/5643#discussion_r1198906389 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithDecoding.java: ## @@ -169,6 +171,108 @@ public void

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5669: HADOOP-17518. Update the regex to A-Z

NishthaShah commented on code in PR #5669: URL: https://github.com/apache/hadoop/pull/5669#discussion_r1198905374 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestCheck.java: ## @@ -116,6 +116,16 @@ public void validIdentifierInvalid3()

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

Hexiaoqiao commented on code in PR #5643: URL: https://github.com/apache/hadoop/pull/5643#discussion_r1198901155 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReadStripedFileWithDecoding.java: ## @@ -169,6 +171,108 @@ public void

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

Hexiaoqiao commented on code in PR #5353: URL: https://github.com/apache/hadoop/pull/5353#discussion_r1198896990 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ## @@ -178,13 +178,13 @@ void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

hadoop-yetus commented on PR #5638: URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1554469170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5569: HDFS-16697.Add code to check the minimumRedundantVolumes value and add related log messages.

hadoop-yetus commented on PR #5569: URL: https://github.com/apache/hadoop/pull/5569#issuecomment-1554419828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5569: HDFS-16697.Add code to check the minimumRedundantVolumes value and add related log messages.

hadoop-yetus commented on PR #5569: URL: https://github.com/apache/hadoop/pull/5569#issuecomment-1554417724 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5677: [YARN-11496] Improve TimelineService log format.

hadoop-yetus commented on PR #5677: URL: https://github.com/apache/hadoop/pull/5677#issuecomment-1554388820 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] rohit-kb commented on pull request #5639: HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code

rohit-kb commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1554375086 Hi @ayushtkn , following up on above comment, I think there are two options to proceed further: 1. One is to cherry-pick

[GitHub] [hadoop] hadoop-yetus commented on pull request #5677: [YARN-11496] Improve TimelineService log format.

hadoop-yetus commented on PR #5677: URL: https://github.com/apache/hadoop/pull/5677#issuecomment-1554372162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] leixm opened a new pull request, #5677: [YARN-11496] Improve TimelineService log format.

leixm opened a new pull request, #5677: URL: https://github.com/apache/hadoop/pull/5677 ### Description of PR Improve TimelineService log format. ### How was this patch tested? Existing UTs. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

hadoop-yetus commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554227074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhangshuyan0 commented on pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

zhangshuyan0 commented on PR #5353: URL: https://github.com/apache/hadoop/pull/5353#issuecomment-1554198518 +1. @Hexiaoqiao Would you mind taking another check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 opened a new pull request, #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

slfan1989 opened a new pull request, #5676: URL: https://github.com/apache/hadoop/pull/5676 ### Description of PR JIRA: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator. ### How was this patch tested? ### For code changes: - [ ]

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

hfutatzhanghb commented on PR #5353: URL: https://github.com/apache/hadoop/pull/5353#issuecomment-1554070835 @zhangshuyan0 Hi, shuyan, could you help to review this code? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5419: HDFS-16928. Both getCurrentEditLogTxid and getEditsFromTxid should be OperationCategory.WRITE

hfutatzhanghb commented on PR #5419: URL: https://github.com/apache/hadoop/pull/5419#issuecomment-1554069423 @ayushtkn @goiri Hi, sir, can we push this PR forward ? Looking forward to your reply~ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5408: HDFS-16898. Remove write lock for processCommandFromActor of DataNode to reduce impact on heartbeat.

hfutatzhanghb commented on PR #5408: URL: https://github.com/apache/hadoop/pull/5408#issuecomment-1554067291 > @hfutatzhanghb Please check failed unit tests if relate with this changes. Thanks. @Hexiaoqiao Sir, the failed unit tests seems to have no relations with this PR. --

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1554053305 @ayushtkn Sir, could you please also help me review this PR ？ thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Comment Edited] (HADOOP-18744) ITestS3ABlockOutputArray failure with IO File name too long

[ https://issues.apache.org/jira/browse/HADOOP-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724060#comment-17724060 ] Viraj Jasani edited comment on HADOOP-18744 at 5/19/23 6:01 AM: Came