[GitHub] [hadoop] hadoop-yetus commented on pull request #5636: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5636: URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1556619161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5674: URL: https://github.com/apache/hadoop/pull/5674#issuecomment-1556567594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] mudit-97 commented on pull request #5680: MAPREDUCE-7438 : Support removal of only selective node states in untracked removal flow

2023-05-21 Thread via GitHub
mudit-97 commented on PR #5680: URL: https://github.com/apache/hadoop/pull/5680#issuecomment-1556562975 Created new PR in Yarn Project: https://github.com/apache/hadoop/pull/5681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] mudit-97 opened a new pull request, #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-21 Thread via GitHub
mudit-97 opened a new pull request, #5681: URL: https://github.com/apache/hadoop/pull/5681 ASF JIRA: https://issues.apache.org/jira/browse/YARN-11497 Allowing config to remove untracked nodes having only selective nodeStates Config: yarn.resourcemanager.node-removal-untracked.node-

[GitHub] [hadoop] hadoop-yetus commented on pull request #5423: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5423: URL: https://github.com/apache/hadoop/pull/5423#issuecomment-1556559339 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5674: URL: https://github.com/apache/hadoop/pull/5674#issuecomment-1556547632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724751#comment-17724751 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-21 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1199923215 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -349,7 +348,7 @@ public void doGet(HttpServletRequest request, HttpS

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724750#comment-17724750 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-21 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1199921484 ## hadoop-common-project/hadoop-common/src/main/conf/log4j.properties: ## @@ -299,7 +299,7 @@ log4j.appender.NMAUDIT.MaxBackupIndex=${nm.audit.log.maxbackupindex}

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5597: HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1556463308 > have triggered the build again, if the build is green will merge this today Sir, thanks for your replying. -- This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop] hfutatzhanghb closed pull request #5600: HDFS-16994. NumTimedOutPendingReconstructions metrics should not be accumulated

2023-05-21 Thread via GitHub
hfutatzhanghb closed pull request #5600: HDFS-16994. NumTimedOutPendingReconstructions metrics should not be accumulated URL: https://github.com/apache/hadoop/pull/5600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5600: HDFS-16994. NumTimedOutPendingReconstructions metrics should not be accumulated

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5600: URL: https://github.com/apache/hadoop/pull/5600#issuecomment-1556462000 > First it is a behaviour change, hence incompatible. > > Second, I don't find any reason we shouldn't accumulate, it is just the metrics telling since last failover/restart ho

[GitHub] [hadoop] ayushtkn commented on pull request #5597: HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts

2023-05-21 Thread via GitHub
ayushtkn commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1556461742 have triggered the build again, if the build is green will merge this today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5597: HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1556455626 force push to fix checkstyle problems. @ayushtkn Hi, sir. Could you please help me review this code and push this PR forward? Thanks a lot. -- This is an automated message from

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

2023-05-21 Thread via GitHub
virajjasani commented on code in PR #5674: URL: https://github.com/apache/hadoop/pull/5674#discussion_r1199906322 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java: ## @@ -1918,6 +1920,9 @@ public void te

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556424290 > @Hexiaoqiao Sir, thanks for your suggestions. 1、The failed UT was passed in my local environment. 2、I have fixed checkstyle problems. Thanks again. -- This is an

[GitHub] [hadoop] hadoop-yetus commented on pull request #5680: MAPREDUCE-7438 : Support removal of only selective node states in untracked removal flow

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5680: URL: https://github.com/apache/hadoop/pull/5680#issuecomment-1556297518 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5561: URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1556286723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5676: URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1556249581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ashutoshcipher commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

2023-05-21 Thread via GitHub
ashutoshcipher commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1556234576 > Good to go from my side. I don't think the test failures are related, double check once. If all safe can revert the changes done in the pom and licence to trigger the tests. We ca

[GitHub] [hadoop] hadoop-yetus commented on pull request #5680: MAPREDUCE-7438 : Support removal of only selective node states in untracked removal flow

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5680: URL: https://github.com/apache/hadoop/pull/5680#issuecomment-1556228795 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread Gautham Banasandra (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautham Banasandra resolved HADOOP-18746. - Fix Version/s: 3.4.0 Target Version/s: 3.4.0 Resolution: Fixed

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724682#comment-17724682 ] ASF GitHub Bot commented on HADOOP-18746: - GauthamBanasandra merged PR #5679: U

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724683#comment-17724683 ] ASF subversion and git services commented on HADOOP-18746: -- Co

[GitHub] [hadoop] GauthamBanasandra merged pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
GauthamBanasandra merged PR #5679: URL: https://github.com/apache/hadoop/pull/5679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubsc

[GitHub] [hadoop] lfxy commented on pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-21 Thread via GitHub
lfxy commented on PR #5561: URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1556199483 @Hexiaoqiao Ok, I have add the NPE check. Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5423: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5423: URL: https://github.com/apache/hadoop/pull/5423#issuecomment-1556177990 @ayushtkn , Sir, could you please help me review this code~ thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724657#comment-17724657 ] ASF GitHub Bot commented on HADOOP-18746: - ayushtkn commented on code in PR #56

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
ayushtkn commented on code in PR #5679: URL: https://github.com/apache/hadoop/pull/5679#discussion_r1199764494 ## dev-support/docker/Dockerfile_windows_10: ## @@ -108,6 +108,12 @@ RUN powershell Copy-Item -Path "C:\LibXXHash\usr\bin\*.dll" -Destination "C:\Pro RUN powershell C

[GitHub] [hadoop] mudit1289 opened a new pull request, #5680: MAPREDUCE-7438 : Support removal of only selective node states in untracked removal flow

2023-05-21 Thread via GitHub
mudit1289 opened a new pull request, #5680: URL: https://github.com/apache/hadoop/pull/5680 ASF JIRA: https://issues.apache.org/jira/browse/MAPREDUCE-7438 Allowing config to remove untracked nodes having only selective nodeStates Config: yarn.resourcemanager.node-removal-untracked.

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
GauthamBanasandra commented on code in PR #5679: URL: https://github.com/apache/hadoop/pull/5679#discussion_r1199758698 ## dev-support/docker/Dockerfile_windows_10: ## @@ -108,6 +108,12 @@ RUN powershell Copy-Item -Path "C:\LibXXHash\usr\bin\*.dll" -Destination "C:\Pro RUN pow

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724645#comment-17724645 ] ASF GitHub Bot commented on HADOOP-18746: - GauthamBanasandra commented on code

[GitHub] [hadoop] hadoop-yetus commented on pull request #5636: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5636: URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1556169512 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ayushtkn commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

2023-05-21 Thread via GitHub
ayushtkn commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1556159707 Good to go from my side. I don't think the test failures are related, double check once. If all safe can revert the changes done in the pom and licence to trigger the tests. We can mer

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5353: HDFS-16909. Improve ReplicaMap#mergeAll method.

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5353: URL: https://github.com/apache/hadoop/pull/5353#issuecomment-1556158848 thanks sir, thanks shuyan. ---Original--- From: ***@***.***> Date: Sun, May 21, 2023 19:09 PM To: ***@***.***>; Cc: ***@***.**@***.***>; Subject: Re:

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724629#comment-17724629 ] ASF GitHub Bot commented on HADOOP-18746: - ayushtkn commented on code in PR #56

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
ayushtkn commented on code in PR #5679: URL: https://github.com/apache/hadoop/pull/5679#discussion_r1199750794 ## dev-support/docker/Dockerfile_windows_10: ## @@ -108,6 +108,12 @@ RUN powershell Copy-Item -Path "C:\LibXXHash\usr\bin\*.dll" -Destination "C:\Pro RUN powershell C

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-21 Thread via GitHub
Hexiaoqiao commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1199749665 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java: ## @@ -121,7 +121,7 @@ private static INodeFile[] verifySr

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5353: HDFS-16909. Improve ReplicaMap#mergeAll method.

2023-05-21 Thread via GitHub
Hexiaoqiao commented on PR #5353: URL: https://github.com/apache/hadoop/pull/5353#issuecomment-1556150811 Committed to trunk. Thanks @hfutatzhanghb and @zhangshuyan0 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] Hexiaoqiao merged pull request #5353: HDFS-16909. Improve ReplicaMap#mergeAll method.

2023-05-21 Thread via GitHub
Hexiaoqiao merged PR #5353: URL: https://github.com/apache/hadoop/pull/5353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-21 Thread via GitHub
Hexiaoqiao commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556147416 > Please use a capital letter at the beginning of the sentences and period at the end of it for all annotation. Just suggest to improve all added comments following this comments

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

2023-05-21 Thread via GitHub
slfan1989 commented on code in PR #5676: URL: https://github.com/apache/hadoop/pull/5676#discussion_r1199742041 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4326,6 +4326,24 @@ public static boolean is

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724603#comment-17724603 ] ASF GitHub Bot commented on HADOOP-18746: - hadoop-yetus commented on PR #5679:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5679: URL: https://github.com/apache/hadoop/pull/5679#issuecomment-1556128063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724596#comment-17724596 ] ASF GitHub Bot commented on HADOOP-18746: - hadoop-yetus commented on PR #5679:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
hadoop-yetus commented on PR #5679: URL: https://github.com/apache/hadoop/pull/5679#issuecomment-1556112446 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724595#comment-17724595 ] ASF GitHub Bot commented on HADOOP-18746: - GauthamBanasandra opened a new pull

[jira] [Updated] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18746: Labels: pull-request-available (was: ) > Install Python 3 for Windows 10 docker image >

[GitHub] [hadoop] GauthamBanasandra opened a new pull request, #5679: HADOOP-18746. Install Python 3 for Windows 10 docker image

2023-05-21 Thread via GitHub
GauthamBanasandra opened a new pull request, #5679: URL: https://github.com/apache/hadoop/pull/5679 ### Description of PR Currently, mvnsite build phase fails due to the following error - ``` [INFO] --< org.apache.hadoop:hadoop-common >---

[jira] [Created] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread Gautham Banasandra (Jira)
Gautham Banasandra created HADOOP-18746: --- Summary: Install Python 3 for Windows 10 docker image Key: HADOOP-18746 URL: https://issues.apache.org/jira/browse/HADOOP-18746 Project: Hadoop Common

[jira] [Updated] (HADOOP-18746) Install Python 3 for Windows 10 docker image

2023-05-21 Thread Gautham Banasandra (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautham Banasandra updated HADOOP-18746: Language: powershell Docker (was: powershell) > Install Python 3 for Windows 10