Re: [PR] YARN-11577. Improve FederationInterceptorREST Method Result. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6190: URL: https://github.com/apache/hadoop/pull/6190#issuecomment-1762633264 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11576. Improve FederationInterceptorREST AuditLog. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6117: URL: https://github.com/apache/hadoop/pull/6117#issuecomment-1762594393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775124#comment-17775124 ] ASF GitHub Bot commented on HADOOP-18868: - haiyang1987 commented on PR #5998: U

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-13 Thread via GitHub
haiyang1987 commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1762591448 Hi @ayushtkn @goiri any suggestions for this change? Thank you very much~ -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6189: URL: https://github.com/apache/hadoop/pull/6189#issuecomment-1762591067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775122#comment-17775122 ] ASF GitHub Bot commented on HADOOP-18930: - xinglin commented on code in PR #616

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-13 Thread via GitHub
xinglin commented on code in PR #6168: URL: https://github.com/apache/hadoop/pull/6168#discussion_r1359140744 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -656,6 +657,11 @@ public void initialize(URI name, Configuration originalCon

[PR] YARN-11577. Improve FederationInterceptorREST Method Result. [hadoop]

2023-10-13 Thread via GitHub
slfan1989 opened a new pull request, #6190: URL: https://github.com/apache/hadoop/pull/6190 ### Description of PR JIRA: YARN-11577. Improve FederationInterceptorREST Method Result. ### How was this patch tested? ### For code changes: - [ ] Does the titl

[jira] [Commented] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775116#comment-17775116 ] ASF GitHub Bot commented on HADOOP-18936: - hadoop-yetus commented on PR #6181:

Re: [PR] HADOOP-18936. upgrade to jetty 9.4.53 [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6181: URL: https://github.com/apache/hadoop/pull/6181#issuecomment-1762519061 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11571. [GPG] Add Information About YARN GPG in Federation.md [hadoop]

2023-10-13 Thread via GitHub
slfan1989 commented on PR #6158: URL: https://github.com/apache/hadoop/pull/6158#issuecomment-1762482447 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] YARN-11571. [GPG] Add Information About YARN GPG in Federation.md [hadoop]

2023-10-13 Thread via GitHub
slfan1989 merged PR #6158: URL: https://github.com/apache/hadoop/pull/6158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-13 Thread via GitHub
slfan1989 opened a new pull request, #6189: URL: https://github.com/apache/hadoop/pull/6189 ### Description of PR JIRA: YARN-11592. Add timeout to GPGUtils#invokeRMWebService. ### How was this patch tested? ### For code changes: - [ ] Does the title or

[jira] [Resolved] (HADOOP-18926) Add documentation related to NodeFencer

2023-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri resolved HADOOP-18926. -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Add documentation

[jira] [Updated] (HADOOP-18926) Add documentation related to NodeFencer

2023-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri updated HADOOP-18926: - Summary: Add documentation related to NodeFencer (was: Add some comments related to NodeFencer

[jira] [Commented] (HADOOP-18926) Add some comments related to NodeFencer

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775085#comment-17775085 ] ASF GitHub Bot commented on HADOOP-18926: - goiri merged PR #6162: URL: https://

Re: [PR] HADOOP-18926. Add documentation related to NodeFencer. [hadoop]

2023-10-13 Thread via GitHub
goiri merged PR #6162: URL: https://github.com/apache/hadoop/pull/6162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[jira] [Commented] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775076#comment-17775076 ] ASF GitHub Bot commented on HADOOP-18917: - pjfanning commented on PR #6151: URL

Re: [PR] HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) [hadoop]

2023-10-13 Thread via GitHub
pjfanning commented on PR #6151: URL: https://github.com/apache/hadoop/pull/6151#issuecomment-1762298839 @steveloughran I have a backport PR for the module-info classes at https://github.com/apache/hadoop/pull/6188 -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775075#comment-17775075 ] ASF GitHub Bot commented on HADOOP-18916: - hadoop-yetus commented on PR #6188:

Re: [PR] HADOOP-18916. Exclude all module-info classes from uber jars (#6131) [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6188: URL: https://github.com/apache/hadoop/pull/6188#issuecomment-1762297729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775072#comment-17775072 ] ASF GitHub Bot commented on HADOOP-18908: - hadoop-yetus commented on PR #6187:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6187: URL: https://github.com/apache/hadoop/pull/6187#issuecomment-1762276417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18929) Build failure while trying to create apache 3.3.7 release locally.

2023-10-13 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18929. Fix Version/s: 3.3.9 Resolution: Fixed > Build failure while trying to create apac

[jira] [Assigned] (HADOOP-18929) Build failure while trying to create apache 3.3.7 release locally.

2023-10-13 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur reassigned HADOOP-18929: -- Assignee: PJ Fanning > Build failure while trying to create apache 3.3.7 release loc

[jira] [Commented] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775033#comment-17775033 ] ASF GitHub Bot commented on HADOOP-18916: - pjfanning opened a new pull request,

[PR] HADOOP-18916. Exclude all module-info classes from uber jars (#6131) [hadoop]

2023-10-13 Thread via GitHub
pjfanning opened a new pull request, #6188: URL: https://github.com/apache/hadoop/pull/6188 Removes java9 and java11 from all modules pulled into the hadoop-client and hadoop-client-minicluster modules. ### Description of PR ### How was this patch tested? ###

[jira] [Commented] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775031#comment-17775031 ] ASF GitHub Bot commented on HADOOP-18917: - steveloughran commented on PR #6151:

Re: [PR] HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6151: URL: https://github.com/apache/hadoop/pull/6151#issuecomment-1762048907 #6131 is in trunk now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] HADOOP-18916. Exclude all module-info classes [hadoop]

2023-10-13 Thread via GitHub
steveloughran merged PR #6131: URL: https://github.com/apache/hadoop/pull/6131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18916) module-info classes from external dependencies appearing in uber jars

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775030#comment-17775030 ] ASF GitHub Bot commented on HADOOP-18916: - steveloughran merged PR #6131: URL:

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775016#comment-17775016 ] ASF GitHub Bot commented on HADOOP-18908: - hadoop-yetus commented on PR #6106:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1762002530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-18889. Third party storage followup. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6186: URL: https://github.com/apache/hadoop/pull/6186#issuecomment-1761976145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775014#comment-17775014 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6186:

Re: [PR] HADOOP-18889. Third party storage followup. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6186: URL: https://github.com/apache/hadoop/pull/6186#issuecomment-1761940026 actually, want to hold back on this as we are getting a test failure which appears related to the main patch ``` [ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775006#comment-17775006 ] ASF GitHub Bot commented on HADOOP-18908: - steveloughran commented on PR #6187:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6187: URL: https://github.com/apache/hadoop/pull/6187#issuecomment-1761920181 3 failures; one from this, one that seems caused by #6141 and a random timeout ``` [ERROR] Failures: [ERROR] ITestS3AEndpointRegion.testWithVPCE:215->lambda$testWithVPCE$7

[jira] [Commented] (HADOOP-18511) TestDecayRpcScheduler.testPriority is a flaky test

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774997#comment-17774997 ] ASF GitHub Bot commented on HADOOP-18511: - Kerr0220 closed pull request #5085:

Re: [PR] HADOOP-18511. Fix flaky test TestDecayRpcScheduler.testPriority [hadoop]

2023-10-13 Thread via GitHub
Kerr0220 closed pull request #5085: HADOOP-18511. Fix flaky test TestDecayRpcScheduler.testPriority URL: https://github.com/apache/hadoop/pull/5085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774996#comment-17774996 ] ASF GitHub Bot commented on HADOOP-18908: - steveloughran opened a new pull requ

[PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
steveloughran opened a new pull request, #6187: URL: https://github.com/apache/hadoop/pull/6187 ### Description of PR #6106 with one extra commit Removes the region probe to S3 and reinstates the region resolution logic that was there before the SDK V2 upgrade. * Re

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1761820755 ok, so playing with it, the sole change i want to make is for that log of region setting to include the origin too. I'll make a pr with that change appended. -- This is an automat

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774994#comment-17774994 ] ASF GitHub Bot commented on HADOOP-18908: - steveloughran commented on PR #6106:

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774985#comment-17774985 ] ASF GitHub Bot commented on HADOOP-18908: - steveloughran commented on PR #6106:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1761805815 going to test this myself to see what happens when i don't set the region -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774982#comment-17774982 ] ASF GitHub Bot commented on HADOOP-18908: - steveloughran commented on code in P

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on code in PR #6106: URL: https://github.com/apache/hadoop/pull/6106#discussion_r1358450649 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -229,4 +254,49 @@ private static URI getS3Endpoint(String endp

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1761793729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18889. Third party storage followup. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6186: URL: https://github.com/apache/hadoop/pull/6186#issuecomment-1761781131 test failure was against s3 london with ` -Dparallel-tests -DtestsThreadCount=10 ` but: the verifyCost call creates and initialises a span before calling innerGetFileStatus();

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774980#comment-17774980 ] ASF GitHub Bot commented on HADOOP-18889: - steveloughran commented on PR #6186:

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774976#comment-17774976 ] ASF GitHub Bot commented on HADOOP-18889: - steveloughran commented on PR #6186:

Re: [PR] HADOOP-18889. Third party storage followup. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6186: URL: https://github.com/apache/hadoop/pull/6186#issuecomment-1761765834 got a test failure: unaudited operation ``` [ERROR] Tests run: 42, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 164.026 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.ITestS3

Re: [PR] HADOOP-18932. upgrade AWS v1 and v2 SDKs [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6178: URL: https://github.com/apache/hadoop/pull/6178#issuecomment-1761742490 s3 london -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (HADOOP-18932) upgrade AWS v1 and v2 SDKs

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774969#comment-17774969 ] ASF GitHub Bot commented on HADOOP-18932: - steveloughran commented on PR #6178:

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774966#comment-17774966 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #6184:

Re: [PR] HADOOP-18487. Make protobuf 2.5 an optional runtime dependency. (#4996) [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #6184: URL: https://github.com/apache/hadoop/pull/6184#issuecomment-1761734949 will merge asap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18487: Fix Version/s: 3.4.0 > protobuf-2.5.0 dependencies => provided >

[jira] [Assigned] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18487: --- Assignee: Steve Loughran > Make protobuf 2.5 an optional runtime dependency. > ---

[jira] [Updated] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18487: Summary: Make protobuf 2.5 an optional runtime dependency. (was: protobuf-2.5.0 dependen

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-10-13 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774965#comment-17774965 ] Mukund Thakur commented on HADOOP-18890: Yes. I see you have already merged. 

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774924#comment-17774924 ] ASF GitHub Bot commented on HADOOP-18908: - ahmarsuhail commented on code in PR

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774923#comment-17774923 ] ASF GitHub Bot commented on HADOOP-18908: - ahmarsuhail commented on code in PR

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
ahmarsuhail commented on code in PR #6106: URL: https://github.com/apache/hadoop/pull/6106#discussion_r1358340239 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -229,4 +254,49 @@ private static URI getS3Endpoint(String endpoi

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
ahmarsuhail commented on code in PR #6106: URL: https://github.com/apache/hadoop/pull/6106#discussion_r1358340239 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -229,4 +254,49 @@ private static URI getS3Endpoint(String endpoi

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1761556857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774912#comment-17774912 ] ASF GitHub Bot commented on HADOOP-18908: - hadoop-yetus commented on PR #6106:

Re: [PR] YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6132: URL: https://github.com/apache/hadoop/pull/6132#issuecomment-1761552674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774904#comment-17774904 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran opened a new pull requ

[PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-10-13 Thread via GitHub
steveloughran opened a new pull request, #6185: URL: https://github.com/apache/hadoop/pull/6185 Followup to the previous HADOOP-18487 patch: changes the scope of protobuf-2.5 in hadoop-common and elsewhere from "compile" to "provided". This means that protobuf-2.5 is * No longe

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774902#comment-17774902 ] Steve Loughran commented on HADOOP-18487: - Part 1 PR of this is in trunk and up

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774901#comment-17774901 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran opened a new pull requ

[PR] HADOOP-18487. Make protobuf 2.5 an optional runtime dependency. (#4996) [hadoop]

2023-10-13 Thread via GitHub
steveloughran opened a new pull request, #6184: URL: https://github.com/apache/hadoop/pull/6184 this is #4996 on branch-3.3 -- Protobuf 2.5 JAR is no longer needed at runtime. The option common.protobuf.scope defines whether the protobuf 2.5.0 dependency is marked as

[jira] [Resolved] (HADOOP-18890) remove okhttp usage

2023-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18890. - Fix Version/s: 3.3.9 Resolution: Fixed merged and backported. [~mukund-thakur]

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774896#comment-17774896 ] ASF GitHub Bot commented on HADOOP-18890: - steveloughran merged PR #6101: URL:

Re: [PR] HADOOP-18890. Remove use of okhttp in runtime code (#6057) [hadoop]

2023-10-13 Thread via GitHub
steveloughran merged PR #6101: URL: https://github.com/apache/hadoop/pull/6101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774893#comment-17774893 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran merged PR #4996: URL:

Re: [PR] HADOOP-18487. protobuf 2.5.0 marked as provided. [hadoop]

2023-10-13 Thread via GitHub
steveloughran merged PR #4996: URL: https://github.com/apache/hadoop/pull/4996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-18487. protobuf 2.5.0 marked as provided. [hadoop]

2023-10-13 Thread via GitHub
steveloughran commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1761463315 dfs upgrade test is flaky (and has a history), created HDFS-17224 to cover the new failure and verified it works standalone -- This is an automated message from the Apache Git Serv

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774892#comment-17774892 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #4996:

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-13 Thread via GitHub
mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1761375332 @slfan1989 , did you get a chance to go through this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1761368403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-13 Thread via GitHub
hadoop-yetus commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1761299675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-10-13 Thread via GitHub
gp1314 opened a new pull request, #6183: URL: https://github.com/apache/hadoop/pull/6183 ### Description of PR * In the case of configuring 3 journal nodes in HDFS, if only 2 journal nodes are available and 1 journal node fails to start due to machine issues, it will result i

[jira] [Commented] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774846#comment-17774846 ] ASF GitHub Bot commented on HADOOP-18917: - pjfanning commented on PR #6151: URL

Re: [PR] HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) [hadoop]

2023-10-13 Thread via GitHub
pjfanning commented on PR #6151: URL: https://github.com/apache/hadoop/pull/6151#issuecomment-1761218019 This is now blocked by https://issues.apache.org/jira/browse/HADOOP-18916 - commons-io 2.14.0 jar has module-info.class -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HADOOP-18937) Add journalnode maintenance node list

2023-10-13 Thread kuper (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kuper resolved HADOOP-18937. Resolution: Abandoned > Add journalnode maintenance node list > - > >

[jira] [Updated] (HADOOP-18937) Add journalnode maintenance node list

2023-10-13 Thread kuper (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kuper updated HADOOP-18937: --- Priority: Trivial (was: Major) > Add journalnode maintenance node list > -

[jira] [Created] (HADOOP-18937) Add journalnode maintenance node list

2023-10-13 Thread kuper (Jira)
kuper created HADOOP-18937: -- Summary: Add journalnode maintenance node list Key: HADOOP-18937 URL: https://issues.apache.org/jira/browse/HADOOP-18937 Project: Hadoop Common Issue Type: Improvement