Re: [PR] YARN-11619. [Federation] Router CLI Supports List SubClusters. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6304: URL: https://github.com/apache/hadoop/pull/6304#issuecomment-1837387492 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
haiyang1987 commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837376037 LGTM +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837343342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18924. Upgrade to grpc 1.53.0 due to CVEs (#6161). [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6313: URL: https://github.com/apache/hadoop/pull/6313#issuecomment-1837309798 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1837250200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-15566) Support OpenTelemetry

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792433#comment-17792433 ] ASF GitHub Bot commented on HADOOP-15566: - hadoop-yetus commented on PR #3445: URL:

Re: [PR] HADOOP-15566 Opentelemetry changes using java agent [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #3445: URL: https://github.com/apache/hadoop/pull/3445#issuecomment-1837247971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18993) Allow to not isolate S3AFileSystem classloader when needed

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792403#comment-17792403 ] ASF GitHub Bot commented on HADOOP-18993: - steveloughran commented on code in PR #6301: URL:

Re: [PR] HADOOP-18993 Allow to not isolate S3AFileSystem classloader when needed [hadoop]

2023-12-02 Thread via GitHub
steveloughran commented on code in PR #6301: URL: https://github.com/apache/hadoop/pull/6301#discussion_r1412838038 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837197821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18997) S3A: add way to turn off CreateSession API

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792401#comment-17792401 ] ASF GitHub Bot commented on HADOOP-18997: - steveloughran commented on code in PR #6316: URL:

Re: [PR] HADOOP-18997. S3A: createSession is optional when working with S3Express buckets [hadoop]

2023-12-02 Thread via GitHub
steveloughran commented on code in PR #6316: URL: https://github.com/apache/hadoop/pull/6316#discussion_r1412834639 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -4498,6 +4500,10 @@ public List listAWSPolicyRules( // way to

[jira] [Commented] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792400#comment-17792400 ] Steve Loughran commented on HADOOP-19001: - we've tried to lock this down for security, if you

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837191941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
ayushtkn commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837183465 there are some checkstyle warnings: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/7/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt -- This is an

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837182918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837158445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11619. [Federation] Router CLI Supports List SubClusters. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6304: URL: https://github.com/apache/hadoop/pull/6304#issuecomment-1837155495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-02 Thread via GitHub
lfxy opened a new pull request, #6319: URL: https://github.com/apache/hadoop/pull/6319 Currently, NNThroughputBenchmark does not support specifying the base directory, therefore does not support multiple clients performing stress testing at the same time. However, for high-performance

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6279: URL: https://github.com/apache/hadoop/pull/6279#issuecomment-1837134470 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412783688 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412783688 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412783688 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412782703 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -2663,6 +2663,8 @@ String

Re: [PR] YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6295: URL: https://github.com/apache/hadoop/pull/6295#issuecomment-1837118568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
ayushtkn commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412780129 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -2663,6 +2663,8 @@ String

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
ayushtkn commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412779989 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412774811 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
haiyang1987 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412773207 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
haiyang1987 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412773207 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic [hadoop]

2023-12-02 Thread via GitHub
haiyang1987 commented on PR #6245: URL: https://github.com/apache/hadoop/pull/6245#issuecomment-1837102256 Hi @ayushtkn Would you mind to take a review this pr when you have time? thank you very much~ -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-02 Thread Zilong Zhu (Jira)
Zilong Zhu created HADOOP-19001: --- Summary: LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR Key: HADOOP-19001 URL: https://issues.apache.org/jira/browse/HADOOP-19001 Project: Hadoop Common

[jira] [Updated] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-02 Thread Zilong Zhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zilong Zhu updated HADOOP-19001: Attachment: (was: image-2023-12-02-16-56-42-363.png) > LD_LIBRARY_PATH is missing

Re: [PR] HDFS-16749. RBF: Gets the wrong directory information from Trash [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6317: URL: https://github.com/apache/hadoop/pull/6317#issuecomment-1837090009 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412761129 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
huangzhaobo99 commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412761129 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java: ## @@ -46,11 +46,6 @@ public class

[jira] [Commented] (HADOOP-18924) Upgrade grpc jars to v1.53.0 due to CVEs

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792347#comment-17792347 ] ASF GitHub Bot commented on HADOOP-18924: - ayushtkn commented on PR #6313: URL:

Re: [PR] HADOOP-18924. Upgrade to grpc 1.53.0 due to CVEs (#6161). [hadoop]

2023-12-02 Thread via GitHub
ayushtkn commented on PR #6313: URL: https://github.com/apache/hadoop/pull/6313#issuecomment-1837084310 Compilation is failing ``` --- [ERROR] Failed to execute goal

Re: [PR] HDFS-17233. The conf dfs.datanode.lifeline.interval.seconds is not co… [hadoop]

2023-12-02 Thread via GitHub
ayushtkn merged PR #6286: URL: https://github.com/apache/hadoop/pull/6286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17271. Fix dead DN sorting in DN report web UI [hadoop]

2023-12-02 Thread via GitHub
ayushtkn merged PR #6318: URL: https://github.com/apache/hadoop/pull/6318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-02 Thread via GitHub
ayushtkn commented on code in PR #6279: URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412752208 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyExcludeSlowNodes.java: ## @@ -136,4 +139,40 @@