Re: [PR] only create cluster and create file system on it once to speed up tests [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6346: URL: https://github.com/apache/hadoop/pull/6346#issuecomment-1851467234 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1851450693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1851432168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17278. Fix order dependent flakiness in TestViewfsWithNfs3.java under hadoop-hdfs-nfs module [hadoop]

2023-12-11 Thread via GitHub
ayushtkn merged PR #6329: URL: https://github.com/apache/hadoop/pull/6329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17281 Added support of reporting rpc round-trip time at NN. [hadoop]

2023-12-11 Thread via GitHub
xinglin commented on PR #6337: URL: https://github.com/apache/hadoop/pull/6337#issuecomment-1851408051 The following two assertions failed during one of the builds. Investigating. ``` assertCounter("RoundTripLockAndSleepNumOps", 1L, rttRB);

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1851402685 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1851399396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] only create cluster and create file system on it once to speed up tests [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6346: URL: https://github.com/apache/hadoop/pull/6346#issuecomment-1851381617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] only create cluster and create file system on it once to speed up tests [hadoop]

2023-12-11 Thread via GitHub
TestBoost opened a new pull request, #6346: URL: https://github.com/apache/hadoop/pull/6346 ### Description of PR This pull request tries to only create/close the cluster and create the file system once in the test class `TestOfflineImageViewerWithStripedBlocks` to speed up

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
ThinkerLei commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1851251616 > Thanks for reporting this. We talked about this before, see #4087. It's very funny. Please see HDFS-16083 -- This is an automated message from the Apache Git Service. To

Re: [PR] HDFS-17276. Fix the nn fetch editlog forbidden in kerberos environment [hadoop]

2023-12-11 Thread via GitHub
gp1314 commented on PR #6326: URL: https://github.com/apache/hadoop/pull/6326#issuecomment-1851244732 @sunchao , could you please make a cr for this modification? I would be very grateful. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] YARN-11624 CapacityScheduler: Add configuration to disable AM preemption [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6345: URL: https://github.com/apache/hadoop/pull/6345#issuecomment-1851244163 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
tomscut commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1851237828 Thanks for reporting this. We talked about this before, see https://github.com/apache/hadoop/pull/4087. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
ThinkerLei commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1851205116 @hadoop-yetus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] YARN-11594. [Addendum] Improve Yarn Federation documentation. [hadoop]

2023-12-11 Thread via GitHub
goiri commented on PR #6340: URL: https://github.com/apache/hadoop/pull/6340#issuecomment-1851177994 Let's open a separate JIRA for adding documentation for this feature. No need for it to be addendum. -- This is an automated message from the Apache Git Service. To respond to the

[PR] YARN-11624 CapacityScheduler: Add configuration to disable AM preemption [hadoop]

2023-12-11 Thread via GitHub
singer-bin opened a new pull request, #6345: URL: https://github.com/apache/hadoop/pull/6345 about : [YARN-11624](https://issues.apache.org/jira/browse/YARN-11624) ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the

[jira] [Created] (HADOOP-19009) Remove keystore parameter requirement from ZookeeperClient

2023-12-11 Thread Zita Dombi (Jira)
Zita Dombi created HADOOP-19009: --- Summary: Remove keystore parameter requirement from ZookeeperClient Key: HADOOP-19009 URL: https://issues.apache.org/jira/browse/HADOOP-19009 Project: Hadoop Common

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1850985184 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1850809526 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18981. moved oncrpc/portmap from hadoop-common-project/hadoop-nfs to hadoop-common-project/hadoop-common [hadoop]

2023-12-11 Thread via GitHub
simbadzina commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1850804895 The PR looks ok to me. My only concern is the number of files that are moved and changed. I'll wait for the other to chime in. @xinglin do you plan on working on the following ```

[jira] [Commented] (HADOOP-18981) Move oncrpc/portmap from hadoop-nfs to hadoop-common

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795499#comment-17795499 ] ASF GitHub Bot commented on HADOOP-18981: - simbadzina commented on PR #6280: URL:

Re: [PR] HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1850784164 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1850705475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19005) Upgrade Guava to 32.0.1 due to CVE-2023-2976

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795480#comment-17795480 ] ASF GitHub Bot commented on HADOOP-19005: - hadoop-yetus commented on PR #6344: URL:

Re: [PR] HADOOP-19005. Upgrade Guava to 32.0.1 due to CVE-2023-2976. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6344: URL: https://github.com/apache/hadoop/pull/6344#issuecomment-1850671031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6343: URL: https://github.com/apache/hadoop/pull/6343#issuecomment-1850636348 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1850570785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19005) Upgrade Guava to 32.0.1 due to CVE-2023-2976

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795448#comment-17795448 ] ASF GitHub Bot commented on HADOOP-19005: - eshwitha opened a new pull request, #6344: URL:

[PR] HADOOP-19005. Upgrade Guava to 32.0.1 due to CVE-2023-2976. [hadoop]

2023-12-11 Thread via GitHub
eshwitha opened a new pull request, #6344: URL: https://github.com/apache/hadoop/pull/6344 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1850426479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6311: URL: https://github.com/apache/hadoop/pull/6311#issuecomment-1850280283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-16083: Forbid Observer NameNode trigger active namenode roll edi… [hadoop]

2023-12-11 Thread via GitHub
ThinkerLei opened a new pull request, #6343: URL: https://github.com/apache/hadoop/pull/6343 When the Observer NameNode is turned on in the cluster, the Active NameNode will receive rollEditLog RPC requests from the Standby NameNode and Observer NameNode in a short time. Observer

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1849814647 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] MAPREDUCE-7463. Modify HistoryServerRest.html content,add comma for the /ws/v1/histo… [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6342: URL: https://github.com/apache/hadoop/pull/6342#issuecomment-1849709457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1849697538 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-12-11 Thread via GitHub
Neilxzn commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1849677715 > @Neilxzn I tried & it fails locally > > ``` > [INFO] --- > [INFO] T E S T S > [INFO]

Re: [PR] HDFS-17280. Pipeline recovery should better end block in advance when bytes acked greater than half of blocksize. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6336: URL: https://github.com/apache/hadoop/pull/6336#issuecomment-1849649707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17281 Added support of reporting rpc round-trip time at NN. [hadoop]

2023-12-11 Thread via GitHub
hadoop-yetus commented on PR #6337: URL: https://github.com/apache/hadoop/pull/6337#issuecomment-1849601339 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17152. Fix the documentation of count command in FileSystemShell.md. [hadoop]

2023-12-11 Thread via GitHub
zhangshuyan0 merged PR #5939: URL: https://github.com/apache/hadoop/pull/5939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MAPREDUCE-7463. Modify HistoryServerRest.html content,add comma for the /ws/v1/histo… [hadoop]

2023-12-11 Thread via GitHub
granewang opened a new pull request, #6342: URL: https://github.com/apache/hadoop/pull/6342 the /ws/v1/history/mapreduce/jobs Response Body is missing a comma ![image](https://github.com/apache/hadoop/assets/7702837/c35265f8-7a50-4f1a-ad51-00be346a0487) -- This is an