Re: [PR] YARN-11653. Add Totoal_Memory and Total_Vcores columns in Nodes page [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6501: URL: https://github.com/apache/hadoop/pull/6501#issuecomment-1916160462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19022) S3A : ITestS3AConfiguration#testRequestTimeout failure

2024-01-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812142#comment-17812142 ] Viraj Jasani commented on HADOOP-19022: --- It's fine [~ste...@apache.org], i anyway

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812136#comment-17812136 ] ASF GitHub Bot commented on HADOOP-19044: - hadoop-yetus commented on PR #6479:

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6479: URL: https://github.com/apache/hadoop/pull/6479#issuecomment-1916021503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17360. Record the number of times a block is read during a certain time period. [hadoop]

2024-01-29 Thread via GitHub
zhangshuyan0 commented on PR #6505: URL: https://github.com/apache/hadoop/pull/6505#issuecomment-1915982912 @huangzhaobo99 Thanks for your reply. If this feature is practical in your scenario, I suggest adding a switch for this feature. -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-19049) Class loader leak caused by StatisticsDataReferenceCleaner thread

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812119#comment-17812119 ] ASF GitHub Bot commented on HADOOP-19049: - Hisoka-X commented on PR #6488: URL:

Re: [PR] HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak [hadoop]

2024-01-29 Thread via GitHub
Hisoka-X commented on PR #6488: URL: https://github.com/apache/hadoop/pull/6488#issuecomment-1915953798 > testing? Adding... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (HADOOP-19049) Class loader leak caused by StatisticsDataReferenceCleaner thread

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812117#comment-17812117 ] ASF GitHub Bot commented on HADOOP-19049: - Hisoka-X commented on code in PR #64

Re: [PR] HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak [hadoop]

2024-01-29 Thread via GitHub
Hisoka-X commented on code in PR #6488: URL: https://github.com/apache/hadoop/pull/6488#discussion_r1470514489 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4077,6 +4077,7 @@ private interface StatisticsAggregator { STAT

Re: [PR] YARN-11653. Add Totoal_Memory and Total_Vcores columns in Nodes page [hadoop]

2024-01-29 Thread via GitHub
yangjiandan commented on PR #6501: URL: https://github.com/apache/hadoop/pull/6501#issuecomment-1915951700 @slfan1989 Thanks for reviewing very much, I'll tregger it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812107#comment-17812107 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915921653 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19047) Support InMemory Tracking Of S3A Magic Commits

2024-01-29 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812104#comment-17812104 ] Syed Shameerur Rahman commented on HADOOP-19047: [~ste...@apache.org] i

[jira] [Commented] (HADOOP-17351) hadoop: shaded client test is too aggressive

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812102#comment-17812102 ] ASF GitHub Bot commented on HADOOP-17351: - jxhan3 commented on PR #6507: URL: h

Re: [PR] HADOOP-17351, Add Support for AWS S3 Access Grants [hadoop]

2024-01-29 Thread via GitHub
jxhan3 commented on PR #6507: URL: https://github.com/apache/hadoop/pull/6507#issuecomment-1915909095 Trunk compile tests all passed, but some of the patch compile tests failed. Could someone help to give some pointer how to fix this? Thanks. -- This is an automated message from the Apach

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812099#comment-17812099 ] ASF GitHub Bot commented on HADOOP-19044: - virajjasani commented on PR #6479: U

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
virajjasani commented on PR #6479: URL: https://github.com/apache/hadoop/pull/6479#issuecomment-1915897439 Tests with bucket created on us-west-2, and endpoint/region configured: 1. endpoint central and region null able to perform all operations, as expected 2. endpoint centr

[jira] [Commented] (HADOOP-17350) hadoop: flag native changes w/no Dockerfile change

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812097#comment-17812097 ] ASF GitHub Bot commented on HADOOP-17350: - jxhan3 commented on PR #6506: URL: h

Re: [PR] HADOOP-17350. Update AWS SDK to v2.23.7 [hadoop]

2024-01-29 Thread via GitHub
jxhan3 commented on PR #6506: URL: https://github.com/apache/hadoop/pull/6506#issuecomment-1915874253 > The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this

[jira] [Commented] (HADOOP-17350) hadoop: flag native changes w/no Dockerfile change

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812096#comment-17812096 ] ASF GitHub Bot commented on HADOOP-17350: - jxhan3 commented on PR #6506: URL: h

Re: [PR] HADOOP-17350. Update AWS SDK to v2.23.7 [hadoop]

2024-01-29 Thread via GitHub
jxhan3 commented on PR #6506: URL: https://github.com/apache/hadoop/pull/6506#issuecomment-1915872751 This unit test failure is not related to this change: [ERROR] Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 143.829 s <<< FAILURE! - in org.apache.hadoop.hdfs.serv

[jira] [Commented] (HADOOP-17351) hadoop: shaded client test is too aggressive

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812094#comment-17812094 ] ASF GitHub Bot commented on HADOOP-17351: - jxhan3 commented on PR #6507: URL: h

Re: [PR] HADOOP-17351, Add Support for AWS S3 Access Grants [hadoop]

2024-01-29 Thread via GitHub
jxhan3 commented on PR #6507: URL: https://github.com/apache/hadoop/pull/6507#issuecomment-1915850470 The failed junit test is not related to this change. (hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2) -- This is an automated message from the Apache Git Service

Re: [PR] YARN-11362: Fix several typos in YARN codebase of misspelled resource [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6474: URL: https://github.com/apache/hadoop/pull/6474#issuecomment-1915699065 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812060#comment-17812060 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915611296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19045) S3A: pass request timeouts down to sdk clients

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812057#comment-17812057 ] ASF GitHub Bot commented on HADOOP-19045: - mukund-thakur commented on code in P

[jira] [Commented] (HADOOP-19045) S3A: pass request timeouts down to sdk clients

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812056#comment-17812056 ] ASF GitHub Bot commented on HADOOP-19045: - mukund-thakur commented on code in P

Re: [PR] HADOOP-19045. S3A: Validate CreateSession Timeout Propagation [hadoop]

2024-01-29 Thread via GitHub
mukund-thakur commented on code in PR #6470: URL: https://github.com/apache/hadoop/pull/6470#discussion_r1470217470 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java: ## @@ -550,6 +550,16 @@ public static void skipIfS3ExpressBucket( !is

Re: [PR] HADOOP-19045. S3A: Validate CreateSession Timeout Propagation [hadoop]

2024-01-29 Thread via GitHub
mukund-thakur commented on code in PR #6470: URL: https://github.com/apache/hadoop/pull/6470#discussion_r1470217470 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java: ## @@ -550,6 +550,16 @@ public static void skipIfS3ExpressBucket( !is

[jira] [Commented] (HADOOP-19045) S3A: pass request timeouts down to sdk clients

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812050#comment-17812050 ] ASF GitHub Bot commented on HADOOP-19045: - mukund-thakur commented on code in P

Re: [PR] HADOOP-19045. S3A: Validate CreateSession Timeout Propagation [hadoop]

2024-01-29 Thread via GitHub
mukund-thakur commented on code in PR #6470: URL: https://github.com/apache/hadoop/pull/6470#discussion_r1470193898 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestCreateSessionTimeout.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812025#comment-17812025 ] ASF GitHub Bot commented on HADOOP-19044: - virajjasani commented on code in PR

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
virajjasani commented on code in PR #6479: URL: https://github.com/apache/hadoop/pull/6479#discussion_r1470057492 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java: ## @@ -257,6 +275,44 @@ public void testWithVPCE() throws Throwable {

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812024#comment-17812024 ] ASF GitHub Bot commented on HADOOP-19044: - virajjasani commented on code in PR

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
virajjasani commented on code in PR #6479: URL: https://github.com/apache/hadoop/pull/6479#discussion_r1470049767 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java: ## @@ -257,6 +275,33 @@ public void testWithVPCE() throws Throwable {

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812019#comment-17812019 ] ASF GitHub Bot commented on HADOOP-19044: - virajjasani commented on code in PR

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
virajjasani commented on code in PR #6479: URL: https://github.com/apache/hadoop/pull/6479#discussion_r1470040175 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -289,17 +290,35 @@ private , ClientT> void builder.fipsEnab

Re: [PR] YARN-11362: Fix several typos in YARN codebase of misspelled resource [hadoop]

2024-01-29 Thread via GitHub
EremenkoValentin commented on code in PR #6474: URL: https://github.com/apache/hadoop/pull/6474#discussion_r1470038367 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/exceptions/SchedulerInvalidResourceRequestException.java: ## @@ -29,19 +

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812007#comment-17812007 ] ASF GitHub Bot commented on HADOOP-18508: - hadoop-yetus commented on PR #5081:

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-1915323735 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811994#comment-17811994 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-29 Thread via GitHub
steveloughran commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915231977 thanks. not sure what is up with docker. will rebase and force push with test run -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-19049) Class loader leak caused by StatisticsDataReferenceCleaner thread

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811991#comment-17811991 ] ASF GitHub Bot commented on HADOOP-19049: - steveloughran commented on code in P

Re: [PR] HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak [hadoop]

2024-01-29 Thread via GitHub
steveloughran commented on code in PR #6488: URL: https://github.com/apache/hadoop/pull/6488#discussion_r146995 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4077,6 +4077,7 @@ private interface StatisticsAggregator {

[jira] [Updated] (HADOOP-18925) S3A: add option "fs.s3a.optimized.copy.from.local.enabled" to enable/disable CopyFromLocalOperation

2024-01-29 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18925: Summary: S3A: add option "fs.s3a.optimized.copy.from.local.enabled" to enable/disable Cop

[jira] [Commented] (HADOOP-19056) Highlight RBF features and improvements targeting version 3.4

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811985#comment-17811985 ] ASF GitHub Bot commented on HADOOP-19056: - tasanuma commented on PR #6512: URL:

Re: [PR] HADOOP-19056. Highlight RBF features and improvements targeting version 3.4. [hadoop]

2024-01-29 Thread via GitHub
tasanuma commented on PR #6512: URL: https://github.com/apache/hadoop/pull/6512#issuecomment-1915171671 @brahmareddybattula Thanks for your review. In the JIRA issues I highlighted, only HADOOP-13144 has been released in 3.3.5. However, I included it because HADOOP-13144, along with HDFS-

[jira] [Commented] (HADOOP-19056) Highlight RBF features and improvements targeting version 3.4

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811981#comment-17811981 ] ASF GitHub Bot commented on HADOOP-19056: - brahmareddybattula commented on PR #

Re: [PR] HADOOP-19056. Highlight RBF features and improvements targeting version 3.4. [hadoop]

2024-01-29 Thread via GitHub
brahmareddybattula commented on PR #6512: URL: https://github.com/apache/hadoop/pull/6512#issuecomment-1915130159 @tasanuma thanks for reporting this and collecting all these jira's. are these part of hadoop-3.3 itself..? -- This is an automated message from the Apache Git Service. T

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1915073995 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19045) S3A: pass request timeouts down to sdk clients

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811976#comment-17811976 ] ASF GitHub Bot commented on HADOOP-19045: - steveloughran commented on PR #6470:

Re: [PR] HADOOP-19045. S3A: Validate CreateSession Timeout Propagation [hadoop]

2024-01-29 Thread via GitHub
steveloughran commented on PR #6470: URL: https://github.com/apache/hadoop/pull/6470#issuecomment-1915066353 tested: s3 london. @mukund-thakur @hiteshs can you two look at this too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (HADOOP-19045) S3A: pass request timeouts down to sdk clients

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811975#comment-17811975 ] ASF GitHub Bot commented on HADOOP-19045: - steveloughran commented on PR #6470:

Re: [PR] HADOOP-19045. S3A: Validate CreateSession Timeout Propagation [hadoop]

2024-01-29 Thread via GitHub
steveloughran commented on PR #6470: URL: https://github.com/apache/hadoop/pull/6470#issuecomment-1915064957 it's similar, and that test was being (mistakenly) skipped locally as i don't have a default endpoint/region set. Not going to try and clean up the whole suite. * if I do set

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1915049414 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811968#comment-17811968 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915042017 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19022) S3A : ITestS3AConfiguration#testRequestTimeout failure

2024-01-29 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811963#comment-17811963 ] Steve Loughran commented on HADOOP-19022: - going to fix this, but also wonderi

Re: [PR] HDFS-17353. Fix failing RBF module tests. [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6491: URL: https://github.com/apache/hadoop/pull/6491#issuecomment-1914838445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-17707) Remove jaeger document from site index

2024-01-29 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-17707: Hadoop Flags: Reviewed > Remove jaeger document from site index > ---

[jira] [Updated] (HADOOP-17730) [thirdparty] Do not exclude error_prone

2024-01-29 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-17730: Component/s: hadoop-thirdparty > [thirdparty] Do not exclude error_prone > --

[jira] [Updated] (HADOOP-17707) Remove jaeger document from site index

2024-01-29 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-17707: Component/s: hadoop-thirdparty > Remove jaeger document from site index > ---

[jira] [Updated] (HADOOP-17707) Remove jaeger document from site index

2024-01-29 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-17707: Affects Version/s: thirdparty-1.1.1 thirdparty-1.2.0 > Remove jaeger docum

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914767780 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811889#comment-17811889 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on code in P

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-29 Thread via GitHub
steveloughran commented on code in PR #6144: URL: https://github.com/apache/hadoop/pull/6144#discussion_r1469632159 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestSelectUnsupported.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

Re: [PR] HDFS-17146.Use the dfsadmin -reconfig command to initiate reconfiguration on all decommissioning datanodes. [hadoop]

2024-01-29 Thread via GitHub
zhtttylz commented on code in PR #6504: URL: https://github.com/apache/hadoop/pull/6504#discussion_r1469631441 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java: ## @@ -1283,4 +1285,90 @@ public void testAllDatanodesReconfig() A

[jira] [Updated] (HADOOP-19046) S3A: update AWS sdk versions to 2.23.5 and 1.12.599

2024-01-29 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19046: Fix Version/s: 3.4.1 > S3A: update AWS sdk versions to 2.23.5 and 1.12.599 >

[jira] [Commented] (HADOOP-19056) Highlight RBF features and improvements targeting version 3.4

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811884#comment-17811884 ] ASF GitHub Bot commented on HADOOP-19056: - tasanuma commented on PR #6512: URL:

Re: [PR] HADOOP-19056. Highlight RBF features and improvements targeting version 3.4. [hadoop]

2024-01-29 Thread via GitHub
tasanuma commented on PR #6512: URL: https://github.com/apache/hadoop/pull/6512#issuecomment-1914732401 @slfan1989 I understand. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] YARN-11362: Fix several typos in YARN codebase of misspelled resource [hadoop]

2024-01-29 Thread via GitHub
slfan1989 commented on code in PR #6474: URL: https://github.com/apache/hadoop/pull/6474#discussion_r1469607772 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/exceptions/SchedulerInvalidResourceRequestException.java: ## @@ -29,19 +29,19 @

Re: [PR] YARN-11653. Add Totoal_Memory and Total_Vcores columns in Nodes page [hadoop]

2024-01-29 Thread via GitHub
slfan1989 commented on PR #6501: URL: https://github.com/apache/hadoop/pull/6501#issuecomment-1914716020 @yangjiandan Can we trigger compilation again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-29 Thread via GitHub
slfan1989 commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1914714875 @yangjiandan Thanks for the contribution! merged into trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-29 Thread via GitHub
slfan1989 merged PR #6490: URL: https://github.com/apache/hadoop/pull/6490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-19056) Highlight RBF features and improvements targeting version 3.4

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811872#comment-17811872 ] ASF GitHub Bot commented on HADOOP-19056: - slfan1989 commented on PR #6512: URL

Re: [PR] HADOOP-19056. Highlight RBF features and improvements targeting version 3.4. [hadoop]

2024-01-29 Thread via GitHub
slfan1989 commented on PR #6512: URL: https://github.com/apache/hadoop/pull/6512#issuecomment-1914709989 > @slfan1989 I'm really sorry for being late, but if there is a chance to incorporate changes into 3.4.0, could you consider including this PR? If RC1 has already been created, perhaps i

[jira] [Commented] (HADOOP-14837) Handle S3A "glacier" data

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811860#comment-17811860 ] ASF GitHub Bot commented on HADOOP-14837: - ahmarsuhail commented on code in PR

Re: [PR] HADOOP-14837 : Support Read Restored Glacier Objects [hadoop]

2024-01-29 Thread via GitHub
ahmarsuhail commented on code in PR #6407: URL: https://github.com/apache/hadoop/pull/6407#discussion_r1469491275 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -581,6 +583,12 @@ public void initialize(URI name, Configuration origina

Re: [PR] HDFS-17353. Fix failing RBF module tests. [hadoop]

2024-01-29 Thread via GitHub
ssanchozz commented on code in PR #6491: URL: https://github.com/apache/hadoop/pull/6491#discussion_r1469489965 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java: ## @@ -2074,9 +2074,6 @@ public void testMkdir

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914526790 > > Contributor > > Hi, sir. IIUC, it is safe. The reason is as below, original code is : > > ```java > ExtendedBlock newBlock = new ExtendedBlock(bpid, block.getB

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hfutatzhanghb commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914526737 > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java#L441 > > ``` > fi

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hfutatzhanghb commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914520297 > Contributor Hi, sir. IIUC, it is safe. The reason is as below, original code is : ```java ExtendedBlock newBlock = new ExtendedBlock(bpid, block.getBlockId(),

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914512212 @Hexiaoqiao @ZanderXu @zhangshuyan0 @tasanuma can you please take a look at this PR when you have free time? Thanks~ -- This is an automated message from the Apache Git Service. To r

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914509936 The failed unit test seems unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17360. Record the number of times a block is read during a certain time period. [hadoop]

2024-01-29 Thread via GitHub
huangzhaobo99 commented on PR #6505: URL: https://github.com/apache/hadoop/pull/6505#issuecomment-1914509805 > Thanks for your contribution, but I don't quite understand why this metric needs to be added to jmx. If you only want to obtain the blocks that are frequently accessed during a cer

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914507289 I have a little question. https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.jav

[jira] [Commented] (HADOOP-19044) AWS SDK V2 - Update S3A region logic

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811827#comment-17811827 ] ASF GitHub Bot commented on HADOOP-19044: - ahmarsuhail commented on code in PR

Re: [PR] HADOOP-19044. AWS SDK V2 - Update S3A region logic [hadoop]

2024-01-29 Thread via GitHub
ahmarsuhail commented on code in PR #6479: URL: https://github.com/apache/hadoop/pull/6479#discussion_r1469449899 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java: ## @@ -257,6 +275,44 @@ public void testWithVPCE() throws Throwable {

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hfutatzhanghb commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914451743 Thanks a lot for responsing, Sir. Will add an UT soonly. Replied Message | From | ***@***.***> | | Date | 01/29/2024 18:45 | | To | ***@***.***> |

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914428268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-01-29 Thread via GitHub
hfutatzhanghb commented on PR #6509: URL: https://github.com/apache/hadoop/pull/6509#issuecomment-1914341592 @Hexiaoqiao @zhangshuyan0 @tomscut Sir, could you please take a look at this PR when you have free time? Thanks a lot. -- This is an automated message from the Apache Git Service.

Re: [PR] HDFS-17342. Fix DataNode may invalidates normal block causing missing block [hadoop]

2024-01-29 Thread via GitHub
zhangshuyan0 commented on PR #6464: URL: https://github.com/apache/hadoop/pull/6464#issuecomment-1914338798 Hi @smarthanwang , do you have any further comments on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (HADOOP-18993) Allow to not isolate S3AFileSystem classloader when needed

2024-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811787#comment-17811787 ] ASF GitHub Bot commented on HADOOP-18993: - tmnd1991 commented on PR #6301: URL:

Re: [PR] HADOOP-18993 Allow to not isolate S3AFileSystem classloader when needed [hadoop]

2024-01-29 Thread via GitHub
tmnd1991 commented on PR #6301: URL: https://github.com/apache/hadoop/pull/6301#issuecomment-1914283535 Hi @steveloughran will you have any time to review this soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HDFS-17362. RBF: RouterObserverReadProxyProvider should use ConfiguredFailoverProxyProvider internally [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6510: URL: https://github.com/apache/hadoop/pull/6510#issuecomment-1914273925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17353. Fix failing RBF module tests. [hadoop]

2024-01-29 Thread via GitHub
ssanchozz commented on code in PR #6491: URL: https://github.com/apache/hadoop/pull/6491#discussion_r1469233706 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpcMultiDestination.java: ## @@ -475,7 +475,7 @@ public