[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821983#comment-17821983 ] ASF GitHub Bot commented on HADOOP-19085: - hadoop-yetus commented on PR #6535: URL:

Re: [PR] HDFS-17316 Add hadoop-compat-bench [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6535: URL: https://github.com/apache/hadoop/pull/6535#issuecomment-1970586476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17405. [FGL] Using different metric name to trace performance for FGL and Global lock [hadoop]

2024-02-28 Thread via GitHub
ZanderXu opened a new pull request, #6600: URL: https://github.com/apache/hadoop/pull/6600 HDFS-17405. [FGL] Using different metric name to trace performance for FGL and Global lock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-19074) Transitive dependencies with CVEs in Hadoop distro

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821966#comment-17821966 ] ASF GitHub Bot commented on HADOOP-19074: - prathapsagar commented on PR #6586: URL:

Re: [PR] Commit to remove vulnerabilities raised for: HADOOP-19074 [hadoop]

2024-02-28 Thread via GitHub
prathapsagar commented on PR #6586: URL: https://github.com/apache/hadoop/pull/6586#issuecomment-1970530948 Hi @dineshchitlangia I have resolved the check style violation and raised a new PR with the changes please validate: https://github.com/apache/hadoop/pull/6586 -- This is an

Re: [PR] [ABFS][CST Optimization] Enhancing Client-Side Metrics Updating Logic [hadoop]

2024-02-28 Thread via GitHub
anujmodi2021 commented on code in PR #6276: URL: https://github.com/apache/hadoop/pull/6276#discussion_r1507087975 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperationMockFailures.java: ## @@ -35,35 +35,25 @@ import static

[PR] HDFS-17398. [FGL] Implement the FGL lock for FSNLockManager [hadoop]

2024-02-28 Thread via GitHub
ZanderXu opened a new pull request, #6599: URL: https://github.com/apache/hadoop/pull/6599 HDFS-17398. [FGL] Implement the FGL lock for FSNLockManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821944#comment-17821944 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-28 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1970491157 > > You also need to add following test configuration to specify the account type you are using `fs.azure.test.namespace.enabled "` > > ``` > > > >

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-28 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821935#comment-17821935 ] Syed Shameerur Rahman commented on HADOOP-19091: [~vnarayanan7] - Can you share the

[jira] [Comment Edited] (HADOOP-19018) Release Hadoop 3.4.0

2024-02-28 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821932#comment-17821932 ] Shilun Fan edited comment on HADOOP-19018 at 2/29/24 5:28 AM: --

[jira] [Commented] (HADOOP-19018) Release Hadoop 3.4.0

2024-02-28 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821932#comment-17821932 ] Shilun Fan commented on HADOOP-19018: - [~ste...@apache.org] after careful consideration of Steve's

Re: [PR] HDFS-17396. BootstrapStandby should download rollback image during RollingUpgrade [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6583: URL: https://github.com/apache/hadoop/pull/6583#issuecomment-1970174103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17404. Add Namenode Index to log message when setting block keys [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1970162166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17396. BootstrapStandby should download rollback image during RollingUpgrade [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6583: URL: https://github.com/apache/hadoop/pull/6583#issuecomment-1969580312 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19094) Update DN to report which NN has provided the updated block keys

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19094: Labels: pull-request-available (was: ) > Update DN to report which NN has provided the

[jira] [Commented] (HADOOP-19094) Update DN to report which NN has provided the updated block keys

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821785#comment-17821785 ] ASF GitHub Bot commented on HADOOP-19094: - Jtdellaringa opened a new pull request, #6598: URL:

[PR] HADOOP-19094. Add Namenode Index to log message when setting block keys [hadoop]

2024-02-28 Thread via GitHub
Jtdellaringa opened a new pull request, #6598: URL: https://github.com/apache/hadoop/pull/6598 ### Description of PR Adds namenode index as class variable to BlockTokenSecretManager and logs it when setting block keys. ### How was this patch tested? n/a ### For code

Re: [PR] HADOOP-18980. Invalid inputs for getTrimmedStringCollectionSplitByEquals (ADDENDUM) [hadoop]

2024-02-28 Thread via GitHub
virajjasani commented on PR #6546: URL: https://github.com/apache/hadoop/pull/6546#issuecomment-1969376821 @steveloughran the PR is ready for another round of review if you have some bandwidth. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (HADOOP-19095) hadoop-aws: downgrade openssl export to test

2024-02-28 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19095: --- Summary: hadoop-aws: downgrade openssl export to test Key: HADOOP-19095 URL: https://issues.apache.org/jira/browse/HADOOP-19095 Project: Hadoop Common

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821727#comment-17821727 ] ASF GitHub Bot commented on HADOOP-19085: - hadoop-yetus commented on PR #6535: URL:

Re: [PR] HDFS-17316 Add hadoop-compat-bench [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6535: URL: https://github.com/apache/hadoop/pull/6535#issuecomment-1969265732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19090. Follow-up: docs and license [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran merged PR #35: URL: https://github.com/apache/hadoop-thirdparty/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] HADOOP-19090. Follow-up: docs and license [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran opened a new pull request, #35: URL: https://github.com/apache/hadoop-thirdparty/pull/35 Followup to #34 Update LICENSE-binary and site index.md.vm with protobuf update Also: * reviewed src/site/site.xml; updated links and moved to https URLs *

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1968986534 actually, just reset the branch to HEAD^ to lose the license change; force pushed it (!). need to update site docs too, see. will do a proper PR -- This is an automated

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1968979867 merged. Then had to do a quick followup patch (same JIRA) to update the LICENSE-binary file. Thought that was easier than doing a revert, cherrypick with the license patch

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-28 Thread Han Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821664#comment-17821664 ] Han Liu commented on HADOOP-19085: -- Thanks for comments from [~drankye]  {quote}Let's do in favor of

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1968944407 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19018) Release Hadoop 3.4.0

2024-02-28 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821634#comment-17821634 ] Shilun Fan commented on HADOOP-19018: - [~ste...@apache.org] Thank you for addressing this issue! I

[jira] [Commented] (HADOOP-19018) Release Hadoop 3.4.0

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821625#comment-17821625 ] Steve Loughran commented on HADOOP-19018: - HADOOP-19018 covers a problem with the new shaded

[jira] [Comment Edited] (HADOOP-19018) Release Hadoop 3.4.0

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821625#comment-17821625 ] Steve Loughran edited comment on HADOOP-19018 at 2/28/24 11:56 AM: ---

[jira] [Assigned] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-19090: --- Assignee: PJ Fanning > Update Protocol Buffers installation to 3.23.4 >

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran merged PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19091: Affects Version/s: (was: 3.4.0) > Add support for Tez to MagicS3GuardCommitter >

[jira] [Assigned] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-19091: --- Assignee: Venkatasubrahmanian Narayanan > Add support for Tez to

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821619#comment-17821619 ] Steve Loughran commented on HADOOP-19091: - [~vnarayanan7] * everything has to be done via

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-1968731068 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] [ABFS][CST Optimization] Enhancing Client-Side Metrics Updating Logic [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6276: URL: https://github.com/apache/hadoop/pull/6276#issuecomment-1968691147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-02-28 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1968643693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401 Erasure Coding: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-02-28 Thread via GitHub
RuinanGu commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1968600059 @jojochuang @tomscut Could you please take a look?The failed UT seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-02-28 Thread via GitHub
xleoken commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-1968580428 @ZanderXu please take a review, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the