[jira] [Commented] (HADOOP-19066) AWS SDK V2 - Enabling FIPS should be allowed with central endpoint

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824646#comment-17824646 ] ASF GitHub Bot commented on HADOOP-19066: - virajjasani commented on PR #6539: U

Re: [PR] HADOOP-19066. S3A: AWS SDK V2 - Enabling FIPS should be allowed with central endpoint [hadoop]

2024-03-07 Thread via GitHub
virajjasani commented on PR #6539: URL: https://github.com/apache/hadoop/pull/6539#issuecomment-1985209550 @ahmarsuhail @mukund-thakur could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Add Shuyan Zhang to Committer List. [hadoop-site]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #52: URL: https://github.com/apache/hadoop-site/pull/52#issuecomment-1985107577 Committed. Thanks all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add Shuyan Zhang to Committer List. [hadoop-site]

2024-03-07 Thread via GitHub
Hexiaoqiao merged PR #52: URL: https://github.com/apache/hadoop-site/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@h

[jira] [Updated] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19102: Labels: pull-request-available (was: ) > [ABFS]: FooterReadBufferSize should not be grea

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824625#comment-17824625 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav opened a new pull reque

[PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-03-07 Thread via GitHub
saxenapranav opened a new pull request, #6617: URL: https://github.com/apache/hadoop/pull/6617 JIRA: https://issues.apache.org/jira/browse/HADOOP-19102 The method `optimisedRead` creates a buffer array of size `readBufferSize`. If footerReadBufferSize is greater than readBufferSize, a

[jira] [Updated] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-07 Thread Pranav Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena updated HADOOP-19102: --- Description: The method `optimisedRead` creates a buffer array of size `readBufferSize`. If

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-07 Thread Kai Zheng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824611#comment-17824611 ] Kai Zheng commented on HADOOP-19085: [~han.liu] Good work! Just a minor, would you

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824610#comment-17824610 ] ASF GitHub Bot commented on HADOOP-19050: - adnanhemani commented on code in PR

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-07 Thread via GitHub
adnanhemani commented on code in PR #6544: URL: https://github.com/apache/hadoop/pull/6544#discussion_r1517130806 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1624,4 +1624,21 @@ private Constants() { * Value: {@value}. */ pu

[PR] Add Shuyan Zhang to Committer List. [hadoop-site]

2024-03-07 Thread via GitHub
Hexiaoqiao opened a new pull request, #52: URL: https://github.com/apache/hadoop-site/pull/52 Shuyan Zhang is one of Committers[1], but not update site yet. [1] https://lists.apache.org/thread/33lfm5dlkhybq55jh3vf13fsg5f3q5tl -- This is an automated message from the Apache Git Servi

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824609#comment-17824609 ] ASF GitHub Bot commented on HADOOP-16822: - pan3793 commented on PR #6458: URL:

Re: [PR] Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-03-07 Thread via GitHub
pan3793 commented on PR #6458: URL: https://github.com/apache/hadoop/pull/6458#issuecomment-1984979072 I think we already reached the consensus in the JIRA discussion, could any committer take a look? cc @slfan1989 @sunchao -- This is an automated message from the Apache Git Se

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
ThinkerLei commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1984976217 > Hi @ThinkerLei , Please check if the failed unite tests are related with this changes. @Hexiaoqiao Thanks for your reply, I will work on this soon. -- This is an automated m

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1984973314 Hi @ThinkerLei , Please check if the failed unite tests are related with this changes. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1984971681 @szetszwo Thanks for your response. > This may not be acceptable in some use cases since the newly created files will be lost (i.e. data loss) if we recover from an earlier fsimag

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6514: URL: https://github.com/apache/hadoop/pull/6514#issuecomment-1984965658 > @Hexiaoqiao @zhangshuyan0 Thanks for your reviews. I realized there's also an ElasticBufferPool in DFSStripedOutputStream. I'm thinking of handling that here as well. What do you thin

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on code in PR #6514: URL: https://github.com/apache/hadoop/pull/6514#discussion_r1517110356 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java: ## @@ -3159,6 +3165,21 @@ private void initThreadsNumForStripedReads(in

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824600#comment-17824600 ] ASF GitHub Bot commented on HADOOP-15984: - hadoop-yetus commented on PR #6606:

Re: [PR] HADOOP-15984. Update jersey from 1.19 to 2.x [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6606: URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1984948590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984392158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
ritegarg commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984310623 > There are few test failures. Can you please take a look? @ritegarg I was looking into the failures, looks like transient failures. The same tests are running fine locally. --

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
shahrs87 commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984012754 There are few test failures. Can you please take a look? @ritegarg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824477#comment-17824477 ] ASF GitHub Bot commented on HADOOP-19050: - steveloughran commented on code in P

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-07 Thread via GitHub
steveloughran commented on code in PR #6544: URL: https://github.com/apache/hadoop/pull/6544#discussion_r1516477473 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1624,4 +1624,21 @@ private Constants() { * Value: {@value}. */

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1983993404 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824472#comment-17824472 ] ASF GitHub Bot commented on HADOOP-19050: - steveloughran commented on PR #6544:

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-07 Thread via GitHub
steveloughran commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-1983988376 Test results. thanks for these. you only need failures. (we don't care about successes unless something has got very slow) * rebase on trunk; you need "HADOOP-19057. S3A: Lands

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1983953951 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19050. SDK Add Support for AWS S3 Access Grants [hadoop]

2024-03-07 Thread via GitHub
steveloughran closed pull request #6507: HADOOP-19050. SDK Add Support for AWS S3 Access Grants URL: https://github.com/apache/hadoop/pull/6507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-07 Thread via GitHub
szetszwo commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1983883646 @Hexiaoqiao , thanks for review this! > ... We should recover from other fsimages first if one fsimage file is corrupted ... This may not be acceptable in some use cases sinc

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983825438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1983822417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6616: URL: https://github.com/apache/hadoop/pull/6616#issuecomment-1983768684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-1983704408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-19104) S3A HeaderProcessing to process all metadata entries of HEAD response

2024-03-07 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19104: Description: S3A HeaderProcessing builds up an incomplete list of headers as its mapping

[jira] [Created] (HADOOP-19104) S3A HeaderProcessing to process all metadata entries of HEAD response

2024-03-07 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19104: --- Summary: S3A HeaderProcessing to process all metadata entries of HEAD response Key: HADOOP-19104 URL: https://issues.apache.org/jira/browse/HADOOP-19104 Project

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-1983568709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17391:Adjust the checkpoint io buffer size to the chunk size [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6594: URL: https://github.com/apache/hadoop/pull/6594#issuecomment-1983556930 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824421#comment-17824421 ] ASF GitHub Bot commented on HADOOP-18708: - ahmarsuhail commented on PR #6164: U

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2024-03-07 Thread via GitHub
ahmarsuhail commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1983551593 Thanks @steveloughran . While looking at the test failures, I found a couple of issues with S3 Encryption Client, opened https://github.com/aws/amazon-s3-encryption-client-java/issues/

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
bbeaudreault commented on PR #6514: URL: https://github.com/apache/hadoop/pull/6514#issuecomment-1983545666 @Hexiaoqiao @zhangshuyan0 Thanks for your reviews. I realized there's also an ElasticBufferPool in DFSStripedOutputStream. I'm thinking of handling that here as well. What do you thin

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
bbeaudreault commented on code in PR #6514: URL: https://github.com/apache/hadoop/pull/6514#discussion_r1516181907 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java: ## @@ -3159,6 +3165,21 @@ private void initThreadsNumForStripedReads(

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-1983540085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
bbeaudreault commented on code in PR #6514: URL: https://github.com/apache/hadoop/pull/6514#discussion_r1516179674 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java: ## @@ -530,6 +530,9 @@ interface StripedRead {

Re: [PR] HDFS-17368. HA: Standby should exit safemode when resources are from low available [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on code in PR #6518: URL: https://github.com/apache/hadoop/pull/6518#discussion_r1516122704 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -1582,6 +1582,10 @@ void startStandbyServices(final C

Re: [PR] HDFS-17364. EC: Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on code in PR #6514: URL: https://github.com/apache/hadoop/pull/6514#discussion_r1516099526 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java: ## @@ -530,6 +530,9 @@ interface StripedRead {

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-03-07 Thread via GitHub
haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1516059534 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,82 @@ public void testRe

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824381#comment-17824381 ] ASF GitHub Bot commented on HADOOP-15984: - hadoop-yetus commented on PR #6606:

Re: [PR] HADOOP-15984. Update jersey from 1.19 to 2.x [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6606: URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1983367997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-07 Thread via GitHub
XbaoWu commented on PR #6577: URL: https://github.com/apache/hadoop/pull/6577#issuecomment-1983324064 > Hi @XbaoWu Please submit PR to trunk first, if approved and committed to trunk, then backport to other active branches if necessary. Okay, thank you for your reminder -- This is

[PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-07 Thread via GitHub
XbaoWu opened a new pull request, #6616: URL: https://github.com/apache/hadoop/pull/6616 ### Description of PR For more information about this PR, please refer to the following issue: [YARN-11626](https://issues.apache.org/jira/browse/YARN-11626) Optimization of the safeDel

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1983209877 Hi @szetszwo , Thanks for your works. I am not sure if this is one safe operations. Now it keeps at least 2 checkpoints by default(dfs.namenode.num.checkpoints.retained), it configs to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1983180401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824341#comment-17824341 ] ASF GitHub Bot commented on HADOOP-19090: - ayushtkn merged PR #6593: URL: https

[jira] [Resolved] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-19090. --- Fix Version/s: 3.4.1 Hadoop Flags: Reviewed Resolution: Fixed > Update Protocol

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824343#comment-17824343 ] Ayush Saxena commented on HADOOP-19090: --- Committed to trunk. Thanx [~pj.fanning]

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-07 Thread via GitHub
ayushtkn merged PR #6593: URL: https://github.com/apache/hadoop/pull/6593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6577: URL: https://github.com/apache/hadoop/pull/6577#issuecomment-1983061802 Hi @XbaoWu Please submit PR to trunk first, if approved and committed to trunk, then backport to other active branches if necessary. -- This is an automated message from the Apache Gi

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983018540 Some nit point: It will be helpful for reviewers when add some description about this improvement background and target. If offer benchmark result will be better. -- This is an autom

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983003619 Thanks @ThinkerLei for your works. It's great performance improvement! The last CI didn't run clean, try to trigger it again. Let's wait what it will say. -- This is an automated mess

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1982845035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6613: URL: https://github.com/apache/hadoop/pull/6613#issuecomment-1982836474 Hi @ritegarg Thanks for your PR. branch-3.2 has been EOL. We should not submit PR to this branch. I will close this one. Please feel free to reopen it if something I missed. Thanks agai

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao closed pull request #6613: HDFS-17299. Adding rack failure tolerance when creating a new file (… URL: https://github.com/apache/hadoop/pull/6613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to