Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2014358463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829741#comment-17829741 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on PR #6409: URL:

Re: [PR] HADOOP-18656: [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-03-21 Thread via GitHub
anujmodi2021 commented on PR #6409: URL: https://github.com/apache/hadoop/pull/6409#issuecomment-2014318061 Hi @steveloughran @mukund-thakur Requesting you review on this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829740#comment-17829740 ] ASF GitHub Bot commented on HADOOP-19096: - anujmodi2021 commented on PR #6276: URL:

Re: [PR] HADOOP-19096: [ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-03-21 Thread via GitHub
anujmodi2021 commented on PR #6276: URL: https://github.com/apache/hadoop/pull/6276#issuecomment-2014317616 Hi @steveloughran , @mukund-thakur Requesting you to kindly review this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] HDFS-17438. RBF: The latest STANDBY and UNAVAILABLE nn should be the lowest prior… [hadoop]

2024-03-21 Thread via GitHub
KeeProMise opened a new pull request, #6655: URL: https://github.com/apache/hadoop/pull/6655 …ity. ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue

[jira] [Resolved] (HADOOP-19121) RBF: The latest STANDBY and UNAVAILABLE nn should be the lowest priority.

2024-03-21 Thread Jian Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jian Zhang resolved HADOOP-19121. - Resolution: Abandoned > RBF: The latest STANDBY and UNAVAILABLE nn should be the lowest

[jira] [Created] (HADOOP-19121) RBF: The latest STANDBY and UNAVAILABLE nn should be the lowest priority.

2024-03-21 Thread Jian Zhang (Jira)
Jian Zhang created HADOOP-19121: --- Summary: RBF: The latest STANDBY and UNAVAILABLE nn should be the lowest priority. Key: HADOOP-19121 URL: https://issues.apache.org/jira/browse/HADOOP-19121 Project:

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2014276916 merged. Thanks @XbaoWu for your contribution. Thanks @slfan1989 @hiwangzhihui for your review. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
ZanderXu merged PR #6651: URL: https://github.com/apache/hadoop/pull/6651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19060) Support hadoop client authentication through keytab configuration.

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829731#comment-17829731 ] ASF GitHub Bot commented on HADOOP-19060: - huangzhaobo99 commented on PR #6516: URL:

Re: [PR] HADOOP-19060. Support hadoop client authentication through keytab configuration. [hadoop]

2024-03-21 Thread via GitHub
huangzhaobo99 commented on PR #6516: URL: https://github.com/apache/hadoop/pull/6516#issuecomment-2014275071 Can anyone help review it? Thanks. Hi @tasanuma @Hexiaoqiao @zhangshuyan0 @slfan1989, Please kindly review this PR as well if you have bandwidth, Thanks. -- This is an

[PR] HDFS-17415. [FGL] RPCs in NamenodeProtocol support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu opened a new pull request, #6654: URL: https://github.com/apache/hadoop/pull/6654 [FGL] RPCs in NamenodeProtocol support fine-grained lock. - getBlocks - getBlockKeys - getTransactionID - getMostRecentCheckpointTxId - rollEditLog - versionRequest -

[jira] [Commented] (HADOOP-19093) Improve rate limiting through ABFS in Manifest Committer

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829728#comment-17829728 ] ASF GitHub Bot commented on HADOOP-19093: - hadoop-yetus commented on PR #6596: URL:

Re: [PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6596: URL: https://github.com/apache/hadoop/pull/6596#issuecomment-2014253128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014192895 > CI reported checkstyle issue. can also fix that. Thanks Done, please help me review it again, thanks -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-17423. [FGL] BlockManagerSafeMode supports fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6645: URL: https://github.com/apache/hadoop/pull/6645#issuecomment-2014187264 @ZanderXu seems failed cases are related to this PR. could you check it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6641: URL: https://github.com/apache/hadoop/pull/6641#issuecomment-2014183343 Thanks for contribution. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6641: URL: https://github.com/apache/hadoop/pull/6641#issuecomment-2014182167 Failed cases are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui merged PR #6641: URL: https://github.com/apache/hadoop/pull/6641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6641: URL: https://github.com/apache/hadoop/pull/6641#issuecomment-2014181960 TestLargeBlockReport tracking in https://issues.apache.org/jira/browse/HDFS-17437 TestDFSAdmin is fixed by HDFS-17422 TestBlockListAsLongs#testFuzz seems the same reason as

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014172936 CI reported checkstyle issue. can also fix that. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2014043907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19093) Improve rate limiting through ABFS in Manifest Committer

2024-03-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19093: Affects Version/s: 3.4.0 (was: 3.3.6) > Improve rate limiting

[jira] [Updated] (HADOOP-19093) Improve rate limiting through ABFS in Manifest Committer

2024-03-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19093: Summary: Improve rate limiting through ABFS in Manifest Committer (was: add load tests

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829701#comment-17829701 ] Steve Loughran commented on HADOOP-19120: - if we move to java11 there's apparently a better one

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2013949219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17365. EC: Add extra redunency configuration in checkStreamerFailures to prevent data loss. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6517: URL: https://github.com/apache/hadoop/pull/6517#issuecomment-2013783212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17365. EC: Add extra redunency configuration in checkStreamerFailures to prevent data loss. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6517: URL: https://github.com/apache/hadoop/pull/6517#issuecomment-2013759811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2013690866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2013679333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829676#comment-17829676 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in PR #6494: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-03-21 Thread via GitHub
mukund-thakur commented on code in PR #6494: URL: https://github.com/apache/hadoop/pull/6494#discussion_r1532928858 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -5457,7 +5421,11 @@ public boolean hasPathCapability(final Path path,

Re: [PR] YARN-11261 Avoid unnecessary reconstruction of ConfigurationProperties [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6652: URL: https://github.com/apache/hadoop/pull/6652#issuecomment-2013027918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2012952640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2012824210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-03-21 Thread via GitHub
ThinkerLei opened a new pull request, #6653: URL: https://github.com/apache/hadoop/pull/6653 In this pr , we do not consider the cases where the source directory is a symlink or involves snapshot in rename. There are currently two methods of rename, and their logic for calculating

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
ThinkerLei closed pull request #6608: HDFS-17408. Reduce quota calculation times in FSDirRenameOp. URL: https://github.com/apache/hadoop/pull/6608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17365. EC: Add extra redunency configuration in checkStreamerFailures to prevent data loss. [hadoop]

2024-03-21 Thread via GitHub
hfutatzhanghb commented on code in PR #6517: URL: https://github.com/apache/hadoop/pull/6517#discussion_r1534166846 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -3908,6 +3908,18 @@ + +

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2012579307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19111) ipc client print client info message duplicate

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829600#comment-17829600 ] ASF GitHub Bot commented on HADOOP-19111: - ayushtkn commented on PR #6630: URL:

Re: [PR] HADOOP-19111,HDFS-17429. Removing redundant debug message about client info(19111) & Fixing wrong log file name in datatransfer Sender.java(17429) [hadoop]

2024-03-21 Thread via GitHub
ayushtkn commented on PR #6630: URL: https://github.com/apache/hadoop/pull/6630#issuecomment-2012565023 If two tickets and two different issues, better to merge separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2012552601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17414. [FGL] RPCs in DatanodeProtocol support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6649: URL: https://github.com/apache/hadoop/pull/6649#issuecomment-2012482210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2012475574 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11261 Avoid unnecessary reconstruction of ConfigurationProperties [hadoop]

2024-03-21 Thread via GitHub
K0K0V0K opened a new pull request, #6652: URL: https://github.com/apache/hadoop/pull/6652 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2012334945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-21 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829565#comment-17829565 ] Shilun Fan commented on HADOOP-15984: - I will continue to follow up on HADOOP-15984. > Update

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829564#comment-17829564 ] ASF GitHub Bot commented on HADOOP-15984: - slfan1989 closed pull request #6606: HADOOP-15984.

Re: [PR] HADOOP-15984. Update jersey from 1.19 to 2.x [hadoop]

2024-03-21 Thread via GitHub
slfan1989 closed pull request #6606: HADOOP-15984. Update jersey from 1.19 to 2.x URL: https://github.com/apache/hadoop/pull/6606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-19111) ipc client print client info message duplicate

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829561#comment-17829561 ] ASF GitHub Bot commented on HADOOP-19111: - slfan1989 commented on PR #6630: URL:

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2012303030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19111,HDFS-17429. Removing redundant debug message about client info(19111) & Fixing wrong log file name in datatransfer Sender.java(17429) [hadoop]

2024-03-21 Thread via GitHub
slfan1989 commented on PR #6630: URL: https://github.com/apache/hadoop/pull/6630#issuecomment-2012302076 @wzk784533 LGTM, I think we should split it into 2 separate PRs for submission. I will need to wait for @ayushtkn Opinion. -- This is an automated message from the Apache Git Service.

[PR] Change Stable to hadoop 3.3.6. [hadoop-site]

2024-03-21 Thread via GitHub
slfan1989 opened a new pull request, #55: URL: https://github.com/apache/hadoop-site/pull/55 Change Stable to hadoop 3.3.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HDFS-17430. RecoveringBlock will skip no live replicas when get block recovery command. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6635: URL: https://github.com/apache/hadoop/pull/6635#issuecomment-2012266961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19120: Labels: pull-request-available (was: ) > [ABFS]: ApacheHttpClient adaptation as network

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829551#comment-17829551 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633: URL:

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
qiuliang988 closed pull request #6648: YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application URL: https://github.com/apache/hadoop/pull/6648 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2012250055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
qiuliang988 commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2012249877 > @qiuliang988 Thank you for your contribution! but I'm sorry, I do not agree with this change. We cannot always maintain backward compatibility, and the best approach would be to

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829547#comment-17829547 ] ASF GitHub Bot commented on HADOOP-19052: - slfan1989 commented on PR #6587: URL:

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2012241859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-21 Thread via GitHub
slfan1989 commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-2012241824 LGTM. @liangyu-1 According to the process, we need to wait for 2 working days. If there are no further feedback, we will merge this PR. -- This is an automated message from

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
slfan1989 commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2012235777 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
slfan1989 commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2012203074 @qiuliang988 Thank you for your contribution! but I'm sorry, I do not agree with this change. We cannot always maintain backward compatibility, and the best approach would be to find a

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
zhangshuyan0 commented on code in PR #6608: URL: https://github.com/apache/hadoop/pull/6608#discussion_r1533779361 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -88,13 +96,19 @@ private static void

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2011932156 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2011925968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-03-21 Thread Pranav Saxena (Jira)
Pranav Saxena created HADOOP-19120: -- Summary: [ABFS]: ApacheHttpClient adaptation as network library Key: HADOOP-19120 URL: https://issues.apache.org/jira/browse/HADOOP-19120 Project: Hadoop Common

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533604421 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2011859573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17436. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
XbaoWu commented on PR #6651: URL: https://github.com/apache/hadoop/pull/6651#issuecomment-2011844402 > This is beneficial for troubleshooting issues with external authentication components, and this log is necessary; However, printing a large number of authentication failure logs is a

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-2011838129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2011794862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17435. Fix TestRouterRpc#testClearStaleNamespacesInRouterStateIdContext() failed [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6650: URL: https://github.com/apache/hadoop/pull/6650#issuecomment-2011742132 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2011738526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533487337 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java: ## @@ -2150,7 +2155,7 @@ int

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533484754 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533464091 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand

Re: [PR] HDFS-17435. Fix TestRouterRpc#testClearStaleNamespacesInRouterStateIdContext() failed [hadoop]

2024-03-21 Thread via GitHub
tasanuma commented on PR #6650: URL: https://github.com/apache/hadoop/pull/6650#issuecomment-2011648612 Hi @simbadzina and @zhangshuyan0. Could you review it when you have bandwidth? This is caused by HDFS-17354. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2011634130 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19109) checkPermission should not ignore original AccessControlException

2024-03-21 Thread Xiaobao Wu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobao Wu updated HADOOP-19109: Component/s: (was: hdfs-client) > checkPermission should not ignore original

[jira] [Commented] (HADOOP-19109) checkPermission should not ignore original AccessControlException

2024-03-21 Thread wangzhihui (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829426#comment-17829426 ] wangzhihui commented on HADOOP-19109: - [~wuxiaobao]  Please update the correct Component options.

Re: [PR] HDFS-17430. RecoveringBlock will skip no live replicas when get block recovery command. [hadoop]

2024-03-21 Thread via GitHub
haiyang1987 commented on PR #6635: URL: https://github.com/apache/hadoop/pull/6635#issuecomment-2011611948 Update PR. Hi @ZanderXu @Hexiaoqiao @dineshchitlangia please help me review this PR again when you have free time, Thank you very much. -- This is an automated message from

[jira] [Updated] (HADOOP-19109) checkPermission should not ignore original AccessControlException

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19109: Labels: pull-request-available (was: ) > checkPermission should not ignore original

[jira] [Commented] (HADOOP-19109) checkPermission should not ignore original AccessControlException

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829419#comment-17829419 ] ASF GitHub Bot commented on HADOOP-19109: - XbaoWu opened a new pull request, #6651: URL:

[PR] HADOOP-19109. Supplement log information for AccessControlException [hadoop]

2024-03-21 Thread via GitHub
XbaoWu opened a new pull request, #6651: URL: https://github.com/apache/hadoop/pull/6651 ### Description of PR For more information about this PR, please refer to the following issue: [HADOOP-19109](https://issues.apache.org/jira/browse/HADOOP-19109) checkPermission should not

[PR] HDFS-17435. Fix TestRouterRpc#testClearStaleNamespacesInRouterStateIdContext() failed [hadoop]

2024-03-21 Thread via GitHub
tasanuma opened a new pull request, #6650: URL: https://github.com/apache/hadoop/pull/6650 ### Description of PR TestRouterRpc and TestRouterRpcMultiDestination are failing with the following error. ``` [ERROR] testProxyGetBlockKeys Time elapsed: 0.573 s <<<

[jira] [Commented] (HADOOP-19047) Support InMemory Tracking Of S3A Magic Commits

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829409#comment-17829409 ] ASF GitHub Bot commented on HADOOP-19047: - shameersss1 commented on PR #6468: URL:

Re: [PR] HADOOP-19047: Support InMemory Tracking Of S3A Magic Commits [hadoop]

2024-03-21 Thread via GitHub
shameersss1 commented on PR #6468: URL: https://github.com/apache/hadoop/pull/6468#issuecomment-2011393345 @steveloughran - Gentle reminder for review Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] HDFS-17414. [FGL] RPCs in DatanodeProtocol support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu opened a new pull request, #6649: URL: https://github.com/apache/hadoop/pull/6649 [FGL] RPCs in DatanodeProtocol support fine-grained lock. - registerDatanode - sendHeartbeat - sendLifeline - blockReport - blockReceivedAndDeleted - errorReport -

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-21 Thread via GitHub
dineshchitlangia merged PR #6616: URL: https://github.com/apache/hadoop/pull/6616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19088) upgrade to jersey-json 1.22.0

2024-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829400#comment-17829400 ] ASF GitHub Bot commented on HADOOP-19088: - hadoop-yetus commented on PR #6626: URL:

Re: [PR] HADOOP-19088. Use jersey-json 1.22.0 (#6585) [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6626: URL: https://github.com/apache/hadoop/pull/6626#issuecomment-2011338358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2011330271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11667. Federation: ResourceRequestComparator occurs NPE when using low version of hadoop submit application [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6648: URL: https://github.com/apache/hadoop/pull/6648#issuecomment-2011310490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-21 Thread via GitHub
XbaoWu commented on PR #6616: URL: https://github.com/apache/hadoop/pull/6616#issuecomment-2011278871 > @XbaoWu - could you please address the 3 checkstyle violations generated by your patch? > > TestCheckRemoveZKNodeRMStateStore.java:95: TestZKRMStateStoreInternal store;:32:

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6616: URL: https://github.com/apache/hadoop/pull/6616#issuecomment-2011277303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |