Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595039239 ## hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md: ## @@ -879,6 +879,42 @@ hierarchical namespace enabled, and set the following configuration settin

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844883#comment-17844883 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844882#comment-17844882 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595038507 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Ap

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844881#comment-17844881 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595037949 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Ap

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844879#comment-17844879 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739:

[PR] HDFS-17515. Erasure Coding: ErasureCodingWork is not effectively limi… [hadoop]

2024-05-08 Thread via GitHub
zhengchenyu opened a new pull request, #6805: URL: https://github.com/apache/hadoop/pull/6805 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17515 ### How was this patch tested? unit test ### For code changes: - Add pendingECBlockReplicatio

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2102051696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] [DRAFT] Jackson 2.14 [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6761: URL: https://github.com/apache/hadoop/pull/6761#issuecomment-2102033031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17512. Unify the logic of the dumpXattrs method [hadoop]

2024-05-08 Thread via GitHub
YaAYadeer closed pull request #6800: HDFS-17512. Unify the logic of the dumpXattrs method URL: https://github.com/apache/hadoop/pull/6800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HDFS-17512. Unify the logic of the dumpXattrs method [hadoop]

2024-05-08 Thread via GitHub
YaAYadeer opened a new pull request, #6800: URL: https://github.com/apache/hadoop/pull/6800 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844862#comment-17844862 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1594972228 ## hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md: ## @@ -879,6 +879,42 @@ hierarchical namespace enabled, and set the following configuration settin

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844860#comment-17844860 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1594954265 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Ap

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844859#comment-17844859 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1594952840 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the Ap

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

[jira] [Commented] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844852#comment-17844852 ] ASF GitHub Bot commented on HADOOP-19156: - hadoop-yetus commented on PR #6767:

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2101905008 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
Hexiaoqiao commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2101893364 Hi @vikaskr22 @ChenSammi Thanks for your works here. One nit concerns, #6001 try to remove synchronization then revert and add RWLock here, any issues do you meet while remove synchroni

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844848#comment-17844848 ] ASF GitHub Bot commented on HADOOP-18851: - Hexiaoqiao commented on PR #6803: UR

Re: [PR] HDFS-17464. Improve some logs output in class FsDatasetImpl [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6724: URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2101890001 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2101828246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844833#comment-17844833 ] ASF GitHub Bot commented on HADOOP-18851: - ChenSammi commented on code in PR #6

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
ChenSammi commented on code in PR #6803: URL: https://github.com/apache/hadoop/pull/6803#discussion_r1594856131 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -169,21 +172,29 @@ pu

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844832#comment-17844832 ] ASF GitHub Bot commented on HADOOP-18851: - ChenSammi commented on code in PR #6

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844831#comment-17844831 ] ASF GitHub Bot commented on HADOOP-18851: - ChenSammi commented on code in PR #6

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
ChenSammi commented on code in PR #6803: URL: https://github.com/apache/hadoop/pull/6803#discussion_r1594856131 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -169,21 +172,29 @@ pu

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
ChenSammi commented on code in PR #6803: URL: https://github.com/apache/hadoop/pull/6803#discussion_r1594856131 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -169,21 +172,29 @@ pu

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
xinglin commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594843688 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

[jira] [Commented] (HADOOP-19154) upgrade bouncy castle to 1.78.1 due to CVEs

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844816#comment-17844816 ] ASF GitHub Bot commented on HADOOP-19154: - hadoop-yetus commented on PR #6755:

Re: [PR] HADOOP-19154. Upgrade bouncycastle to 1.78.1 due to CVEs [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6755: URL: https://github.com/apache/hadoop/pull/6755#issuecomment-2101690935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844812#comment-17844812 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2101665324 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844809#comment-17844809 ] ASF GitHub Bot commented on HADOOP-19013: - hadoop-yetus commented on PR #6646:

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6646: URL: https://github.com/apache/hadoop/pull/6646#issuecomment-2101656498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844784#comment-17844784 ] ASF GitHub Bot commented on HADOOP-19013: - mukund-thakur commented on code in P

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-05-08 Thread via GitHub
mukund-thakur commented on code in PR #6646: URL: https://github.com/apache/hadoop/pull/6646#discussion_r1594676316 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/EncryptionTestUtils.java: ## @@ -111,4 +119,27 @@ public static void assertEncrypted(S3AFileSyste

Re: [PR] HDFS-13603: do not propagate ExecutionException and add maxRetries li… [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6774: URL: https://github.com/apache/hadoop/pull/6774#issuecomment-2101381146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594514981 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6784: URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2101225659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-08 Thread via GitHub
kaiyaok2 commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2101208144 Resolved the trailing space issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6780: URL: https://github.com/apache/hadoop/pull/6780#issuecomment-2101119072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17503. Unreleased volume references because of OOM. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6782: URL: https://github.com/apache/hadoop/pull/6782#issuecomment-2101107605 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
xinglin commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594406970 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] YARN-11691. Add HTTP POST method to yarn web proxy servlet [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6781: URL: https://github.com/apache/hadoop/pull/6781#issuecomment-2101061013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844718#comment-17844718 ] ASF GitHub Bot commented on HADOOP-18786: - ctubbsii commented on PR #5789: URL:

Re: [PR] HADOOP-18786. Use CDN instead of ASF archive [hadoop]

2024-05-08 Thread via GitHub
ctubbsii commented on PR #5789: URL: https://github.com/apache/hadoop/pull/5789#issuecomment-2101037371 This was previously approved, and I've answered all the questions raised. I just resolved the merge conflicts from upstream, where some lines got moved around in the Dockerfile for Window

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
mccormickt12 commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594349582 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void u

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100903362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7402. fix mapreduce.task.io.sort.factor=1 lead to an infinite loop. [hadoop]

2024-05-08 Thread via GitHub
KeeProMise commented on PR #6622: URL: https://github.com/apache/hadoop/pull/6622#issuecomment-2100839456 > Was gonna hit the merge button, but got curious. > > Earlier if the value was 1, was it an infinite loop always? or in just in a corner case, if in just one corner case & now if

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-08 Thread via GitHub
KeeProMise commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2100829995 @goiri hi, If you have time, please take a look again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2100800444 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844664#comment-17844664 ] ASF GitHub Bot commented on HADOOP-19156: - Hexiaoqiao commented on PR #6767: UR

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

2024-05-08 Thread via GitHub
Hexiaoqiao commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2100603374 @liubin101 Almost look good to me. Also need to update ResourceManagerHA.md / Federation.md / ResourceManagerRestart.md about zk config guide. Thanks. -- This is an automated message

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2100562189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] YARN-11693. Refactor Container Scheduler [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6786: URL: https://github.com/apache/hadoop/pull/6786#issuecomment-2100318644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100275260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844617#comment-17844617 ] ASF GitHub Bot commented on HADOOP-18610: - hadoop-yetus commented on PR #6787:

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6787: URL: https://github.com/apache/hadoop/pull/6787#issuecomment-2100265963 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844616#comment-17844616 ] ASF GitHub Bot commented on HADOOP-19167: - hadoop-yetus commented on PR #6798:

Re: [PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6798: URL: https://github.com/apache/hadoop/pull/6798#issuecomment-2100264516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2100256835 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844615#comment-17844615 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844613#comment-17844613 ] ASF GitHub Bot commented on HADOOP-18851: - vikaskr22 commented on code in PR #6

Re: [PR] HDFS-17496. DataNode supports more fine-grained dataset lock based on blockid. [hadoop]

2024-05-08 Thread via GitHub
hfutatzhanghb commented on PR #6764: URL: https://github.com/apache/hadoop/pull/6764#issuecomment-2100255912 > @hfutatzhanghb Hello.Sir. Although I am very excited about this PR, I would like to ask why we don't split the lock granularity into INode level? @BsoBird Sir, thanks for not

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844612#comment-17844612 ] ASF GitHub Bot commented on HADOOP-18851: - vikaskr22 commented on code in PR #6

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
vikaskr22 commented on code in PR #6803: URL: https://github.com/apache/hadoop/pull/6803#discussion_r1593797928 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -441,18 +496,14 @@ pr

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-08 Thread via GitHub
vikaskr22 commented on code in PR #6803: URL: https://github.com/apache/hadoop/pull/6803#discussion_r1593797668 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -169,21 +172,29 @@ pu

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844610#comment-17844610 ] ASF GitHub Bot commented on HADOOP-19161: - hadoop-yetus commented on PR #6789:

Re: [PR] HDFS-17504. DN process should exit when BPServiceActor exit [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6792: URL: https://github.com/apache/hadoop/pull/6792#issuecomment-2100245841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2100244716 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100214644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17496. DataNode supports more fine-grained dataset lock based on blockid. [hadoop]

2024-05-08 Thread via GitHub
BsoBird commented on PR #6764: URL: https://github.com/apache/hadoop/pull/6764#issuecomment-2100170875 @hfutatzhanghb Hello.Sir. Although I am very excited about this PR, I would like to ask why we don't split the lock granularity into INode level? -- This is an automated message from

Re: [PR] HDFS-17303 Make WINDOW_SIZE and NUM_WINDOWS configurable. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6801: URL: https://github.com/apache/hadoop/pull/6801#issuecomment-2100073151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17512. Unify the logic of the dumpXattrs method [hadoop]

2024-05-08 Thread via GitHub
YaAYadeer closed pull request #6800: HDFS-17512. Unify the logic of the dumpXattrs method URL: https://github.com/apache/hadoop/pull/6800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina opened a new pull request, #6804: URL: https://github.com/apache/hadoop/pull/6804 ### Description of PR When a namenode that had "dfs.namenode.state.context.enabled" set to true is restarted with the configuration set to false, routers will keep using a previously cach

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2099980404 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2099978892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2099943783 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Moved] (HADOOP-19167) Change of Codec configuration does not work

2024-05-08 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin moved HDFS-17510 to HADOOP-19167: --- Component/s: compress (was: compress) Key: