Re: [PR] HDFS-17569 Change Code Logic for Generating Block Reconstruction Work [hadoop]

2024-07-25 Thread via GitHub
hadoop-yetus commented on PR #6924: URL: https://github.com/apache/hadoop/pull/6924#issuecomment-2250284646 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17544. [ARR] The router client rpc protocol PB supports asynchrony. [hadoop]

2024-07-25 Thread via GitHub
hadoop-yetus commented on PR #6870: URL: https://github.com/apache/hadoop/pull/6870#issuecomment-2250209592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19231. Add JacksonUtil [hadoop]

2024-07-25 Thread via GitHub
hadoop-yetus commented on PR #6953: URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2250183729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11709. NodeManager should be shut down or blacklisted when it ca… [hadoop]

2024-07-25 Thread via GitHub
hadoop-yetus commented on PR #6960: URL: https://github.com/apache/hadoop/pull/6960#issuecomment-2250175940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HADOOP-19237. Upgrade to dnsjava 3.6.0 due to CVEs [hadoop]

2024-07-25 Thread via GitHub
pjfanning opened a new pull request, #6961: URL: https://github.com/apache/hadoop/pull/6961 ### Description of PR HADOOP-19237 - replaces #6955 ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with the

Re: [PR] Bump dnsjava:dnsjava from 3.4.0 to 3.6.0 in /hadoop-project [hadoop]

2024-07-25 Thread via GitHub
pjfanning commented on PR #6955: URL: https://github.com/apache/hadoop/pull/6955#issuecomment-2250144209 compile issues ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile (default-testCompile) on project hadoop-registry: Compilation

Re: [PR] HADOOP-19230. Jackson 2.14.3 [hadoop]

2024-07-25 Thread via GitHub
pjfanning commented on PR #6761: URL: https://github.com/apache/hadoop/pull/6761#issuecomment-2250096203 This is the change to Jackson JAX-RS that is forcing Hadoop to stick with Jackson 2.12. https://github.com/FasterXML/jackson-jaxrs-providers/issues/134#issuecomment-1180637522

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-25 Thread via GitHub
steveloughran commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2250077439 thanks. just testing the trunk code locally, to see if there are any problems first -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] YARN-11709. NodeManager should be shut down or blacklisted when it ca… [hadoop]

2024-07-25 Thread via GitHub
K0K0V0K commented on PR #6960: URL: https://github.com/apache/hadoop/pull/6960#issuecomment-2249929451 Thanks @ferdelyi for the change, seems good to me. Can you please add some sort of unit test to this commit? -- This is an automated message from the Apache Git Service. To respond to

[PR] YARN-11709. NodeManager should be shut down or blacklisted when it ca… [hadoop]

2024-07-25 Thread via GitHub
ferdelyi opened a new pull request, #6960: URL: https://github.com/apache/hadoop/pull/6960 …nnot run program /var/lib/yarn-ce/bin/container-executor ### Description of PR ### How was this patch tested? ### For code changes: - [x] Does the title or

Re: [PR] HDFS-17545. [ARR] router async rpc client. [hadoop]

2024-07-24 Thread via GitHub
hfutatzhanghb commented on code in PR #6871: URL: https://github.com/apache/hadoop/pull/6871#discussion_r1690851360 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -284,6 +304,12 @@ public

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
saxenapranav commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2249408482 Thank you very much @steveloughran. Really thankful to you for your time and energy in this. Have raised a backport PR https://github.com/apache/hadoop/pull/6959 on branch-3.4. Thank

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
saxenapranav commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2249402554 Hi @steveloughran , This is backport of trunk PR https://github.com/apache/hadoop/pull/6633. Requesting your kind review please. Thank you very much! -- This is an automated

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
shameersss1 commented on code in PR #6938: URL: https://github.com/apache/hadoop/pull/6938#discussion_r1690800271 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java: ## @@ -228,15 +228,15 @@ protected Map, RetryPolicy> createExceptionMap() {

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
shameersss1 commented on code in PR #6938: URL: https://github.com/apache/hadoop/pull/6938#discussion_r1690798138 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/AWSStatus500Exception.java: ## @@ -22,21 +22,20 @@ /** * A 5xx response came back from a

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
shameersss1 commented on code in PR #6938: URL: https://github.com/apache/hadoop/pull/6938#discussion_r1690793840 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java: ## @@ -927,28 +931,32 @@ private void uploadBlockAsync(final

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
shameersss1 commented on code in PR #6938: URL: https://github.com/apache/hadoop/pull/6938#discussion_r1690765946 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/store/ByteBufferInputStream.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

Re: [PR] HDFS-17544. [ARR] The router client rpc protocol PB supports asynchrony. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6870: URL: https://github.com/apache/hadoop/pull/6870#issuecomment-2249272166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17588. RBF: RouterObserverReadProxyProvider should perform an msync before executing the first read. [hadoop]

2024-07-24 Thread via GitHub
fuchaohong commented on PR #6956: URL: https://github.com/apache/hadoop/pull/6956#issuecomment-2249156919 @simbadzina Master, please help me review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17575. SaslDataTransferClient should use SaslParticipant to create messages. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6954: URL: https://github.com/apache/hadoop/pull/6954#issuecomment-2249121010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2248543856 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2248536907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-24 Thread via GitHub
szetszwo merged PR #6888: URL: https://github.com/apache/hadoop/pull/6888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2248483299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2248484596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2248371220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-07-24 Thread via GitHub
steveloughran commented on code in PR #6789: URL: https://github.com/apache/hadoop/pull/6789#discussion_r1689944706 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/performance.md: ## @@ -276,7 +283,45 @@ Fix: Use one of the dedicated [S3A

Re: [PR] HADOOP-19231. Add JacksonUtil [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6953: URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2247956464 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-15815. if required storageType are unavailable, log the failed reason during choosing Datanode. Contributed by Yang Yun. [hadoop]

2024-07-24 Thread via GitHub
zlokomatic commented on PR #2882: URL: https://github.com/apache/hadoop/pull/2882#issuecomment-2247828873 > Just upgraded our cluster from 3.1.x to 3.3.x, and seeing this log line printed hundreds of times per minute: > > ``` > INFO

Re: [PR] HADOOP-19187: [ABFS][FNSOverBlob] Making AbfsClient Abstract for supporting both DFS and Blob Endpoint [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6879: URL: https://github.com/apache/hadoop/pull/6879#issuecomment-2247821581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17588. RBF: RouterObserverReadProxyProvider should perform an msync before executing the first read. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6956: URL: https://github.com/apache/hadoop/pull/6956#issuecomment-2247808734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2247729029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-24 Thread via GitHub
steveloughran commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2247701393 s3 london with: -Dparallel-tests -DtestsThreadCount=8 -Dscale This is ready to be reviewed. @mukund-thakur, @HarshitGupta11 and @shameersss1 could you all look at this?

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2247374679 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-24 Thread via GitHub
CLevasseur commented on code in PR #4262: URL: https://github.com/apache/hadoop/pull/4262#discussion_r1689341481 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAccountConfiguration.java: ## @@ -444,6 +439,30 @@ private static void

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
saxenapranav commented on PR #6959: URL: https://github.com/apache/hadoop/pull/6959#issuecomment-2247090911 -- AGGREGATED TEST RESULT HNS-OAuth

[PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-24 Thread via GitHub
saxenapranav opened a new pull request, #6959: URL: https://github.com/apache/hadoop/pull/6959 JIRA: https://issues.apache.org/jira/browse/HADOOP-19120 trunk pr: https://github.com/apache/hadoop/pull/6633 Apache httpclient 4.5.x is the new default implementation of http

Re: [PR] HADOOP-19005. Upgrade Guava to 32.0.1 due to CVE-2023-2976. [hadoop]

2024-07-24 Thread via GitHub
hadoop-yetus commented on PR #6344: URL: https://github.com/apache/hadoop/pull/6344#issuecomment-2247066148 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-24 Thread via GitHub
anujmodi2021 commented on code in PR #4262: URL: https://github.com/apache/hadoop/pull/4262#discussion_r1689199461 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAccountConfiguration.java: ## @@ -444,6 +439,30 @@ private static void

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-24 Thread via GitHub
anujmodi2021 commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2246988401 > I've rebased the branch onto the latest trunk, you should be good to run the integration tests Thanks @CLevasseur I have ran tests and added result above. The

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-24 Thread via GitHub
anujmodi2021 commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2246985287 -- AGGREGATED TEST RESULT HNS-OAuth

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2246807235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2246807169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11707. Fix UT checkstyle error in TestRMAdminCLI [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6958: URL: https://github.com/apache/hadoop/pull/6958#issuecomment-2246801119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11707. Fix UT checkstyle error in TestRMAdminCLI [hadoop]

2024-07-23 Thread via GitHub
granewang commented on PR #6958: URL: https://github.com/apache/hadoop/pull/6958#issuecomment-2246802142 Why always "Docker failed to build" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2246801681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11707. Fix UT checkstyle error in TestRMAdminCLI [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6958: URL: https://github.com/apache/hadoop/pull/6958#issuecomment-2246801429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2246764742 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11707. Fix UT checkstyle error in TestRMAdminCLI [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6958: URL: https://github.com/apache/hadoop/pull/6958#issuecomment-2246720036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11707. Fix UT checkstyle error in TestRMAdminCLI [hadoop]

2024-07-23 Thread via GitHub
granewang opened a new pull request, #6958: URL: https://github.com/apache/hadoop/pull/6958 In patch https://github.com/apache/hadoop/pull/6957 ,checkstyle error always exists ,Fix all the checkstyle error like:

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
granewang commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2246683649 Fix blanks eol,while the checkstyle error is keeping with the legacy code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2246199183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2245970791 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread [hadoop]

2024-07-23 Thread via GitHub
dotzborro commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-2245967534 This bug seems to have been solved by https://github.com/apache/hadoop/pull/5629 (https://issues.apache.org/jira/browse/YARN-11489), after which the futures are held in

Re: [PR] HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2245868417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19197. S3A: Support AWS KMS Encryption Context [hadoop]

2024-07-23 Thread via GitHub
steveloughran merged PR #6874: URL: https://github.com/apache/hadoop/pull/6874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-23 Thread via GitHub
KeeProMise closed pull request #6888: HADOOP-19235. IPC client uses CompletableFuture to support asynchronous operations. URL: https://github.com/apache/hadoop/pull/6888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2245386325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2245384864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19231. Add JacksonUtil [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6953: URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2245374122 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17588. RBF: RouterObserverReadProxyProvider should perform an msync before executing the first read. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6956: URL: https://github.com/apache/hadoop/pull/6956#issuecomment-2245206728 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16690. Automatically format unformatted JNs with JournalNodeSyncer [hadoop]

2024-07-23 Thread via GitHub
Hexiaoqiao commented on PR #6925: URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2245176501 Committed to trunk. Thanks @aswinmprabhu for your works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HDFS-16690. Automatically format unformatted JNs with JournalNodeSyncer [hadoop]

2024-07-23 Thread via GitHub
Hexiaoqiao merged PR #6925: URL: https://github.com/apache/hadoop/pull/6925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19218. Addendum. Update TestFSNamesystemLockReport to exclude hostname resolution from regex. [hadoop]

2024-07-23 Thread via GitHub
Hexiaoqiao commented on PR #6951: URL: https://github.com/apache/hadoop/pull/6951#issuecomment-2245166427 Committed to trunk and branch-3.4. Thanks @virajjasani . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HADOOP-19218. Addendum. Update TestFSNamesystemLockReport to exclude hostname resolution from regex. [hadoop]

2024-07-23 Thread via GitHub
Hexiaoqiao merged PR #6951: URL: https://github.com/apache/hadoop/pull/6951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-16690. Automatically format unformatted JNs with JournalNodeSyncer [hadoop]

2024-07-23 Thread via GitHub
aswinmprabhu commented on PR #6925: URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2245100184 Thanks, @Hexiaoqiao for the approval. Can we merge at the end of today? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2245016042 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2244999777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-2139. Fast copy for HDFS.FastCopy (This is used for test case . And in the futuer this will split to subtask submission. ) [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6950: URL: https://github.com/apache/hadoop/pull/6950#issuecomment-2244969587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11706. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6957: URL: https://github.com/apache/hadoop/pull/6957#issuecomment-2244785161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2244755461 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2244747625 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2244746137 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-23 Thread via GitHub
CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2244717146 I've rebased the branch onto the latest trunk, you should be good to run the integration tests -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HDFS-17588. RBF: RouterObserverReadProxyProvider should perform an msync before executing the first read. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6956: URL: https://github.com/apache/hadoop/pull/6956#issuecomment-2244690119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19219. Resolve Certificate error in Hadoop-auth tests. [hadoop]

2024-07-23 Thread via GitHub
hadoop-yetus commented on PR #6939: URL: https://github.com/apache/hadoop/pull/6939#issuecomment-2244538787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11563. Make yarn rmadmin tool support failover function [hadoop]

2024-07-23 Thread via GitHub
granewang opened a new pull request, #6957: URL: https://github.com/apache/hadoop/pull/6957 ### Description of PR Currently,yarn rmadmin can not support failover,This failover step is just the same as step : yarn rmadmin -transitionToStandby -forcemanual rm1 yarn rmadmin

Re: [PR] HDFS-17552. [ARR] IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2244243913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19197. S3A: Support AWS KMS Encryption Context [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6874: URL: https://github.com/apache/hadoop/pull/6874#issuecomment-2244139487 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17552. [ARR] IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-22 Thread via GitHub
KeeProMise commented on code in PR #6888: URL: https://github.com/apache/hadoop/pull/6888#discussion_r1687280654 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java: ## @@ -283,6 +326,7 @@ static class Call { boolean done;

Re: [PR] HADOOP-19218 Update TestFSNamesystemLockReport to exclude hostname resolution from regex (ADDENDUM) [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6951: URL: https://github.com/apache/hadoop/pull/6951#issuecomment-2243985730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19231. Add JacksonUtil [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6953: URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2243964322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2243875908 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-07-22 Thread via GitHub
virajjasani commented on code in PR #6789: URL: https://github.com/apache/hadoop/pull/6789#discussion_r1687142291 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -2209,7 +2237,8 @@ public FSDataOutputStreamBuilder createFile(final

Re: [PR] HDFS-17552. [ARR] IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2243625841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17575. SaslDataTransferClient should use SaslParticipant to create messages. [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6954: URL: https://github.com/apache/hadoop/pull/6954#issuecomment-2243623593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19197. S3A: Support AWS KMS Encryption Context [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on code in PR #6874: URL: https://github.com/apache/hadoop/pull/6874#discussion_r1686963532 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEncryptionSSEKMSWithEncryptionContext.java: ## @@ -0,0 +1,100 @@ +/** + * Licensed to

Re: [PR] HADOOP-19197. S3A: Support AWS KMS Encryption Context [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on PR #6874: URL: https://github.com/apache/hadoop/pull/6874#issuecomment-2243532260 > The checks are failing because they are trying to compile three classes that I removed in the second commit. I don't know how to make it not use them. needs a squashed

Re: [PR] HDFS-17552. [ARR] IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2243526536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-22 Thread via GitHub
steveloughran merged PR #6633: URL: https://github.com/apache/hadoop/pull/6633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17552. [ARR] IPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2243525500 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2243524698 ok! merged! please do the branch 3.4 backport and test. because httpclient is the new default, "compile" is the correct maven scope. I will look at the cloud storage

Re: [PR] HADOOP-18542. Keep MSI tenant ID and client ID optional [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-2243498857 @CLevasseur if @anujmodi2021 is happy to run the integration tests, please do the rebase and I'll go with his test results. thanks -- This is an automated message from the Apache

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on code in PR #6789: URL: https://github.com/apache/hadoop/pull/6789#discussion_r1686918836 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -2209,7 +2237,8 @@ public FSDataOutputStreamBuilder createFile(final

Re: [PR] HADOOP-19219. Resolve Certificate error in Hadoop-auth tests. [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on code in PR #6939: URL: https://github.com/apache/hadoop/pull/6939#discussion_r1686912760 ## hadoop-common-project/hadoop-auth/pom.xml: ## @@ -272,5 +272,68 @@ + + java-8 + +1.8 + + +

Re: [PR] HADOOP-19221. S3A: Unable to recover from failure of multipart block upload attempt [hadoop]

2024-07-22 Thread via GitHub
steveloughran commented on PR #6938: URL: https://github.com/apache/hadoop/pull/6938#issuecomment-2243467975 tested s3 london with ` -Dparallel-tests -DtestsThreadCount=12 -Dscale` prefetch failures, timing related (12 too big...) ``` [ERROR] Failures: [ERROR]

Re: [PR] HDFS-2139. Fast copy for HDFS.FastCopy (This is used for test case . And in the futuer this will split to subtask submission. ) [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6950: URL: https://github.com/apache/hadoop/pull/6950#issuecomment-2243414957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Bump dnsjava:dnsjava from 3.4.0 to 3.6.0 in /hadoop-project [hadoop]

2024-07-22 Thread via GitHub
hadoop-yetus commented on PR #6955: URL: https://github.com/apache/hadoop/pull/6955#issuecomment-2243348207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] Bump dnsjava:dnsjava from 3.4.0 to 3.6.0 in /hadoop-project [hadoop]

2024-07-22 Thread via GitHub
dependabot[bot] opened a new pull request, #6955: URL: https://github.com/apache/hadoop/pull/6955 Bumps [dnsjava:dnsjava](https://github.com/dnsjava/dnsjava) from 3.4.0 to 3.6.0. Release notes Sourced from https://github.com/dnsjava/dnsjava/releases;>dnsjava:dnsjava's releases.

Re: [PR] HADOOP-19219. Resolve Certificate error in Hadoop-auth tests. [hadoop]

2024-07-22 Thread via GitHub
pan3793 commented on code in PR #6939: URL: https://github.com/apache/hadoop/pull/6939#discussion_r1686646604 ## hadoop-project/pom.xml: ## @@ -167,9 +167,11 @@ --> [${javac.version},) [3.3.0,) - + Review Comment: read

  1   2   3   4   5   6   7   8   9   10   >