steveloughran commented on code in PR #6789:
URL: https://github.com/apache/hadoop/pull/6789#discussion_r1686918836
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -2209,7 +2237,8 @@ public FSDataOutputStreamBuilder createFile(final Path
path) {
builder
.create()
.overwrite(true)
- .must(FS_S3A_CREATE_PERFORMANCE, performanceCreation);
+ .must(FS_S3A_CREATE_PERFORMANCE,
+ getPerformanceFlags().enabled(PerformanceFlagEnum.Create));
Review Comment:
I worry about doing things like this which can have unexpected consequences
with stuff like mocking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
