[GitHub] [hadoop] ayushtkn commented on pull request #3387: HADOOP-17892. Add Hadoop code formatter in dev-support

2021-09-22 Thread GitBox
ayushtkn commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-925535985 I added that line, @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] ayushtkn commented on pull request #3387: HADOOP-17892. Add Hadoop code formatter in dev-support

2021-09-11 Thread GitBox
ayushtkn commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-917454461 > if we want to change import order for thirdparty shaded guava, I believe we can first do it on checkstyle.xml and then update formatter accordingly. WDYT? I think we ca

[GitHub] [hadoop] ayushtkn commented on pull request #3387: HADOOP-17892. Add Hadoop code formatter in dev-support

2021-09-09 Thread GitBox
ayushtkn commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-916167736 I am quite convinced with having a formatter checked in to the code. Mostly, if it can take care of import ordering. With a exception that we keep the shaded guava imports at