[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-546029768 +1, merged to trunk. Thanks! (if you do a PR with this cherry picked back to 3.2/3.1 then I'll pull back there

[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-546027287 thanks. code LGTM. Now github is saying things won't merge. Can you try to rebase this to trunk (yes, at the cost of the

[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-545526777 I like all tests in our code to provide enough diagnostics on failure that we can work out what went wrong purely from

[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-541085339 code is good, you just need to deal with those checkstyles, which are mostly indentation and a couple of minor line

[GitHub] [hadoop] steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider

steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-540691162 oops, deleted the wrong yetus comment. once you update the patch it will kick off again. Overall -patch LGTM; a