steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1550129607
did a local build and test with -Dparallel-tests -DtestsThreadCount=8
-Dscale against s3 london; failures in ITestS3ABucketExistence were seen, but
I've not looked at the details th
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1550074617
sorry, i'm creating confusion. I was going to merge this into the feature
branch.
I hadn't realised that the sdk was going to hurt rename; yes, that would be
an issue.
How
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1547909482
so you want me to merge this as is?
oh, here's my list for the next iteration
```
*
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1547877112
I'm going to merge this in and then play with myself; see if there are any
more final-final-final changes to worry about. then pull into trunk.
--
This is an automated message fro
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1523433345
oh, and based some other changes, spotbugs warning about extant spotbugs
doesn't mean you've added a new one, just that there is one to get rid of.
yetus can still warn there even if
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1520411654
> do you mean reverting the changes made for spotbugs (moving to a separate
method)?
new method is fine, we just need to add in whatever shuts spotbugs up. I
would have hoped
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1520404440
here's what I propose: merge then fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1520403758
ok, let's give up on spotbugs. this is one of its enternal losing battles,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1517736384
spotbugs is happy; deprecation warnings file...all that is left is to get
the name of the new method right
--
This is an automated message from the Apache Git Service.
To respond t
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1515158123
it looks exactly the same as the one above, doesn't it?
Sometimes with findbugs is simplest to just surrender: create some setter
which is synchronized and set it through that.
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1508895984
ok, before merging, that spotbugs needs to be quietened
```
ode | Warning
-- | --
IS | Inconsistent synchronization of
org.apache.hadoop.fs.s3a.S3AFileSystem.s3Asy
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1490348322
w.r.t merging, add the amazon.cn check so it doesn't get forgotten about.
then we should be good to mergel
--
This is an automated message from the Apache Git Service.
To respond t
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1490346831
i don't know about those third party stores; someone in your sdk team
probably knows better there. I think generally it is just account + secret,
unless something like kerberos/activ
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1484983979
`Endpoint is not set || Endpoint is set && ends in amazonaws.com || ARN is
set` is roughly what storediag does:
https://github.com/steveloughran/cloudstore/blob/trunk/src/main/java/o
steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1470822345
there's some new warnings about deprecation and cast. you can add @ tags to
suppress these
```
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:801:
15 matches
Mail list logo
