[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1231328961 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1231228930 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1229989659 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1229989659 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1229947285 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228698595 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468922 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468230 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468922 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228468230 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -636,10 +637,17 @@ void updateMetrics(Call call, long startTime, boolean

[GitHub] [hadoop] xinglin commented on a diff in pull request #5730: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode

xinglin commented on code in PR #5730: URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228448128 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -600,17 +600,18 @@ void logSlowRpcCalls(String methodName, Call call,