Hexiaoqiao commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1803445430
Committed to trunk. Thanks @K0K0V0K and @ferdelyi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Hexiaoqiao merged PR #6229:
URL: https://github.com/apache/hadoop/pull/6229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1794740228
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Hexiaoqiao commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1794084419
@K0K0V0K Please check the report from Yetus if we need to fix checkstyle and
javadoc/blanks. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
Hexiaoqiao commented on code in PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#discussion_r1382780238
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java:
##
@@ -62,10 +62,15 @@ public static void assertReFind(String re,
hadoop-yetus commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1792605958
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
K0K0V0K commented on code in PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#discussion_r1381509417
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java:
##
@@ -62,10 +62,15 @@ public static void assertReFind(String re,
K0K0V0K commented on code in PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#discussion_r1381509417
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java:
##
@@ -62,10 +62,15 @@ public static void assertReFind(String re,
Hexiaoqiao commented on code in PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#discussion_r1379590128
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java:
##
@@ -62,10 +62,15 @@ public static void assertReFind(String re,
hadoop-yetus commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1785644669
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
K0K0V0K commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1784860320
Check style says
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:146:
protected transient boolean nanFilter;:31: Variable
hadoop-yetus commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1783162841
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ferdelyi commented on PR #6229:
URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1782855814
LGTM, thank you for your work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
K0K0V0K opened a new pull request, #6229:
URL: https://github.com/apache/hadoop/pull/6229
### Description of PR
- The JMX json represents NaN like invalid JSON token, so some parser can
not parse.
- To fix this a new feature introduced to replace NaN with 0.0 values.
- The
14 matches
Mail list logo
