Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-18 Thread via GitHub
hfutatzhanghb closed pull request #6434: HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. URL: https://github.com/apache/hadoop/pull/6434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-18 Thread via GitHub
hfutatzhanghb commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1898012100 > > > Line211 has already ensured that we have a monitor for this object: > > > https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/h

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-18 Thread via GitHub
zhangshuyan0 commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1897981697 > > Line211 has already ensured that we have a monitor for this object: > > https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-17 Thread via GitHub
hfutatzhanghb commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1897837901 > Line211 has already ensured that we have a monitor for this object: > > https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/had

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-17 Thread via GitHub
zhangshuyan0 commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1897739440 Line211 has already ensured that we have a monitor for this object: https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/sr

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-10 Thread via GitHub
hfutatzhanghb commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1886067772 @Hexiaoqiao @zhangshuyan0 @tomscut Sir, could you please take a look at this PR when you have free time? Thanks. -- This is an automated message from the Apache Git Service. To

Re: [PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-10 Thread via GitHub
hadoop-yetus commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1885348791 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method. [hadoop]

2024-01-10 Thread via GitHub
hfutatzhanghb opened a new pull request, #6434: URL: https://github.com/apache/hadoop/pull/6434 ### Description of PR In method FSEditLogAsync#enqueueEdit , there exist the below codes: ```java if (Thread.holdsLock(this)) { // if queue is full, synchronized c