Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-06-17 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2172465823 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-06-16 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2171832002 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-215932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-06-12 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1636965918 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-23 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1611850764 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-21 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1608866841 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-21 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1608864957 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-16 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1603594294 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-16 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r160870 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-14 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1600246934 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-13 Thread via GitHub
Hexiaoqiao commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1599314271 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-13 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1599005240 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-13 Thread via GitHub
Hexiaoqiao commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1598536353 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597807172 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597806803 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597806803 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597693783 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106325014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106300111 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597594907 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106176232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-11 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597551434 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-11 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597551434 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean

[PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-10 Thread via GitHub
ThinkerLei opened a new pull request, #6809: URL: https://github.com/apache/hadoop/pull/6809 In the lease monitor, if a file is closed, method checklease will return true, and then the edits log will not be sync. In my opinion, we should sync the edits log to avoid not synchronizing the