[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468413#comment-16468413
]
Yongjun Zhang commented on HADOOP-10571:
Found this Jira is not in 3.0.1 and 3.0.2. It's in
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372550#comment-16372550
]
Andras Bokor commented on HADOOP-10571:
---
Thanks for the review and commit!
> Use Log.*(Object,
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371157#comment-16371157
]
Andras Bokor commented on HADOOP-10571:
---
Patch for branch-3.0 seems good to go.
> Use
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370431#comment-16370431
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367318#comment-16367318
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367289#comment-16367289
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364386#comment-16364386
]
Hudson commented on HADOOP-10571:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13655 (See
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364357#comment-16364357
]
Steve Loughran commented on HADOOP-10571:
-
OK, +1 from me too
committed to 3.1+
I'd support a
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363876#comment-16363876
]
Andras Bokor commented on HADOOP-10571:
---
I had to modify a wrong indented block so the 2
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363746#comment-16363746
]
Steve Loughran commented on HADOOP-10571:
-
OK, submitted the new patch.
what do we do about the
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362682#comment-16362682
]
Akira Ajisaka commented on HADOOP-10571:
Thanks! Now I'm +1 pending Jenkins and Steve's next
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362612#comment-16362612
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362207#comment-16362207
]
Andras Bokor commented on HADOOP-10571:
---
Thanks for the comments [~ajisakaa]! Please find my
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362053#comment-16362053
]
Akira Ajisaka commented on HADOOP-10571:
Thanks [~boky01] for continuing the work! Overall looks
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358618#comment-16358618
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358308#comment-16358308
]
Andras Bokor commented on HADOOP-10571:
---
Patch 06: One of the checkstyles was fixable.
> Use
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354234#comment-16354234
]
Steve Loughran commented on HADOOP-10571:
-
OK, I'm happy with this.
+1, pending my next action
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353264#comment-16353264
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353044#comment-16353044
]
Andras Bokor commented on HADOOP-10571:
---
{quote}
h4. LocalFileSystem
L142 we could move to making
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352722#comment-16352722
]
Steve Loughran commented on HADOOP-10571:
-
It's way past time to get this in, so lets aim for
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351854#comment-16351854
]
Andras Bokor commented on HADOOP-10571:
---
JUnits are unrelated and the 2 checkstyle are not cause
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351849#comment-16351849
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351609#comment-16351609
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351225#comment-16351225
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350805#comment-16350805
]
Andras Bokor commented on HADOOP-10571:
---
Attaching patch 02 with addressing [~hanishakoneru].
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346100#comment-16346100
]
Steve Loughran commented on HADOOP-10571:
-
this has been lingering for ages. If we can get the
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346043#comment-16346043
]
genericqa commented on HADOOP-10571:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345939#comment-16345939
]
Hanisha Koneru commented on HADOOP-10571:
-
Thanks for working on this [~boky01].
In the files
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345290#comment-16345290
]
Andras Bokor commented on HADOOP-10571:
---
Uploading a new patch based on [~arpitagarwal]'s patch
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716418#comment-14716418
]
Steve Loughran commented on HADOOP-10571:
-
# I've found the combo of
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524833#comment-14524833
]
Hadoop QA commented on HADOOP-10571:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524789#comment-14524789
]
Hadoop QA commented on HADOOP-10571:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025664#comment-14025664
]
Arpit Agarwal commented on HADOOP-10571:
Hi [~sureshms] / [~ste...@apache.org],
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990572#comment-13990572
]
Steve Loughran commented on HADOOP-10571:
-
Fine, but as the patches are adding
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990006#comment-13990006
]
Arpit Agarwal commented on HADOOP-10571:
Steve, I just read through the thread
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990036#comment-13990036
]
Suresh Srinivas commented on HADOOP-10571:
--
I agree with [~arpitagarwal]. Lets
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989110#comment-13989110
]
Steve Loughran commented on HADOOP-10571:
-
Arpit, we had a discussion on
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988257#comment-13988257
]
Suresh Srinivas commented on HADOOP-10571:
--
There are some place where we
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988280#comment-13988280
]
Suresh Srinivas commented on HADOOP-10571:
--
This might be an opportunity to add
[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988283#comment-13988283
]
Arpit Agarwal commented on HADOOP-10571:
Thanks Suresh, I used my judgement
40 matches
Mail list logo
